Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-28 Thread Marc Kleine-Budde
On 10/27/2016 06:28 PM, Cong Wang wrote: >>> Hmm, bo->bound should guarantee it, so never mind, your patch >>> looks fine. >> >> Can I add your Acked-by? > > Of course. > > Acked-by: Cong Wang Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux S

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-27 Thread Cong Wang
On Thu, Oct 27, 2016 at 1:45 AM, Marc Kleine-Budde wrote: > On 10/24/2016 10:17 PM, Cong Wang wrote: >> On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang wrote: >>> On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp >>> wrote: if (proc_dir) { /* unique socket address as

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-27 Thread Marc Kleine-Budde
On 10/24/2016 09:11 PM, Oliver Hartkopp wrote: > Andrey Konovalov reported an issue with proc_register in bcm.c. > As suggested by Cong Wang this patch adds a lock_sock() protection and > a check for unsuccessful proc_create_data() in bcm_connect(). > > Reference: http://marc.info/?l=linux-netdev&

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-27 Thread Marc Kleine-Budde
On 10/24/2016 10:17 PM, Cong Wang wrote: > On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang wrote: >> On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp >> wrote: >>> if (proc_dir) { >>> /* unique socket address as filename */ >>> sprintf(bo->procname, "%lu", sock

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-25 Thread Andrey Konovalov
Hi Oliver, I can confirm that your patch fixes the warnings for me. Tested-by: Andrey Konovalov On Mon, Oct 24, 2016 at 10:17 PM, Cong Wang wrote: > On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang wrote: >> On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp >> wrote: >>> if (proc_dir) { >>

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-24 Thread Cong Wang
On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang wrote: > On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp > wrote: >> if (proc_dir) { >> /* unique socket address as filename */ >> sprintf(bo->procname, "%lu", sock_i_ino(sk)); >> bo->bcm_proc_rea

Re: [PATCH] can: fix warning in bcm_connect/proc_register

2016-10-24 Thread Cong Wang
On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp wrote: > if (proc_dir) { > /* unique socket address as filename */ > sprintf(bo->procname, "%lu", sock_i_ino(sk)); > bo->bcm_proc_read = proc_create_data(bo->procname, 0644, >

[PATCH] can: fix warning in bcm_connect/proc_register

2016-10-24 Thread Oliver Hartkopp
Andrey Konovalov reported an issue with proc_register in bcm.c. As suggested by Cong Wang this patch adds a lock_sock() protection and a check for unsuccessful proc_create_data() in bcm_connect(). Reference: http://marc.info/?l=linux-netdev&m=147732648731237 Reported-by: Andrey Konovalov Suggest