Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-08-16 Thread Robin Murphy
On 16/08/2019 09:15, Shaokun Zhang wrote: Hi Will, On 2019/8/16 0:46, Will Deacon wrote: On Thu, May 16, 2019 at 11:14:35AM +0800, Zhangshaokun wrote: On 2019/5/15 17:47, Will Deacon wrote: On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: On 12/04/2019 10:52, Will Deacon wrote:

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-08-16 Thread Shaokun Zhang
Hi Will, On 2019/8/16 0:46, Will Deacon wrote: > On Thu, May 16, 2019 at 11:14:35AM +0800, Zhangshaokun wrote: >> On 2019/5/15 17:47, Will Deacon wrote: >>> On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: On 12/04/2019 10:52, Will Deacon wrote: > I'm waiting for Robin to com

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-08-15 Thread Will Deacon
On Thu, May 16, 2019 at 11:14:35AM +0800, Zhangshaokun wrote: > On 2019/5/15 17:47, Will Deacon wrote: > > On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: > >> On 12/04/2019 10:52, Will Deacon wrote: > >>> I'm waiting for Robin to come back with numbers for a C implementation. > >>> >

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Zhangshaokun
Hi Will, On 2019/5/15 17:47, Will Deacon wrote: > On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: >> On 12/04/2019 10:52, Will Deacon wrote: >>> I'm waiting for Robin to come back with numbers for a C implementation. >>> >>> Robin -- did you get anywhere with that? >> >> Still not wh

RE: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread David Laight
lists.infradead.org; > >> netdev@vger.kernel.org; > >> ilias.apalodi...@linaro.org; huanglingyan (A); steve.cap...@arm.com > >> Subject: Re: [PATCH] arm64: do_csum: implement accelerated scalar version > >> > >> On 15/05/2019 11:15, David Laight wro

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Robin Murphy
ubject: Re: [PATCH] arm64: do_csum: implement accelerated scalar version On 15/05/2019 11:15, David Laight wrote: ... ptr = (u64 *)(buff - offset); shift = offset * 8; /* * Head: zero out any excess leading bytes. Shifting back by the same * amount should b

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Robin Murphy
On 15/05/2019 10:47, Will Deacon wrote: On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: On 12/04/2019 10:52, Will Deacon wrote: I'm waiting for Robin to come back with numbers for a C implementation. Robin -- did you get anywhere with that? Still not what I would call finished,

RE: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread David Laight
From: Robin Murphy > Sent: 15 May 2019 11:58 > To: David Laight; 'Will Deacon' > Cc: Zhangshaokun; Ard Biesheuvel; linux-arm-ker...@lists.infradead.org; > netdev@vger.kernel.org; > ilias.apalodi...@linaro.org; huanglingyan (A); steve.cap...@arm.com > Subject: Re: [PATC

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Robin Murphy
On 15/05/2019 11:15, David Laight wrote: ... ptr = (u64 *)(buff - offset); shift = offset * 8; /* * Head: zero out any excess leading bytes. Shifting back by the same * amount should be at least as fast as any other way of handling the * odd/ev

RE: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread David Laight
... > > ptr = (u64 *)(buff - offset); > > shift = offset * 8; > > > > /* > > * Head: zero out any excess leading bytes. Shifting back by the same > > * amount should be at least as fast as any other way of handling the > > * odd/even alignment, and means we can ignore it

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Will Deacon
On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: > On 12/04/2019 10:52, Will Deacon wrote: > > I'm waiting for Robin to come back with numbers for a C implementation. > > > > Robin -- did you get anywhere with that? > > Still not what I would call finished, but where I've got so far

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-04-15 Thread Robin Murphy
On 12/04/2019 10:52, Will Deacon wrote: On Fri, Apr 12, 2019 at 10:31:16AM +0800, Zhangshaokun wrote: On 2019/2/19 7:08, Ard Biesheuvel wrote: It turns out that the IP checksumming code is still exercised often, even though one might expect that modern NICs with checksum offload have no use for

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-04-12 Thread Will Deacon
On Fri, Apr 12, 2019 at 10:31:16AM +0800, Zhangshaokun wrote: > On 2019/2/19 7:08, Ard Biesheuvel wrote: > > It turns out that the IP checksumming code is still exercised often, > > even though one might expect that modern NICs with checksum offload > > have no use for it. However, as Lingyan point

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-04-11 Thread Zhangshaokun
Hi maintainers and Ard, Any update on it? Thanks, Shaokun On 2019/2/19 7:08, Ard Biesheuvel wrote: > It turns out that the IP checksumming code is still exercised often, > even though one might expect that modern NICs with checksum offload > have no use for it. However, as Lingyan points out, th

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-02-28 Thread Ard Biesheuvel
On Thu, 28 Feb 2019 at 16:14, Robin Murphy wrote: > > Hi Ard, > > On 28/02/2019 14:16, Ard Biesheuvel wrote: > > (+ Catalin) > > > > On Tue, 19 Feb 2019 at 16:08, Ilias Apalodimas > > wrote: > >> > >> On Tue, Feb 19, 2019 at 12:08:42AM +0100, Ard Biesheuvel wrote: > >>> It turns out that the IP c

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-02-28 Thread Robin Murphy
Hi Ard, On 28/02/2019 14:16, Ard Biesheuvel wrote: (+ Catalin) On Tue, 19 Feb 2019 at 16:08, Ilias Apalodimas wrote: On Tue, Feb 19, 2019 at 12:08:42AM +0100, Ard Biesheuvel wrote: It turns out that the IP checksumming code is still exercised often, even though one might expect that modern

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-02-28 Thread Ard Biesheuvel
(+ Catalin) On Tue, 19 Feb 2019 at 16:08, Ilias Apalodimas wrote: > > On Tue, Feb 19, 2019 at 12:08:42AM +0100, Ard Biesheuvel wrote: > > It turns out that the IP checksumming code is still exercised often, > > even though one might expect that modern NICs with checksum offload > > have no use fo

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-02-19 Thread Ilias Apalodimas
On Tue, Feb 19, 2019 at 12:08:42AM +0100, Ard Biesheuvel wrote: > It turns out that the IP checksumming code is still exercised often, > even though one might expect that modern NICs with checksum offload > have no use for it. However, as Lingyan points out, there are > combinations of features whe

[PATCH] arm64: do_csum: implement accelerated scalar version

2019-02-18 Thread Ard Biesheuvel
It turns out that the IP checksumming code is still exercised often, even though one might expect that modern NICs with checksum offload have no use for it. However, as Lingyan points out, there are combinations of features where the network stack may still fall back to software checksumming, and s