On Tue, Jan 30, 2007 at 10:45:18PM +0100, Francois Romieu wrote:
> Olof Johansson <[EMAIL PROTECTED]> :
> > On Mon, Jan 29, 2007 at 11:35:06PM +0100, Francois Romieu wrote:
> [...]
> > > - The driver does not contain a single SMP locking instruction but
> > > http://www.pasemi.com claims the plat
Olof Johansson <[EMAIL PROTECTED]> :
> On Mon, Jan 29, 2007 at 11:35:06PM +0100, Francois Romieu wrote:
[...]
> > - The driver does not contain a single SMP locking instruction but
> > http://www.pasemi.com claims the platform to be multicore.
> > Is the driver really designed to be lockless ?
On Mon, Jan 29, 2007 at 09:34:06PM -0500, Jeff Garzik wrote:
> Olof Johansson wrote:
> >Right now it's guaranteed that the interrupts will not be shared. They're
> >fixed for the on-chip devices, and no other driver should be binding to
> >the same channels (and thus irqs).
> >
> >If it changes in
On Tue, Jan 30, 2007 at 10:03:58AM +, Christoph Hellwig wrote:
> On Mon, Jan 29, 2007 at 12:08:52AM -0600, Olof Johansson wrote:
> > Driver for the PA Semi PWRficient on-chip Ethernet (1/10G)
> >
> > Basic enablement, will be complemented with performance enhancements
> > over time. PHY suppor
On Tue, Jan 30, 2007 at 10:06:49AM +, Christoph Hellwig wrote:
> On Mon, Jan 29, 2007 at 07:41:16PM -0600, Olof Johansson wrote:
> > Maybe a bit of introduction could be useful (also regarding the
> > pci_map/alloc comments below).
> >
> > Our devices are on-chip, and while they're not on a PC
On Mon, Jan 29, 2007 at 07:41:16PM -0600, Olof Johansson wrote:
> Maybe a bit of introduction could be useful (also regarding the
> pci_map/alloc comments below).
>
> Our devices are on-chip, and while they're not on a PCI(e) bus internally,
> they do have config headers and will show up as device
On Mon, Jan 29, 2007 at 12:08:52AM -0600, Olof Johansson wrote:
> Driver for the PA Semi PWRficient on-chip Ethernet (1/10G)
>
> Basic enablement, will be complemented with performance enhancements
> over time. PHY support will be added as well.
>
> This patch still uses the numerical PCI vendor
Olof Johansson wrote:
On Mon, Jan 29, 2007 at 10:22:33AM -0800, Stephen Hemminger wrote:
Basic initalization, setup comments.
Thanks, fixes have been incorporated and will be reposted. Most of them
was obviously just my lack of diligence. See however the two below.
+static irqreturn_t pasemi
Hi,
Thanks for the comments. In general I have applied them, with some specific
comments below.
I'll repost a new version of the driver based on this and other feedback
later tonight.
On Mon, Jan 29, 2007 at 11:35:06PM +0100, Francois Romieu wrote:
> Olof Johansson <[EMAIL PROTECTED]> :
> > Driv
On Mon, Jan 29, 2007 at 10:22:33AM -0800, Stephen Hemminger wrote:
> Basic initalization, setup comments.
Thanks, fixes have been incorporated and will be reposted. Most of them
was obviously just my lack of diligence. See however the two below.
> > +static irqreturn_t pasemi_mac_tx_intr(int irq,
Olof Johansson <[EMAIL PROTECTED]> :
> Driver for the PA Semi PWRficient on-chip Ethernet (1/10G)
>
> Basic enablement, will be complemented with performance enhancements
> over time. PHY support will be added as well.
- The driver does not contain a single SMP locking instruction but
http://ww
Basic initalization, setup comments.
> +static int pasemi_mac_open(struct net_device *dev)
> +{
> + struct pasemi_mac *mac = netdev_priv(dev);
> + unsigned int flags;
> + int ret;
> +
> + pr_debug("pasemi_mac_open\n");
dev_dbg() ?
> +
> + /* enable rx section */
> + pci_w
Driver for the PA Semi PWRficient on-chip Ethernet (1/10G)
Basic enablement, will be complemented with performance enhancements
over time. PHY support will be added as well.
This patch still uses the numerical PCI vendor id, it will be replaced
when the pci_ids.h change goes in (same as the other
13 matches
Mail list logo
