On Mon, Jan 29, 2007 at 09:34:06PM -0500, Jeff Garzik wrote:
> Olof Johansson wrote:
> >Right now it's guaranteed that the interrupts will not be shared. They're
> >fixed for the on-chip devices, and no other driver should be binding to
> >the same channels (and thus irqs).
> >
> >If it changes in the future, the driver would need other rework as well.
>
> Nonetheless, it is far more sane to check for work, and return if no
> work. Who knows if the hardware will signal an interrupt early or late.
Easy enough. Added in the next version.
> >>>+static struct pci_driver pasemi_mac_driver = {
> >>>+ .name = "pasemi_mac",
> >>>+ .id_table = pasemi_mac_pci_tbl,
> >>>+ .probe = pasemi_mac_probe,
> >>Don't you need a remove routine?
> >
> >No hotplug support at this time, so I didn't see any use in providing one.
>
> module remove.
Oh, good point. Added in the next version to be posted.
Thanks,
-Olof
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
