Re: [EXT] Re: [PATCH v2 net-next 01/12] net: atlantic: changes for multi-TC support

2020-05-25 Thread Jakub Kicinski
On Fri, 22 May 2020 19:47:37 + Mark Starovoytov wrote: > > > * use AQ_HW_*_TC instead of hardcoded magic numbers; > > > * actually use the 'ret' value in aq_mdo_add_secy(); > > > > Whenever you do an enumeration like this - it's a strong indication that > > those > > should all be separate

RE: [EXT] Re: [PATCH v2 net-next 01/12] net: atlantic: changes for multi-TC support

2020-05-22 Thread Mark Starovoytov
Hi Jakub, Thank you for the review. > > This patch contains the following changes: > > * access cfg via aq_nic_get_cfg() in aq_nic_start() and > > aq_nic_map_skb(); ... > > * use AQ_HW_*_TC instead of hardcoded magic numbers; > > * actually use the 'ret' value in aq_mdo_add_secy(); > > Whenever