On Fri, 22 May 2020 19:47:37 +0000 Mark Starovoytov wrote: > > > * use AQ_HW_*_TC instead of hardcoded magic numbers; > > > * actually use the 'ret' value in aq_mdo_add_secy(); > > > > Whenever you do an enumeration like this - it's a strong indication that > > those > > should all be separate patches. Please keep that in mind going forward. > > Understood, but I've also seen a recommendation that a single > patchset shouldn't have more than 15 patches (if my memory doesn't > fail me). And unfortunately it would have been impossible to meet the > 15 patches limit, if all these small changes were in separate > patches. What's the best/recommended approach in this case?
Non-functional changes like that will usually get reviewed and merged within 24 hours, so if series gets longer than 15 patches I'd personally separate low-risk / refactoring changes into a series of their own. And then post the rest of the code once they get merged.
