Re: TPACKET_V3 timeout bug?

2017-05-02 Thread chetan loke
On Tue, May 2, 2017 at 8:04 AM, chetan loke wrote: > On Sat, Apr 15, 2017 at 7:41 PM, Guy Harris wrote: >> On Apr 15, 2017, at 7:10 PM, Andrew Lunn wrote: >> >>> Do you think this is a kernel problem, libpcap problem, or an >>> application problem? >&

Re: TPACKET_V3 timeout bug?

2017-05-02 Thread chetan loke
On Sat, Apr 15, 2017 at 7:41 PM, Guy Harris wrote: > On Apr 15, 2017, at 7:10 PM, Andrew Lunn wrote: > >> Do you think this is a kernel problem, libpcap problem, or an >> application problem? > Its clearly a kernel regression. If you look at if_packet.h, I have explicitly called out all the cas

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

2017-03-06 Thread chetan loke
On Mon, Mar 6, 2017 at 9:45 AM, Willem de Bruijn wrote: > On Mon, Mar 6, 2017 at 12:13 PM, chetan loke wrote: >>>> >>>> Gosh. Can we also replace this BUG() into something less aggressive ? >>> >>> >>> There are currently 5 of these WARN() +

Re: [RFC PATCH 1/2] af_packet: direct dma for packet ineterface

2017-03-06 Thread chetan loke
On Tue, Jan 31, 2017 at 9:09 PM, John Fastabend wrote: >> If I understand correctly, the difficulty lies in v3 requiring that the >> timer "close" the block when the timer expires. That may not be worth >> implementing, indeed. >> > > Yep that is where I just gave up and decided it wasn't worth i

Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode

2017-03-06 Thread chetan loke
>> >> Gosh. Can we also replace this BUG() into something less aggressive ? > > > There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only > for the 'default' TPACKET version spread all over af_packet, so probably > makes sense to rather make all of them less aggressive. > > Very