Re: [PATCH bpf-next v3] virtio_net: add XDP meta data support

2019-07-02 Thread Yuya Kusakabe
On 7/2/19 5:33 PM, Jason Wang wrote: > > On 2019/7/2 下午4:16, Yuya Kusakabe wrote: >> This adds XDP meta data support to both receive_small() and >> receive_mergeable(). >> >> Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") >> Signed-o

[PATCH bpf-next v3] virtio_net: add XDP meta data support

2019-07-02 Thread Yuya Kusakabe
This adds XDP meta data support to both receive_small() and receive_mergeable(). Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") Signed-off-by: Yuya Kusakabe --- v3: - fix preserve the vnet header in receive_small(). v2: - keep copy untouched in page_to_skb(). - pr

Re: [PATCH bpf-next v2] virtio_net: add XDP meta data support

2019-07-01 Thread Yuya Kusakabe
On 7/2/19 12:59 PM, Jason Wang wrote: > > On 2019/7/2 上午11:15, Yuya Kusakabe wrote: >> This adds XDP meta data support to both receive_small() and >> receive_mergeable(). >> >> Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") >&

[PATCH bpf-next v2] virtio_net: add XDP meta data support

2019-07-01 Thread Yuya Kusakabe
This adds XDP meta data support to both receive_small() and receive_mergeable(). Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") Signed-off-by: Yuya Kusakabe --- v2: - keep copy untouched in page_to_skb(). - preserve the vnet header in receive_small(). - fix i

Re: [PATCH bpf-next] virtio_net: add XDP meta data support

2019-07-01 Thread Yuya Kusakabe
On 7/1/19 6:30 PM, Jason Wang wrote: > > On 2019/6/27 下午4:06, Yuya Kusakabe wrote: >> This adds XDP meta data support to both receive_small() and >> receive_mergeable(). >> >> Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") >> Signed-

[PATCH bpf-next] virtio_net: add XDP meta data support

2019-06-27 Thread Yuya Kusakabe
This adds XDP meta data support to both receive_small() and receive_mergeable(). Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") Signed-off-by: Yuya Kusakabe --- drivers/net/virtio_net.c | 40 +--- 1 file changed, 29 inserti

Re: [PATCH bpf-next] virtio_net: add XDP meta data support in receive_small()

2019-06-27 Thread Yuya Kusakabe
upport XDP meta data to receive_mergeable(). But I'll try it a little more. Please wait for the next patch. >> >> Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") >> Signed-off-by: Yuya Kusakabe > > >Could you please cc virtio maintainer

[PATCH bpf-next] virtio_net: add XDP meta data support in receive_small()

2019-06-26 Thread Yuya Kusakabe
This adds XDP meta data support to the code path receive_small(). mrg_rxbuf=off is required on qemu, because receive_mergeable() still doesn't support XDP meta data. Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") Signed-off-by: Yuya Kusakabe --- drivers/net/vi

[PATCH v3] net: Fix missing meta data in skb with vlan packet

2019-04-15 Thread Yuya Kusakabe
skb_reorder_vlan_header() should move XDP meta data with ethernet header if XDP meta data exists. Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") Signed-off-by: Yuya Kusakabe Signed-off-by: Takeru Hayasaka Co-developed-by: Takeru Hayasaka --- net/core/skb

Re: [PATCH v2] net: Fix missing meta data in skb with vlan packet

2019-04-15 Thread Yuya Kusakabe
On 4/16/19 9:45 AM, Toshiaki Makita wrote: > On 2019/04/15 23:21, Yuya Kusakabe wrote: >> skb_reorder_vlan_header() should move XDP meta data with ethernet header >> if XDP meta data exists. >> >> Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access&q

[PATCH v2] net: Fix missing meta data in skb with vlan packet

2019-04-15 Thread Yuya Kusakabe
skb_reorder_vlan_header() should move XDP meta data with ethernet header if XDP meta data exists. Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") Signed-off-by: Yuya Kusakabe Signed-off-by: Takeru Hayasaka Co-developed-by: Takeru Hayasaka --- net/core/skb

Re: [PATCH] net: Fix missing meta data in skb with vlan packet

2019-04-15 Thread Yuya Kusakabe
On Mon, Apr 15, 2019 at 5:08 PM Toshiaki Makita wrote: > > On 2019/04/15 16:43, Yuya Kusakabe wrote: > ... > > > @@ -5095,6 +5096,13 @@ static struct sk_buff > > > *skb_reorder_vlan_header(struct sk_buff *skb) > > > mem

Re: [PATCH] net: Fix missing meta data in skb with vlan packet

2019-04-15 Thread Yuya Kusakabe
Hi, Thank you for the review. On Mon, Apr 15, 2019 at 3:06 PM Toshiaki Makita wrote: > > Hi, > (CC: XDP maintainers) > > On 2019/04/13 21:16, Yuya Kusakabe wrote: > > skb_reorder_vlan_header() should move XDP meta data with ethernet > > header if XDP meta data ex

[PATCH] net: Fix missing meta data in skb with vlan packet

2019-04-13 Thread Yuya Kusakabe
skb_reorder_vlan_header() should move XDP meta data with ethernet header if XDP meta data exists. Signed-off-by: Yuya Kusakabe Signed-off-by: Takeru Hayasaka Co-developed-by: Takeru Hayasaka --- net/core/skbuff.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a