Re: rtl8152 / power management kernel hang

2021-04-19 Thread Thiago Macieira
is still on 5.11. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering

Re: rtl8152 / power management kernel hang

2021-04-15 Thread Thiago Macieira
27;s one they used to offer for sale 4 years ago or so and has an HDMI, a mini-DP, VGA, three USB and one network port in the back. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering

rtl8152 / power management kernel hang

2021-04-13 Thread Thiago Macieira
io Bus 001 Device 004: ID 0bda:5682 Realtek Semiconductor Corp. Integrated_Webcam_HD -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering Bus 004 Device 003: ID 0bda:8153 Realtek Semiconductor Corp. RTL8153 Gigabit Ethernet Adapter Couldn't

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-16 Thread Thiago Macieira
On Wednesday, 16 August 2017 16:27:17 PDT Willem de Bruijn wrote: > Actually, it is safe even without the check. Overflow of the signed integer > is benign here. Usually, it's a bad idea to allow UB to happen. Where is the overflow? I didn't see it in the patches so far. --

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-14 Thread Thiago Macieira
On Monday, 14 August 2017 12:03:16 PDT Willem de Bruijn wrote: > On Mon, Aug 14, 2017 at 2:58 PM, Thiago Macieira > > wrote: > > On Monday, 14 August 2017 11:46:42 PDT Willem de Bruijn wrote: > >> > By the way, what were the usecases for the peek offset feature? &g

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-14 Thread Thiago Macieira
with epoll, there's no new edge trigger since event is already at level. How will they avoid busy-waiting? And won't this secondary coordination obviate the need for offset peeking? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-14 Thread Thiago Macieira
Understood. By the way, what were the usecases for the peek offset feature? Also, do they apply to non-peeking recv? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-14 Thread Thiago Macieira
of skipping over datagrams that are too short? > > That's how we deal with empty datagrams anyway. > > What is? With no-offset and a zero payload skb at the head, peek > or recv returns 0, right? Right. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-14 Thread Thiago Macieira
hould the reading return an empty datagram? This would indicate to the caller that there was a datagram there, which was skipped over. That's how we deal with empty datagrams anyway. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center