the current patch went through Intel
testing and is merged. Smaller patches, smaller steps are usually
better, so let's make one change at a time.
Thanks!
Stefan
> Slawek
>
>
> -Original Message-
> From: Stefan Assmann
> Sent: Wednesday, March 17, 2021 8:50 AM
On 16.03.21 23:02, Jesse Brandeburg wrote:
> Jakub Kicinski wrote:
I personally think that the overuse of flags in Intel drivers brings
nothing but trouble. At which point does it make sense to just add a
lock / semaphore here rather than open code all this with no clear
semanti
On 16.03.21 18:14, Jakub Kicinski wrote:
> On Tue, 16 Mar 2021 11:01:41 +0100 Stefan Assmann wrote:
>> To avoid races between iavf_init_task(), iavf_reset_task(),
>> iavf_watchdog_task(), iavf_adminq_task() as well as the shutdown and
>> remove functions more locking is req
function perorms a state transition and also free's
resources.
iavf_lock_timeout() is introduced to avoid waiting infinitely
and cause a deadlock. Rather unlock and print a warning.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 57 ++---
1
Both iavf_free_all_tx_resources() and iavf_free_all_rx_resources() have
already been called in the very same function.
Remove the duplicate calls.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net
;state in iavf_watchdog_task()
and let the reset task handle the state transition.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 0a8
ility")
Fix-suggested-by: Paolo Abeni
Signed-off-by: Stefan Assmann
---
.../ethernet/intel/i40e/i40e_virtchnl_pf.c| 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
b/drivers/net/ethernet/
: 9889707b06ac ("i40e: Fix crash caused by stress setting of VF MAC
addresses")
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtch
ned-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 8e133d6545bd..9c4b166f3346 100644
---
uling while atomic possibility)
Reported-by: Michal Schmidt
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
b/drivers/net/ethernet/
: 37d318d7805f ("i40e: Remove scheduling while atomic possibility")
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
b/d
On 12.08.20 19:46, Jakub Kicinski wrote:
> On Wed, 12 Aug 2020 16:39:50 +0200 Stefan Assmann wrote:
>> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function
>> ‘i40e_set_vsi_promisc’:
>> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1176:14: error: ‘aq
statement and the for loop does not get
executed aq_ret will be uninitialized when the variable gets returned at
the end of the function.
Fixes: 37d318d7805f ("i40e: Remove scheduling while atomic possibility")
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_virtchn
place.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 1 -
drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 7 +++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
b/drivers/net/ethernet/intel/iavf
On 03.09.19 08:42, Paul Menzel wrote:
> Dear Stefan,
Hi Paul,
> On 03.09.19 08:08, Stefan Assmann wrote:
>> In the case of an invalid min tx rate being requested
>> i40e_ndo_set_vf_bw() immediately returns -EINVAL instead of releasing
>> __I40E_VIRTCHNL_OP_PENDING first
In the case of an invalid min tx rate being requested
i40e_ndo_set_vf_bw() immediately returns -EINVAL instead of releasing
__I40E_VIRTCHNL_OP_PENDING first.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
i_filters() in
i40e_sync_filters_subtask() needs to be guarded by __I40E_VF_DISABLE,
which is also used by i40e_free_vfs().
Note: put the __I40E_VF_DISABLE check after the
__I40E_MACVLAN_SYNC_PENDING check as the latter is more likely to
trigger.
Signed-off-by: Stefan Assmann
---
drivers/net/ether
The current check for WoL on i40e is broken. Code comment says only
magic packet is supported, so only check for that.
Fixes: 540a152da762 (i40e/ixgbe/igb: fail on new WoL flag setting
WAKE_MAGICSECURE)
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3
00:08:00.0: fw 6.1.49420 api 1.7 nvm 6.80 0x80003c64 1.2007.0
and after
i40e :08:00.0: fw 6.1.49420 api 1.7 nvm 6.80 0x80003c64 1.2007.0
[8086:1572] [8086:0004]
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 7 ---
1 file changed, 4 insertions(+), 3
opefully that makes the code easier to read.
Fixes: 458867b2ca0c ("i40e: don't remove netdev->dev_addr when syncing uc list")
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
I ran into the same issue. Here's my proposed fix.
>From 46c74c25496bab06712641c7b2b6b34e365397a2 Mon Sep 17 00:00:00 2001
From: Stefan Assmann
Date: Mon, 30 Jul 2018 21:38:43 +0200
Subject: [PATCH] i40e: fix i40e_get_stat_strings strings count warning
The current code calculates p - data,
On 2018-03-01 19:40, Alexander Duyck wrote:
> On Thu, Mar 1, 2018 at 8:12 AM, wrote:
> > + intel-wired-...@lists.osuosl.org
> >
> >
> > On 2018-03-01 21:41, p...@codeaurora.org wrote:
> >>
> >> Hi All,
> >>
> >> I am facing the following issue on kernel 4.14.14.
> >>
> >> Enable SRIOV on Intel x7
disabled
The NIC is fully operational after the flash and even after a cold boot
any follow-up eeprom checks succeed.
This needs to be investigated, but for now it should be more important
to make sure the firmware update works as expected.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel
recent workqueue change. Haven't gotten to the bottom of this yet, but
for the sake of a smooth firmware update experience let's revert the
commit for now.
Stefan Assmann (2):
i40e: use non-locking i40e_read_nvm_word() function during nvmupdate
Revert "i40e: remove WQ_UNBOU
working again.
Fixes: ("96a39aed25e6 i40e: Acquire NVM lock before reads on all devices")
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_nvm.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/
The current name of vf_offload_flags indicates that the bitmap is
limited to offload related features. Make this more generic by renaming
it to vf_cap_flags, which allows for other capabilities besides
offloading to be added.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e
address change
without the VF trust hint.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 +++
drivers/net/ethernet/intel/i40evf/i40evf_main.c| 3 ++-
include/linux/avf/virtchnl.h | 1 +
3 files changed, 6 insertions(+), 1 deletion
patch then adds a flag to vf_cap_flags to give the VF information on
whether it runs in trusted mode and makes use of the flag in i40evf.
Patches are against jkirshers dev-queue branch.
Stefan Assmann (2):
i40e/i40evf: rename vf_offload_flags to vf_cap_flags in struct
virtchnl_vf_resource
On 25.06.2017 08:21, Leon Romanovsky wrote:
> On Fri, Jun 23, 2017 at 09:46:24AM +0200, Stefan Assmann wrote:
>> When an administratively set MAC was previously set and should now be
>> switched back to 00:00:00:00:00:00 the pf_set_mac flag did not get
>> toggled back to fals
When an administratively set MAC was previously set and should now be
switched back to 00:00:00:00:00:00 the pf_set_mac flag did not get
toggled back to false.
As a result VFs were still treated as if an administratively set MAC was
present.
Signed-off-by: Stefan Assmann
---
drivers/net
On 04.04.2017 18:56, Or Gerlitz wrote:
> On Tue, Apr 4, 2017 at 5:34 PM, Stefan Assmann wrote:
>> The client interface is meant for X722 iWARP support. Modprobing i40iw
>> on systems with X710/XL710 NICs currently may crash the system.
>
> just curious may or crash? and why?
The client interface is meant for X722 iWARP support. Modprobing i40iw
on systems with X710/XL710 NICs currently may crash the system. Adding a
check which limits client interface access to the appropriate hardware.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_client.c
On 29.09.2016 14:05, Alexander Duyck wrote:
> So the i40e driver had a really convoluted configuration for how to handle
> the debug flags contained in msg_enable. Part of the issue is that the
> driver has its own 32 bit mask that it was using to track a separate set of
> debug features. From wh
On 24.09.2016 04:48, Alexander Duyck wrote:
> On Fri, Sep 23, 2016 at 6:30 AM, Stefan Assmann wrote:
>> This debug statement is confusing and never set in the code. Any debug
>> output should be guarded by the proper I40E_DEBUG_* statement which can
>> be enabled via the debu
v2 fixes setting the debug_mask in i40e_set_msglevel().
Stefan Assmann (2):
i40e: remove superfluous I40E_DEBUG_USER statement
i40e: fix setting debug parameter early
drivers/net/ethernet/intel/i40e/i40e_common.c | 3 --
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6
drivers
the bitmask as that's what the driver actually uses
in i40e_debug(). Otherwise the debug parameter is just a noop.
Fixes: 5b5faa4 ("i40e: enable debug earlier")
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++-
1 file changed, 7
i40e_set_msglevel() so that the
debug level can still be altered via ethtool msglvl.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_common.c | 3 ---
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6 -
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3
, attempting to redistribute
vectors
i40e 00.0 MSI-X vector distribution: PF 78, VMDq 8, FDSB 0, iWARP 42
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 38 +
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/drivers/net
During MSI-X vector allocation for VMDq, a check for "no vectors left"
was missing, add it. This prevents more vectors to be allocated than
available.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 27 ---
1 file changed, 16
Stefan Assmann (3):
i40e: check if vectors are already depleted when doing VMDq allocation
i40e: fix MSI-X vector redistribution if hw limit is reached
i40e: fix sideband flow director vector allocation
drivers/net/ethernet/intel/i40e/i40e_main.c | 76 ++---
1 file
Currently if the MSI-X vector limit is reached the sideband flow
director gets disabled. A bit too early to make that decision, as
vectors may get re-distributed. So move the check further back.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +--
1
Stefan Assmann (2):
i40e: remove superfluous I40E_DEBUG_USER statement
i40e: fix setting debug parameter early
drivers/net/ethernet/intel/i40e/i40e_common.c | 3 --
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 --
drivers/net
the bitmask as that's what the driver actually uses
in i40e_debug(). Otherwise the debug parameter is just a noop.
Fixes: 5b5faa4 ("i40e: enable debug earlier")
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++-
1 file changed, 7
This debug statement is confusing and never set in the code. Any debug
output should be guarded by the proper I40E_DEBUG_* statement which can
be enabled via the debug module parameter.
Remove or convert the I40E_DEBUG_USER cases to I40E_DEBUG_INIT.
Signed-off-by: Stefan Assmann
---
drivers/net
-negotiation: No
Advertised link modes: 1baseT/Full
[...]
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
b/drivers/net/ethernet/intel/i40e
On 06.02.2016 00:13, Stefan Assmann wrote:
> On 02/05/2016 10:24 PM, Laine Stump wrote:
>> Stefan,
>>
>> I have an AMD 990FX system with an Intel 82576 card that could not
>> successfully boot with any kernel starting somewhere prior to 4.2, but
>> does boot prop
and investigaton is here:
https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg10687.html
On 09/17/2015 08:46 AM, Stefan Assmann wrote:
In igb_sw_init() the sequence of calls was changed from
igb_init_queue_configuration()
igb_init_interrupt_scheme()
igb_pro
On 02.02.2016 22:28, David Miller wrote:
>
> Always, when sending an updated version of a patch which is part of a
> series, always resubmit the entire series rather than just the patch
> which is changing.
>
> Thanks.
>
Sorry Dave, going to send out a complete V2 right away.
Stefan
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++--
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 2 ++
drivers/net/ethernet/intel/ix
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/igb/igb.h | 2 ++
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
drivers/net/ethernet/intel/igb/igb_main.c
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/e1000/e1000.h | 2 ++
drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++--
drivers/net/ethernet/intel/e1000/e1000_m
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 ++
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_m
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
V2: rename e1000_open(), e1000_close() to e1000e_open(), e1000e_close()
to avoid name clash with e1000.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/e1000e/e1000.h
_open(), e1000e_close()
to avoid name clash with e1000.
Stefan Assmann (6):
i40e: call ndo_stop() instead of dev_close() when running offline
selftest
ixgbe: call ndo_stop() instead of dev_close() when running offline
selftest
ixgbevf: call ndo_stop() instead of dev_close() when ru
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--
drivers/net/ethernet/intel/i40e/i40e_m
Here's a V2 that fixes the name collision.
>From 8f617672b97324058adf5b8981c4b91defad8c3a Mon Sep 17 00:00:00 2001
From: Stefan Assmann
Date: Mon, 1 Feb 2016 13:18:24 +0100
Subject: [PATCH net-next] e1000e: call ndo_stop() instead of dev_close() when
running offline selftest
Calling d
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++--
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 2 ++
drivers/net/ethernet/intel/ix
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/igb/igb.h | 2 ++
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
drivers/net/ethernet/intel/igb/igb_main.c
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/e1000e/e1000.h | 2 ++
drivers/net/ethernet/intel/e1000e/ethtool.c | 4 ++--
drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--
drivers/net/ethernet/intel/i40e/i40e_m
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/e1000/e1000.h | 2 ++
drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++--
drivers/net/ethernet/intel/e1000/e1000_m
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 ++
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_m
ur is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Tested this with igb, e1000e, ixgbe and i40e. All drivers now are able to
resume operation without restoring the IP address, gateway or such.
Stefan Assmann (6):
i40e: call ndo_stop() inste
e calling
igb_probe_vfs(). The real interrupt capabilities will be checked during
igb_init_interrupt_scheme() so this is safe to do.
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/igb/igb_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/i
0xe/0x10
[ 68.680038] [] igbvf_clean_rx_ring+0x96/0x370 [igbvf]
[ 68.687516] [] igbvf_down+0x105/0x110 [igbvf]
[ 68.694219] [] igbvf_change_mtu+0x16b/0x180 [igbvf]
[...]
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/igbvf/netdev.c | 1 +
1 file changed, 1 insertion(+)
diff
028:0481]
Signed-off-by: Stefan Assmann
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet/intel/igb/igb_main.c
index f287186..7f41237 100644
--- a/drivers/net/e
There's some trouble with a kvm guest that is bridged to the host
networks i40e (X710) NIC. The guest no longer receives DHCP replies and
probably other traffic as well.
I bisected this back to the following commit.
commit 79c21a827e98081895a8b9650f1b0a8b37b16125
Author: Anjali Singhai Jain
Date:
67 matches
Mail list logo
