[PATCH net-next 4/4] sh_eth: place RX/TX descriptor *enum*s after their *struct*s

2021-03-12 Thread Sergey Shtylyov
Place the RX/TX descriptor bit *enum*s where they belong -- after the corresponding RX/TX descriptor *struct*s and, while at it, switch to declaring one *enum* entry per line... Signed-off-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/sh_eth.h | 82

[PATCH net-next 3/4] sh_eth: rename *enum*s still not matching register names

2021-03-12 Thread Sergey Shtylyov
Finally, rename the rest of the *enum* tags still not (exactly) matching the abbreviated register names from the manuals... Signed-off-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/sh_eth.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Index: net-next/drivers/net

[PATCH net-next 2/4] sh_eth: rename PSR bits

2021-03-12 Thread Sergey Shtylyov
In all the SoC manuals (except R-Car gen2) the PHY status register's name is abbreviated to PSR with the only valid bit 0 named LMON. Follow the suit and rename the corresponding *enum* tag/entry. Signed-off-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |2 +- driver

[PATCH net-next 1/4] sh_eth: rename TRSCER bits

2021-03-12 Thread Sergey Shtylyov
In all the SoC manuals the TRSCER register bits match the corresponding EESR registers's bits, but only on the R-Car gen2 SoC those are named RINT and TINT. Follow the suit and rename the *enum* tag/entries from DESC_I_* to TRSCER_*. Signed-off-by: Sergey Shtylyov --- drivers/net/eth

[PATCH net-next 0/4] Improve the register/bit definitions in the Ether driver

2021-03-12 Thread Sergey Shtylyov
Here are 4 patches against DaveM's 'net-next' repo. Mainly I'm renaming the register *enum* tags/entries to match the SoC manuals,and also moving the RX-TX descriptor *enum*s closer to the corresponding *struct*s... [1/4] sh_eth: rename TRSCER bits [2/4] sh_eth: rename PSR bits [3/4] sh_eth: ren

[PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210

2021-02-28 Thread Sergey Shtylyov
Add R7S9210 support") Signed-off-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |2 ++ 1 file changed, 2 insertions(+) Index: net/drivers/net/ethernet/renesas/sh_eth.c === --- net.orig/drivers/net/ethernet/renesas

[PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100

2021-02-28 Thread Sergey Shtylyov
;sh_eth: Add support for r7s72100") Signed-off-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |2 ++ 1 file changed, 2 insertions(+) Index: net/drivers/net/ethernet/renesas/sh_eth.c === --- net.orig/dri

[PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x

2021-02-28 Thread Sergey Shtylyov
bits declared (and set) in the original driver. Follow the suit and add the explicit sh_eth_cpu_data::trscer_err_mask initializer for SH771x... Fixes: 86a74ff21a7a ("net: sh_eth: add support for Renesas SuperH Ethernet") Signed-off-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/

[PATCH net 0/3] Fix TRSCER masks in the Ether driver

2021-02-28 Thread Sergey Shtylyov
Here are 3 patches against DaveM's 'net' repo. I'm fixing the TRSCER masks in the driver to match the manuals... [1/3] sh_eth: fix TRSCER mask for SH771x [2/3] sh_eth: fix TRSCER mask for R7S72100 [3/3] sh_eth: fix TRSCER mask for R7S9210

Re: [PATCH 1/2] bluetooth: hci_event: consolidate error paths in hci_phy_link_complete_evt()

2021-01-23 Thread Sergey Shtylyov
On 11/23/20 2:58 PM, Marcel Holtmann wrote: >>>> hci_phy_link_complete_evt() has several duplicate error paths -- >>>> consolidate >>>> them, using the *goto* statements. >>>> >>>> Signed-off-by: Sergey Shtylyov >>>> >

[PATCH net-next 2/2] ravb: update "undocumented" annotations

2021-01-06 Thread Sergey Shtylyov
.. Signed-off-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/ravb.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) Index: net-next/drivers/net/ethernet/renesas/ravb.h === --- net-next.or

[PATCH net-next 0/2] Update register/bit definitions in the EtherAVB driver

2021-01-06 Thread Sergey Shtylyov
Here are 2 patches against DaveM's 'net-next' repo. I'm updating the driver to match the recent R-Car gen2/3 manuals... [1/2] ravb: remove APSR_DM [2/2] ravb: update "undocumented" annotations

[PATCH net-next 1/2] ravb: remove APSR_DM

2021-01-06 Thread Sergey Shtylyov
do several more things to the declaration of *enum* APSR_BIT: - remove superfluous indentation; - annotate APSR_MEMS as undocumented; - annotate APSR as R-Car Gen3 only. Fixes: 61fccb2d6274 ("ravb: Add tx and rx clock internal delays mode of APSR") Signed-off-by: Sergey Shtylyov

Re: [PATCH 1/2] bluetooth: hci_event: consolidate error paths in hci_phy_link_complete_evt()

2020-11-12 Thread Sergey Shtylyov
Hello! On 11.11.2020 14:12, Marcel Holtmann wrote: hci_phy_link_complete_evt() has several duplicate error paths -- consolidate them, using the *goto* statements. Signed-off-by: Sergey Shtylyov --- net/bluetooth/hci_event.c | 16 ++-- 1 file changed, 6 insertions(+), 10

[PATCH 2/2] bluetooth: hci_event: reduce indentation levels

2020-10-07 Thread Sergey Shtylyov
Reduce the indentation levels in the HCI driver, mostly by using *goto* in the error paths (and also by collapsing "double" *if* statements into the "singular" ones). This makes the coding style more consistent across the HCI driver. Signed-off-by: Sergey Shtylyov

[PATCH 1/2] bluetooth: hci_event: consolidate error paths in hci_phy_link_complete_evt()

2020-10-07 Thread Sergey Shtylyov
hci_phy_link_complete_evt() has several duplicate error paths -- consolidate them, using the *goto* statements. Signed-off-by: Sergey Shtylyov --- net/bluetooth/hci_event.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) Index: bluetooth-next/net/bluetooth

[PATCH 0/2] bluetooth: hci_event: make coding style more consistent

2020-10-07 Thread Sergey Shtylyov
Here are 2 patches against the 'bluetooth-next,git' repo. Mainly, I'm reducing the indentation levels in the HCI driver, mostly by using *goto* in the error paths in the functions where this hasn't been done -- this makes the coding style more consistent across the HCI driver... [1/2] bluetoo

Re: [PATCH RFC] bluetooth: add support for some old headsets

2020-07-21 Thread Sergey Shtylyov
Hello! On 7/17/20 10:12 PM, Sergey Shtylyov wrote: >>>>> The MediaTek Bluetooth platform (MT6630 etc.) has a peculiar >>>>> implementation >>>>> for the eSCO/SCO connection via BT/EDR: the host controller returns error &g

Re: [PATCH RFC] bluetooth: add support for some old headsets

2020-07-17 Thread Sergey Shtylyov
t precise that errors > should be reported > via sync conn complete events. My assumption would be that your headset only > supports SCO and > thus the controller realizes that eSCO request can not be completed anyway. > So the controller > opt

Re: [PATCH RFC] bluetooth: add support for some old headsets

2020-07-16 Thread Sergey Shtylyov
plen 4 >#2 [hci0] 6.719598 Setup Synchronous Connection (0x01|0x0028) ncmd 1 Status: Unsupported LMP Parameter Value / Unsupported LL Parameter Value (0x20) >> Based on the patch by Ildar Kamaletdinov . >> >>

[PATCH RFC] bluetooth: add support for some old headsets

2020-07-16 Thread Sergey Shtylyov
rofile and actually tries to check all available connection parameters despite of the specific MediaTek implementation. Without it one was unable to establish eSCO/SCO connection with some headsets. Based on the patch by Ildar Kamaletdinov . Signed-off-by: Sergey Shtylyov --- This patch is a