Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-03-17 Thread Seewer Philippe
Don Fry wrote: I get the same results in my testing. Good catch on the coding error for ecmd.transciever. Without adding some more specific code to support the Allied Telesyn cards I don`t know how to get things to work without using ethtool. Maybe someone else has a better idea. Here is my

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-27 Thread Seewer Philippe
Seewer Philippe wrote: Don Fry wrote: On Mon, Feb 20, 2006 at 04:30:22PM +0100, Seewer Philippe wrote: Basic result: Works perfectly (exceptions see below) out of the box Problem 1: During probe1, lp->options is silently overwritten with PCNET32_PORT_MII. Even setting the statement to

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-24 Thread Seewer Philippe
Don Fry wrote: On Mon, Feb 20, 2006 at 04:30:22PM +0100, Seewer Philippe wrote: Basic result: Works perfectly (exceptions see below) out of the box Problem 1: During probe1, lp->options is silently overwritten with PCNET32_PORT_MII. Even setting the statement to lp->options |= doesn&#

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-20 Thread Seewer Philippe
I'm probably stupid, but I really can't find that post. Could anyone repost please? found it (yes, this means i'm stupid) First of all, please consider all the patches i sent as junk. The mentioned patch is better than mine by a factor of a few thousands. I've tested the patch on 2.6.16-rc

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-20 Thread Seewer Philippe
I am looking over this change and the following one, to try and understand what and why you made your changes. The change made by Thomas Bogendoerfer and modified by myself is much more flexible than your changes, in that they are not specific just to the Allied Telesyn boards with multiple Phys.

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-18 Thread Seewer Philippe
> I sent out a patch for testing on November 8 to netdev which is > available on the archives, with a patch to support boards with multiple > phys. I have received few comments on the code. Maybe you could test > that code and see if it does what you need. I was waiting until 2.6.16 > is final b

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-17 Thread Seewer Philippe
ic PHY scanner (which is possible) because that would have haa impact on all cards not only cards that actually have more than one phy. I really tried to put this into pcnet32_open. But i just didn't work... > > As I review your patches I will follow up to the mailing list. > >

Re: [PATCH 2/2] pcnet32: PHY selection support

2006-02-17 Thread Seewer Philippe
Adam Kropelin wrote: > Seewer Philippe wrote: > >>Most AMD pcnet chips support up to 32 external PHYs. This patch >>introduces basic PHY selection/switching support, by adding two >>new module parameters: >>-maxphy: how many PHYs the card supports >>-usephy

[PATCH 2/2] pcnet32: PHY selection support

2006-02-17 Thread Seewer Philippe
Most AMD pcnet chips support up to 32 external PHYs. This patch introduces basic PHY selection/switching support, by adding two new module parameters: -maxphy: how many PHYs the card supports -usephy: which phy to use instead of eeprom default Maxphy is necessary in order to check the range of us

[PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-02-17 Thread Seewer Philippe
This patch extends Don Fry's last patch for AT 2700/01 FX to set the speed/fdx options for the FTX variants of these cards as well. Additionally the option override has been moved from pcnet32_open to pcnet32_probe1 because it's only necessary to override the options once. Tested and works. Pat