Adam Kropelin wrote: > Seewer Philippe wrote: > >>Most AMD pcnet chips support up to 32 external PHYs. This patch >>introduces basic PHY selection/switching support, by adding two >>new module parameters: >>-maxphy: how many PHYs the card supports >>-usephy: which phy to use instead of eeprom default >> >>Maxphy is necessary in order to check the range of usephy and may >>be overriden inside the module. > > > It seems a bit pointless for the range check of a user-supplied value to > be driven by another user-supplied value. I just want to make sure and there's the possibility of supplying only maxphy and let the autoswitch algorithm decide... > > >>If only maxphy is present I've implemented an algorithm which checks >>the link state on all PHYs and uses the one that has a link. > > > Knowing how many PHYs to scan is potentially useful, but how about > determining that at runtime? Missing PHYs should be detectable with a > timeout or similar. Too risky? Actually its possible to query them with mii and all non-present phy's should "return" 0xffff. I wanted my changes to have no impact on pcnet cards with only one phy, thats why.
> > --Adam > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
