alize
tcp_ulp_ops. Also make sure tls context is freed only for listen
sockets.
Fixes: 95fa145479fb ("bpf: sockmap/tls, close can race with map free")
Signed-off-by: Vinay Kumar Yadav
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/chtls/chtls_cm.c| 12 ---
.../chelsi
On 13/01/21 10:37 PM, Tariq Toukan wrote:
On 1/13/2021 5:35 AM, Alexander Duyck wrote:
On Tue, Jan 12, 2021 at 6:43 PM rohit maheshwari
wrote:
On 07/01/21 12:47 AM, Jakub Kicinski wrote:
On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote:
Mandating NETIF_F_HW_CSUM to enable TLS
On 07/01/21 12:47 AM, Jakub Kicinski wrote:
On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote:
Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong.
And it broke tls offload feature for the drivers, which are still
using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use
abled")
Signed-off-by: Rohit Maheshwari
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index a46334906c94..b1f99287f280 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -9643,7 +9643,7 @@ static netdev_
rt to hw_features")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 7fd264a6d085..f9
rotocol-aware")
Signed-off-by: Rohit Maheshwari
---
net/tls/tls_device.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index 6cc9fe778356..f7fb7d2c1de1 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -998,
Currently lock gets freed only if timeout expires, but missed a
case when HW returns failure and goes for cleanup.
Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails")
Signed-off-by: Rohit Maheshwari
---
.../net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c|
Currently lock gets freed only if timeout expires, but missed a
case when HW returns failure and goes for cleanup.
Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails")
Signed-off-by: Rohit Maheshwari
---
.../net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c |
Stop the queue and ask for the credits if queue reaches to
threashold.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 18 +++---
1 file changed, 15 insertions(+), 3
context id and port id should be filled while sending tcb update.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12
1 file changed, 8 insertions(+), 4 deletion
time, that's
why we need to check if remaining part is smaller than TAG
size, then reset TX_MAX to be TAG starting sequence number.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/c
ve it for tls offload handling.
v2->v3:
- Removed ifdef.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
;v3:
- Replaced GFP_KERNEL with GFP_ATOMIC.
- Removed mixed fixes.
v3->v4:
- Corrected fixes tag issue.
v4->v5:
- Separated mixed fixes from patch 4.
v5-v6:
- Fixes tag should be at the end.
Rohit Maheshwari (12):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls: Correction in finding
iddle part of record")
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 2 +
.../net/ethernet/chelsio/cxgb4/cxgb4_uld.h| 1 +
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 116 +-
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 1
Checksum update was missing in the WR.
Fixes: 429765a149f1 ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/d
There is a possibility of linear skbs coming in. Correcting
the length extraction logic.
v2->v3:
- Separated un-related changes from this patch.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktl
If its a last packet and fin is set. Make sure FIN is informed
to HW before skb gets freed.
Fixes: 429765a149f1 ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12 ++--
1 file changed, 10
dling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 38 ---
1 file changed, 33 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
b/drivers/net/ethernet/chelsio/inline_cryp
trimmed length calculation goes wrong if skb has only tag part
to send. It should be zero if there is no data bytes apart from
TAG.
Fixes: dc05f3df8fac ("chcr: Handle first or middle part of record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c
uot;chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 3 +
drivers/net/ethernet/chelsio/cxgb4/sge.c | 108 +++
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 284 +++---
3 files changed, 226 inser
If an skb has only header part which doesn't start from
beginning, is not being handled properly.
Fixes: dc05f3df8fac ("chcr: Handle first or middle part of record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 25 ---
1 f
context id and port id should be filled while sending tcb update.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12
1 file changed, 8 insertions(+), 4 deletion
iddle part of record")
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 2 +
.../net/ethernet/chelsio/cxgb4/cxgb4_uld.h| 1 +
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 116 +-
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 1
Stop the queue and ask for the credits if queue reaches to
threashold.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 18 +++---
1 file changed, 15 insertions(+), 3
dling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 38 ---
1 file changed, 33 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
b/drivers/net/ethernet/chelsio/inline_cryp
If its a last packet and fin is set. Make sure FIN is informed
to HW before skb gets freed.
Fixes: 429765a149f1 ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12 ++--
1 file changed, 10
There is a possibility of linear skbs coming in. Correcting
the length extraction logic.
v2->v3:
- Separated un-related changes from this patch.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktl
;v3:
- Replaced GFP_KERNEL with GFP_ATOMIC.
- Removed mixed fixes.
v3->v4:
- Corrected fixes tag issue.
v4->v5:
- Separated mixed fixes from patch 4.
Rohit Maheshwari (12):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls: Correction in finding correct length
ch_ktls: Update che
trimmed length calculation goes wrong if skb has only tag part
to send. It should be zero if there is no data bytes apart from
TAG.
Fixes: dc05f3df8fac ("chcr: Handle first or middle part of record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c
time, that's
why we need to check if remaining part is smaller than TAG
size, then reset TX_MAX to be TAG starting sequence number.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/c
If an skb has only header part which doesn't start from
beginning, is not being handled properly.
Fixes: dc05f3df8fac ("chcr: Handle first or middle part of record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 25 ---
1 f
ecord")
v4->v5:
- Removed extra changes.
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 3 +
drivers/net/ethernet/chelsio/cxgb4/sge.c | 108 +++
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 284 +++---
3 files changed, 226 inser
Checksum update was missing in the WR.
Fixes: 429765a149f1 ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/d
ve it for tls offload handling.
v2->v3:
- Removed ifdef.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
On 04/11/20 2:21 AM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 23:32:22 +0530 Rohit Maheshwari wrote:
There could be a case where ACK for tls exchanges prior to start
marker is missed out, and by the time tls is offloaded. This pkt
should not be discarded and handled carefully. It could be
On 04/11/20 2:16 AM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 23:32:20 +0530 Rohit Maheshwari wrote:
Creating SKB per tls record and freeing the original one causes
panic. There will be race if connection reset is requested. By
freeing original skb, refcnt will be decremented and that means
dling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 36 +++
1 file changed, 30 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
b/drivers/net/ethernet/chelsio/inline_cryp
If a record starts in middle, reset TCB UNA so that
we could avoid sending out extra packet which is
needed to make it 16 byte aligned to start AES CTR.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_cryp
context id and port id should be filled while sending tcb update.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12
1 file changed, 8 insertions(+), 4 deletion
iddle part of record")
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 2 +
.../net/ethernet/chelsio/cxgb4/cxgb4_uld.h| 1 +
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 115 +-
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 1
Stop the queue and ask for the credits if queue reaches to
threashold.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 19 +++
1 file changed, 15 insertions(+), 4
Use of GFP_KERNEL under lock is not correct. Replacing it
with GFP_ATOMIC.
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls
ecord")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 3 +
drivers/net/ethernet/chelsio/cxgb4/sge.c | 108
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 545 +++---
3 files changed, 328 insertions(+), 328 deletions(-)
diff --git
Checksum update was missing in the WR.
Fixes: 429765a149f1 ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 21 ---
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/d
ve it for tls offload handling.
v2->v3:
- Removed ifdef.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
There is a possibility of linear skbs coming in. Correcting
the length extraction logic.
v2->v3:
- Separated un-related changes from this patch.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktl
ches threshold value.
v1->v2:
- Corrected fixes tag issue.
- Marked chcr_ktls_sw_fallback() static.
v2->v3:
- Replaced GFP_KERNEL with GFP_ATOMIC.
- Removed mixed fixes.
v3->v4:
- Corrected fixes tag issue.
Rohit Maheshwari (10):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls:
ve it for tls offload handling.
v2->v3:
- Removed ifdef.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
Stop the queue and ask for the credits if queue reaches to
threashold.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 19 +++
1 file changed, 15 insertions(+), 4
context id and port id should be filled while sending tcb update.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12
1 file changed, 8 insertions(+), 4 deletion
dling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 36 +++
1 file changed, 30 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
b/drivers/net/ethernet/chelsio/inline_cryp
ecord")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 3 +
drivers/net/ethernet/chelsio/cxgb4/sge.c | 108
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 545 +++---
3 files changed, 328 insertions(+), 328 deletions(-)
diff --git
If a record starts in middle, reset TCB UNA so that
we could avoid sending out extra packet which is
needed to make it 16 byte aligned to start AES CTR.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_cryp
iddle part of record")
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 2 +
.../net/ethernet/chelsio/cxgb4/cxgb4_uld.h| 1 +
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 115 +-
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 1
ches threshold value.
v1->v2:
- Corrected fixes tag issue.
- Marked chcr_ktls_sw_fallback() static.
v2->v3:
- Replaced GFP_KERNEL with GFP_ATOMIC.
- Removed mixed fixes.
Rohit Maheshwari (10):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls: Correction in finding correct length
There is a possibility of linear skbs coming in. Correcting
the length extraction logic.
v2->v3:
- Separated un-related changes from this patch.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktl
Use of GFP_KERNEL under lock is not correct. Replacing it
with GFP_ATOMIC.
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls
Checksum update was missing in the WR.
Fixes: 429765a149f1 ("chcr: handle partial end part of a record")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 21 ---
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/d
ve it for tls offload handling.
v2->v3:
- Removed ifdef.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling"
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h
context id and port id should be filled while sending tcb update.
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls
has partial TAG bytes
only. HW can't handle those, hence using sw crypto for such pkts.
Patch 7 corrects the potential tcb update problem.
v1->v2:
- Corrected fixes tag issue.
- Marked chcr_ktls_sw_fallback() static.
Rohit Maheshwari (7):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls
There is a possibility of linear skbs coming in. Correcting
the length extraction logic.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 62 +++
1 file changed, 37
There could be a case where ACK for tls exchanges prior to start
marker is missed out, and by the time tls is offloaded. This pkt
should not be discarded and handled carefully. It could be
plaintext alone or plaintext + finish as well.
Signed-off-by: Rohit Maheshwari
---
.../chelsio
If TCP congestion caused a very small packets which only has some
part fo the TAG, and that too is not till the end. HW can't handle
such case, so falling back to sw crypto in such cases.
v1->v2:
- Marked chcr_ktls_sw_fallback() static.
Signed-off-by: Rohit Maheshwari
---
.../ethernet
If a record starts in middle, reset TCB UNA so that
we could avoid sending out extra packet which is
needed to make it 16 byte aligned to start AES CTR.
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 21 +--
1 file changed, 15 insertions
ecord")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 3 +
drivers/net/ethernet/chelsio/cxgb4/sge.c | 108
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 543 +++---
3 files changed, 327 insertions(+), 327 deletions(-)
diff --git
ve it for tls offload handling.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 3 +++
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 +++
drivers/net/e
context id and port id should be filled while sending tcb update.
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls
If TCP congestion caused a very small packets which only has some
part fo the TAG, and that too is not till the end. HW can't handle
such case, so falling back to sw crypto in such cases.
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 2 +
.../net/eth
There could be a case where ACK for tls exchanges prior to start
marker is missed out, and by the time tls is offloaded. This pkt
should not be discarded and handled carefully. It could be
plaintext alone or plaintext + finish as well.
Signed-off-by: Rohit Maheshwari
---
.../chelsio
If a record starts in middle, reset TCB UNA so that
we could avoid sending out extra packet which is
needed to make it 16 byte aligned to start AES CTR.
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 21 +--
1 file changed, 15 insertions
There is a possibility of linear skbs coming in. Correcting
the length extraction logic.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 62 +++
1 file changed, 37
ecord"
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 3 +
drivers/net/ethernet/chelsio/cxgb4/sge.c | 108
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 543 +++---
3 files changed, 327 insertions(+), 327 deletions(-)
diff --git a/d
has partial TAG bytes
only. HW can't handle those, hence using sw crypto for such pkts.
Patch 7 corrects the potential tcb update problem.
Rohit Maheshwari (7):
cxgb4/ch_ktls: decrypted bit is not enough
ch_ktls: Correction in finding correct length
cxgb4/ch_ktls: creating skbs ca
ve it for tls offload handling.
Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 3 +++
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 +++
drivers/net/e
sed on more bit.
Fixes: d829e9c4112b ("tls: convert to generic sk_msg interface")
Signed-off-by: Rohit Maheshwari
---
net/tls/tls_device.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index b74e2741f74f..cec86229
sed on more bit.
Also incase if tls_do_allocation() fails, and if record len is only
prepend_size, then destroy the record.
v1->v2:
- handle tls_do_allocation() failure handling.
Signed-off-by: Rohit Maheshwari
---
net/tls/tls_device.c | 27 +--
1 file changed, 13 insertion
All the ktls stats were at adapter level, but now changing it
to port level.
Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 35 ++---
.../ethernet/chelsio/cxgb4/cxgb4
Fixes: 34aba2c45024 ("cxgb4/chcr : Register to tls add and del callback")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 283 +-
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 17 +-
2 files changed, 153 insertions(+), 147 deletions(
Changing these logs to dynamic debugs. If issue is seen, these
logs can be enabled at run time.
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4
ktls statistics at port level.
v1->v2:
- removed conn_up from all places.
v2->v3:
- Corrected timeout handling.
Rohit Maheshwari (3):
ch_ktls: Issue if connection offload fails
cxgb4: Avoid log flood
cxgb4/ch_ktls: ktls stats are added at port level
.../ethernet/chelsio/cxgb4/cxgb
> -Original Message-
> From: Jakub Kicinski
> Sent: Friday, September 25, 2020 3:27 AM
> To: Rohit Maheshwari
> Cc: netdev@vger.kernel.org; da...@davemloft.net;
vakul.g...@nxp.com; secdev
> Subject: Re: [PATCH net] net/tls: sendfile fails with ktls offload
>
-Original Message-
From: Jakub Kicinski
Sent: Friday, September 25, 2020 3:27 AM
To: Rohit Maheshwari
Cc: netdev@vger.kernel.org; da...@davemloft.net; vakul.g...@nxp.com; secdev
Subject: Re: [PATCH net] net/tls: sendfile fails with ktls offload
On Thu, 24 Sep 2020 13:20:25 +0530
sed on more bit.
Fixes: d829e9c4112b ("tls: convert to generic sk_msg interface")
Signed-off-by: Rohit Maheshwari
---
net/tls/tls_device.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index b74e2741f74f..a02aadef
t for async encryption of records for
performance")
Signed-off-by: Rohit Maheshwari
---
net/tls/tls_sw.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 9a3d9fedd7aa..95ab5545a931 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_
All the ktls stats were at adapter level, but now changing it
to port level.
Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 35 ++---
.../ethernet/chelsio/cxgb4/cxgb4
Changing these logs to dynamic debugs. If issue is seen, these
logs can be enabled at run time.
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4
r to tls add and del callback")
Signed-off-by: Rohit Maheshwari
---
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 251 --
.../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 13 +-
2 files changed, 112 insertions(+), 152 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/
ktls statistics at port level.
v1->v2:
- removed conn_up from all places.
Rohit Maheshwari (3):
ch_ktls: Issue if connection offload fails
cxgb4: Avoid log flood
cxgb4/ch_ktls: ktls stats are added at port level
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 35 +--
.../ethernet/chels
On 23/09/20 4:14 AM, Jakub Kicinski wrote:
On Tue, 22 Sep 2020 23:14:59 +0530 Rohit Maheshwari wrote:
Since driver first return success to tls_dev_add, if req to HW is
successful, but later if HW returns failure, that connection traffic
fails permanently and connection status remains unknown
Since driver first return success to tls_dev_add, if req to HW is
successful, but later if HW returns failure, that connection traffic
fails permanently and connection status remains unknown to stack.
Fixes: 34aba2c45024 ("cxgb4/chcr : Register to tls add and del callback")
Signed-off
Changing these logs to dynamic debugs. If issue is seen, these
logs can be enabled at run time.
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4
All the ktls stats were at adapter level, but now changing it
to port level.
Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
Signed-off-by: Rohit Maheshwari
---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 35 ++---
.../ethernet/chelsio/cxgb4/cxgb4
ktls statistics at port level.
Rohit Maheshwari (3):
ch_ktls: Issue if connection offload fails
cxgb4: Avoid log flood
cxgb4/ch_ktls: ktls stats are added at port level
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 35 +--
.../ethernet/chelsio/cxgb4/cxgb4_ethtool.c| 50 +++-
.../net/eth
This patch moves complete nic tls offload (kTLS) code from crypto
directory to drivers/net/ethernet/chelsio/inline_crypto/ch_ktls
directory. nic TLS is made a separate ULD of cxgb4.
Signed-off-by: Rohit Maheshwari
---
drivers/crypto/chelsio/Kconfig| 11 --
drivers/crypto
cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which
is under CONFIG_CHELSIO_TLS_DEVICE macro.
Fixes: a3ac249a1ab5 ("cxgb4/chcr: Enable ktls settings at run time")
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +-
1 file changed, 1
cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which
is under CONFIG_CHELSIO_TLS_DEVICE macro.
Signed-off-by: Rohit Maheshwari
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4
Error messages seen while building kernel with CONFIG_IPV6
disabled.
Signed-off-by: Rohit Maheshwari
---
drivers/crypto/chelsio/chcr_ktls.c | 48 --
1 file changed, 33 insertions(+), 15 deletions(-)
diff --git a/drivers/crypto/chelsio/chcr_ktls.c
b/drivers/crypto
is now registering to tlsdev_ops.
- module refcount inc/dec in chcr.
- refcount is only for connections.
- removed new code from cxgb_set_feature().
v3->v4:
- fixed warning message.
Signed-off-by: Rohit Maheshwari
---
drivers/crypto/chelsio/chcr_core.c| 23 +++--
drivers/crypt
is now registering to tlsdev_ops.
- module refcount inc/dec in chcr.
- refcount is only for connections.
- removed new code from cxgb_set_feature().
Signed-off-by: Rohit Maheshwari
---
drivers/crypto/chelsio/chcr_core.c| 23 +++--
drivers/crypto/chelsio/chcr_core.h
1 - 100 of 104 matches
Mail list logo
