On 07/01/21 12:47 AM, Jakub Kicinski wrote:
On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote:Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. And it broke tls offload feature for the drivers, which are still using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use NETIF_F_CSUM_MASK instead. Fixes: ae0b04b238e2 ("net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled") Signed-off-by: Rohit Maheshwari <roh...@chelsio.com>Please use Tariq's suggestion.
HW_TLS_TX feature is for both IPv4/v6. And If one device is limited to support only IPv4 checksum offload, TLS offload should be allowed for that too. So I think putting a check of CSUM_MASK is enough.
