Re: [PATCH] Add another Prism2 card to hostap

2008-01-30 Thread Pavel Roskin
PC Card", "Version 01.02", "" >manfid: 0x0156, 0x0002 >function: 6 (network) > > Signed-off-by: Marcin Juszkiewicz <[EMAIL PROTECTED]> Acked-by: Pavel Roskin <[EMAIL PROTECTED]> > diff --git a/drivers/net/wireless/hostap/hostap_cs.c &

Re: [PATCH] Add Linksys WCF11 to hostap driver

2007-12-30 Thread Pavel Roskin
Quoting Marcin Juszkiewicz <[EMAIL PROTECTED]>: + PCMCIA_DEVICE_PROD_ID1233( + "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P", + 0xa5f472c2, 0x9c05598d, 0xc9049a39), Acked-by: Pavel Roskin <[EMAI

Re: [PATCH] Add Linksys WCF11 to hostap driver

2007-12-28 Thread Pavel Roskin
a5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194), I would prefer that revisions are not used for card identification in presence of the chip name. It's not like RevB would need another driver as long as "ISL37300P" is still a part of the PCMCIA ID. PCMCIA_DEVICE_PROD_ID123 should be eno

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Pavel Roskin
at least the compatible kernel API) should go away soon. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Kernel bug in bcm43xx-d80211

2007-02-19 Thread Pavel Roskin
. It's just something that would help a lot. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Kernel bug in bcm43xx-d80211

2007-02-19 Thread Pavel Roskin
though I haven't seen a problem like yours, I strongly suggest that you try the above repository and post your results to the bcm43xx-dev list. Even if the results are more positive :) -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: iwlwifi initial bugs/thanks

2007-02-13 Thread Pavel Roskin
->name, > newname); I think KERN_INFO is the right level, but maybe KERN_DEBUG would be more readily accepted. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: The new SSB subsystem for bcm43xx (and others)

2007-02-10 Thread Pavel Roskin
gt; rather than in the top level of /sys/devices. I've just checked, pcmcia/ciscode.h is not needed. The rest is needed. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [ipw3945-devel] [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-10 Thread Pavel Roskin
couple of wrinkles in the standalone build system are irrelevant to the kernel interation. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Pavel Roskin
C is defined twice in Makefile. That must be wrong. I'm going to try everything on a more traditional build in the tree and without d80211. And then I'll try to break some assumptions. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Pavel Roskin
fficial ipw3945 drivers as well. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Hermes PCI broken on 2.6.20?

2007-02-08 Thread Pavel Roskin
ou may want to send further replies to [EMAIL PROTECTED] where it would be seen by those actually using the driver. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: d80211: a patch for standalone d80211 tarball

2007-01-29 Thread Pavel Roskin
f good programming style. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] d80211: configure hardware when the interface is brought up

2007-01-25 Thread Pavel Roskin
needs to be reconfigured. Without this patch, bcm43xx_d80211 needs the channel to be set again after the interface goes down and up. Similar problems are reported for rt2x00 drivers. Failure in ieee80211_hw_config() leads to the interface staying down. Signed-off-by: Pavel Roskin <[EMAIL PROTEC

[RFC PATCH] bcm43xx: set channel when the interface is brought up

2007-01-24 Thread Pavel Roskin
iples. If the hardware drivers are supposed to do it, here's my patch. It is working fine for me and ready to be applied. The changelog is in the subject. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c |3 +++ 1 files changed,

Re: Can someone please try...

2007-01-23 Thread Pavel Roskin
On Tue, 2007-01-23 at 10:21 +0100, Michael Buesch wrote: > On Tuesday 23 January 2007 07:14, Pavel Roskin wrote: > > I have tried the patch, and it doesn't fix the problem. It's a separate > > problem. It happens when bcm43xx_interrupt_handler() is called on a > &g

Re: Can someone please try...

2007-01-22 Thread Pavel Roskin
but ARP and ping packets from AP to > > STA are lost. The frames are even acknowledged, but not seen on the > > station side. It takes from one to ten minutes util ping suddenly > > starts working. > > Hm, is this 4318? It is known to loose lots of packets. No, it

Re: Can someone please try...

2007-01-22 Thread Pavel Roskin
STA are lost. The frames are even acknowledged, but not seen on the station side. It takes from one to ten minutes util ping suddenly starts working. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] bcm43xx_d80211: Fix major memory corruption bug

2007-01-20 Thread Pavel Roskin
Set phy->lo_control to NULL whenever it's freed. Failure to do so leads to zeroing a block of memory that uses to hold *phy->lo_control, which caused random crashes down the road. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/bcm43xx/bcm4

Re: Can someone please try...

2007-01-18 Thread Pavel Roskin
onfirm my suspicion that the actual corruption happened before this point. We are just hitting it when trying to allocate more memory. Help with debugging this problem will be appreciated. I've never hunted down such problems, especially in kernel space. -- Regards, Pavel Roskin - To u

Re: Can someone please try...

2007-01-18 Thread Pavel Roskin
ible. It appears that most loss is on the receiving side. I'll try to debug the problem when I have time. At least I'll try to find out if it's specific to the architecture or to another kernel option. Anyway, it's exciting that I could send first packets today! -- Regards,

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
On Tue, 2007-01-16 at 23:07 +0100, Michael Buesch wrote: > On Tuesday 16 January 2007 22:50, Pavel Roskin wrote: > > On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: > > > > > A patch for that is already upstream. > > > > I don't see it. It'

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
l as on x86_64. The dump was for x86_64, as evidenced by the register size. Maybe you have less debugging options enabled? > Patch was > [PATCH] bcm43xx-d80211: Fix DMA TX skb doublefree Even with this hint, I cannot spot the bug immediately, so it would be great if you sync the public r

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
uot;bcm43xx-d80211: Various cleanups all over the code" SMP is disabled this time, just to make things simpler. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: What is in bcm43xx-wireless-dev.git?

2007-01-14 Thread Pavel Roskin
Quoting Michael Buesch <[EMAIL PROTECTED]>: > Ok, nice. > Can you send me a complete dmesg log after you brought up the card > and tried to assoc/send some packets? Attached. -- Regards, Pavel Roskin ACPI: PCI Interrupt :0c:00.0[A] -> GSI 17 (level, low) -> IRQ 17 PCI:

Re: What is in bcm43xx-wireless-dev.git?

2007-01-14 Thread Pavel Roskin
7;t work over and > over again. > So, well. What to do? :) I'll check in with a HostAP based AP and a separate sniffer, so I can see what's on the air and what the AP sees. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev&

Re: What is in bcm43xx-wireless-dev.git?

2007-01-13 Thread Pavel Roskin
My immediate suspect is that we > have > > too many different fields called "dev". All it takes is one cast to hide a > > horrible mistake. Although I think it would have affected you as well > (unless > > We don't cast devs. Yet I was pretty close :) --

Re: What is in bcm43xx-wireless-dev.git?

2007-01-13 Thread Pavel Roskin
for me to think that your changes would fix accociation to the AP? I have never had any success with any d80211 based driver, so I have a strong suspicion that I'm doing something wrong. I'll try to report a clear-cut case with a less problematic driver in a separate thread. -- Regard

Re: What is in bcm43xx-wireless-dev.git?

2007-01-12 Thread Pavel Roskin
tried wpa_supplicant, but it won't associate either. The kernel messages and the wpa_supplicant output are attached. I could not compile wpa_supplicant with MLME (too much code to fix), but I don't think it should be required. I tried the current version from your branch without SM

Re: What is in bcm43xx-wireless-dev.git?

2007-01-11 Thread Pavel Roskin
x-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_phy.c:1650 bcm43xx_d80211: Chip initialized bcm43xx_d80211: ERROR: This card does not support PIO operation mode. Please use DMA mode (module parameter pio=0). bcm43xx_d80211: Radio turned off -- Regards, Pavel Roskin - To unsubscribe from this list

Re: [PATCH] fix cfg80211 WE compat code

2006-12-21 Thread Pavel Roskin
On Thu, 2006-12-21 at 21:53 -0500, Pavel Roskin wrote: > On Sun, 2006-12-10 at 17:21 +0100, Johannes Berg wrote: > > John, please apply this to wireless-dev if Pavel says it works (I think > > it should). > > Yes, it's working for me. Please apply the patch. Actually

Re: [PATCH] fix cfg80211 WE compat code

2006-12-21 Thread Pavel Roskin
On Sun, 2006-12-10 at 17:21 +0100, Johannes Berg wrote: > John, please apply this to wireless-dev if Pavel says it works (I think > it should). Yes, it's working for me. Please apply the patch. Sorry for answering so late. -- Regards, Pavel Roskin - To unsubscribe from this lis

Please make CONFIG_CFG80211 harder to enable

2006-12-09 Thread Pavel Roskin
they won't be able to debug their drivers effectifely; they'll have to fix cfg80211 first. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/10] d80211: move away from wmaster towards wiphy

2006-11-17 Thread Pavel Roskin
ider and longer discussion (at least give driver maintainers and the top kernel folks a chance to look at what you are suggesting). -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Madwifi-devel] ANNOUNCE: SFLC helps developers assess ar5k (enabling free Atheros HAL)

2006-11-15 Thread Pavel Roskin
n be reshuffled and eliminated by one person in a few days. Making things work properly takes years. That's what MadWifi has been working on for a long time, using contributions and bug reports from scores of users and developers. Rejecting MadWifi because it's HAL based is like thro

[PATCH FIXED] hostap_plx: fix CIS verification

2006-10-24 Thread Pavel Roskin
hostap_plx: fix two related off-by-one errors in CIS parser From: Pavel Roskin <[EMAIL PROTECTED]> The length of the manfid CIS should be at least 4, and it's normally 4. It's incorrect to require it to be at least 5. This breaks support for most (if not all) cards. The right

Re: [PATCH] hostap_plx: fix CIS verification

2006-10-24 Thread Pavel Roskin
Hello, Jouni! On Fri, 2006-10-20 at 18:19 -0700, Jouni Malinen wrote: > On Fri, Oct 20, 2006 at 06:20:15PM -0400, Pavel Roskin wrote: > > > The record length for numerical manufacturer ID should be at least 4 > > bytes (two 16-bit words). The code required 5 bytes, which w

Re: [PATCH] hostap_plx: fix CIS verification

2006-10-24 Thread Pavel Roskin
feels more comfortable with an additional check, I'll add it. I don't have Coverity to check, and I think the results of Coverity were misinterpreted. It doesn't know anything about CIS structure. Anyway, let me just check Jouni's suggestion on a real PLX card. -- Regards, Pave

[PATCH] hostap_plx: fix CIS verification

2006-10-20 Thread Pavel Roskin
hostap_plx: fix CIS verification The record length for numerical manufacturer ID should be at least 4 bytes (two 16-bit words). The code required 5 bytes, which would break for most (if not all) cards. Reported by [EMAIL PROTECTED] Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- This

Re: [Madwifi-devel] d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-17 Thread Pavel Roskin
that could harm the chances of d80211 to make it to the mainline > > kernel. > > Christoph et. all will insist that everything be EXPORT_SYMBOL_GPL. That shouldn't be an issue at all. HAL does not and can not call any Linux functions directly. It can only communicate

Re: [Madwifi-devel] d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-17 Thread Pavel Roskin
rs, and they will ensure that useful features of d80211 are not lost. Unless I'm missing something obvious, I don't see absolutely anything that could harm the chances of d80211 to make it to the mainline kernel. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line &

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-05 Thread Pavel Roskin
compatibility. I'm trying to maintain a Subversion repository with the driver modified to be compatible with a few latest kernels. But it looks like it's an uphill battle that I'm not going to win. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsub

[PATCH] Restore antenna selection settings after port reset

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Intersil firmware 1.7.4 (and possibly others) loses the antenna selection settings when the port is reset. Signed-off-by: David Acker <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/hostap/

[PATCH 1/2] orinoco: Don't use "extern inline" on locking functions

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> SPARC architecture has been fixed, so it's no longer needed. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.h |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/w

[PATCH 2/2] Don't rely on linux/if_arp.h being included by other headers

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/orinoco.c b/drivers/net/wireless/orinoco.c index 317ace7..1174ff5 100644 --- a/drivers/net/wireless/orinoco.c +++ b/d

[PATCH] spectrum_cs: Fix incorrect use of pcmcia_dev_present()

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> This bug was introduced during the PCMCIA API conversion and broke spectrum_cs completely. Tracked down by Fredrik Tolf <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- This patch should go to 2.6.18 and 2.6.17.y.

Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread Pavel Roskin
/ > > > > Didn't that get fixed up for SPARC a year or so back? > > That's right, this problem no longer exists. Then, I guess, "static inline" would be just fine, right? -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netd

Re: [2.6 patch] orinoco.h: "extern inline" -> "static __always_inline"

2006-08-15 Thread Pavel Roskin
errors. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks for the patch! I'm removing the last sentence in the comment as irrelevant and fixing the comment. The patch is being sent to netdev by StGIT, cc: author. -- Regards, Pavel Roskin - To unsubscribe from this

[PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> This is exactly the case when they are needed. This also fixed a warning with -Wmissing-prototypes Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.h |

[PATCH] Replace pci_module_init with pci_register_driver in drivers/net

2006-08-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/3c59x.c |2 +- drivers/net/8139cp.c |2 +- drivers/net/8139too.c |2 +- drivers/net/acenic.c |2 +- drivers/net/amd8

Re: Can we have GET_NETDEV_DEV?

2006-07-25 Thread Pavel Roskin
On Tue, 2006-07-25 at 14:26 -0700, Stephen Hemminger wrote: > On Tue, 25 Jul 2006 17:08:11 -0400 > Pavel Roskin <[EMAIL PROTECTED]> wrote: > > Considering the drivers that are already in the kernel, you may prefer > > to have a more high-level function that would clone t

Re: Can we have GET_NETDEV_DEV?

2006-07-25 Thread Pavel Roskin
k netdev_get_pdev() would be mostly used for such cloning if implemented. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Can we have GET_NETDEV_DEV?

2006-07-24 Thread Pavel Roskin
t_device. It should be done before class_dev is removed or in the same time. Should I send a patch? -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 9/15] pcmcia: hostap_cs.c - 0xc00f, 0x0000 conflicts with pcnet_cs

2006-07-03 Thread Pavel Roskin
CL-11", "ISL37300P", 0xa21501a, 0x59868926, 0xc9049a39), -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 9/15] pcmcia: hostap_cs.c - 0xc00f, 0x0000 conflicts with pcnet_cs

2006-06-30 Thread Pavel Roskin
;WL PCCL-11", "ISL37300P", "RevA" manfid 0xc00f, 0x bind "hostap_cs" (from http://www.handhelds.org/hypermail/oe-commits/41/4121.html) -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-14 Thread Pavel Roskin
ficient details. I haven't seen any detailed reports of this problem. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-14 Thread Pavel Roskin
rily for systems that cannot use udev. But it's far from the top of my TODO list. And I'm not sure it would actually help users of desktop distributions. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: orinoco encodeext + auth patch on lkml

2006-06-01 Thread Pavel Roskin
lkml/2006/5/30/433 Thanks for heads up. Actually, this e-mail was copied to the orinoco mailing list, so I'm aware of it. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 3/6] new pcmcia IDs for hostap

2006-05-17 Thread Pavel Roskin
Signed-off-by: Marcin Juszkiewicz <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> > drivers/net/wireless/hostap/hostap_cs.c |6 ++ > 1 file changed, 6 insertions(+) > > Index: linux/d

Re: [PATCH 3/6] new pcmcia IDs for hostap

2006-05-16 Thread Pavel Roskin
.org/forums/index.php?showtopic=14544 > + PCMCIA_DEVICE_PROD_ID123( > + "Pretec", "CompactWLAN Card 802.11b", "2.5", > + 0x1cadd3e5, 0xe697636c, 0x7a5bfcf1), That's a good one. > + PCMCIA_DEVICE_PROD_ID1234( > + "U.S. Robotics", "IEEE 802.11b PC-CARD", "Version 01.02", "" > + 0xc7b8df9d, 0x1700d087, 0x4b74baa0, 0x), Another useful entry, but please don't match the empty string. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] new pcmcia IDs for hostap - ASUS WL-110

2006-05-12 Thread Pavel Roskin
On Fri, 2006-05-12 at 15:21 +0200, Marcin Juszkiewicz wrote: > All patches require 24_hostap_cs_id.diff from Pavel Roskin. This patch was never submitted. Please ignore the series. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in

Patches from Marcin Juszkiewicz

2006-05-12 Thread Pavel Roskin
ot with patches that remove IDs for compatible cards that were carefully collected over the years. Any patches for Orinoco drivers that don't come from kernel subsystem maintainers should be sent to the driver mailing list at [EMAIL PROTECTED] -- Regards, Pavel Roskin - To unsubscribe from

Re: [PATCH 1/5] new pcmcia IDs for hostap - ASUS WL-110

2006-05-12 Thread Pavel Roskin
footprint of hostap). Once again, I really appreciate your vigilance, Jean :-) I strongly believe that every driver should list all devices it can support. In case of multiple drivers supporting one device, the choice should be done in userspace. -- Regards, Pavel Roskin - To unsubscribe fr

Re: dBm cutoff at -1dBm is too low

2006-05-08 Thread Pavel Roskin
m). That's what I want to see fixed. One tricky case would be when the driver sets the max signal e.g. to 30 and reports 35 (i.e. a positive value within the "reasonable" dBm range). I would probably prefer to show it as 30/30 rather than 35dBm, but the driver is nuts any

Re: dBm cutoff at -1dBm is too low

2006-05-07 Thread Pavel Roskin
n integer) and pushes it into unsigned char in the hope that the client side can understand it using the common sense. Interpreting 0dBm as -256dBm goes against the common sense. This has to be specifically worked around in the drivers. Of course, it would be nice to document it somewhere, and to

Re: dBm cutoff at -1dBm is too low

2006-05-06 Thread Pavel Roskin
> don't want to cutoff the bottom of the range (is -128dBm enough ?). > I tried to use 'signed' in the struct a long while ago, and > for some reason it broke left and right, I don't remember the > details. So, whatever we do, it would not be straightforward. I sugg

dBm cutoff at -1dBm is too low

2006-05-04 Thread Pavel Roskin
would put the cutoff and 127dBm. 500 gigawatts should be enough for everyone :-) -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add some new card IDs to hostap_cs

2006-05-01 Thread Pavel Roskin
h because it's > clear you don't know what you are doing. > Some of those cards are Orinoco or Symbol cards. I agree. Please don't apply this patch. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

[PATCH 1/5] orinoco: unregister network device before releasing PCMCIA resources

2006-04-30 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Hardware resources should not be made available to other devices while the network device is still registered. Also remove the related debug statements. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_

[PATCH 2/5] orinoco: report more relevant data on startup

2006-04-30 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Report only the first I/O window and IRQ, and also add the driver name. The second I/O window, Vpp and configuration index are not interesting to most users. They can be found by PCMCIA debug tools if needed. Signed-off-by: Pavel Roskin <[EMAIL

[PATCH 4/5] orinoco: eliminate the suspend/resume functions if CONFIG_PM is unset

2006-04-30 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_pci.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/orinoco_pci.h b/drivers/net/wireless/orinoco_pci.h i

[PATCH 5/5] orinoco: don't put PCI resource data to the network device

2006-04-30 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> The resource data in the network device is intended for ISA and other older busses, but not for PCI. Don't put PCI data there. Don't (ab)use the network device for keeping the IRQ number. Retire orinoco_pci_setup_netdev(), and pr

[PATCH 3/5] orinoco: simplify locking, fix error handling in PCMCIA resume

2006-04-30 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Don't use flags in the spinlocks - the PCMCIA resume functions may not be called under lock. Don't ignore any errors. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_cs.c |7 +++

More Orinoco patches

2006-04-30 Thread Pavel Roskin
Hello! I'm about to send some more patches for Orinoco drivers. Unlike the previous set, the new patches are mostly cosmetic changes based on the feedback I received from the already submitted patches. Please apply to the trees that have the previous patches. -- Regards, Pavel Roskin

[PATCH] Unregister network device before releasing PCMCIA resources

2006-04-20 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> This is the right thing to do and it prevents kernel BUG on unload. Some PCMCIA network drivers use link->dev_node as a flag indicating that the network device has been successfully registered. Recent code changes cause this flag to be 0 aft

[PATCH] Fix crash on big-endian systems during scan

2006-04-14 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> The original code was doing arithmetics on a little-endian value. Reported by Stelios Koroneos <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/hostap/hostap_ioctl.c |4 ++-- 1 files cha

Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Pavel Roskin
t netdev->irq? Is it going to be obsolete too? Then I can easily remove orinoco_pci_setup_netdev() with very minimal adjustments. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 19/21] orinoco: reduce differences between PCI drivers, create orinoco_pci.h

2006-04-07 Thread Pavel Roskin
rinoco_up(dev); > > I wonder if it would be enough to issue hermes_set_irqmask() later > in __orinoco_up() to release this irq disabled section. Maybe, but I prefer not to touch this code, since it's about to undergo a much more radical rework. -- Regards, Pavel Roskin - To unsubs

Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Pavel Roskin
nge; > > - dev->mem_end = pci_iorange + pci_iolen - 1; > > + dev->mem_start = pci_resource_start(pdev, 0); > > + dev->mem_end = dev->mem_start + pci_resource_len(pdev, 0) - 1; > > Is there a reason why dev->mem_{start/end} should not be removed ? Is

Re: [PATCH 16/21] orinoco_pci: disable device and free IRQ when suspending

2006-04-07 Thread Pavel Roskin
Hello! On Fri, 2006-04-07 at 23:24 +0200, Francois Romieu wrote: > Pavel Roskin <[EMAIL PROTECTED]> : > [...] > > diff --git a/drivers/net/wireless/orinoco_pci.c > > b/drivers/net/wireless/orinoco_pci.c > > index 5362c21..e57e92b 100644 > > --- a/drivers/

[PATCH 14/21] orinoco: fix BAP0 offset error after several days of operation

2006-04-07 Thread Pavel Roskin
ion of the problem can be found at https://bugzilla.novell.com/show_bug.cgi?id=154773 The same problem with different card is reported at http://sourceforge.net/mailarchive/message.php?msg_id=14597046 Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[

[PATCH 07/21] orinoco: Symbol card supported by spectrum_cs is LA4137, not LA4100

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/spectrum_cs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/spectrum_cs.c b/drivers/net/wireless/spectrum_cs.c i

[PATCH 08/21] orinoco: optimize Tx exception handling in orinoco

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> When processing Tx exception, only read data until addr1. Rename hermes_tx_descriptor_802_11 to hermes_txexc_data since it's only used to Tx exceptions. Reuse existing hermes_tx_descriptor structure. Remove fields after addr1 - they are not re

[PATCH 13/21] orinoco: simplify 802.3 encapsulation code

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Use skb_pull() to strip the addresses from the original packet. Don't strip protocol bytes. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.c | 44 ++-- drivers/net/w

[PATCH 21/21] orinoco: bump version to 0.15

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/orinoco.h b/drivers/net/wireless/orinoco.h index ca01e45..16db3e1

[PATCH 12/21] orinoco: refactor and clean up Tx error handling

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> The result of orinoco_xmit() can be OK, dropped packet and busy transmitter. Rename labels accordingly. Increment stats->tx_errors in one place. Increment stats->tx_dropped - nobody is doing it for us. Signed-off-by: Pavel Roskin <[

[PATCH 18/21] orinoco: support PCI suspend/resume for Nortel, PLX and TMD adaptors

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Copy PCI suspend/resume functions from orinoco_pci.c. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_nortel.c | 87 +++-- drivers/net/wireless/orinoco_plx

[PATCH 16/21] orinoco_pci: disable device and free IRQ when suspending

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_pci.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/orinoco_pci.c b/drivers/net/wireless/orinoco

[PATCH 10/21] orinoco replace hermes_write_words() with hermes_write_bytes()

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> The new function can write an odd number of bytes, thus making padding unnecessary. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/hermes.c | 17 - drivers/net/wireless/hermes.h |7

[PATCH 11/21] orinoco: don't use any padding for Tx frames

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> hermes_bap_pwrite() supports odd-sized packets now. There is no minimal packet size for 802.11. Also, hermes_bap_pwrite() supports odd-sized packets now. This removes all reasons to pad the Tx data. Signed-off-by: Pavel Roskin <[EMAIL

[PATCH 19/21] orinoco: reduce differences between PCI drivers, create orinoco_pci.h

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Make all Orinoco PCI drivers (orinoco_pci, orinoco_plx, orinoco_tmd and orinoco_nortel) as similar as possible. Use the best implementation of error handling, the best error messages, the best comments. Put common code to orinoco_pci.h. For now

[PATCH 15/21] orinoco: delay FID allocation after firmware initialization

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> This is needed to identify the card before possible allocation problems, so that the user at least can report the firmware version that fails. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orin

[PATCH 09/21] orinoco: orinoco_xmit() should only return valid symbolic constants

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Don't ever return -errno from orinoco_xmit() - the network layer doesn't expect it. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.c | 12 ++-- 1 files changed, 6 insertions(+), 6 dele

[PATCH 20/21] orinoco: further comment cleanup in the PCI drivers

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_nortel.c |7 +-- drivers/net/wireless/orinoco_pci.c| 69 + drivers/net/wireless/orinoco_plx.c| 42 +++--

[PATCH 17/21] orinoco_pci: use pci_iomap() for resources

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_pci.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/orinoco_pci.c b/drivers/net/wireless/orinoco

[PATCH 01/21] orinoco: Remove useless CIS validation

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> The PCMCIA drivers would never be loaded if the CIS were wrong. No other PCMCIA drivers validate CIS. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_cs.c |3 --- drivers/net/wireless/spectrum_cs.c |3

[PATCH 05/21] orinoco: remove tracing code, it's unused

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.c | 83 drivers/net/wireless/orinoco.h |3 - 2 files changed, 0 insertions(+), 86 deletions(-) diff --git a

[PATCH 04/21] orinoco: fix truncating commsquality RID with the latest Symbol firmware

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Symbol firmware F3.91-71 has an additional word in the commsquality RID. Extend the receiving buffer by one word to accomodate it. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.c |2 +- 1 files changed,

[PATCH 06/21] orinoco: remove debug buffer code and userspace include support

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/hermes.c | 19 --- drivers/net/wireless/hermes.h | 34 -- 2 files changed, 0 insertions(+), 53 deletions(-) diff --g

[PATCH 02/21] orinoco: remove PCMCIA audio support, it's useless for wireless cards

2006-04-07 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco_cs.c |6 -- drivers/net/wireless/spectrum_cs.c |6 -- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ori

  1   2   >