n't
so long that it will have a major impact on start-up time.
So it looks good to me.
Reviewed-by: Paul Barker
--
Paul Barker
Konsulko Group
prev_msg = "";
> + prev_mode = "";
> + }
> + dev_info(dev->dev,
> +"Port%d: using phy mode %s%s%s\n",
> +i,
> - phy_modes(dev->interface),
> ++ phy_modes(p->interface),
> +prev_msg,
> +prev_mode);
>
> /* enable cpu port */
> ksz9477_port_setup(dev, i, true);
Looks good to me wrt my patch "net: dsa: microchip: Improve phy mode message".
Thanks,
--
Paul Barker
Konsulko Group
On Wed, 9 Sep 2020 at 19:26, David Miller wrote:
>
> From: Paul Barker
> Date: Wed, 9 Sep 2020 11:04:13 +0100
>
> > These changes were made while debugging the ksz9477 driver for use on a
> > custom board which uses the ksz9893 switch supported by this driver. The
>
We can't assume that the link partner supports the in-band status
reporting which is enabled by default on the KSZ9893 when using RGMII
for the upstream port.
Signed-off-by: Paul Barker
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/microchip/ksz9477.c | 3 +
easy to see any errors here will help identify
issues with SPI data corruption or reset sequencing.
Signed-off-by: Paul Barker
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/microchip/ksz9477.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b
-next.
* Dropped unnecessary `#include `.
* Instead of printing the phy mode in `ksz9477_port_setup()`, modify
the existing print in `ksz9477_config_cpu_port()` to always produce
output and to be more clear.
Paul Barker (4):
net: dsa: microchip: Make switch detection more informative
range used here is
somewhat arbitrary, as long as the reset is asserted for at least 10ms
we should be ok.
Signed-off-by: Paul Barker
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/microchip/ksz_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa
: Paul Barker
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/microchip/ksz9477.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/drivers/net/dsa/microchip/ksz9477.c
index df5ecd0261fa..d9030820f406 100644
--- a
range used here is
somewhat arbitrary, as long as the reset is asserted for at least 10ms
we should be ok.
Signed-off-by: Paul Barker
---
drivers/net/dsa/microchip/ksz_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.c
b/drivers
: Paul Barker
---
drivers/net/dsa/microchip/ksz9477.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/drivers/net/dsa/microchip/ksz9477.c
index df5ecd0261fa..9513af057793 100644
--- a/drivers/net/dsa/microchip/ksz9477.c
easy to see any errors here will help identify
issues with SPI data corruption or reset sequencing.
Signed-off-by: Paul Barker
---
drivers/net/dsa/microchip/ksz9477.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/drivers/net/dsa/microchip/ksz9477.c
We can't assume that the link partner supports the in-band status
reporting which is enabled by default on the KSZ9893 when using RGMII
for the upstream port.
Signed-off-by: Paul Barker
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/microchip/ksz9477.c | 3 +++
1 file changed, 3 inser
clude Reviewed-by tag from v1 series so it isn't lost (is this
correct?).
Paul Barker (4):
net: dsa: microchip: Make switch detection more informative
net: dsa: microchip: Improve phy mode message
net: dsa: microchip: Disable RGMII in-band status on KSZ9893
net: dsa: microchip:
On Sat, 5 Sep 2020 at 16:34, Andrew Lunn wrote:
>
> On Sat, Sep 05, 2020 at 03:03:21PM +0100, Paul Barker wrote:
> > These changes were made while debugging the ksz9477 driver for use on a
> > custom board which uses the ksz9893 switch supported by this driver. The
> > p
On Sat, 5 Sep 2020 at 16:32, Andrew Lunn wrote:
>
> On Sat, Sep 05, 2020 at 03:03:24PM +0100, Paul Barker wrote:
> > We can't assume that the link partner supports the in-band status
> > reporting which is enabled by default on the KSZ9893 when using RGMII
> > for t
range used here is
somewhat arbitrary, as long as the reset is asserted for at least 10ms
we should be ok.
Signed-off-by: Paul Barker
---
drivers/net/dsa/microchip/ksz_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.c
b/drivers
build tested on top of 5.9-rc3.
Paul Barker (4):
net: dsa: microchip: Make switch detection more informative
net: dsa: microchip: Add debug print for XMII port mode
net: dsa: microchip: Disable RGMII in-band status on KSZ9893
net: dsa: microchip: Implement recommended reset timing
drivers/ne
When debug is enabled for this driver, this allows users to confirm that
the correct port mode is in use.
Signed-off-by: Paul Barker
---
drivers/net/dsa/microchip/ksz9477.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/drivers/net/dsa/microchip
We can't assume that the link partner supports the in-band status
reporting which is enabled by default on the KSZ9893 when using RGMII
for the upstream port.
Signed-off-by: Paul Barker
---
drivers/net/dsa/microchip/ksz9477.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/driver
easy to see any errors here will help identify
issues with SPI data corruption or reset sequencing.
Signed-off-by: Paul Barker
---
drivers/net/dsa/microchip/ksz9477.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/drivers/net/dsa/microchip/ksz9477
This change allows us to see which device the err or info messages are
referring to if we have multiple b53 compatible devices on a board.
As this removes the only pr_*() calls in this file we can drop the
definition of pr_fmt().
Signed-off-by: Paul Barker
---
drivers/net/dsa/b53/b53_common.c
ow if further testing is required.
Unfortunately I don't have a board to hand which boots with a more
recent kernel and has a switch supported by the b53 driver. I'd still
like to upstream these patches if possible though.
Paul Barker (2):
net: dsa: b53: Use dev_{err,info} instead of
This allows us to differentiate between the possible failure modes of
b53_switch_reset() by looking at the dmesg output.
Signed-off-by: Paul Barker
---
drivers/net/dsa/b53/b53_common.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/b53/b53_common.c b
In the "single port" example code for configuring a DSA switch without
tagging support from userspace the command to bring up the "lan2" link
was typo'd.
Signed-off-by: Paul Barker
---
Documentation/networking/dsa/configuration.rst | 2 +-
1 file changed, 1 insertio
On Wed, 5 Apr 2017 10:00:04 -0400
"John W. Linville" wrote:
> On Mon, Apr 03, 2017 at 11:25:54AM +0100, Paul Barker wrote:
> > Hi,
> >
> > It looks like the checksum of the following file has changed recently:
> > https://www.kernel.org/pub/softwa
gz file as corrupted since the checksums do not match those
originally recorded.
Thanks,
Paul Barker
26 matches
Mail list logo
