Re: [PATCH net-next v3 1/3] netvsc: transparent VF management

2017-08-03 Thread Olaf Hering
On Tue, Aug 01, Stephen Hemminger wrote: > static void netvsc_get_stats64(struct net_device *net, > struct rtnl_link_stats64 *t) > { > struct net_device_context *ndev_ctx = netdev_priv(net); > struct netvsc_device *nvdev = rcu_dereference_rtnl(ndev_ctx->n

Re: nfs NULL-dereferencing in net-next

2016-11-10 Thread Olaf Hering
On Thu, Nov 03, Anna Schumaker wrote: > Aww, I was hoping that patch would work. It still seemed to fix some > issues for me when mounting multiple servers, so I'm planning to keep > it. Unfortunately I'm out of town this week, so I haven't had much of > a chance to keep poking at this issue. I

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-07 Thread Olaf Hering
On Thu, Jun 30, Dexuan Cui wrote: > +/* The MTU is 16KB per the host side's design. */ > +struct hvsock_recv_buf { > + unsigned int data_len; > + unsigned int data_offset; > + > + struct vmpipe_proto_header hdr; > + u8 buf[PAGE_SIZE * 4]; Please use some macro related to the proto

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-06-30 Thread Olaf Hering
On Thu, Jun 30, Olaf Hering wrote: > On Thu, Jun 30, Dexuan Cui wrote: > > > -#define AF_MAX 43 /* For now.. */ > > +#define AF_MAX 44 /* For now.. */ > > Should this patch also change the places where AF_MAX is used, > like all th

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-06-30 Thread Olaf Hering
On Thu, Jun 30, Dexuan Cui wrote: > -#define AF_MAX 43 /* For now.. */ > +#define AF_MAX 44 /* For now.. */ Should this patch also change the places where AF_MAX is used, like all the arrays in net/core/sock.c? Olaf signature.asc Description: PGP signature

Re: [PATCH V6 8/8] hvsock: introduce Hyper-V Socket feature

2016-01-26 Thread Olaf Hering
On Tue, Jan 26, Dexuan Cui wrote: > +#define AF_MAX 42 /* For now.. */ Maybe net/core/sock.c needs additional strings for the new socket? Olaf

Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-07 Thread Olaf Hering
On Tue, Jul 07, Dexuan Cui wrote: > OK, removing the line seems better than 'default n', though both reproduce > the same "# CONFIG_HYPERV_SOCK is not set". Perhaps "default VMBUS" (or whatever syntax is needed) may be the way to enable it conditionally. Olaf -- To unsubscribe from this list: se

Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-07 Thread Olaf Hering
On Tue, Jul 07, Paul Bolle wrote: > On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote: > > --- /dev/null > > +++ b/net/hv_sock/Kconfig > > > +config HYPERV_SOCK > > + tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)" > > + depends on HYPERV > > + default m > It's a bit odd to advise to s

[PATCH] add modalias info to mv643xx_eth.ko

2008-01-18 Thread Olaf Hering
mv643xx_eth has an platform modalias file in sysfs. But the module itself has no alias: line. Autoloading fails without the alias info in the module. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c |1 + 1 file changed, 1 insertion(+) --- a/drive

[PATCH] fix mace_handle_misc_intrs compilation

2007-09-24 Thread Olaf Hering
Fix compilation after incomplete struct net_device changes. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> --- drivers/net/mace.c |8 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/net/mace.c +++ b/drivers/net/mace.c @@ -633,7 +633,7 @@ stati

[PATCH] bmac: add simple ethtool support for network manager

2007-08-25 Thread Olaf Hering
NetworkManager will not start dhcpd on an interface unless it reports link-up state via ethtool. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> --- drivers/net/bmac.c | 13 + 1 file changed, 13 insertions(+) --- a/drivers/net/bmac.c +++ b/drivers/net/bmac.c @@ -19,6

Re: 2.6.22: ERROR: "__ucmpdi2" [drivers/net/s2io.ko] undefined!

2007-06-19 Thread Olaf Hering
On Tue, Jun 19, Stephen Hemminger wrote: > On Tue, 19 Jun 2007 21:02:53 +0200 > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > > What happend to __ucmpdi2 from David Woodhouse? > > google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2: >

Re: [PATCH] fix MCA when shutting down tulip quad-NIC

2007-04-10 Thread Olaf Hering
On Thu, Apr 05, Valerie Henson wrote: > On Tue, Apr 03, 2007 at 11:19:16PM +0200, Olaf Hering wrote: > > From: [EMAIL PROTECTED] > > > > https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204 > > Wow, registering for Novell's bugzilla is painful. And in the end

[PATCH] fix MCA when shutting down tulip quad-NIC

2007-04-03 Thread Olaf Hering
From: [EMAIL PROTECTED] https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204 Shutting down the network causes an MCA because of an IO TLB error when a DEC quad 10/100 card is in any slot. This problem was originally seen on an HP rx4640. Signed-off-by: Olaf Hering <[EMAIL PROTEC

Re: [PATCH] mark non-compiling ISA network drivers i386 only

2006-11-09 Thread Olaf Hering
On Thu, Nov 09, Stephen Hemminger wrote: > On Thu, 9 Nov 2006 19:40:21 +0100 (MET) > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > > Provide drivers for the old toys only on i386 > > isa_bus_to_virt is defined only on i386, mips and arm > > isa_virt_to

[PATCH] mark non-compiling ISA network drivers i386 only

2006-11-09 Thread Olaf Hering
vers/net/3c515.ko] undefined! WARNING: "isa_virt_to_bus" [drivers/net/3c515.ko] undefined! WARNING: "isa_virt_to_bus" [drivers/net/3c505.ko] undefined! I'm sure noone will miss the drivers. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> --- drivers/net/Kco

Re: revert mv643xx change from ubuntu tree

2006-10-19 Thread Olaf Hering
On Fri, Oct 20, Ben Collins wrote: > On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote: > > Somehow the Ubuntu guys managed to sneak this compile error into the > > tree: > > > > commit ce9e3d9953c8cb67001719b5516da2928e956be4 > > > > [mv643x

revert mv643xx change from ubuntu tree

2006-10-19 Thread Olaf Hering
Somehow the Ubuntu guys managed to sneak this compile error into the tree: commit ce9e3d9953c8cb67001719b5516da2928e956be4 [mv643xx] Add pci device table for auto module loading. drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type drivers/net/mv643xx_eth.c:1561:

[PATCH] keep track of network interface renaming

2006-08-15 Thread Olaf Hering
about what network hardware maps to what kernel interface in later driver or network stack messages. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> --- net/core/dev.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-2.6.18-rc4/net/core

Re: incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo

2006-07-21 Thread Olaf Hering
On Fri, Jul 21, Michael Buesch wrote: > On Friday 21 July 2006 20:59, Olaf Hering wrote: > > > > bcm43xx_get_drvinfo in 2.6.18-rc2 unfortunately uses UTS_RELEASE as > > driver version. I think this specific info can be obtained by other > > ways. > > Can you g

incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo

2006-07-21 Thread Olaf Hering
bcm43xx_get_drvinfo in 2.6.18-rc2 unfortunately uses UTS_RELEASE as driver version. I think this specific info can be obtained by other ways. Can you give bcm43xx a real version number and provide it via the ethtool ioctl? It will trigger a rebuild if the uname -r of the kernel to build changes. -

Re: Linux v2.6.17-rc4

2006-05-12 Thread Olaf Hering
On Fri, May 12, Michael Buesch wrote: > On Friday 12 May 2006 12:24, you wrote: > > On Thu, May 11, 2006 at 04:44:03PM -0700, Linus Torvalds wrote: > > > Ok, I've let the release time between -rc's slide a bit too much again, > > > but -rc4 is out there, and this is the time to hunker down for 2

kmalloc_node returns unaligned memory

2006-03-13 Thread Olaf Hering
kmalloc_node returns unaligned pointers on powerpc, when CONFIG_DEBUG_SLAB is enabled. This makes iptables very unhappy. It checks the alignment in net/ipv6/netfilter/ip6_tables.c:check_entry_size_and_hooks(). __alignof__(struct ip6t_entry) returns 8. But returned pointers from xt_alloc_table_inf

Re: SLAB corruption with sungem

2006-03-05 Thread Olaf Hering
On Mon, Mar 06, Benjamin Herrenschmidt wrote: > On Fri, 2006-03-03 at 09:06 +0100, Olaf Hering wrote: > > the RX errors I'm seeing every once in a while are still there in > > 2.6.16rc5. Maybe they happen if there is some IO load on the IDE disks, > > just upgraded

slab corruption in tg3_alloc_rx_skb in 2.6.16-rc5-git2

2006-03-05 Thread Olaf Hering
No idea if tg3 is to blame. Its a JS20, root on ext3 on raid0 on qla23xx fibrechannel 16 hours uptime, it did some package building, no special workload, some ftp download, some nfs upload. Slab corruption: start=ca7c4e60, len=2048 Redzone: 0x5a2cf071/0x5a2cf071. Last user: [](.release_me

Re: [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-03-04 Thread Olaf Hering
On Fri, Mar 03, Jesse Brandeburg wrote: > thanks for testing, I wonder if there is something wrong with my 630, oh well. You have them in SMP mode (non-partitioned)? Maybe that makes a difference. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-03-03 Thread Olaf Hering
On Tue, Feb 28, Jesse Brandeburg wrote: > On Tue, 28 Feb 2006, Olaf Hering wrote: > > >On Mon, Feb 27, Jesse Brandeburg wrote: > > > >>>http://ozlabs.org/pipermail/linuxppc-dev/2006-February/021308.html > >> > >> > >>Olaf I reprod

SLAB corruption with sungem

2006-03-03 Thread Olaf Hering
the RX errors I'm seeing every once in a while are still there in 2.6.16rc5. Maybe they happen if there is some IO load on the IDE disks, just upgraded openoffice.rpm Mar 3 08:56:35 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Mar 3 08:56:35 nectarine kernel: eth0: RX MAC fifo ov

Re: [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-02-28 Thread Olaf Hering
On Tue, Feb 28, Jesse Brandeburg wrote: > BTW do you notice the system seeming to stall while this ethtool test is > running? I tried it with init=/bin/bash, will check this part tomorrow. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-02-28 Thread Olaf Hering
On Mon, Feb 27, Jesse Brandeburg wrote: > >http://ozlabs.org/pipermail/linuxppc-dev/2006-February/021308.html > > > Olaf I reproduced this problem on a 630 and this patch fixes it for me, > please verify. Due to the new load ucode command the cb list must be > allocated before calling e100_i

Re: [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-02-27 Thread Olaf Hering
commit 24180333206519e6b0c4633eab81e773b4527cac > author Jesse Brandeburg <[EMAIL PROTECTED]> Wed, 18 Jan 2006 07:01:06 -0800 > committer Jeff Garzik <[EMAIL PROTECTED]> Wed, 18 Jan 2006 05:15:15 -0500 > > [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading > issue) > >

Re: [2.6 patch] make UNIX a bool

2006-02-25 Thread Olaf Hering
On Sat, Feb 25, Adrian Bunk wrote: > CONFIG_UNIX=m doesn't make much sense. There is likely more code to support a modular unix.ko, this has to go as well. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [PATCH] keep track of network interface renaming

2006-02-19 Thread Olaf Hering
On Sat, Feb 18, Jeff Garzik wrote: > Fix Xen network support not to do such stupid stuff... No Xen due to lack of A20 gates. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

Re: [PATCH] keep track of network interface renaming

2006-02-18 Thread Olaf Hering
On Sat, Feb 18, Andrew Morton wrote: > What caused all that renaming? If it was userspace-initiated then perhaps > we should display current->comm too? Its udev, or nameif. Some apps (and worse: lusers!) expect stable network device names. They cant be bothered to name them foo and bar and be d

[PATCH] keep track of network interface renaming

2006-02-18 Thread Olaf Hering
eth0 dev_change_name: about to rename 'ethxx1' to 'eth2' ethxx1 renamed to eth2 e1000: eth0: e1000_watchdog_task: NIC Link is Up 100 Mbps Full Duplex The KERN_DEBUG line can obviously go in the final version. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> net/core/dev

Re: slab corruption after sungem recieve errors

2006-02-11 Thread Olaf Hering
On Fri, Feb 10, Olaf Hering wrote: > I have seen this kind of error every once in a while on my G4/450 Mac. > > > Linux version 2.6.13-20050921064541-default ([EMAIL PROTECTED]) (gcc version > 4.0.2 20050901 (prerelease) (SUSE Linux)) #1 Wed Sep 21 06:45:41 UTC 2005 > >

slab corruption after sungem recieve errors

2006-02-10 Thread Olaf Hering
I have seen this kind of error every once in a while on my G4/450 Mac. Linux version 2.6.13-20050921064541-default ([EMAIL PROTECTED]) (gcc version 4.0.2 20050901 (prerelease) (SUSE Linux)) #1 Wed Sep 21 06:45:41 UTC 2005 sungem.c:v0.98 8/24/03 David S. Miller (davem@redhat.com) PHY ID: 406212,

Re: [PATCH netdev-2.6 30/39] e1000: Added variable to handle return values for pci_enable_* functions

2006-01-26 Thread Olaf Hering
On Wed, Jan 11, Jeff Kirsher wrote: > Added variable to handle return values for pci_enable_* functions > > This was to fix compilation warnings. Also added log messages when > pci_enable_* functions return with an error. I object to this patch. Useless error messages for unhandled return val

Re: [PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work

2006-01-23 Thread Olaf Hering
On Mon, Jan 23, Andrew Morton wrote: > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > > > We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16 > > still doesnt work for you on this sort of hardware? I did not find a > > bugzilla nor a better

Re: [PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work

2006-01-23 Thread Olaf Hering
On Mon, Jan 23, Andrew Morton wrote: > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > > > We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16 > > still doesnt work for you on this sort of hardware? I did not find a > > bugzilla nor a better

[PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work

2006-01-21 Thread Olaf Hering
We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16 still doesnt work for you on this sort of hardware? I did not find a bugzilla nor a better description. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> diff -ur linux-2.6.10/drivers/net/tulip/media.c linux-2.6.10work/d

Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-19 Thread Olaf Hering
On Wed, Jan 18, Dale Farnsworth wrote: > On Wed, Jan 18, 2006 at 04:26:00PM +0100, Olaf Hering wrote: > > I havent checked if this patch is the culprit, but 2.6.16-rc1-git1 does > > lockup after modprobe -v mv643xx_eth , dhcpcd eth2. > > Have to find a serial console for t

Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-18 Thread Olaf Hering
On Mon, Jan 16, Dale Farnsworth wrote: > This driver has historically held a spin_lock during the entire open > and stop functions and while receiving multiple packets. This is > unecessarily long and holds locks during calls that may sleep. > This patch reduces the size of windows where locks a

Re: [PATCH] sis900 and sis190 depend on CONFIG_ISA

2006-01-18 Thread Olaf Hering
On Wed, Jan 18, Patrick McHardy wrote: > Olaf Hering wrote: > > isa_bridge is used in drivers/net/sis190.c and drivers/net/sis900.c > > include/linux/pci.h hides it in CONFIG_ISA. > > Let both drivers depend on ISA. > > But it includes a NOP definition for the

[PATCH] sis900 and sis190 depend on CONFIG_ISA

2006-01-18 Thread Olaf Hering
isa_bridge is used in drivers/net/sis190.c and drivers/net/sis900.c include/linux/pci.h hides it in CONFIG_ISA. Let both drivers depend on ISA. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> drivers/net/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: linux-

Re: [PATCH] fix mv643xx compilation

2006-01-16 Thread Olaf Hering
lete type linux-2.6.15/drivers/net/mv643xx_eth.c:1224: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1227: error: dereferencing pointer to incomplete type Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> drivers/net/mv643xx_eth.c |1 + 1 files changed,

[PATCH] fix mv643xx compilation

2006-01-16 Thread Olaf Hering
linux-2.6.15/drivers/net/mv643xx_eth.c: In function `mv643xx_eth_start_xmit': linux-2.6.15/drivers/net/mv643xx_eth.c:1159: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1161: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx

Re: [PATCH 4/4] mv643xx: Don't call request_irq with a held lock

2006-01-03 Thread Olaf Hering
On Wed, Dec 28, Dale Farnsworth wrote: > From: Dale Farnsworth <[EMAIL PROTECTED]> > > We can't call request_irq() while holding a spin lock. This still calls malloc with the lock held. What is the lock trying to protect anyway? Maybe the lock should be moved to the place where the lock is real

[PATCH] remove bouncing mail address of mv643xx_eth maintainer

2005-12-19 Thread Olaf Hering
Remove bouncing mail address of mv643xx maintainer. Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> MAINTAINERS |1 - drivers/net/mv643xx_eth.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.15-rc6-olh/MAINT

Re: [PATCH] skge: get rid of warning on race

2005-12-13 Thread Olaf Hering
On Tue, Dec 06, Stephen Hemminger wrote: > Get rid of warning in case of race with ring full and lockless > tx on the skge driver. It is possible to be in the transmit > routine with no available slots and already stopped. Where do I find that netif_stopped? -- short story of a lazy sysadmin:

[PATCH] pcnet32: use MAC address from prom also on powerpc

2005-12-09 Thread Olaf Hering
worked only on the 270. Only netbooting after a cold start provides the correct MAC address via prom and CSR. This makes it very unreliable. I dont know why the MAC is stored in two different places. Remove the special case for powerpc, which was added in early 2.4 development. Signed-off-by: Olaf

[PATCH] ieee80211_crypt_tkip depends on NET_RADIO

2005-12-01 Thread Olaf Hering
*** Warning: ".wireless_send_event" [net/ieee80211/ieee80211_crypt_tkip.ko] undefined! Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> net/ieee80211/Kconfig |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.14/net/i

Re: [LLC]: Fix TX window scaling

2005-11-17 Thread Olaf Hering
On Tue, Nov 15, Linux Kernel Mailing List wrote: > tree 574e979829d3363c16c8c6d1fe624b206d8ce4f9 > parent cb422c464bdaeeb3b9ad4539010e357bf1bd1745 > author Jochen Friedrich <[EMAIL PROTECTED]> Tue, 15 Nov 2005 13:57:15 -0800 > committer David S. Miller <[EMAIL PROTECTED]> Tue, 15 Nov 2005 13:57:1

Re: more ipsec crashes in 2.6.13

2005-09-07 Thread Olaf Hering
On Wed, Sep 07, Herbert Xu wrote: > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > The patch 'p' which was posted by Herbert today doesnt fix it. > > Can you please double check? That bug would cause exactly what > you're seeing here since i

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
On Tue, Sep 06, Olaf Hering wrote: > > This happens after: > > ssh [EMAIL PROTECTED] "rcipsec restart" > ssh [EMAIL PROTECTED] "rcipsec restart" > > ssh [EMAIL PROTECTED] "ping -i 0.01 -s 4096 g167.suse.de" > > The patch 'p'

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
On Tue, Sep 06, Olaf Hering wrote: > > This happens after: > > ssh [EMAIL PROTECTED] "rcipsec restart" > ssh [EMAIL PROTECTED] "rcipsec restart" > > ssh [EMAIL PROTECTED] "ping -i 0.01 -s 4096 g167.suse.de" > > The patch 'p'

Re: more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
On Tue, Sep 06, Olaf Hering wrote: > put_page gets NULL. >dar: bdf20d2efc7304a2 No, it is garbage. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

more ipsec crashes in 2.6.13

2005-09-06 Thread Olaf Hering
This happens after: ssh [EMAIL PROTECTED] "rcipsec restart" ssh [EMAIL PROTECTED] "rcipsec restart" ssh [EMAIL PROTECTED] "ping -i 0.01 -s 4096 g167.suse.de" The patch 'p' which was posted by Herbert today doesnt fix it. put_page gets NULL. Welcome to SUSE LINUX 10.0 (PPC) - Kernel 2.6.13-pp