Re: [net-next 11/15] i40e: Implement debug macro hw_dbg using pr_debug

2019-09-02 Thread Mauro Rodrigues
On Wed, Aug 28, 2019 at 03:39:53PM -0700, Jakub Kicinski wrote: > On Tue, 27 Aug 2019 23:44:03 -0700, Jeff Kirsher wrote: > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_osdep.h > > b/drivers/net/ethernet/intel/i40e/i40e_osdep.h > > index a07574bff550..c0c9ce3eab23 100644 > > --- a/drivers/n

Re: [PATCH net-next] ibmvnic: Add device identification to requested IRQs

2019-04-25 Thread Mauro Rodrigues
On Thu, Apr 25, 2019 at 11:02:33AM -0300, Murilo Fossa Vicentini wrote: > The ibmvnic driver currently uses the same fixed name when using > request_irq, this makes it hard to parse when multiple VNIC devices are > available at the same time. This patch adds the unit_address as the device > identif

Re: [PATCH net-next] ibmvnic: Report actual backing device speed and duplex values

2019-03-19 Thread Mauro Rodrigues
On Tue, Mar 19, 2019 at 10:28:51AM -0300, Murilo Fossa Vicentini wrote: > The ibmvnic driver currently reports a fixed value for both speed and > duplex settings regardless of the actual backing device that is being > used. By adding support to the QUERY_PHYS_PARMS command defined by the > PAPR+ we

Re: [PATCH net] tg3: APE heartbeat changes

2018-02-16 Thread Mauro Rodrigues
On Fri, Feb 16, 2018 at 11:22:43AM +0530, Satish Baddipadige wrote: > From: Prashant Sreedharan > > In ungraceful host shutdown or driver crash case BMC connectivity is > lost. APE firmware is missing the driver state in this > case to keep the BMC connectivity alive. > This patch has below chang

Re: [net-intel-i40e] question about assignment overwrite

2017-06-07 Thread Mauro Rodrigues
On Wed, May 17, 2017 at 10:49:11PM -0700, Jeff Kirsher wrote: > On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > > While looking into Coverity ID 1408956 I ran into the following > > piece   > > of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807: > > > > 8807    if (pf-

Re: [PATCH net v2] i40e/i40evf: proper update of the page_offset field

2017-05-15 Thread Mauro Rodrigues
On Mon, May 15, 2017 at 06:52:00AM +0200, Björn Töpel wrote: > From: Björn Töpel > > In f8b45b74cc62 ("i40e/i40evf: Use build_skb to build frames") > i40e_build_skb updates the page_offset field with an incorrect offset, > which can lead to data corruption. This patch updates page_offset > correc