[PATCH v5] net/af_unix: don't create a path for a bound socket

2021-01-19 Thread Denis Kirjanov
\n"); } kda@SLES15-SP2:~> ./test First bind() Second bind() bind() failed : Invalid argument kda@SLES15-SP2:~> ls -la /tmp/.first_bind .first_bind .first_bind_failed Signed-off-by: Denis Kirjanov --- net/unix/af_unix.c | 17 - 1 file changed, 16 insert

[PATCH v4] net/af_unix: don't create a path for a bound socket

2020-12-03 Thread Denis Kirjanov
\n"); } kda@SLES15-SP2:~> ./test First bind() Second bind() bind() failed : Invalid argument kda@SLES15-SP2:~> ls -la /tmp/.first_bind .first_bind .first_bind_failed Signed-off-by: Denis Kirjanov v2: move a new path creation after the address assignment check v3: fixed goto l

Re: [PATCH v3] net/af_unix: don't create a path for a binded socket

2020-12-03 Thread Denis Kirjanov
On 12/1/20, Jakub Kicinski wrote: > On Tue, 1 Dec 2020 12:33:06 +0300 Denis Kirjanov wrote: >> in the case of the socket which is bound to an adress >> there is no sense to create a path in the next attempts >> >> here is a program that shows the issue: >>

[PATCH v3] net/af_unix: don't create a path for a binded socket

2020-12-01 Thread Denis Kirjanov
\n"); } kda@SLES15-SP2:~> ./test First bind() Second bind() bind() failed : Invalid argument kda@SLES15-SP2:~> ls -la /tmp/.first_bind .first_bind .first_bind_failed Signed-off-by: Denis Kirjanov v2: move a new path creation after the address assignment check v3: fixed goto lab

Re: [net/af_unix] 556d816147: WARNING:lock_held_when_returning_to_user_space

2020-12-01 Thread Denis Kirjanov
knod() should be fixed as well. I'll send a next version shortly. Thanks! > url: > https://github.com/0day-ci/linux/commits/Denis-Kirjanov/net-af_unix-don-t-create-a-path-for-a-binded-socket/20201130-213012 > base: https://git.kernel.org/cgit/linux/kernel/git/davem/net.git > 4d5

[PATCH v2] net/af_unix: don't create a path for a binded socket

2020-11-30 Thread Denis Kirjanov
\n"); } kda@SLES15-SP2:~> ./test First bind() Second bind() bind() failed : Invalid argument kda@SLES15-SP2:~> ls -la /tmp/.first_bind .first_bind .first_bind_failed Signed-off-by: Denis Kirjanov v2: move a new patch creation after the address assignment check. --- net/unix/af_

Re: [PATCH] net/af_unix: don't create a path for a binded socket

2020-11-26 Thread Denis Kirjanov
On 11/26/20, Jakub Kicinski wrote: > On Tue, 24 Nov 2020 15:24:21 +0300 Denis Kirjanov wrote: >> in the case of the socket which is bound to an adress >> there is no sense to create a path in the next attempts > >> diff --git a/net/unix/af_unix.c b/net/unix/af_unix

[PATCH] net/af_unix: don't create a path for a binded socket

2020-11-24 Thread Denis Kirjanov
\n"); } kda@SLES15-SP2:~> ./test First bind() Second bind() bind() failed : Invalid argument kda@SLES15-SP2:~> ls -la /tmp/.first_bind .first_bind .first_bind_failed Signed-off-by: Denis Kirjanov --- net/unix/af_unix.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) dif

Re: [PATCH net-next resend 1/2] enetc: Fix endianness issues for enetc_ethtool

2020-11-19 Thread Denis Kirjanov
On 11/19/20, Claudiu Manoil wrote: > These particular fields are specified in the H/W reference > manual as having network byte order format, so enforce big > endian annotation for them and clear the related sparse > warnings in the process. > > Signed-off-by: Claudiu Manoil > --- > drivers/net/

Re: [PATCH net v2] net: emaclite: Add error handling for of_address_ and _mdio_setup functions

2020-11-17 Thread Denis Kirjanov
On 11/17/20, Radhey Shyam Pandey wrote: > From: Shravya Kumbham > > Add ret variable, condition to check the return value and error > path for the of_address_to_resource() function. It also adds error > handling for mdio setup and decrement refcount of phy node. > > Addresses-Coverity: Event chec

Re: [PATCH] xsk: add cq event

2020-11-16 Thread Denis Kirjanov
On 11/16/20, Denis Kirjanov wrote: > On 11/16/20, Xuan Zhuo wrote: >> On Mon, 16 Nov 2020 12:13:21 +0300, Denis Kirjanov >> >> wrote: >>> On 11/16/20, Xuan Zhuo wrote: >>> > When we write all cq items to tx, we have to wait for a new event >&g

Re: [PATCH] xsk: add cq event

2020-11-16 Thread Denis Kirjanov
On 11/16/20, Xuan Zhuo wrote: > On Mon, 16 Nov 2020 12:13:21 +0300, Denis Kirjanov > wrote: >> On 11/16/20, Xuan Zhuo wrote: >> > When we write all cq items to tx, we have to wait for a new event based >> > on poll to indicate that it is writable. But the current

Re: [PATCH] xsk: add cq event

2020-11-16 Thread Denis Kirjanov
On 11/16/20, Xuan Zhuo wrote: > When we write all cq items to tx, we have to wait for a new event based > on poll to indicate that it is writable. But the current writability is > triggered based on whether tx is full or not, and In fact, when tx is > dissatisfied, the user of cq's item may not ne

Re: [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id

2020-11-10 Thread Denis Kirjanov
On 11/10/20, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The unsigned variable datasec_id is assigned a return value from the call > to check_pseudo_btf_id(), which may return negative error code. > > Fixes coccicheck warning: > > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expre

Re: [PATCH v2 06/11] sundance: use generic power management

2020-07-08 Thread Denis Kirjanov
On 7/3/20, Denis Kirjanov wrote: > On 7/1/20, Vaibhav Gupta wrote: >> With legacy PM, drivers themselves were responsible for managing the >> device's power states and takes care of register states. >> >> After upgrading to the generic structure, PCI core will ta

Re: [PATCH v2 06/11] sundance: use generic power management

2020-07-03 Thread Denis Kirjanov
On 7/1/20, Vaibhav Gupta wrote: > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific ope

[PATCH net-next v14 1/3] xen: netif.h: add a new extra type for XDP

2020-06-29 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. The offset value from a guest is passed via xenstore. Signed-off-by: Denis Kirjanov --- include/xen/interface/io/netif.h | 20

[PATCH net-next v14 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-29 Thread Denis Kirjanov
done by using xenbus state switching: Reconfiguring -> Reconfigured- > Connected UDP packets drop rate using xdp program is around 310 kpps using ./pktgen_sample04_many_flows.sh and 160 kpps without the patch. Signed-off-by: Denis Kirjanov --- drivers/net/Kconfig| 1 + drivers/n

[PATCH net-next v14 0/3] xen networking: add XDP support to xen-netfront

2020-06-29 Thread Denis Kirjanov
CT support (tested with modified xdp_redirect_kern) - moved xdp negotiation to xen-netback v2: - avoid data copying while passing to XDP - tell xen-netback that we need the headroom space Denis Kirjanov (3): xen: netif.h: add a new extra type for XDP xen networking: add basic XDP support for xe

Re: [PATCH net-next v13 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-29 Thread Denis Kirjanov
On 6/26/20, Jakub Kicinski wrote: > On Fri, 26 Jun 2020 14:40:38 +0300 Denis Kirjanov wrote: >> The patch adds a basic XDP processing to xen-netfront driver. >> >> We ran an XDP program for an RX response received from netback >> driver. Also we request xen-netbac

Re: [PATCH net-next v13 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-29 Thread Denis Kirjanov
On 6/26/20, Jesper Dangaard Brouer wrote: > On Fri, 26 Jun 2020 14:40:38 +0300 > Denis Kirjanov wrote: > >> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >> index 482c6c8..91a3b53 100644 >> --- a/drivers/net/xen-netfront.c >>

[PATCH net-next v14 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-29 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Reviewed-by: Paul Durrant Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h| 4 drivers/net/xen-netback/interface.c | 2 ++ drivers/net/xen-netback/netback.c

[PATCH net-next v13 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-26 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h| 4 drivers/net/xen-netback/interface.c | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers

[PATCH net-next v13 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-26 Thread Denis Kirjanov
done by using xenbus state switching: Reconfiguring -> Reconfigured- > Connected UDP packets drop rate using xdp program is around 310 kpps using ./pktgen_sample04_many_flows.sh and 160 kpps without the patch. Signed-off-by: Denis Kirjanov --- drivers/net/Kconfig| 1 + drivers/n

[PATCH net-next v13 0/3] xen networking: add XDP support to xen-netfront

2020-06-26 Thread Denis Kirjanov
h modified xdp_redirect_kern) - moved xdp negotiation to xen-netback v2: - avoid data copying while passing to XDP - tell xen-netback that we need the headroom space Denis Kirjanov (3): xen: netif.h: add a new extra type for XDP xen networking: add basic XDP support for xen-netfront xen networking: add

[PATCH net-next v13 1/3] xen: netif.h: add a new extra type for XDP

2020-06-26 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. The offset value from a guest is passed via xenstore. Signed-off-by: Denis Kirjanov --- include/xen/interface/io/netif.h | 20

Re: [PATCH net-next v12 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-26 Thread Denis Kirjanov
On 6/26/20, Denis Kirjanov wrote: > the patch basically adds the offset adjustment and netfront > state reading to make XDP work on netfront side. > > Signed-off-by: Denis Kirjanov Ooops, please ignore it. That was to quick :/ > --- > drivers/net/xen-netback/common.h|

[PATCH net-next v12 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-26 Thread Denis Kirjanov
done by using xenbus state switching: Reconfiguring -> Reconfigured- > Connected UDP packets drop rate using xdp program is around 310 kpps using ./pktgen_sample04_many_flows.sh and 160 kpps without the patch. Signed-off-by: Denis Kirjanov --- drivers/net/Kconfig| 1 + drivers/n

[PATCH net-next v12 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-26 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h| 4 drivers/net/xen-netback/interface.c | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers

[PATCH net-next v12 1/3] xen: netif.h: add a new extra type for XDP

2020-06-26 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. The offset value from a guest is passed via xenstore. Signed-off-by: Denis Kirjanov --- include/xen/interface/io/netif.h | 20

[PATCH net-next v12 0/3] xen networking: add XDP support to xen-netfront

2020-06-26 Thread Denis Kirjanov
etback v2: - avoid data copying while passing to XDP - tell xen-netback that we need the headroom space Denis Kirjanov (3): xen: netif.h: add a new extra type for XDP xen networking: add basic XDP support for xen-netfront xen networking: add XDP offset adjustment to xen-netback drivers/n

[PATCH net-next v11 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-26 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h| 4 drivers/net/xen-netback/interface.c | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers

[PATCH net-next v11 1/3] xen: netif.h: add a new extra type for XDP

2020-06-26 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. The offset value from a guest is passed via xenstore. Signed-off-by: Denis Kirjanov --- include/xen/interface/io/netif.h | 20

[PATCH net-next v11 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-26 Thread Denis Kirjanov
done by using xenbus state switching: Reconfiguring -> Reconfigured- > Connected UDP packets drop rate using xdp program is around 310 kpps using ./pktgen_sample04_many_flows.sh and 160 kpps without the patch. Signed-off-by: Denis Kirjanov --- drivers/net/Kconfig| 1 + drivers/n

[PATCH net-next v11 0/3] xen networking: add XDP support to xen-netfront

2020-06-26 Thread Denis Kirjanov
tback that we need the headroom space Denis Kirjanov (3): xen: netif.h: add a new extra type for XDP xen networking: add basic XDP support for xen-netfront xen networking: add XDP offset adjustment to xen-netback drivers/net/Kconfig | 1 + drivers/net/xen-netback/common.

[PATCH v3] tcp: don't ignore ECN CWR on pure ACK

2020-06-25 Thread Denis Kirjanov
CWR on pure ACKs received. v3: - Add a sequence check to avoid sending an ACK to an ACK v2: - Adjusted the comment - move CWR check before checking for unacknowledged packets Signed-off-by: Denis Kirjanov --- net/ipv4/tcp_input.c | 14 +++--- 1 file changed, 11 insertions(+), 3 delet

[PATCH v2] tcp: don't ignore ECN CWR on pure ACK

2020-06-24 Thread Denis Kirjanov
CWR on pure ACKs received. v2: - Adjusted the comment - move CWR check before checking for unacknowledged packets Signed-off-by: Denis Kirjanov --- net/ipv4/tcp_input.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c in

Re: [PATCH] tcp: don't ignore ECN CWR on pure ACK

2020-06-24 Thread Denis Kirjanov
On 6/23/20, Neal Cardwell wrote: > On Tue, Jun 23, 2020 at 10:54 AM Denis Kirjanov > wrote: >> >> there is a problem with the CWR flag set in an incoming ACK segment >> and it leads to the situation when the ECE flag is latched forever >> >> the following p

[PATCH] tcp: don't ignore ECN CWR on pure ACK

2020-06-23 Thread Denis Kirjanov
will still keep ECE latched here, with packetdrill // flagging a missing ECE flag, expecting // >[ect0] PE. 2001:3001(1000) ack 14001 // in the script In the situation above we will continue to send ECN ECHO packets and trigger the peer to reduce the congestion window. Signed-off-by: Denis Kirja

Re: [PATCH net-next v10 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-22 Thread Denis Kirjanov
On 6/22/20, Jesper Dangaard Brouer wrote: > On Mon, 22 Jun 2020 15:45:46 +0300 > Denis Kirjanov wrote: > >> On 6/22/20, Jesper Dangaard Brouer wrote: >> > >> > On Mon, 22 Jun 2020 12:21:11 +0300 Denis Kirjanov >> > >> > wrote: >> >

Re: [PATCH net-next v10 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-22 Thread Denis Kirjanov
On 6/22/20, Paul Durrant wrote: >> -Original Message- >> From: Denis Kirjanov >> Sent: 22 June 2020 10:21 >> To: netdev@vger.kernel.org >> Cc: bro...@redhat.com; jgr...@suse.com; wei@kernel.org; p...@xen.org; >> ilias.apalodi...@linaro.org >

Re: [PATCH net-next v10 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-22 Thread Denis Kirjanov
On 6/22/20, Jesper Dangaard Brouer wrote: > > On Mon, 22 Jun 2020 12:21:11 +0300 Denis Kirjanov > wrote: > >> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >> index 482c6c8..1b9f49e 100644 >> --- a/drivers/net/xen-netfront.c >&

[PATCH net-next v10 2/3] xen networking: add basic XDP support for xen-netfront

2020-06-22 Thread Denis Kirjanov
done by using xenbus state switching: Reconfiguring -> Reconfigured- > Connected UDP packets drop rate using xdp program is around 310 kpps using ./pktgen_sample04_many_flows.sh and 160 kpps without the patch. Signed-off-by: Denis Kirjanov --- drivers/net/Kconfig| 1 + drivers/n

[PATCH net-next v10 0/3] xen networking: add XDP support to xen-netfront

2020-06-22 Thread Denis Kirjanov
ith xdping echoserver) - added XDP_REDIRECT support (tested with modified xdp_redirect_kern) - moved xdp negotiation to xen-netback v2: - avoid data copying while passing to XDP - tell xen-netback that we need the headroom space Denis Kirjanov (3): xen: netif.h: add a new extra type for XDP xen netwo

[PATCH net-next v10 3/3] xen networking: add XDP offset adjustment to xen-netback

2020-06-22 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h| 4 drivers/net/xen-netback/interface.c | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers

[PATCH net-next v10 1/3] xen: netif.h: add a new extra type for XDP

2020-06-22 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. The offset value from a guest is passed via xenstore. Signed-off-by: Denis Kirjanov --- include/xen/interface/io/netif.h | 18

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-12 Thread Denis Kirjanov
On 5/12/20, Jürgen Groß wrote: > On 12.05.20 14:27, Denis Kirjanov wrote: >> On 5/12/20, Jürgen Groß wrote: >>> On 11.05.20 19:27, Denis Kirjanov wrote: >>>> On 5/11/20, Jürgen Groß wrote: >>>>> On 11.05.20 12:22, Denis Kirjanov wrote: >&g

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-12 Thread Denis Kirjanov
On 5/12/20, Jürgen Groß wrote: > On 11.05.20 19:27, Denis Kirjanov wrote: >> On 5/11/20, Jürgen Groß wrote: >>> On 11.05.20 12:22, Denis Kirjanov wrote: >>>> The patch adds a basic XDP processing to xen-netfront driver. >>>> >>>> We ran a

Re: [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-12 Thread Denis Kirjanov
On 5/12/20, Paul Durrant wrote: >> -Original Message- >> From: Denis Kirjanov >> Sent: 11 May 2020 18:22 >> To: p...@xen.org >> Cc: netdev@vger.kernel.org; bro...@redhat.com; jgr...@suse.com; >> wei@kernel.org; >> ilias.apalodi...@linaro.

Re: [PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-11 Thread Denis Kirjanov
On 5/11/20, Jürgen Groß wrote: > On 11.05.20 12:22, Denis Kirjanov wrote: >> The patch adds a basic XDP processing to xen-netfront driver. >> >> We ran an XDP program for an RX response received from netback >> driver. Also we request xen-netback to adjust data offset

Re: [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-11 Thread Denis Kirjanov
On 5/11/20, Paul Durrant wrote: >> -Original Message- >> From: Denis Kirjanov >> Sent: 11 May 2020 13:12 >> To: p...@xen.org >> Cc: netdev@vger.kernel.org; bro...@redhat.com; jgr...@suse.com; >> wei@kernel.org; >> ilias.apalodi...@linaro.

Re: [PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-11 Thread Denis Kirjanov
On 5/11/20, Paul Durrant wrote: >> -Original Message- >> From: Denis Kirjanov >> Sent: 11 May 2020 11:22 >> To: netdev@vger.kernel.org >> Cc: bro...@redhat.com; jgr...@suse.com; wei@kernel.org; p...@xen.org; >> ilias.apalodi...@linaro.org >

[PATCH net-next v9 0/2] xen networking: add XDP support to xen-netfront

2020-05-11 Thread Denis Kirjanov
ded XDP_TX support (tested with xdping echoserver) - added XDP_REDIRECT support (tested with modified xdp_redirect_kern) - moved xdp negotiation to xen-netback v2: - avoid data copying while passing to XDP - tell xen-netback that we need the headroom space Denis Kirjanov (2): xen networking: add

[PATCH net-next v9 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-11 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers/net/xen-netback/rx.c | 7 ++- drivers/net

[PATCH net-next v9 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-11 Thread Denis Kirjanov
done by using xenbus state switching: Reconfiguring -> Reconfigured- > Connected UDP packets drop rate using xdp program is around 310 kpps using ./pktgen_sample04_many_flows.sh and 160 kpps without the patch. Signed-off-by: Denis Kirjanov --- drivers/net/Kconfig| 1 + drivers/n

Re: [PATCH net-next v8 1/3] xen networking: add basic XDP support for xen-netfront

2020-05-09 Thread Denis Kirjanov
On 5/9/20, Jakub Kicinski wrote: > On Thu, 7 May 2020 15:40:39 +0300 Denis Kirjanov wrote: >> The patch adds a basic XDP processing to xen-netfront driver. >> >> We ran an XDP program for an RX response received from netback >> driver. Also we request xen-netbac

[PATCH net-next v8 1/3] xen networking: add basic XDP support for xen-netfront

2020-05-07 Thread Denis Kirjanov
d XDP_TX support (tested with xdping echoserver) - added XDP_REDIRECT support (tested with modified xdp_redirect_kern) - moved xdp negotiation to xen-netback v2: - avoid data copying while passing to XDP - tell xen-netback that we need the headroom space Signed-off-by: Denis Kirjanov --- drivers/ne

[PATCH net-next v8 2/3] xen networking: add XDP offset adjustment to xen-netback

2020-05-07 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers/net/xen-netback/rx.c | 7 ++- drivers/net

[PATCH net-next v8 3/3] net: xen: select PAGE_POOL for xen-netfront

2020-05-07 Thread Denis Kirjanov
xen-netfront uses page pool API so select it in Kconfig Signed-off-by: Denis Kirjanov --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 25a8f93..45918ce 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -479,6

Re: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-07 Thread Denis Kirjanov
On 5/7/20, Paul Durrant wrote: >> -Original Message- >> From: Denis Kirjanov >> Sent: 06 May 2020 18:45 >> To: p...@xen.org >> Cc: netdev@vger.kernel.org; jgr...@suse.com; wei@kernel.org; >> ilias.apalodi...@linaro.org >> Subject: Re: [PATC

Re: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-06 Thread Denis Kirjanov
On 5/5/20, Paul Durrant wrote: >> -Original Message- >> >> @@ -417,6 +431,11 @@ static void frontend_changed(struct xenbus_device >> >> *dev, >> >> set_backend_state(be, XenbusStateConnected); >> >> break; >> >> >> >> + case XenbusStateReconfiguring: >> >> + rea

Re: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-05 Thread Denis Kirjanov
On 5/5/20, Paul Durrant wrote: >> -Original Message- >> From: Denis Kirjanov >> Sent: 04 May 2020 09:38 >> To: netdev@vger.kernel.org >> Cc: jgr...@suse.com; wei@kernel.org; p...@xen.org; >> ilias.apalodi...@linaro.org >> Subject: [PATC

[PATCH net-next v7 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-04 Thread Denis Kirjanov
e passing to XDP - tell xen-netback that we need the headroom space Signed-off-by: Denis Kirjanov --- drivers/net/xen-netfront.c | 300 - 1 file changed, 296 insertions(+), 4 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-

[PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-04 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers/net/xen-netback/rx.c | 7 ++- drivers/net

[PATCH net-next v6 2/2] xen networking: add XDP offset adjustment to xen-netback

2020-05-01 Thread Denis Kirjanov
the patch basically adds the offset adjustment and netfront state reading to make XDP work on netfront side. Signed-off-by: Denis Kirjanov --- drivers/net/xen-netback/common.h | 2 ++ drivers/net/xen-netback/netback.c | 7 +++ drivers/net/xen-netback/rx.c | 7 ++- drivers/net

[PATCH net-next v6 1/2] xen networking: add basic XDP support for xen-netfront

2020-05-01 Thread Denis Kirjanov
d XDP_TX support (tested with xdping echoserver) - added XDP_REDIRECT support (tested with modified xdp_redirect_kern) - moved xdp negotiation to xen-netback v2: - avoid data copying while passing to XDP - tell xen-netback that we need the headroom space Signed-off-by: Denis Kirjanov --- drivers/ne

[PATCH v3 net-next] be2net: disable bh with spin_lock in be_process_mcc

2019-08-06 Thread Denis Kirjanov
be_process_mcc() is invoked in 3 different places and always with BHs disabled except the be_poll function but since it's invoked from softirq with BHs disabled it won't hurt. v1->v2: added explanation to the patch v2->v3: add a missing call from be_cmds.c Signed-off-by

[PATCH v2 net-next] be2net: disable bh with spin_lock in be_process_mcc

2019-08-01 Thread Denis Kirjanov
be_process_mcc() is invoked in 3 different places and always with BHs disabled except the be_poll function but since it's invoked from softirq with BHs disabled it won't hurt. v1->v2: added explanation to the patch Signed-off-by: Denis Kirjanov --- drivers/net/ethernet/emulex/be

Re: [PATCH net-next] be2net: disable bh with spin_lock in be_process_mcc

2019-07-31 Thread Denis Kirjanov
On 7/30/19, Willem de Bruijn wrote: > On Tue, Jul 30, 2019 at 7:33 AM Denis Kirjanov > wrote: >> >> Signed-off-by: Denis Kirjanov > > This is a partial revert of the previous change to these lines in 2012 > in commit 072a9c486004 ("netpoll: revert 6bdb7fe

Re: [PATCH] net: usb: pegasus: fix improper read if get_registers() fail

2019-07-30 Thread Denis Kirjanov
On 7/30/19, David Miller wrote: > From: Denis Kirjanov > Date: Tue, 30 Jul 2019 15:13:57 +0200 > >> get_registers() may fail with -ENOMEM and in this >> case we can read a garbage from the status variable tmp. >> >> Reported-by: syzbot+3499a83b2d062ae40...@syzkal

[PATCH] net: usb: pegasus: fix improper read if get_registers() fail

2019-07-30 Thread Denis Kirjanov
get_registers() may fail with -ENOMEM and in this case we can read a garbage from the status variable tmp. Reported-by: syzbot+3499a83b2d062ae40...@syzkaller.appspotmail.com Signed-off-by: Denis Kirjanov --- drivers/net/usb/pegasus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] net: usb: pegasus: fix improper read if get_registers() fail

2019-07-30 Thread Denis Kirjanov
get_registers() may fail with -ENOMEM and in this case we can read a garbage from the status variable tmp. Reported-by: syzbot+3499a83b2d062ae40...@syzkaller.appspotmail.com Signed-off-by: Denis Kirjanov --- drivers/net/usb/pegasus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH net-next] be2net: disable bh with spin_lock in be_process_mcc

2019-07-30 Thread Denis Kirjanov
Signed-off-by: Denis Kirjanov --- drivers/net/ethernet/emulex/benet/be_cmds.c | 4 ++-- drivers/net/ethernet/emulex/benet/be_main.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c

Re: [PATCH] vhost: fix null pointer dereference in vhost_del_umem_range

2019-07-10 Thread Denis Kirjanov
On 7/9/19, David Miller wrote: > From: Denis Kirjanov > Date: Tue, 9 Jul 2019 13:42:51 +0200 > >> @@ -962,7 +962,8 @@ static void vhost_del_umem_range(struct vhost_umem >> *umem, >> >> while ((node = vhost_umem_interval

[PATCH] vhost: fix null pointer dereference in vhost_del_umem_range

2019-07-09 Thread Denis Kirjanov
0f 85 3c 0b 00 00 49 8b 6e 60 48 85 ed 0f > 84 1c 0b 00 00 48 89 ea 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> > 3c 02 00 0f 85 f4 0a 00 00 4c 8b 7d 00 4d 85 ff 0f 84 e7 06 > RIP: vhost_chr_write_iter+0x525/0x1330 [vhost] RSP: 88004a827a38 > ---[ end trace 49849730b5255f76 ]---

[PATCH iproute2-next v4 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-28 Thread Denis Kirjanov
state disable, trust off, query_rss off v1->v2: updated kernel headers to uapi commit v2->v3: fixed alignment v3->v4: aligned print statements as used through the source Signed-off-by: Denis Kirjanov --- ip/ipaddress.c | 40 +++- 1 file changed, 35 in

[PATCH iproute2-next v4 2/2] uapi: update if_link.h

2019-06-28 Thread Denis Kirjanov
update if_link.h to commit 75345f888f700c4ab2448287e35d48c760b202e6 ("ipoib: show VF broadcast address") Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_li

Re: [PATCH iproute2-next v3 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-28 Thread Denis Kirjanov
On 6/24/19, David Ahern wrote: > On 6/22/19 12:00 PM, Denis Kirjanov wrote: >> @@ -365,13 +367,45 @@ static void print_vfinfo(FILE *fp, struct rtattr >> *vfinfo) >> parse_rtattr_nested(vf, IFLA_VF_MAX, vfinfo); >> >> vf_mac = RTA_DATA(vf[IFLA_VF_MAC]); &

[PATCH iproute2-next v3 2/2] uapi: update if_link.h

2019-06-22 Thread Denis Kirjanov
update if_link.h to commit 75345f888f700c4ab2448287e35d48c760b202e6 ("ipoib: show VF broadcast address") Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_li

[PATCH iproute2-next v3 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-22 Thread Denis Kirjanov
state disable, trust off, query_rss off v1->v2: updated kernel headers to uapi commit v2->v3: fixed alignment Signed-off-by: Denis Kirjanov --- ip/ipaddress.c | 44 +++- 1 file changed, 39 insertions(+), 5 deletions(-) diff --git a/ip/ipaddress.c b/ip/

Re: [PATCH iproute2-next v2 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-21 Thread Denis Kirjanov
On 6/20/19, Denis Kirjanov wrote: > Current code assumes that we print Etheret mac and > that doesn't work in IPoIB case with SRIOV-enabled hardware > > Before: > 11: ib1: mtu 2044 qdisc pfifo_fast > state UP mode DEFAULT group default qlen 256 > link/infiniband

[PATCH iproute2-next v2 2/2] uapi: update if_link.h

2019-06-20 Thread Denis Kirjanov
update if_link.h to commit 75345f888f700c4ab2448287e35d48c760b202e6 ("ipoib: show VF broadcast address") Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_li

[PATCH iproute2-next v2 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-20 Thread Denis Kirjanov
sable, trust off, query_rss off v1->v2: updated kernel headers to uapi commit Signed-off-by: Denis Kirjanov --- ip/ipaddress.c | 42 +- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index b504200b..13ad76d

[PATCH iproute2 v2 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-19 Thread Denis Kirjanov
sable, trust off, query_rss off v1->v2: updated kernel headers to uapi commit Signed-off-by: Denis Kirjanov --- ip/ipaddress.c | 42 +- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index b504200b..13ad76d

[PATCH iproute2 v2 2/2] uapi: update if_link.h

2019-06-19 Thread Denis Kirjanov
update if_link.h to commit 75345f888f700c4ab2448287e35d48c760b202e6 ("ipoib: show VF broadcast address") Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_li

[PATCH 1/2] ipoib: correcly show a VF hardware address

2019-06-17 Thread Denis Kirjanov
disable, trust off, query_rss off [0]: https://patchwork.kernel.org/patch/10997111/ v1->v2: just copy an address without modifing ifla_vf_mac v2->v3: update the changelog v3->v4: update the changelog: add a link to the patch for iproute2 Signed-off-by: Denis Kirjanov --- drivers/infin

[PATCH net-next v4 1/2] ipoib: correcly show a VF hardware address

2019-06-17 Thread Denis Kirjanov
, query_rss off v1->v2: just copy an address without modifing ifla_vf_mac v2->v3: update the changelog Signed-off-by: Denis Kirjanov --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniba

[PATCH net-next v4 2/2] ipoib: show VF broadcast address

2019-06-17 Thread Denis Kirjanov
ROADCAST constant v2->v3: put IFLA_VF_BROADCAST at the end to avoid KABI breakage and set NLA_REJECT dev_setlink Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + net/core/rtnetlink.c | 5 + 2 files changed, 10 insertions(+) diff --git a/include/uapi/linux/

[PATCH 2/2] ipoib: show VF broadcast address

2019-06-17 Thread Denis Kirjanov
https://patchwork.kernel.org/patch/10997111 v1->v2: add the IFLA_VF_BROADCAST constant v2->v3: put IFLA_VF_BROADCAST at the end to avoid KABI breakage and set NLA_REJECT dev_setlink v3->v4: update the changelog: add a link to the patch for iproute2 Signed-off-by: Denis Kirjanov --- incl

[iproute2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-15 Thread Denis Kirjanov
s off Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_infiniband.h | 29 +++ include/uapi/linux/if_link.h | 5 + include/uapi/linux/netdevice.h | 2 +- ip/ipaddress.c | 41 +- 4 files change

[PATCH] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-15 Thread Denis Kirjanov
s off Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_infiniband.h | 29 +++ include/uapi/linux/if_link.h | 5 + include/uapi/linux/netdevice.h | 2 +- ip/ipaddress.c | 41 +- 4 files change

Re: [PATCH 2/2] ipoib: show VF broadcast address

2019-06-15 Thread Denis Kirjanov
On 6/14/19, Doug Ledford wrote: > On Fri, 2019-06-14 at 15:32 +0200, Denis Kirjanov wrote: >> in IPoIB case we can't see a VF broadcast address for but >> can see for PF >> >> Before: >> 11: ib1: mtu 2044 qdisc pfifo_fast >> state UP mode DEFAULT g

Re: [PATCH net-next v2 2/2] ipoib: show VF broadcast address

2019-06-14 Thread Denis Kirjanov
On 6/13/19, Michal Kubecek wrote: > On Thu, Jun 13, 2019 at 04:20:03PM +0200, Denis Kirjanov wrote: >> in IPoIB case we can't see a VF broadcast address for but >> can see for PF >> >> Before: >> 11: ib1: mtu 2044 qdisc pfifo_fast >> state UP mod

[PATCH net-next v3 2/2] ipoib: show VF broadcast address

2019-06-14 Thread Denis Kirjanov
ROADCAST constant v2->v3: put IFLA_VF_BROADCAST at the end to avoid KABI breakage and set NLA_REJECT dev_setlink Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + net/core/rtnetlink.c | 5 + 2 files changed, 10 insertions(+) diff --git a/include/uapi/linux/

[PATCH 1/2] ipoib: correcly show a VF hardware address

2019-06-14 Thread Denis Kirjanov
, query_rss off v1->v2: just copy an address without modifing ifla_vf_mac v2->v3: update the changelog Signed-off-by: Denis Kirjanov --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniba

[PATCH net-next v3 1/2] ipoib: correcly show a VF hardware address

2019-06-14 Thread Denis Kirjanov
, query_rss off v1->v2: just copy an address without modifing ifla_vf_mac v2->v3: update the changelog Signed-off-by: Denis Kirjanov --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniba

[PATCH 2/2] ipoib: show VF broadcast address

2019-06-14 Thread Denis Kirjanov
ROADCAST constant v2->v3: put IFLA_VF_BROADCAST at the end to avoid KABI breakage and set NLA_REJECT dev_setlink Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + net/core/rtnetlink.c | 5 + 2 files changed, 10 insertions(+) diff --git a/include/uapi/linux/

[PATCH net-next v2 2/2] ipoib: show VF broadcast address

2019-06-13 Thread Denis Kirjanov
ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff vf 0 link/infiniband 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off, query_rss off Signed-off-by: Denis Kir

[PATCH 1/2] ipoib: correcly show a VF hardware address

2019-06-13 Thread Denis Kirjanov
:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off, query_rss off v1->v2: just copy an address without modifing ifla_vf_mac Signed-off-by: Denis Kirjanov --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/

[PATCH 2/2] ipoib: show VF broadcast address

2019-06-13 Thread Denis Kirjanov
ROADCAST constant Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 + net/core/rtnetlink.c | 6 ++ 2 files changed, 11 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index 5b225ff63b48..1f36dd3a45d6 100644 --- a/include/ua

  1   2   >