[RFC v2 PATCH 02/11] decnet: Move dn_next into decnet route structure.

2017-10-31 Thread David S. Miller
Signed-off-by: David S. Miller --- include/net/dn_route.h | 1 + include/net/dst.h | 1 - net/decnet/dn_route.c | 34 ++ 3 files changed, 19 insertions(+), 17 deletions(-) diff --git a/include/net/dn_route.h b/include/net/dn_route.h index 55df9939bca2

[RFC v2 PATCH 08/11] xfrm: Move dst->path into struct xfrm_dst

2017-10-31 Thread David S. Miller
or an ipv6 route. This is largely used to make sure that PMTU events propagate down to the correct ipv4 or ipv6 route. When we don't have the top of an IPSEC bundle 'dst->path == dst'. Move it down into xfrm_dst and key off of dst->xfrm. Signed-off-by: David S. Miller -

[RFC v2 PATCH 07/11] ipv6: Move dst->from into struct rt6_info.

2017-10-31 Thread David S. Miller
6 uses this mechanism, and only ipv6 code references it. So it is safe to move it into rt6_info. Signed-off-by: David S. Miller --- include/net/dst.h | 3 +-- include/net/ip6_fib.h | 9 - net/core/dst.c| 1 - net/ipv6/route.c | 34 +-

[RFC v2 PATCH 10/11] xfrm: Stop using dst->next in bundle construction.

2017-10-31 Thread David S. Miller
in this order so that pmtu values lower in the stack of routes can propagate up to the higher ones. Avoid using dst->next by simply maintaining an array of dst pointers as we already do for the xfrm_state objects when building the bundle. Signed-off-by: David S. Miller --- net/xfrm/xfrm_po

[RFC v2 PATCH 09/11] net: Rearrange dst_entry layout to avoid useless padding.

2017-10-31 Thread David S. Miller
items such as the rcu_head and the error code. Signed-off-by: David S. Miller --- include/net/dst.h | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h index e860c3b11322..ffd0d81f861f 100644 --- a/include/net/dst.h

[RFC v2 PATCH 06/11] xfrm: Move child route linkage into xfrm_dst.

2017-10-31 Thread David S. Miller
put() loop have dst->xfrm non-NULL and are therefore xfrm_dst objects. Since we break out of the loop when we find dst->xfrm NULL, we will not try to dereference 'dst' as if it were an xfrm_dst. Signed-off-by: David S. Miller --- include/net/dst.h | 3 +-- include/net/xfr

[RFC v2 PATCH 00/11] net: Significantly shrink the size of routes.

2017-10-31 Thread David S. Miller
ches logically based upon feedback. Fix the strange patch #7. Signed-off-by: David S. Miller

[RFC v2 PATCH 01/11] net: dst->rt_next is unused.

2017-10-31 Thread David S. Miller
Delete it. Signed-off-by: David S. Miller --- include/net/dst.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/dst.h b/include/net/dst.h index 2f53ecc2c296..1551fdeadc7a 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ -100,7 +100,6 @@ struct dst_entry { struct

[RFC v2 PATCH 04/11] net: Create and use new helper xfrm_dst_child().

2017-10-31 Thread David S. Miller
Only IPSEC routes have a non-NULL dst->child pointer. And IPSEC routes are identified by a non-NULL dst->xfrm pointer. Signed-off-by: David S. Miller --- include/net/xfrm.h | 9 + net/core/dst.c | 8 +--- net/ipv4/xfrm4_mode_tunnel.c | 2 +- ne

[RFC v2 PATCH 03/11] ipv6: Move rt6_next from dst_entry into ipv6 route structure.

2017-10-31 Thread David S. Miller
Signed-off-by: David S. Miller --- include/net/dst.h | 1 - include/net/ip6_fib.h | 5 +++-- net/ipv6/ip6_fib.c| 26 +- net/ipv6/route.c | 10 +- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h

[RFC v2 PATCH 05/11] ipsec: Create and use new helpers for dst child access.

2017-10-31 Thread David S. Miller
This will make a future change moving the dst->child pointer less invasive. Signed-off-by: David S. Miller --- include/net/xfrm.h | 5 + net/xfrm/xfrm_policy.c | 47 +++ 2 files changed, 28 insertions(+), 24 deletions(-) diff --git a/incl

[RFC v2 PATCH 11/11] net: Remove dst->next

2017-10-31 Thread David S. Miller
There are no more users. Signed-off-by: David S. Miller --- include/net/dst.h | 4 net/core/dst.c| 1 - 2 files changed, 5 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h index ffd0d81f861f..b0e71091d159 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ -82,10

Re: Netchannel subsystem update.

2006-05-21 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Sat, 20 May 2006 19:52:02 +0400 > While developing first apporoach I've found that input TCP processing > sometimes refers to dst_entry which can only be obtained through the input > routing code. You can find appropriate changes in attached increm

Re: [GIT PATCH] SCTP updates

2006-05-19 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 19 May 2006 15:24:58 -0700 > Please pull the following SCTP updates from >master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git Pulled, thanks a lot Sridhar. - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH] reno sacked_out count fix

2006-05-16 Thread David S. Miller
From: "Angelo P. Castellani" <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 11:24:00 +0200 > Using NewReno, if a sk_buff is timed out and is accounted as lost_out, > it should also be removed from the sacked_out. > > This is necessary because recovery using NewReno fast retransmit could > take up to

Re: [1/1] connector: export cn_already_initialized.

2006-05-16 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Sat, 6 May 2006 12:40:45 +0400 > Some external patches, which can be built both as static build and as > module just check that value, and thus will fail with unresolved symbol > when cn and module are built as modules. > > The right set of operati

Re: Controlling TCP window size

2006-05-16 Thread David S. Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 14:28:23 -0400 > The problem really is that the window_clamp variable is overloaded. > It's used as a kind of cache for rcvbuf -> window conversion, but also > as a user-settable bound in window size. On examination, it looks like >

Re: [2.6 patch] net/802/tr.c: remove an unused export

2006-05-16 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 20:48:43 +0200 > This patch removes the unused EXPORT_SYMBOL(tr_source_route). > > (No, the usage in net/llc/llc_output.c can't be modular.) > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from thi

Re: [PATCH] ipv6: endian fix

2006-05-16 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 22:36:46 +0400 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks Alexey. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [PATCH] ipx: correct return type of ipx_map_frame_type

2006-05-16 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 22:49:40 +0400 > Casting BE16 to int and back may or may not work. Correct, to be sure. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] ipx: correct return type of ipxrtr_delete

2006-05-16 Thread David S. Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Wed, 17 May 2006 00:12:38 +0400 > A single caller passes __u32. Inside function "net" is compared with > __u32 (__be32 really, just wasn't annotated). > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, but I had to fix your changelog,

Re: Setting TCP_NODELAY doesn't disable Nagle's alg. on loopback

2006-05-16 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 09:16:06 -0700 > If it is 2.6.5 that is over 2+ years old. Please try with something > past the Pleistocene era... R O F L! If that doesn't belong in a quotes file, I don't know what does :-) - To unsubscribe from this list: send

Re: [PATCH] Enabling standard compliant behaviour in the Linux TCP implementation

2006-05-16 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 09:24:07 -0700 > Read Linus's comments on standards. We make software for users, not for > academic use. > http://kerneltrap.org/node/5725 > > If we added this then paranoid users would set it. I totally agree, and naming t

Re: [1/1] netchannel subsystem.

2006-05-16 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 10:59:23 +0400 > And what if we use ESP which would place it's hashed sequence number as > port? If it makes you happy put something like: case TCP: case UDP: case SCTP: case DCCP: ...

Re: [1/1] netchannel subsystem.

2006-05-15 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 10:19:09 +0400 > +static int netchannel_convert_skb_ipv4(struct sk_buff *skb, struct > unetchannel *unc) > +{ ... > + switch (unc->proto) { > + case IPPROTO_TCP: ... > + case IPPROTO_UDP: ... Why do

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-05-15 Thread David S. Miller
From: Kelly Daly <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 11:02:29 +1000 > +/* handles default chan buffers that nobody else wants */ > +static int default_netchannel_thread(void *unused) > +{ > + wait_queue_t wait; > + struct netchannel_buftrailer *bp; > + struct sk_buff *skbp; > +

Re: [PATCH] net_sched: potential jiffy wrap bug in dev_watchdog

2006-05-15 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 15 May 2006 16:28:58 -0700 > There is a potential jiffy wraparound bug in the transmit watchdog > that is easily avoided by using time_after(). > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscrib

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-15 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 03:22:21 +0200 > Patrick McHardy wrote: > > 3) Clone the skb and have dev_queue_xmit_nit() consume it. > > > > That should actually be pretty easy. > > On second thought, thats not so great either. netdev_nit > just globally signal

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-05-15 Thread David S. Miller
From: Kelly Daly <[EMAIL PROTECTED]> Date: Tue, 16 May 2006 11:02:29 +1000 > On Friday 05 May 2006 12:48, Kelly Daly wrote: > > done! I will continue with implementation of default netchannel for now. Some context? It's been a week since we were discussing this, so I'd like to know what we're l

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-15 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 15 May 2006 16:41:01 -0700 > kfree_skb(NULL) is legal so the conditional here is unneeded. > > But the increased calls to kfree_skb(NULL) would probably bring the > "unlikely()" hordes descending on kfree_skb, so maybe: And unfortunately as

Re: [RFC] changing value of NETDEV_ALIGN to cacheline size

2006-05-15 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Mon, 15 May 2006 14:39:23 -0700 > How about: How about, just leave it alone? :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-in

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-15 Thread David S. Miller
From: Mark A Smith <[EMAIL PROTECTED]> Date: Mon, 15 May 2006 14:39:06 -0700 > I discovered that in some cases, send(), sendmsg(), and sendto() are not > thread-safe. Although the man page for these functions does not specify > whether these functions are supposed to be thread-safe, my reading of

Re: [RFC] changing value of NETDEV_ALIGN to cacheline size

2006-05-15 Thread David S. Miller
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Mon, 15 May 2006 08:02:58 -0700 > > -#defineNETDEV_ALIGN32 > > +#defineNETDEV_ALIGNL1_CACHE_BYTES > > #defineNETDEV_ALIGN_CONST (NETDEV_ALIGN - 1) > > I don't know about the fixed value of 32, but if this pat

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-15 Thread David S. Miller
From: Ranjit Manomohan <[EMAIL PROTECTED]> Date: Mon, 15 May 2006 14:19:06 -0700 (PDT) > Heres a new version which does a copy instead of the clone to avoid > the double cloning issue. I still very much dislike this patch because it is creating 1 more clone per packet than is actually necessary a

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-14 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 14 May 2006 03:10:34 -0700 > It's a bit sad to be taking a clone of a clone like this. > Avoidable? Besides, clones of clones are illegal, if it's already a clone you must make a copy. - To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH] fix IP-over-ATM and ARP interaction - formatting fixed.

2006-05-12 Thread David S. Miller
From: Simon Kelley <[EMAIL PROTECTED]> Date: Sat, 06 May 2006 18:02:00 +0100 > This patch adds a new function, neigh_table_init_no_netlink() which > does everything the neigh_table_init() does, except add the table to > the netlink all-arp-tables chain. In addition neigh_table_init() has a > check

Re: [PATCH] expose simplified skb_checksum_recalc

2006-05-12 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 11 May 2006 11:28:43 -0700 > Many users of skb_checksum_help() are just using it to recalculate > outbound checksum, so why not expose the interface in a more useful > way. Suggested by Ingo Oeser. > > Signed-off-by: Stephen Hemminger <[EMAIL

Re: [PATCH] ethtool always report port is TP on tg3

2006-05-12 Thread David S. Miller
From: Karsten Keil <[EMAIL PROTECTED]> Date: Fri, 12 May 2006 19:46:23 +0200 > Even with fiber cards ethtool reports that the connected port is TP, > the patch fix this. > > Signed-off-by: Karsten Keil <[EMAIL PROTECTED]> Applied, thanks a lot Karsten. - To unsubscribe from this list: send the l

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-12 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 12 May 2006 10:47:11 +0400 > On Fri, May 12, 2006 at 01:53:44AM +0200, Brice Goglin ([EMAIL PROTECTED]) > wrote: > > > Imho you will want to work directly with pages shortly. > > > > > > > We had thought about doing this, but were a little

Re: [NET_SCHED]: HFSC: fix thinko in hfsc_adjust_levels()

2006-05-11 Thread David S. Miller
This patch looks fine, applied. Thanks a lot Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-11 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 11 May 2006 20:18:15 +0400 > Here is profile result: > 1463625 78.0003 poll_idle > 19171 1.0217 _spin_lock_irqsave > 15887 0.8467 _read_lock > 14712 0.7840 kfree > 13370 0.7125 ip_frag_queue > 11896 0.6340 delay_pmtmr

Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-11 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 11 May 2006 10:40:37 +0400 > > It is absolutely necessary to find ways to get rid of these layering > > costs. "Layering is how you design networking protocols, not how you > > implement them." > > If I provide a patch which will allow to mar

Re: [RFC 0/3] [IPSEC]: Add xfrm_mode support

2006-05-10 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 6 May 2006 21:20:26 +1000 > These patches abstract out the protocol-specific encapsulation parts of > IPsec into what I've termed xfrm_mode objects. This allows us to share > a little bit more code. But more importantly, it allows us to add new > e

Re: possible problem with TSO and ip_queue

2006-05-10 Thread David S. Miller
From: Paul Jakma <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 21:17:33 +0100 (IST) > On Wed, 10 May 2006, David S. Miller wrote: > > > When you have a rule installed that will add MD5, just mark the > > route as not being TSO capable. > > Ah, didn't realis

Re: [PATCH] skb leakage in inet6_csk_xmit

2006-05-10 Thread David S. Miller
From: Alexey Kuznetsov <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 13:02:16 +0400 > inet6_csk_xit does not free skb when routing fails. > > Signed-off-by: Alexey Kuznetsov <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH 0/2] register_netdevice and sysfs changes

2006-05-10 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 10:14:52 -0700 > This is a signed-off version of yesterday's fix, plus the bridge > code no longer needs to be so tricky. I'll apply this stuff, thanks a lot. Although since I have the blocking --> raw notifier fixup in my tree I

Re: possible problem with TSO and ip_queue

2006-05-10 Thread David S. Miller
From: Paul Jakma <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 21:07:31 +0100 (IST) > Is there a better way to deal with TSO besides documenting: > > "disable TSO on all interfaces which /ever/ potentially could be used > to reach TCP-MD5 authenticated BGP peers." > > ? When you have a rule inst

Re: address pingable with interface down

2006-05-10 Thread David S. Miller
From: Jon DeVree <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 15:48:18 -0400 > I've noticed in the past that the address owned by an interface is > still pingable after that interface is brought down. People bring this up all the time and this behavior is intentional. Linux uses a "host based" add

Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-10 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Mon, 8 May 2006 16:24:22 +0400 > I hope he does not take offence at name shortening :) Perhaps you are still not convinced how truly expensive the code path from netif_receive_skb() to the protocol receive processing really is. Van's channels elim

Re: possible problem with TSO and ip_queue

2006-05-10 Thread David S. Miller
From: Chris Caputo <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 18:44:30 + (GMT) > Does this sound like a bug or by design? > > Does it make sense that ip_queue mangled packets be subjected to TSO, > given that the TCP header can be messed with by the user mode code? This is by design. Netfi

Re: [RFC] netdev sysfs failure handling

2006-05-09 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 14:40:49 -0700 > Agreed, especially since rtnl is now a real mutex. The case, that > I was worried about: > rtnl_lock() > spin_lock_irq(&mylock); > x = register_netdevice(); > ... > > Doesn't show up in any curre

Re: [NET] linkwatch: Handle jiffies wrap-around

2006-05-09 Thread David S. Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 18:51:49 +0200 > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Acked-by: Stefan Rompf <[EMAIL PROTECTED]> Applied, thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [

Re: [PATCH 4/4] IrDA: Switching to a workqueue for the SIR work

2006-05-09 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 00:24:10 +0300 > Since sir_kthread.c pretty much duplicates the workqueue functionality, > we'd better switch. > The SIR fsm has been merged into sir_dev.c and thus sir_kthread.c is > deleted. > > Signed-off-by: Christoph Hellwig <[EMAI

Re: [PATCH 3/4] IrDA: smsc-ircc: Minimal hotplug support.

2006-05-09 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 00:23:59 +0300 > Minimal PNP hotplug support for the smsc-ircc2 driver. A modular driver > will be modprobed via hotplug, but still bypasses driver model probing. > > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > Signed-off-by: S

Re: [PATCH 2/4] IrDA: Removing unused EXPORT_SYMBOLs

2006-05-09 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 00:23:44 +0300 > This patch removes the following unused EXPORT_SYMBOL's: > - irias_find_attrib > - irias_new_string_value > - irias_new_octseq_value > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Signed-off-by: Samuel Ortiz <[EMA

Re: [PATCH 1/4] New IrDA maintainer

2006-05-09 Thread David S. Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 00:23:33 +0300 > As agreed with Jean Tourrilhes, I am taking over IrDA > maintainership. > > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH]ip_options_fragment() has no effect on fragmentation

2006-05-09 Thread David S. Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Fri, 05 May 2006 20:36:14 -0400 > I had tested the patch under linux system, maybe this mail is correct. > > Fix error point to options in ip_options_fragment(). optptr get a error > pointer to the ipv4 header, correct is pointer to ipv4 options. > > S

Re: [PATCH] Documentation: add missing operstates.txt

2006-05-09 Thread David S. Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Sun, 7 May 2006 12:18:59 +0200 > seems documentation got lost when the RFC2863-patch was applied. Having > documentation is good, so I resend it ;-) > > Signed-off-by: Stefan Rompf <[EMAIL PROTECTED]> Applied, thanks Stefan. - To unsubscribe from this

Re: [RFC] netdev sysfs failure handling

2006-05-09 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 12:01:07 -0700 > Something like this would handle errors better, but introduce possible > problems for drivers that call register_netdevice with irq's disabled. > There was some comment about racing with linkwatch, but don't see how

Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-08 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Mon, 8 May 2006 23:51:32 +0400 > Since nocopy is actually equal to dma into mapped buffer, > so we get something close to 6 times less CPU usage, and if it can be > lineary transferred into performance gain, we found where the most > significant par

Re: [PATCH] TCP congestion module: add TCP-LP supporting for 2.6.16.14

2006-05-08 Thread David S. Miller
From: "Wong Edison" <[EMAIL PROTECTED]> Date: Tue, 9 May 2006 01:50:36 +0800 > > Or, just include it, and select it with the TCP_CONGESTION socket > > option when you want it. Sorry, this does require app modifications. > > i would like to have more information about this > so within the app > a

Re: [PATCH] netdev: hotplug napi race cleanup

2006-05-08 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 8 May 2006 09:54:58 -0700 > The issue is are there network devices that can't sleep during > register_netdevice? Oh right, I forgot about that. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E

Re: [PATCH] TCP congestion module: add TCP-LP supporting for 2.6.16.14

2006-05-08 Thread David S. Miller
From: Pavel Machek <[EMAIL PROTECTED]> Date: Mon, 8 May 2006 11:29:15 + > Hi! > > > TCP Low Priority is a distributed algorithm whose goal > > is to utilize only > > the excess network bandwidth as compared to the ``fair > > share`` of > > bandwidth as targeted by TCP. Available from: > >

Re: [PATCH] core: linkwatch should use jiffies64

2006-05-07 Thread David S. Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Sun, 7 May 2006 12:13:56 +0200 > the linkwatch code can overflow on a jiffies wrap, scheduling > work with a too large delay. If the delay is >0x8000, > internal_add_timer() seems to overflow too, hiding the bug, so > this isn't triggered too easily

Re: [PATCH]ip_options_fragment() has no effect on fragmentation

2006-05-07 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Fri, 5 May 2006 13:50:02 -0400 > Does this patch will be used? > > This patch resolved the following problem: When I send IPv4 packet(contain > Record Route Option) which need to be fragmented to the router, the router > can not fragment it correctly. After fragme

Re: [PATCH]ip_options_fragment() has no effect on fragmentation

2006-05-07 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Fri, 5 May 2006 13:50:02 -0400 > Does this patch will be used? Your patch is in the tree already. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordo

Re: [PATCH] TCP congestion module: add TCP-LP supporting for 2.6.16.14

2006-05-06 Thread David S. Miller
How many times are you going to post this same patch over and over again? Please don't do that, thank you. We all saw it the first time. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.o

Re: [PATCH] irda-usb: use NULL instead of 0

2006-05-06 Thread David S. Miller
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Mon, 1 May 2006 15:31:34 -0700 > Use NULL instead of 0 for a null pointer value (sparse warning): > drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL > pointer > > Correct timeout argument to use milliseconds instead of jiffi

Re: [PATCH] netdev: hotplug napi race cleanup

2006-05-06 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 24 Apr 2006 15:23:41 -0700 > This follows after the earlier two patches. > > Change the initialization of the class device portion of the net device > to be done earlier, so that any races before registration completes are > harmless. Add a

Re: [RFC] netdev sysfs failure handling

2006-05-06 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 21 Apr 2006 13:42:05 -0700 > In case of sysfs failure, don't let device be brought up. > It can be cleared by unregister_netdevice so module can be unloaded > normally. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I'm not so sure

Re: [PATCH 2/2] netdev: create attribute_groups with class_device_add

2006-05-06 Thread David S. Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Sat, 6 May 2006 15:59:04 -0700 > On Fri, May 05, 2006 at 11:00:50PM -0700, David S. Miller wrote: > > The networking bit by Stephen is a bug fix. > > Good point. Ok, feel free to send both patches to Linus now if you &g

Re: [PATCH 2/2] netdev: create attribute_groups with class_device_add

2006-05-05 Thread David S. Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Fri, 5 May 2006 21:08:39 -0700 > On Fri, May 05, 2006 at 06:41:58PM -0700, David S. Miller wrote: > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Fri, 21 Apr 2006 12:54:38 -0700 > > > > > Atomically cr

Re: [PATCH 2/2] netdev: create attribute_groups with class_device_add

2006-05-05 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 21 Apr 2006 12:54:38 -0700 > Atomically create attributes when class device is added. This avoids the > race between registering class_device (which generates hotplug event), > and the creation of attribute groups. > > Signed-off-by: Stephen

Re: [PATCH] Re: a question on tcp_highspeed.c (in 2.6.16)

2006-05-05 Thread David S. Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Thu, 04 May 2006 15:06:00 -0400 > Xiaoliang (David) Wei wrote: > > Hi gurus, > > > >I am reading the code of tcp_highspeed.c in the kernel and have a > > question on the hstcp_cong_avoid function, specifically the following > > AI part (line 136~14

Re: [RFC PATCH] [IPV6] ADDRCONF: Convert addrconf_lock to RCU.

2006-05-05 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 05 May 2006 12:24:52 +0900 (JST) > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> It is critical that we free the inet6 device structure using an RCU callback in order for this locking strategy to work. An RCU head needs to be added to

Re: VJ Channel API - driver level (PATCH)

2006-05-05 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 5 May 2006 13:36:56 +0400 > Hardware folks could also create it's own implementation and show > community if theirs approach is good or not. Designing hardware for non-existing software infrastructure is risky buisness :-) - To unsubscribe fro

Re: [PATCH 2/3] Eleminate HZ from NET/ROM kernel interfaces

2006-05-05 Thread David S. Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Tue, 2 May 2006 00:52:35 +0100 > On Sun, Apr 30, 2006 at 05:21:36PM -0700, David S. Miller wrote: > > > > With such extensive patches for netrom and rose modules that will go > > > into a future 2.6.x kernel, I think i

Re: [1/1] connector: export cn_already_initialized.

2006-05-05 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 4 May 2006 16:24:22 +0400 > No in-kernel users require it to be exported, so if you do think it > should not be exported I will force external module changes. What are the alternatives? - To unsubscribe from this list: send the line "unsubscri

Re: [DCCP]: Fix sock_orphan dead lock

2006-05-05 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 4 May 2006 17:17:50 +1000 > Anyway, the same issue affects DCCP (and SCTP too probably). Here > is a patch that does the same thing for DCCP. Thanks for catching that, applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] bridge: keep track of received multicast packets

2006-05-05 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 4 May 2006 16:10:19 -0700 > It makes sense to add this simple statistic to keep track of received > multicast packets. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe from this list: send th

Re: [PATCH 4/4] [SCTP]: Fix state table entries for chunks received in CLOSED state.

2006-05-05 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 05 May 2006 12:14:50 -0700 > [SCTP]: Fix state table entries for chunks received in CLOSED state. > > Discard an unexpected chunk in CLOSED state rather can calling BUG(). > > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> Applied, th

Re: [PATCH 3/4] [SCTP]: Fix panic's when receiving fragmented SCTP control chunks.

2006-05-05 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 05 May 2006 12:14:45 -0700 > [SCTP]: Fix panic's when receiving fragmented SCTP control chunks. > > Use pskb_pull() to handle incoming COOKIE_ECHO and HEARTBEAT chunks that > are received as skb's with fragment list. > > Signed-off-by: Sridh

Re: [PATCH 1/4] [SCTP]: Allow spillover of receiver buffer to avoid deadlock

2006-05-05 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 05 May 2006 12:14:28 -0700 > [SCTP]: Allow spillover of receive buffer to avoid deadlock. > > This patch fixes a deadlock situation in the receive path by allowing > temporary spillover of the receive buffer. > > - If the chunk we receive ha

Re: [PATCH 2/4] [SCTP]: Prevent possible infinite recursion with multiple bundled DATA.

2006-05-05 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 05 May 2006 12:14:38 -0700 > [SCTP]: Prevent possible infinite recursion with multiple bundled DATA. > > There is a rare situation that causes lksctp to go into infinite recursion > and crash the system. The trigger is a packet that contains

Re: latest -stable breaks Squid

2006-05-04 Thread David S. Miller
From: "Ian McDonald" <[EMAIL PROTECTED]> Date: Thu, 4 May 2006 13:59:04 +1200 > Wouldn't it be more likely commit 5d0b6f2bdaf7e016e750cd24164a241512d968a3 > > as this touches net/ipv4/tcp_output.c and is also in same general area? This commit makes us account transmit memory properly. Previousl

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-05-04 Thread David S. Miller
From: Kelly Daly <[EMAIL PROTECTED]> Date: Thu, 4 May 2006 12:59:23 +1000 > We DID write an infrastructure to resolve this issue, although it is more > complex than the dynamic descriptor scheme for userspace. And we want to > keep this simple - right? Yes. I wonder if it is possible to manag

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-05-04 Thread David S. Miller
From: Kelly Daly <[EMAIL PROTECTED]> Date: Thu, 4 May 2006 17:28:27 +1000 > On Wednesday 26 April 2006 17:59, David S. Miller wrote: > > Next, you can't even begin to work on the protocol channels before you > > do one very important piece of work. Integration of al

Re: VJ Channel API - driver level (PATCH)

2006-05-04 Thread David S. Miller
From: Alex Aizman <[EMAIL PROTECTED]> Date: Thu, 04 May 2006 15:49:11 -0700 > So, what are the requirements? I will say it a 10th time, "we simply don't know yet." Please be patient and let us design the net channel infrastructure properly, then we can think clearly about how hardware might supp

Re: [PATCH] DECnet: Fix level1 router hello

2006-05-03 Thread David S. Miller
From: Patrick Caulfield <[EMAIL PROTECTED]> Date: Thu, 27 Apr 2006 13:37:23 +0100 > This patch fixes hello messages sent when a node is a level 1 router. Slightly > contrary to the spec (maybe) VMS ignores hello messages that do not name > level2 routers that it also knows about. > > So, here we

Re: [TCP]: Fix sock_orphan dead lock

2006-05-03 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 23:13:20 +1000 > On Sat, Apr 29, 2006 at 09:15:07PM +1000, herbert wrote: > > > > Unfortunately this is only true for TCP. All of the connectionless > > protocols use the callback lock without the socket lock so it does > > still serve

Re: [PATCH 2/3] Eleminate HZ from NET/ROM kernel interfaces

2006-05-03 Thread David S. Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 15:16:13 +0100 > Convert all NET/ROM sysctl time values from jiffies to ms as units. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

Re: [PATCH 3/3] Eleminate HZ from ROSE kernel interfaces

2006-05-03 Thread David S. Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 15:19:24 +0100 > Convert all ROSE sysctl time values from jiffies to ms as units. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [PATCH 1/3] Eleminate HZ from AX.25 kernel interfaces

2006-05-03 Thread David S. Miller
From: Ralf Baechle DL5RB <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 15:12:44 +0100 > Convert all AX.25 sysctl time values from jiffies to ms as units. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [ROSE] Fix routing table locking in rose_remove_neigh.

2006-05-03 Thread David S. Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 14:31:41 +0100 > The locking rule for rose_remove_neigh() are that the called needs to > hold rose_neigh_list_lock, so we better don't take it yet again in > rose_neigh_list_lock. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Ap

Re: [AX.25] Move AX.25 symbol exports

2006-05-03 Thread David S. Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 14:40:23 +0100 > Move AX.25 symbol exports to next to their definitions where they're > supposed to be these days. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscrib

Re: [HAMRADIO] Remove remaining SET_MODULE_OWNER calls from hamradio drivers.

2006-05-03 Thread David S. Miller
From: Ralf Baechle DL5RB <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 15:34:13 +0100 > Signed-off-by: Ralf Baechle DL5RB <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger

Re: [AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

2006-05-03 Thread David S. Miller
From: Ralf Baechle DL5RB <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 15:29:43 +0100 > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [AX.25] Spelling fix

2006-05-03 Thread David S. Miller
From: Ralf Baechle DL5RB <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 15:24:27 +0100 > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kerne

Re: [ROSE] Remove useless prototype for rose_remove_neigh().

2006-05-03 Thread David S. Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Sat, 29 Apr 2006 14:25:53 +0100 > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: VJ Channel API - driver level (PATCH)

2006-05-03 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Wed, 3 May 2006 22:07:40 +0400 > On Wed, May 03, 2006 at 08:56:23AM -0700, Caitlin Bestler ([EMAIL PROTECTED]) > wrote: > > > I'd expect high end NIC ASICs to implement rx steering based > > > upon some sort of hash (for load balancing), as well as

  1   2   3   4   5   6   7   8   9   10   >