From: John Heffner <[EMAIL PROTECTED]>
Date: Thu, 04 May 2006 15:06:00 -0400
> Xiaoliang (David) Wei wrote:
> > Hi gurus,
> >
> > I am reading the code of tcp_highspeed.c in the kernel and have a
> > question on the hstcp_cong_avoid function, specifically the following
> > AI part (line 136~143 in net/ipv4/tcp_highspeed.c ):
> >
> > /* Do additive increase */
> > if (tp->snd_cwnd < tp->snd_cwnd_clamp) {
> > tp->snd_cwnd_cnt += ca->ai;
> > if (tp->snd_cwnd_cnt >= tp->snd_cwnd) {
> > tp->snd_cwnd++;
> > tp->snd_cwnd_cnt -= tp->snd_cwnd;
> > }
> > }
> >
> > In this part, when (tp->snd_cwnd_cnt == tp->snd_cwnd),
> > snd_cwnd_cnt will be -1... snd_cwnd_cnt is defined as u16, will this
> > small chance of getting -1 becomes a problem?
> > Shall we change it by reversing the order of the cwnd++ and cwnd_cnt -=
> > cwnd?
>
> Absolutely correct. Thanks.
>
> Signed-off-by: John Heffner <[EMAIL PROTECTED]>
Applied, thanks a lot everyone.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
