d80211: inhibit duplicate authentication requests when setting bssid

2006-12-21 Thread David Kimdon
If we are already authenticating don't send another authentication request. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_sta.c === --- wireless-dev.orig/net/d80211/ieee

d80211: clear ifsta->associated flag when authentication starts

2006-12-21 Thread David Kimdon
The 'associated' flag might be set if a previous association did not end cleanly. If the 'associated' flag is left set here then when association succeeds ieee80211_set_associated() will think there is nothing to report and will not inform userspace of the event. Signed-

Re: [PATCH] d80211: add radiotap support

2006-12-18 Thread David Kimdon
On Sat, Dec 16, 2006 at 06:01:03PM -0500, Michael Wu wrote: > skb->mac.raw = skb->data; > skb->ip_summed = CHECKSUM_UNNECESSARY; > skb->pkt_type = PACKET_OTHERHOST; > - skb->protocol = htons(ETH_P_802_2); > + skb->protocol = __constant_htons(ETH_P_802_2); > memset(sk

Re: [patch 7/7] d80211: do not pass an invalid key index to set_key()

2006-12-07 Thread David Kimdon
> Use HW_KEY_IDX_INVALID, please. oops, here you go (also fixed bad indentation): -- d80211: do not pass an invalid key index to set_key() If a hardware key has not been configured then there is no point to calling DISABLE_KEY. Signed-off-by: David Kimdon <[EMAIL PROTECTED]&g

[patch 6/7] d80211: fix invalid check for sub interface type AP

2006-12-06 Thread David Kimdon
We should be checking the type member, not the raw pointer. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_ioctl.c === --- wireless-dev.orig/net/d80211/ieee80211_ioctl.c +++ wireless-d

[patch 2/7] d80211: set default_wep_only dynamically

2006-12-06 Thread David Kimdon
Without this change d80211 relies on userspace to let it know when it can configure default wep keys. It is always safe to set default_wep_only if there is a single station interface. This allows for hardware accelleration for the case of a single station interface. Signed-off-by: David Kimdon

[patch 3/7] d80211: fix potential interface name overflow

2006-12-06 Thread David Kimdon
dev->name and ndev->name are both IFNAMSIZ in length, the ".%d" is not guarenteed to fit in ndev->name. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_iface.c ===

[patch 4/7] d80211: fix potential invalid array index returning key information

2006-12-06 Thread David Kimdon
sdata->keys[] has NUM_DEFAULT_KEYS elements, don't access past that. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_ioctl.c === --- wireless-dev.orig/net/d80211/iee

[patch 7/7] d80211: do not pass an invalid key index to set_key()

2006-12-06 Thread David Kimdon
If a hardware key has not been configured then there is no point to calling DISABLE_KEY. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_ioctl.c === --- wireless-dev.orig/net/

[patch 5/7] d80211: remove unused references to sub interface data

2006-12-06 Thread David Kimdon
In these three cases the pointer returned by IEEE80211_DEV_TO_SUB_IF() is never used. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee8

[patch 1/7] d80211: allow for hardware crypto of default keys

2006-12-06 Thread David Kimdon
Remove incorrect prohibition of hardware crypto support. This was originally present to prevent hardware crypto when more than one station interface was created for a single hardware device, the code in question is no longer correct and should be removed. Signed-off-by: David Kimdon <[EM

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread David Kimdon
On Wed, Nov 29, 2006 at 04:38:56PM +0100, Michael Buesch wrote: > On Wednesday 29 November 2006 16:24, David Kimdon wrote: > > On Wed, Nov 29, 2006 at 04:12:33PM +0100, Michael Buesch wrote: > > > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > Why do you

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread David Kimdon
On Wed, Nov 29, 2006 at 10:21:09AM -0500, Dan Williams wrote: > On Wed, 2006-11-29 at 16:12 +0100, Michael Buesch wrote: > > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > > Good luck then ;-) > > > > > > If anyone wants to help on making ar5k work with newer madwifi > > > version

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-11-29 Thread David Kimdon
On Wed, Nov 29, 2006 at 04:12:33PM +0100, Michael Buesch wrote: > On Wednesday 29 November 2006 15:34, Nick Kossifidis wrote: > > Good luck then ;-) > > > > If anyone wants to help on making ar5k work with newer madwifi > > versions and fix bugs etc (that 'll also help bsd ppl) plzz mail me. > > W

Re: [PATCH] d80211: fix scan issues with new ops

2006-11-19 Thread David Kimdon
On Sun, Nov 19, 2006 at 05:57:39PM +0100, Johannes Berg wrote: > On Sun, 2006-11-19 at 08:55 -0800, David Kimdon wrote: > > > ok. I am concerned that making this split between per driver and per > > card is difficult to get right. Setting or not setting a function > >

Re: [PATCH] d80211: fix scan issues with new ops

2006-11-19 Thread David Kimdon
On Sun, Nov 19, 2006 at 05:34:49PM +0100, Johannes Berg wrote: > On Sun, 2006-11-19 at 07:56 -0800, David Kimdon wrote: > > > What is wrong with the driver setting the function pointer to NULL for > > the cards that do not support scanning? Where does this requirment >

Re: [PATCH 4/10] d80211: reduce mdev usage, fix ieee80211_rx_mgmt

2006-11-19 Thread David Kimdon
Reply-To: In-Reply-To: <[EMAIL PROTECTED]> > > --- wireless-dev.orig/net/d80211/ieee80211.c 2006-11-17 20:01:54.999703408 > +0100 > +++ wireless-dev/net/d80211/ieee80211.c 2006-11-17 20:01:55.659703408 > +0100 > @@ -210,9 +210,16 @@ static void ieee80211_key_threshold_noti >

Re: [PATCH] d80211: fix scan issues with new ops

2006-11-19 Thread David Kimdon
On Sun, Nov 19, 2006 at 01:21:13AM +0100, Johannes Berg wrote: > If hardware shall do scanning, the hw_scan operation must be set. However, > if the driver is for multiple cards that may or may not do hardware > scanning, it'll need a flag. What is wrong with the driver setting the function pointe

d80211: RFC: divide by zero when hw->maxssi not set

2006-11-17 Thread David Kimdon
Hi, commit 448bf25bc9e3d70a211fdf235426472089371c43 added ieee80211_get_wireless_stats in net/d80211/ieee80211_ioctl.c. At present we get a divide by zero (oops) if the low level driver does not set the new hw->maxssi field. Perhaps: - reject registration of devices which do not set maxssi - do

[patch] d80211: Remove unused ENABLE_COMPRESSION, DISABLE_COMPRESSION cmds to hw->set_key

2006-11-16 Thread David Kimdon
These two commands are currently unused. They were previously used to enable hardware compression on Atheros hardware. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h === --- wi

Re: [Madwifi-devel] ANNOUNCE: SFLC helps developers assessar5k (enabling free Atheros HAL)

2006-11-15 Thread David Kimdon
On Wed, Nov 15, 2006 at 02:39:01PM -0500, Pavel Roskin wrote: > On Wed, 2006-11-15 at 14:21 -0500, John W. Linville wrote: > > On Wed, Nov 15, 2006 at 07:42:14PM +0100, Michael Buesch wrote: > > I said it before, and it's worth repeating. Dissolving HAL in the > sources is easy. It's just a matt

[patch] d80211: fix usage of capability field for ibss mode

2006-11-12 Thread David Kimdon
Thanks to sparse for pointing out these errors. 'capability' is stored in struct ieee80211_sta_bss in host byte order, do not swap bytes. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211

[patch] d80211: endian annotations for ieee80211_frame_info, etc.

2006-11-12 Thread David Kimdon
Thanks to sparse for pointing out these missing endian annotations. All the fields in the AVS capture header (struct ieee80211_frame_info) are in network byte order. The length in the ethernet header is in network byte order. last_seq_ctrl is stored little endian. Signed-off-by: David Kimdon

[take4 3/5] d80211: remove bitfields from ieee80211_key_conf

2006-11-12 Thread David Kimdon
All three one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_KEY_* definitions. The 8 bit keyidx bitfield is converted to type s8. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43x

[take4 2/5] d80211: remove bitfields from ieee80211_tx_status

2006-11-12 Thread David Kimdon
Both one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TX_STATUS_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[take4 0/5] d80211: remove bitfields from include/net/d80211.h

2006-11-12 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. I converted the 1 bit bitfields into a bit in a u32 flags structure member. Larger bitfields I converted into their u8/

[take4 5/5] d80211: remove bitfields from ieee80211_conf

2006-11-12 Thread David Kimdon
All four one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_CONF_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h

[take4 4/5] d80211: remove bitfields from ieee80211_hw

2006-11-12 Thread David Kimdon
All twelve one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_HW_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/a

[take4 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-11-12 Thread David Kimdon
All one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TXCTL_* definitions. The multiple bit members were converted to u8, s8 or u16 as appropriate. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-11-08 Thread David Kimdon
On Thu, Nov 02, 2006 at 10:30:56PM -0500, John W. Linville wrote: > David, may I presume there will be a "take4"? yes, refreshing is in progress. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

Re: [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set

2006-11-08 Thread David Kimdon
sch_fifo.c instead. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/sched/Kconfig === --- wireless-dev.orig/net/sched/Kconfig +++ wireless-dev/net/sched/Kconfig @@ -6,6 +6,7 @@ menu "QoS and/or fa

[patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set

2006-10-31 Thread David Kimdon
for WME. At present it uses net/d80211/fifo_qdisc.c which is functionally equivalent to sch_fifo.c. This patch will allow the d80211 stack to remove net/d80211/fifo_qdisc.c and use sch_fifo.c instead. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net

[take1] d80211: switch crypto to use new ciphers API

2006-10-30 Thread David Kimdon
new cipher API. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/wep.c === --- wireless-dev.orig/net/d80211/wep.c +++ wireless-dev/net/d80211/wep.c @@ -14,6 +14,7 @@ #include #include

[RFC] d80211: switch crypto to use block ciphers

2006-10-25 Thread David Kimdon
itch d80211 software crypto to use the block cipher API. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/wep.c === --- wireless-dev.orig/net/d80211/wep.c +++ wireless-dev/net/d80211/wep.c @@ -26,7 +26,8

[patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc

2006-10-25 Thread David Kimdon
wme.c needs a generic fifo qdisc for each hardware queue. Switch wme.c to use the generic fifo qdisc in net/sched/sch_fifo.c. This allows removal of net/d80211/fifo_qdisc.c which isn't particularily tied to IEEE 802.11 in any way. Signed-off-by: David Kimdon <[EMAIL PROTECTED]

Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-25 Thread David Kimdon
On Wed, Oct 25, 2006 at 03:01:29PM -0400, Jeff Garzik wrote: > On Wed, Oct 25, 2006 at 11:42:44AM -0700, David Kimdon wrote: > > Continue d80211 bitfield removal. In general, compilers have > > difficulty generating efficient code for bitfields. This patchset > > remov

[take3 2/5] d80211: remove bitfields from ieee80211_tx_status

2006-10-25 Thread David Kimdon
Both one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TX_STATUS_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[take3 4/5] d80211: remove bitfields from ieee80211_hw

2006-10-25 Thread David Kimdon
All twelve one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_HW_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/a

[take3 5/5] d80211: remove bitfields from ieee80211_conf

2006-10-25 Thread David Kimdon
All four one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_CONF_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h

[take3 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-25 Thread David Kimdon
All one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TXCTL_* definitions. The multiple bit members were converted to u8, s8 or u16 as appropriate. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-25 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags structure member. Larger bitfields I converted into

[take3 3/5] d80211: remove bitfields from ieee80211_key_conf

2006-10-25 Thread David Kimdon
All three one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_KEY_* definitions. The 8 bit keyidx bitfield is converted to type s8. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43x

d80211: remove unused variable in ieee80211_rx_irqsafe

2006-10-25 Thread David Kimdon
tmp is unused. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee80211.c +++ wireless-dev/net/d80211/ieee80211.c @@ -3843,7 +3843,7 @

Re: [RFC] [PATCH 0/3] Add Regulatory Domain support to d80211

2006-10-24 Thread David Kimdon
Hi, > The following patches extend 802.11 regulatory domain support of the > d80211 wireless stack through two modules: > > 1. ieee80211_regdomains > 2. iso3166-1 I am glad to see this work, this is something that we need a solution for. I do wonder if we can push most of this out of the kernel

Re: [RFC] [PATCH 3/3] Kconfig update for regulatory domain

2006-10-23 Thread David Kimdon
This last chunk is broken: . . . Hunk #2 FAILED at 90. > --- wireless-dev-old/net/d80211/Kconfig 2006-10-23 13:56:11.0 > -0400 > +++ wireless-dev/net/d80211/Kconfig 2006-10-23 17:04:12.0 -0400 > @@ -16,8 +90,6 @@ config D80211_LEDS > This option enables a few LED tr

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-10-23 Thread David Kimdon
On Mon, Oct 23, 2006 at 02:40:28PM +0200, Jiri Benc wrote: > On Fri, 20 Oct 2006 17:19:36 +0800, Hong Liu wrote: > > --- a/include/net/d80211.h > > +++ b/include/net/d80211.h > > @@ -176,6 +176,7 @@ struct ieee80211_tx_control { > > */ > > int icv_len:8; /* Length of the ICV

[patch] d80211: fix kernel doc for ieee80211_get_buffered_bc

2006-10-18 Thread David Kimdon
ieee80211_beacon_get() was already described. The doc entry in question describes ieee80211_get_buffered_bc(). Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h === --- wireless-de

[take2 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-18 Thread David Kimdon
All one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TXCTL_* definitions. The multiple bit members were converted to u8, s8 or u16 as appropriate. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[take2 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-18 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags structure member. Larger bitfields I converted into

[take2 2/5] d80211: remove bitfields from ieee80211_tx_status

2006-10-18 Thread David Kimdon
Both one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TX_STATUS_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[take2 3/5] d80211: remove bitfields from ieee80211_key_conf

2006-10-18 Thread David Kimdon
All three one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_KEY_* definitions. The 8 bit keyidx bitfield is converted to type s8. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43x

[take2 5/5] d80211: remove bitfields from ieee80211_conf

2006-10-18 Thread David Kimdon
All four one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_CONF_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h

[take2 4/5] d80211: remove bitfields from ieee80211_hw

2006-10-18 Thread David Kimdon
All twelve one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_HW_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/a

Re: [take1 0/5] d80211 patches

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 07:23:14PM +0200, Ivo van Doorn wrote: > On Wednesday 18 October 2006 19:20, David Kimdon wrote: > > On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: > > > On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: > > > > Continu

Re: [take1 0/5] d80211 patches

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote: > On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote: > > Continue d80211 bitfield removal. In general, compilers have > > difficulty generating efficient code for bitfields. This patchset > > removes all bitfi

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-18 Thread David Kimdon
On Wed, Oct 18, 2006 at 03:56:07PM +0200, Jiri Benc wrote: > On Mon, 9 Oct 2006 13:11:02 -0700, David Kimdon wrote: > > --- wireless-dev.orig/net/d80211/ieee80211_sta.c > > +++ wireless-dev/net/d80211/ieee80211_sta.c > > @@ -930,8 +930,8 @@ static void ieee802

d80211: ANNOUNCE: DadWifi, a port of MadWifi to d80211

2006-10-17 Thread David Kimdon
Hi, DadWifi is a port of MadWifi to the d80211 stack. It works now in managed and monitor mode, lightly tested. Any card supported by MadWifi should be supported by DadWifi [1]. This allows a large number of cards to now take advantage of the d80211 stack. DadWifi uses the same (binary only) h

Re: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-17 Thread David Kimdon
I am not particularily attached to bitfields or no bitfields. I am interested in getting d80211 merged. Bitfields have been discussed as an important TODO. Perhaps this can serve as a starting point for discussion of the tasks to complete before d80211 is merged? On Mon, Oct 16, 2006 at 12:34:

[take1 3/5] d80211: remove bitfields from ieee80211_key_conf

2006-10-17 Thread David Kimdon
All three one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_KEY_* definitions. The 8 bit keyidx bitfield is converted to type s8. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43x

[take1 4/5] d80211: remove bitfields from ieee80211_hw

2006-10-17 Thread David Kimdon
All twelve one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_HW_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/a

[take1 2/5] d80211: remove bitfields from ieee80211_tx_status

2006-10-17 Thread David Kimdon
Both one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TX_STATUS_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[take1 5/5] d80211: remove bitfields from ieee80211_conf

2006-10-17 Thread David Kimdon
All four one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_CONF_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h

Re: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-17 Thread David Kimdon
On Mon, Oct 16, 2006 at 06:07:25PM +0200, Michael Buesch wrote: > On Friday 13 October 2006 21:20, David Kimdon wrote: > > All one-bit bitfields have been subsumed into the new 'flags' > > structure member and the new IEEE80211_TXCTL_* definitions. The > > multipl

[take1 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-17 Thread David Kimdon
All one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TXCTL_* definitions. The multiple bit members were converted to u8, s8 or u16 as appropriate. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[take1 0/5] d80211 patches

2006-10-17 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags structure member. Larger bitfields I converted into

Re: [PATCH] d80211: remove unused Super AG definitions, purgecomment

2006-10-17 Thread David Kimdon
On Tue, Oct 17, 2006 at 08:59:13AM +0200, Johannes Berg wrote: > On Mon, 2006-10-16 at 11:39 -0700, David Kimdon wrote: > You want to adjust that last constant there too, I guess. Indeed, updated patch inline. > Why is it an > enum anyway if things are assigned statically? I don&#

[PATCH] d80211: remove unused Super AG definitions, purge comment

2006-10-16 Thread David Kimdon
Remove unused Super AG structure members, enums. In struct ieee80211_tx_status the queue_length and queue_number could be useful outside the context of Super AG, so remove the comment and leave the members. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d8

[patch] d80211: remove initialization of unused xr structure members

2006-10-13 Thread David Kimdon
The structure member xr_end was removed from d80211.h. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2400pci.c === --- wireless-dev.orig/drivers/net/wireless/d80211/

[patch 5/5] d80211: remove bitfields from ieee80211_conf

2006-10-13 Thread David Kimdon
All four one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_CONF_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h

[patch 0/5] d80211.h bitfield removal

2006-10-13 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h (except for the xr and Super A/G fields which are completely removed by previous patches). I converted the 1 bit bitfield

[patch 2/5] d80211: remove bitfields from ieee80211_tx_status

2006-10-13 Thread David Kimdon
Both one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TX_STATUS_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

[patch 4/5] d80211: remove bitfields from ieee80211_hw

2006-10-13 Thread David Kimdon
All twelve one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_HW_* definitions. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/a

[patch 3/5] d80211: remove bitfields from ieee80211_key_conf

2006-10-13 Thread David Kimdon
All three one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_KEY_* definitions. The 8 bit keyidx bitfield is converted to type s8. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43x

[patch 1/5] d80211: remove bitfields from ieee80211_tx_control

2006-10-13 Thread David Kimdon
All one-bit bitfields have been subsumed into the new 'flags' structure member and the new IEEE80211_TXCTL_* definitions. The multiple bit members were converted to u8, s8 or u16 as appropriate. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/incl

Re: [PATCH] d80211: extend extra_hdr_room to be a bytecount

2006-10-11 Thread David Kimdon
Perhaps rename it to extra_tx_headroom? - existing users would then need to take notice of the change - the name 'extra_tx_headroom' is more descriptive of what it actually is -David On Wed, Oct 11, 2006 at 11:58:28AM +0200, Michael Buesch wrote: > Extend ieee80211_hw's extra_hdr_room to be a b

Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-10 Thread David Kimdon
On Tue, Oct 10, 2006 at 11:04:05PM +0200, Michael Buesch wrote: > On Tuesday 10 October 2006 15:45, David Kimdon wrote: > > On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote: > > > On Monday 09 October 2006 19:03, David Kimdon wrote: > > > > This flag is

Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-10 Thread David Kimdon
On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote: > On Monday 09 October 2006 19:03, David Kimdon wrote: > > This flag is unused by all in tree drivers. Furthermore, the way that > > it is documented is not consistent with the way it is actually used by > &

Re: [patch 5/5] d80211: allow wireless vlan interface to havesameMAC an AP interface

2006-10-10 Thread David Kimdon
On Tue, Oct 10, 2006 at 12:50:27PM +0200, Johannes Berg wrote: > On Mon, 2006-10-09 at 14:38 -0700, Jouni Malinen wrote: > > > Yes, I just merged in support for this (dynamic VLANs) into hostapd. > > RADIUS Access-Accept is used select VLAN is being used and the STA is > > bound at that point to a

Re: [patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-09 Thread David Kimdon
This switches algs[] to be obviously a constant array, and derives the value of num_algs algs[]. The code is correct and equivalent with or without this change. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d

Re: cfg80211 take 7

2006-10-09 Thread David Kimdon
FYI, all three patches mentioned as possibly required by the nl80211 patchset in the header of nl80211.patch are already in wireless-dev: http://marc.theaimsgroup.com/?l=linux-netdev&m=115625436628696&w=2 (Introduces NLA_NUL_STRING) http://marc.theaimsgroup.com/?l=linux-netdev&m=115625168405439

[patch 3/3] d80211: silence sparse warning: bad constant expression

2006-10-09 Thread David Kimdon
with or without this change. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_sta.c === --- wireless-dev.orig/net/d80211/ieee80211_sta.c +++ wireless-dev/net/d80211/ieee80211_sta.c @@ -9

[patch 1/3] d80211: use FCS_LEN instead of hardcoded number.

2006-10-09 Thread David Kimdon
Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee80211.c +++ wireless-dev/net/d80211/ieee80211.c @@ -451,7 +451,7 @@ ieee80211_tx_h_fragment(

[patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag

2006-10-09 Thread David Kimdon
header (example: Atheros). Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h === --- wireless-dev.orig/include/net/d80211.h +++ wireless-dev/include/net/d80211.h @@ -476,10 +476,6 @@

[patch 1/5] d80211: Fix overflow when creating AVS header

2006-10-03 Thread David Kimdon
frame is received. (from http://www.locustworld.com/tracker/getfile/prism2drivers/doc/capturefrm.txt) it is a u64. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-de

[patch 2/5] d80211: remove unused xr structure members, interface, etc.

2006-10-03 Thread David Kimdon
From: Elliot Schwartz <[EMAIL PROTECTED]> This is all unused. Signed-off-by: Elliot Schwartz <[EMAIL PROTECTED]> Index: wireless-dev/include/net/d80211.h === --- wireless-dev.orig/include/net/d80211.h +++ wireless-dev/include/net/

[patch 5/5] d80211: allow wireless vlan interface to have same MAC an AP interface

2006-10-03 Thread David Kimdon
Wireless vlan interfaces need to have the same mac address as AP interfaces. The STA must not see the change when it is bound to a specific vlan, so the address of the vlan interface must be the same as the address of the AP interface the station associated with. Signed-off-by: David Kimdon

[patch 3/5] d80211: remove rate limit code

2006-10-03 Thread David Kimdon
From: Elliot Schwartz <[EMAIL PROTECTED]> Remove unused and more or less pointless rate limiting code. This would have just dropped multicast frames arbitrarily when the limit is reached which is quite useless and does not really belong to 802.11 code. Signed-off-by: Elliot Schwartz <[EMAIL PROTE

[patch 4/5] d80211: retain PS frames for at least STA listen interval

2006-10-03 Thread David Kimdon
From: Jouni Malinen <[EMAIL PROTECTED]> Start using 2 * listen_int * beacon_int as a timeout for PS buffered unicast frames if that is longer than 10 seconds. Previously, we used fixed 10 second limit regardless of the listen interval. This fixes power saving for STAs that request very long liste

Re: [patch] d80211: remove sub-interface mac address policy

2006-09-21 Thread David Kimdon
On Thu, Sep 21, 2006 at 08:09:39PM +0200, Jiri Benc wrote: > On Thu, 14 Sep 2006 07:33:21 -0700, David Kimdon wrote: > > Wireless vlan interfaces need to have the same mac address as > > other sub interfaces. Rather than complicate the kernel here by > > adding yet another

[patch] d80211: allow vlan interfaces to receive ToDS frames

2006-09-14 Thread David Kimdon
receive ToDS frames. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee80211.c +++ wireless-dev/net/d80211/ieee80211.c @@ -2353,7 +

[patch] d80211: remove sub-interface mac address policy

2006-09-14 Thread David Kimdon
here. It is difficult to get it right in all cases and does not belong in the kernel. It is better to leave this to be implemented as a userspace policy. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: linux-2.6.16/net/d80211/ieee8

[patch] d80211: fix WEP on big endian cpus

2006-09-10 Thread David Kimdon
The ICV is transmitted on the network as a 4 byte little endian quantity. WEP encryption needs to swap the bytes before transmission and decryption needs to swap bytes before ICV verification. Index: wireless-dev/net/d80211/wep.c ==

[patch] Fix type of prism2_hostapd_param crypt.alg

2006-09-07 Thread David Kimdon
crypt.alg is a string, use the correct type. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/hostapd_ioctl.h === --- wireless-dev.orig/net/d80211/hostapd_ioctl.h +++ wireless-dev/net/

[patch] d80211: fix multiple device ap support

2006-09-05 Thread David Kimdon
Another fix to the interpretation of dev_alloc_name() return value. dev_alloc_name() returns the number of the unit assigned or a negative errno code. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: linux-2.6.16/net/d80211/ieee80211_i

[patch] d80211: fix crash in ieee80211_rx_michael_mic_report()

2006-08-25 Thread David Kimdon
This fixes a crash at ieee80211.c line 3461, ieee80211_rx_michael_mic_report() (rx->sdata->type == IEEE80211_IF_TYPE_AP). rx.sdata needs to be set before calling ieee80211_rx_michael_mic_report(). Signed-off-by: Elliot Schwartz <[EMAIL PROTECTED]> Signed-off-by: David Kimdon <[

[patch 4/5] d80211/bcm43xx: fix build for ARM

2006-08-22 Thread David Kimdon
ARM targets support udelay(N) where N <= 2000. Use mdelay() when N >= 2000. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_power.c === --- wireless-dev.

[patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-22 Thread David Kimdon
This ioctl is used when radar is delected on a channel. Data frames must stop but management frames must be allowed to continue for some time to communicate the channel switch to stations. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: linux-2.6.16/net/d80211/hostapd_i

[patch 1/5] d80211: allow for large scan results

2006-08-22 Thread David Kimdon
Fix a problem where incomplete scan results could be returned if the environment includes a large number of devices. Do not truncate the scan results and allow a result to contain more than IW_SCAN_MAX_DATA bytes. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/

[patch 0/5] d80211 patches

2006-08-22 Thread David Kimdon
Hi, Here are some patches for d80211. Thanks, David -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 3/5] d80211: fix interface removal

2006-08-22 Thread David Kimdon
Calls to ieee80211_if_remove() should use the ieee80211 interface types. Convert interface type from hostapd to ieee80211 format. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_i

  1   2   >