Andrew
On 11/19/20 7:49 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+ int ret = 0;
+
+ if (phy_interface_is_rgmii(phydev)) {
+ if (dp83td510->rgmii_delay) {
+
Andrew
On 11/17/20 2:31 PM, Andrew Lunn wrote:
On Tue, Nov 17, 2020 at 02:15:53PM -0600, Dan Murphy wrote:
Per the 802.3cg spec the 10base T1L can operate at 2 different
differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
ability
Ack
drive that output is dependent on the
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 64 +++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
diff --git a/Documentation
to auto negotiation to
determine the proper p2p voltage.
Signed-off-by: Dan Murphy
---
v4 - Considerable rework of the code after secondary test setup was created.
This version also uses the handle_interrupt call back and reduces the
configuration arrays as it was determined that 80% of the
a top level ethernet document.
Signed-off-by: Dan Murphy
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
PHYAD: 1
Transceiver: external
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Signed-off-by: Dan Murphy
x27;s
capability.
Dan
Dan Murphy (4):
ethtool: Add 10base-T1L link mode entries
dt-bindings: net: Add Rx/Tx output configuration for 10base T1L
dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
.../devicetree/binding
Marc
On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc:
fixes this problem by changing the case to CAN_STATE_ERROR_WARNING.
Signed-off-by: Wu Bo
Link: http://lore.kernel.org/r/20200129022330.21248-2-wubo.o...@gmail.com
Cc: Dan Murphy
Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
Signed-off-by: Marc Kleine-Budde
---
d
Marc
On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
This patch adds the missing error checking when initializing the regmap
interface fails.
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy
Link: http://lore.kernel.org/r/20201019154233
Andrew
On 11/3/20 11:18 AM, Andrew Lunn wrote:
On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote:
Andrew
On 10/30/20 3:15 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+
Andrew
On 11/3/20 11:21 AM, Andrew Lunn wrote:
On Tue, Nov 03, 2020 at 11:09:44AM -0600, Dan Murphy wrote:
Hello
On 10/30/20 6:03 PM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that
Hello
On 10/30/20 6:03 PM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that supports 10M single pair cable.
The device supports both 2.4-V p2p and 1-V p2p output voltage as defined
by IEEE
Andrew
On 10/30/20 3:15 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+ int mst_slave_cfg;
+ int ret = 0;
+
+ if (phy_interface_is_rgmii(phydev)) {
+ if (dp83td510
Andrew
On 10/30/20 2:56 PM, Andrew Lunn wrote:
On Fri, Oct 30, 2020 at 12:29:48PM -0500, Dan Murphy wrote:
Per the 802.3cg spec the 10base T1L can operate at 2 different
differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
drive that output is dependent on the PHY's on
a top level ethernet document.
Signed-off-by: Dan Murphy
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 62 +++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
diff --git a/Documentation
x27;s
capability.
Dan
Dan Murphy (4):
ethtool: Add 10base-T1L link mode entries
dt-bindings: net: Add Rx/Tx output configuration for 10base T1L
dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
.../devicetree/binding
PHYAD: 1
Transceiver: external
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Signed-off-by: Dan Murphy
---
drivers/net/phy/phy-core.c | 4 +++-
include/uapi/linux
to auto negotiation to
determine the proper p2p voltage.
Signed-off-by: Dan Murphy
---
drivers/net/phy/Kconfig | 6 +
drivers/net/phy/Makefile| 1 +
drivers/net/phy/dp83td510.c | 681
3 files changed, 688 insertions(+)
create mode 100644 drivers
Andrew
On 10/20/20 2:07 PM, Andrew Lunn wrote:
Humm. Are 1v and 2.4v advertised so it can be auto negotiated? Maybe a
PHY tunable is not correct? Is this voltage selection actually more
like pause and EEE?
[Goes and looks at the datasheet]
Register 0x20E, bit 13:
1 = Advertise that the 10BASE
x27;s
capability.
Dan
Dan Murphy (3):
ethtool: Add 10base-T1L link mode entries
dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
.../devicetree/bindings/net/ti,dp83td510.yaml | 72 +++
drivers/net/phy/Kc
to auto negotiation to
determine the proper p2p voltage.
Signed-off-by: Dan Murphy
---
drivers/net/phy/Kconfig | 6 +
drivers/net/phy/Makefile| 1 +
drivers/net/phy/dp83td510.c | 600
3 files changed, 607 insertions(+)
create mode 100644 drivers
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 72 +++
1 file changed, 72 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
diff --git a/Documentation
: MII
PHYAD: 1
Transceiver: external
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Signed-off-by: Dan Murphy
---
drivers/net/phy/phy-core.c | 4 +++-
include/uapi
Andrew
On 10/19/20 5:04 PM, Dan Murphy wrote:
Andrew
On 10/19/20 4:55 PM, Andrew Lunn wrote:
On Mon, Oct 19, 2020 at 04:33:18PM -0500, Dan Murphy wrote:
Andrew
On 10/16/20 5:02 PM, Andrew Lunn wrote:
On Thu, Oct 08, 2020 at 11:23:47AM -0500, Dan Murphy wrote:
The DP83TD510E is an ultra-low
Andrew
On 10/19/20 4:55 PM, Andrew Lunn wrote:
On Mon, Oct 19, 2020 at 04:33:18PM -0500, Dan Murphy wrote:
Andrew
On 10/16/20 5:02 PM, Andrew Lunn wrote:
On Thu, Oct 08, 2020 at 11:23:47AM -0500, Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that
Andrew
On 10/16/20 5:02 PM, Andrew Lunn wrote:
On Thu, Oct 08, 2020 at 11:23:47AM -0500, Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that supports 10M single pair cable.
Hi Dan
I think you are going to have to add
Florian
Thanks for the review
On 10/8/20 12:11 PM, Florian Fainelli wrote:
On 10/8/2020 9:23 AM, Dan Murphy wrote:
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 70 +++
1 file
Heiner
On 10/8/20 11:51 AM, Heiner Kallweit wrote:
On 08.10.2020 18:23, Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that supports 10M single pair cable.
The device supports both 2.4-V p2p and 1-V p2p output voltage as defined
by IEEE 802.3cg
support a specific
voltage or allowed to perfrom auto negotiation on the voltage level. The
default for the PHY is auto negotiation but if the PHY is forced to a specific
voltage then the LP must also support the same voltage.
Dan
Dan Murphy (2):
dt-bindings: dp83td510: Add binding for DP83TD510
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 70 +++
1 file changed, 70 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
diff --git a/Documentation
to auto negotiation to
determine the proper p2p voltage.
Signed-off-by: Dan Murphy
---
drivers/net/phy/Kconfig | 6 +
drivers/net/phy/Makefile| 1 +
drivers/net/phy/dp83td510.c | 583
3 files changed, 590 insertions(+)
create mode 100644 drivers
support a specific
voltage or allowed to perfrom auto negotiation on the voltage level. The
default for the PHY is auto negotiation but if the PHY is forced to a specific
voltage then the LP must also support the same voltage.
Dan
Dan Murphy (2):
dt-bindings: dp83td510: Add binding for DP83TD510
parison issue
reported by zero day.
Acked-by: Dan Murphy
Michal
On 9/28/20 11:37 AM, Michal Kubecek wrote:
On Mon, Sep 28, 2020 at 09:44:01AM -0500, Dan Murphy wrote:
Commit 63130d0b00040 ("update link mode tables") missed adding in the
40base link_caps to the array.
Signed-off-by: Dan Murphy
---
I'm sorry, I only found these
Hello
Add the WoL and Speed Optimization (aka downshift) support for the DP83869
Ethernet PHY.
Dan
Dan Murphy (2):
net: phy: dp83869: support Wake on LAN
net: phy: dp83869: Add speed optimization feature
drivers/net/phy/dp83869.c | 292 ++
1 file
connected instead of the standard cabling with
eight wires (four twisted pairs).
The number of failed link attempts before falling back to 100M operation is
configurable. By default, four failed link attempts are required before
falling back to 100M.
Signed-off-by: Dan Murphy
---
drivers/net/phy
This adds WoL support on TI DP83869 for magic, magic secure, unicast and
broadcast.
Signed-off-by: Dan Murphy
---
v5 - Fixed 0-day warning for u16, removed defconfig
drivers/net/phy/dp83869.c | 176 ++
1 file changed, 176 insertions(+)
diff --git a/drivers
Hello
On 9/28/20 9:46 AM, Dan Murphy wrote:
This adds WoL support on TI DP83869 for magic, magic secure, unicast and
broadcast.
Signed-off-by: Dan Murphy
---
v5 - Fixed 0-day warning for u16
arch/arm/configs/ti_sdk_omap2_debug_defconfig | 2335 +
I have to repost this
This adds WoL support on TI DP83869 for magic, magic secure, unicast and
broadcast.
Signed-off-by: Dan Murphy
---
v5 - Fixed 0-day warning for u16
arch/arm/configs/ti_sdk_omap2_debug_defconfig | 2335 +
drivers/net/phy/dp83869.c | 176 ++
2 files changed
connected instead of the standard cabling with
eight wires (four twisted pairs).
The number of failed link attempts before falling back to 100M operation is
configurable. By default, four failed link attempts are required before
falling back to 100M.
Signed-off-by: Dan Murphy
---
drivers/net/phy
Hello
Add the WoL and Speed Optimization (aka downshift) support for the DP83869
Ethernet PHY.
Dan
Dan Murphy (2):
net: phy: dp83869: support Wake on LAN
net: phy: dp83869: Add speed optimization feature
arch/arm/configs/ti_sdk_omap2_debug_defconfig | 2335 +
drivers/net
Update to kernel commit 55f13311785c
Signed-off-by: Dan Murphy
---
uapi/linux/ethtool.h | 2 ++
uapi/linux/ethtool_netlink.h | 19 ++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/uapi/linux/ethtool.h b/uapi/linux/ethtool.h
index 847ccd0b1fce
Commit 63130d0b00040 ("update link mode tables") missed adding in the
40base link_caps to the array.
Signed-off-by: Dan Murphy
---
ethtool.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 4f93c0f96985..974b14063de2 100644
--- a/ethto
Update the link mode tables to include 100base Fx Full and Half duplex
modes.
Signed-off-by: Dan Murphy
---
ethtool.8.in | 2 ++
ethtool.c | 6 ++
netlink/settings.c | 2 ++
3 files changed, 10 insertions(+)
diff --git a/ethtool.8.in b/ethtool.8.in
index d0921949b37e
Update the link mode tables to include 100base Fx Full and Half duplex
modes.
Signed-off-by: Dan Murphy
---
ethtool.c | 6 ++
netlink/settings.c | 2 ++
2 files changed, 8 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index ab9b4577cbce..2f71fa92bb09 100644
--- a/ethtool.c
Update to kernel commit 55f13311785c
Signed-off-by: Dan Murphy
---
uapi/linux/ethtool.h | 2 ++
uapi/linux/ethtool_netlink.h | 19 ++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/uapi/linux/ethtool.h b/uapi/linux/ethtool.h
index 847ccd0b1fce
connected instead of the standard cabling with
eight wires (four twisted pairs).
The number of failed link attempts before falling back to 100M operation is
configurable. By default, four failed link attempts are required before
falling back to 100M.
Signed-off-by: Dan Murphy
---
v4 - Fixed error from
Hello
Add the WoL and Speed Optimization (aka downshift) support for the DP83869
Ethernet PHY.
Dan
Dan Murphy (2):
net: phy: dp83869: support Wake on LAN
net: phy: dp83869: Add speed optimization feature
drivers/net/phy/dp83869.c | 292 ++
1 file
This adds WoL support on TI DP83869 for magic, magic secure, unicast and
broadcast.
Signed-off-by: Dan Murphy
---
v4 - Added checking error on phy_read
drivers/net/phy/dp83869.c | 176 ++
1 file changed, 176 insertions(+)
diff --git a/drivers/net/phy
PHYAD: 1
Transceiver: external
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Signed-off-by: Dan Murphy
---
v2 - Updated ethtool example in the commit message no
Update the fiber advertisement for speed and duplex modes with the
100base-FX full and half linkmode entries.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83822.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy
100Mbps.
Corresponding user land ethtool patches are available but rely on these patches
to be applied first.
Dan
Dan Murphy (3):
ethtool: Add 100base-FX link mode entries
net: dp83869: Add ability to advertise Fiber connection
net: phy: dp83822: Update the fiber advertisement for speed
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not supported on this PHY when in fiber mode.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 73 +++
1 file changed, 73
Andrew
On 9/15/20 6:29 PM, Dan Murphy wrote:
Andrew
On 9/15/20 3:21 PM, Andrew Lunn wrote:
On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote:
Add entries for the 100base-FX full and half duplex supported modes.
$ ethtool eth0
Supported ports: [ TP MII FIBRE
Geert
On 9/17/20 8:57 AM, Geert Uytterhoeven wrote:
Some EtherAVB variants support internal clock delay configuration, which
can add larger delays than the delays that are typically supported by
the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps"
properties).
Historically, the Ether
Andrew
On 9/16/20 5:13 PM, Andrew Lunn wrote:
On Wed, Sep 16, 2020 at 03:54:34PM -0500, Dan Murphy wrote:
Andrew
On 9/15/20 3:17 PM, Andrew Lunn wrote:
+ linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT,
+phydev->suppor
Andrew
On 9/15/20 3:17 PM, Andrew Lunn wrote:
+ linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT,
+phydev->supported);
+ linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Half_BIT,
+phydev->supported);
+
Andrew
On 9/15/20 3:21 PM, Andrew Lunn wrote:
On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote:
Add entries for the 100base-FX full and half duplex supported modes.
$ ethtool eth0
Supported ports: [ TPMII FIBRE ]
Supported link modes: 10baseT/Half 10baseT
Andrew
On 9/15/20 3:10 PM, Andrew Lunn wrote:
On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote:
@@ -160,6 +160,8 @@ static const struct phy_setting settings[] = {
PHY_SETTING(100, FULL,100baseT_Full ),
PHY_SETTING(100, FULL,100baseT1_Full
100Mbps.
Corresponding user land ethtool patches are available but rely on these patches
to be applied first.
Dan
Dan Murphy (3):
ethtool: Add 100base-FX link mode entries
net: dp83869: Add ability to advertise Fiber connection
net: phy: dp83822: Update the fiber advertisement for speed
Update the fiber advertisement for speed and duplex modes with the
100base-FX full and half linkmode entries.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83822.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Signed-off-by: Dan Murphy
---
drivers/net/phy/phy-core.c | 4 +++-
include/uapi/linux/ethtool.h | 2 ++
net/ethtool/common.c
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not supported on this PHY when in fiber mode.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 73 +++
1 file changed, 73
fiber bits
into the kernel.
If the kernel needs to be updated first then I can prepare those patches and
reference them.
Dan
Dan Murphy (1):
ethtool: Add 100BaseFX half and full duplex link modes
ethtool.c| 6 ++
netlink/settings.c | 2 ++
uapi/linux/ethtool.h | 2 ++
3
The kernel can now indicate if the PHY supports operating over a
fiber cable at 100Mbps either Full or Half duplex.
Signed-off-by: Dan Murphy
---
ethtool.c| 6 ++
netlink/settings.c | 2 ++
uapi/linux/ethtool.h | 2 ++
3 files changed, 10 insertions(+)
diff --git a/ethtool.c
Andrew
On 9/10/20 1:02 PM, Andrew Lunn wrote:
static int dp83869_config_port_mirroring(struct phy_device *phydev)
{
struct dp83869_private *dp83869 = phydev->priv;
Overall this code looks quite similar to dp83867, is there no way to
factor this out?
Factor what out? Yes the DP83
Hello
On 9/7/20 9:29 AM, Andrew Lunn wrote:
On Sat, Sep 05, 2020 at 11:17:55AM -0700, Jakub Kicinski wrote:
On Thu, 3 Sep 2020 06:42:57 -0500 Dan Murphy wrote:
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not
Jakub
On 9/8/20 12:47 PM, Jakub Kicinski wrote:
On Tue, 8 Sep 2020 09:07:22 -0500 Dan Murphy wrote:
On 9/5/20 1:38 PM, Jakub Kicinski wrote:
On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote:
+static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt)
+{
+ int val, count
Jakub
Thanks for the review
On 9/5/20 1:34 PM, Jakub Kicinski wrote:
On Thu, 3 Sep 2020 06:42:58 -0500 Dan Murphy wrote:
This adds WoL support on TI DP83869 for magic, magic secure, unicast and
broadcast.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 128
Jakub
On 9/5/20 1:38 PM, Jakub Kicinski wrote:
On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote:
+static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt)
+{
+ int val, count;
+
+ if (cnt > DP83869_DOWNSHIFT_8_COUNT)
+ return -E2BIG;
ERANGE
This is
Fix spacing issues reported for misaligned switch..case and extra new
lines.
Also updated the file header to comply with networking commet style.
Reviewed-by: Florian Fainelli
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83867.c | 45 ++-
1 file changed
Florian
On 9/3/20 11:34 AM, Florian Fainelli wrote:
On 9/3/2020 7:15 AM, Dan Murphy wrote:
Fix spacing issues reported for misaligned switch..case and extra new
lines.
Also updated the file header to comply with networking commet style.
Signed-off-by: Dan Murphy
---
drivers/net/phy
supports Wake on Lan feature with SecureOn password.
Downshift:
Speed optimization or AKA downshift is also supported by this PHY.
Dan
Dan Murphy (3):
net: dp83869: Add ability to advertise Fiber connection
net: phy: dp83869: support Wake on LAN
net: dp83869: Add speed optimization feature
This adds WoL support on TI DP83869 for magic, magic secure, unicast and
broadcast.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 128 ++
1 file changed, 128 insertions(+)
diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not supported on this PHY when in fiber mode.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 36
1 file changed, 36
Fix spacing issues reported for misaligned switch..case and extra new
lines.
Also updated the file header to comply with networking commet style.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83867.c | 47 ++-
1 file changed, 22 insertions(+), 25 deletions
connected instead of the standard cabling with
eight wires (four twisted pairs).
The number of failed link attempts before falling back to 100M operation is
configurable. By default, four failed link attempts are required before
falling back to 100M.
Signed-off-by: Dan Murphy
---
v3 - Fixed checkpatch
Jakub
On 9/2/20 9:06 PM, Jakub Kicinski wrote:
On Wed, 2 Sep 2020 15:34:44 -0500 Dan Murphy wrote:
Set the speed optimization bit on the DP83869 PHY.
Speed optimization, also known as link downshift, enables fallback to 100M
operation after multiple consecutive failed attempts at Gigabit link
This adds WoL support on TI DP83869 for magic, magic secure, unicast and
broadcast.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 128 ++
1 file changed, 128 insertions(+)
diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index
connected instead of the standard cabling with
eight wires (four twisted pairs).
The number of failed link attempts before falling back to 100M operation is
configurable. By default, four failed link attempts are required before
falling back to 100M.
Signed-off-by: Dan Murphy
---
drivers/net/phy
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not supported on this PHY when in fiber mode.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 36
1 file changed, 36
that this PHY supports fiber.
WoL:
The PHY also supports Wake on Lan feature with SecureOn password.
Downshift:
Speed optimization or AKA downshift is also supported by this PHY.
Dan Murphy (3):
net: dp83869: Add ability to advertise Fiber connection
net: phy: dp83869: support Wake on LAN
net
Fix the registers being written to as the values were being over written
when writing the same registers.
Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN")
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83867.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On 9/2/20 8:25 AM, Dan Murphy wrote:
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not supported on this PHY when in fiber mode.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 35
Add the ability to advertise the Fiber connection if the strap or the
op-mode is configured for 100Base-FX.
Auto negotiation is not supported on this PHY when in fiber mode.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 35 +++
1 file changed, 35
Remove the m_can_class_suspend() call to fix this.
Fixes: 0704c5743694 (can: m_can_platform: remove unnecessary
m_can_class_resume() call)
Not sure about this wrap around for the fixes in the commit msg.
Otherwise
Acked-by: Dan Murphy
Signed-off-by: Lucas Stach
---
drivers/net
*/
+ m_can_config_endisable(cdev, true);
+
/* set the state as STOPPED */
cdev->can.state = CAN_STATE_STOPPED;
}
Acked-by: Dan Murphy
signal.
Fiber mode is only applicable to the DP83822 so rework the PHY match
table so that non-fiber PHYs can still use the same driver but not call
or use any of the fiber features.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83822.c | 225 --
1 file changed
Add a dt binding for the TI dp83822 ethernet phy device.
Reviewed-by: Rob Herring
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83822.yaml | 80 +++
1 file changed, 80 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml
the PHY will not perform signal loss detection.
v2 review from a long time ago can be found here -
https://lore.kernel.org/patchwork/patch/1270958/
Dan
Dan Murphy (2):
dt-bindings: net: dp83822: Add TI dp83822 phy
net: phy: DP83822: Add ability to advertise Fiber connection
.../devicetree
Andrew
On 8/26/20 7:58 AM, Andrew Lunn wrote:
On Tue, Aug 25, 2020 at 02:57:35PM -0500, Dan Murphy wrote:
Andrew
On 8/25/20 8:37 AM, Andrew Lunn wrote:
On Tue, Aug 25, 2020 at 02:07:21PM +0200, Daniel Gorsulowski wrote:
The RGMII control register at 0x32 indicates the states for the bits
val);
With the exception on bot knowing what net tree this goes to via the subject
Acked-by: Dan Murphy
l
I would like to see some sort of response from Dan Murphy about this.
Daniel had sent this privately to me and I encouraged him to send it in
for review.
Unfortunately he did not cc me on the patch he sent to the list.
But reviewing it off the list it looks fine to me
Dan
Andrew
On 7/11/20 1:45 PM, Andrew Lunn wrote:
+#define MII_DP83822_FIBER_ADVERTISE(SUPPORTED_AUI | SUPPORTED_FIBRE | \
+SUPPORTED_BNC | SUPPORTED_Pause | \
+SUPPORTED_Asym_Pause | \
+
Andrew
On 7/11/20 1:54 PM, Andrew Lunn wrote:
@@ -302,6 +357,48 @@ static int dp83822_config_init(struct phy_device *phydev)
}
}
+ if (dp83822->fx_enabled) {
+ err = phy_modify(phydev, MII_DP83822_CTRL_2,
+DP83822_FX_ENABL
the PHY will not perfomr signal loss detection.
Dan
Dan Murphy (2):
dt-bindings: net: dp83822: Add TI dp83822 phy
net: phy: DP83822: Add ability to advertise Fiber connection
.../devicetree/bindings/net/ti,dp83822.yaml | 80 +
drivers/net/phy/dp83822.c | 161
Add a dt binding for the TI dp83822 ethernet phy device.
CC: Rob Herring
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83822.yaml | 80 +++
1 file changed, 80 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml
diff --git
signal.
Fiber mode is only applicable to the DP83822 so rework the PHY match
table so that non-fiber PHYs can still use the same driver but not call
or use any of the fiber features.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83822.c | 161 ++
1 file changed
1 - 100 of 342 matches
Mail list logo
