Andrew
On 9/15/20 6:29 PM, Dan Murphy wrote:
Andrew
On 9/15/20 3:21 PM, Andrew Lunn wrote:
On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote:
Add entries for the 100base-FX full and half duplex supported modes.
$ ethtool eth0
Supported ports: [ TP MII FIBRE ]
Supported link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
100baseFX/Half 100baseFX/Full
Supported pause frame use: Symmetric Receive-only
Supports auto-negotiation: No
Supported FEC modes: Not reported
Advertised link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
100baseFX/Half 100baseFX/Full
I thought this PHY could not switch between TP and Fibre. It has a
strap which decides? So i would expect the supported modes to be
either BaseT or BaseFX. Not both. Same for Advertised?
Andrew
I found that the phy-device was setting all these bits in phy_init in
features_init.
My first pass was to clear all these bits as well because the PHY was
still advertising these modes.
But you are right this PHY cannot switch without strapping.
I can clear these bits.
I re-read your reply and this is just an example. This patch really has
nothing to do with any PHY as it is just adding in the new link modes.
Unless you comment wanted me to remove the TP and advertised modes from
the example in the commit message?
Dan
Dan