[PATCH] ath9k: debug: Remove redundant check

2017-10-14 Thread Christos Gkekas
Variable val is unsigned, so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath9k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k

[PATCH] ath10k: spectral: Remove redundant check

2017-10-14 Thread Christos Gkekas
Variable val is unsigned, so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath10k/spectral.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless

Re: [PATCH] ath9k: debug: Simplify error checking

2017-10-14 Thread Christos Gkekas
On 13/10/17 15:49:15 +0300, Kalle Valo wrote: > Christos Gkekas writes: > > > Variable val is unsigned so checking whether it is less than zero is > > redundant. > > > > Signed-off-by: Christos Gkekas > > --- > > drivers/net/wireless/ath/ath9k/debug.c

Re: [PATCH] ath10k: spectral: Simplify error checking

2017-10-14 Thread Christos Gkekas
On 13/10/17 12:28:50 +, Kalle Valo wrote: > Christos Gkekas writes: > > > Variable val is unsigned so checking whether it is less than zero is > > redundant. > > > > Signed-off-by: Christos Gkekas > > --- > > drivers/net/wireless/ath/ath10k/s

[PATCH] rtlwifi: Remove unused cur_rfstate variables

2017-10-11 Thread Christos Gkekas
Clean up unused cur_rfstate variables in rtl8188ee, rtl8723ae, rtl8723be and rtl8821ae. Signed-off-by: Christos Gkekas --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 4 +--- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 4 +--- drivers/net/wireless/realtek/rtlwifi/rtl8723be

[PATCH] vxge: Clean up unused variables in vxge-traffic

2017-10-11 Thread Christos Gkekas
Delete unused channel variables in vxge-traffic. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/neterion/vxge/vxge-traffic.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c b/drivers/net/ethernet/neterion/vxge

[PATCH] qed: Delete redundant check on dcb_app priority

2017-10-08 Thread Christos Gkekas
dcb_app priority is unsigned thus checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net

[PATCH] ath9k: debug: Simplify error checking

2017-10-08 Thread Christos Gkekas
Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath9k/debug.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath

[PATCH] ath10k: spectral: Simplify error checking

2017-10-08 Thread Christos Gkekas
Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath10k/spectral.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net

[PATCH] net: ethernet: stmmac: Clean up dead code

2017-10-08 Thread Christos Gkekas
Many macros in dwmac-ipq806x are unused and should be removed. Moreover gmac->id is an unsigned variable and therefore checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 14 +- 1 file chan

Re: [PATCH] vxge: Fix rts_mac_en config parameter check

2017-09-24 Thread Christos Gkekas
On 24/09/17 19:50:21 +0100, Christos Gkekas wrote: > Current checks return VXGE_HW_BADCFG_RTS_MAC_EN if rts_mac_en is not > equal to DISABLE *and* not equal to ENABLE. This condition is always > false and the check should change to *or* to properly verify the value. > > Signed-o

[PATCH] vxge: Fix rts_mac_en config parameter check

2017-09-24 Thread Christos Gkekas
Current checks return VXGE_HW_BADCFG_RTS_MAC_EN if rts_mac_en is not equal to DISABLE *and* not equal to ENABLE. This condition is always false and the check should change to *or* to properly verify the value. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/neterion/vxge/vxge-config.c

[PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()

2017-07-02 Thread Christos Gkekas
Pointer hdr in netxen_setup_minidump() is set but never used, thus should be removed. Signed-off-by: Christos Gkekas --- drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c b/drivers/net

[PATCH] pptp: Remove unused variable in pptp_release()

2017-06-18 Thread Christos Gkekas
Variable opt in pptp_release() is set but never used, thus needs to be removed. Signed-off-by: Christos Gkekas --- drivers/net/ppp/pptp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c index 1951b10..5b0fd89 100644 --- a/drivers/net/ppp