Current checks return VXGE_HW_BADCFG_RTS_MAC_EN if rts_mac_en is not
equal to DISABLE *and* not equal to ENABLE. This condition is always
false and the check should change to *or* to properly verify the value.

Signed-off-by: Christos Gkekas <chris.ge...@gmail.com>
---
 drivers/net/ethernet/neterion/vxge/vxge-config.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c 
b/drivers/net/ethernet/neterion/vxge/vxge-config.c
index 6223930..c694f97 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
@@ -1286,8 +1286,8 @@ __vxge_hw_device_config_check(struct 
vxge_hw_device_config *new_config)
            (new_config->intr_mode != VXGE_HW_INTR_MODE_DEF))
                return VXGE_HW_BADCFG_INTR_MODE;
 
-       if ((new_config->rts_mac_en != VXGE_HW_RTS_MAC_DISABLE) &&
-           (new_config->rts_mac_en != VXGE_HW_RTS_MAC_ENABLE))
+       if (new_config->rts_mac_en != VXGE_HW_RTS_MAC_DISABLE ||
+           new_config->rts_mac_en != VXGE_HW_RTS_MAC_ENABLE)
                return VXGE_HW_BADCFG_RTS_MAC_EN;
 
        for (i = 0; i < VXGE_HW_MAX_VIRTUAL_PATHS; i++) {
-- 
2.7.4

Reply via email to