rmal
> > > shutdown or any error paths.
> > >
> > > Fixes: 322b87ca55f2 ("bnxt_en: add page_pool support")
> > > Cc: Ilias Apalodimas
> > > Cc: Andy Gospodarek
> > > Signed-off-by: Michael Chan
> > > ---
> > >
On Tue, Jul 09, 2019 at 09:27:46AM +0300, Ilias Apalodimas wrote:
>
> Thanks and sorry for the inconvenience :(
> /Ilias
No worries. I didn't know Ivan's patch was going to go in so quickly!
fcnt and reintroduce
> page_pool_destroy")
>
> The special error handling code to call page_pool_free() can now be
> removed. bnxt_free_rx_rings() will always be called during normal
> shutdown or any error paths.
>
> Fixes: 322b87ca55f2 ("bnxt_en: add page_pool supp
On Sat, Jul 06, 2019 at 03:36:18AM -0400, Michael Chan wrote:
> From: Andy Gospodarek
>
> This removes contention over page allocation for XDP_REDIRECT actions by
> adding page_pool support per queue for the driver. The performance for
> XDP_REDIRECT actions scales linearly wit
On Mon, Jul 08, 2019 at 05:51:37PM +0300, Ilias Apalodimas wrote:
> Hi Andy,
>
> > On Mon, Jul 08, 2019 at 11:28:03AM +0300, Ilias Apalodimas wrote:
> > > Thanks Andy, Michael
> > >
> > > > + if (event & BNXT_REDIRECT_EVENT)
> > > > + xdp_do_flush_map();
> > > > +
> > > >
On Mon, Jul 08, 2019 at 11:28:03AM +0300, Ilias Apalodimas wrote:
> Thanks Andy, Michael
>
> > + if (event & BNXT_REDIRECT_EVENT)
> > + xdp_do_flush_map();
> > +
> > if (event & BNXT_TX_EVENT) {
> > struct bnxt_tx_ring_info *txr = bnapi->tx_ring;
> > u16 pro
On Fri, Feb 22, 2019 at 12:31:34PM -0800, Florian Fainelli wrote:
> This is no longer necessary after eca59f691566 ("net: Remove support for
> bridge bypass ndos from stacked devices")
>
> Suggested-by: Ido Schimmel
> Signed-off-by: Florian Fainelli
Rev
On Thu, Feb 14, 2019 at 07:39:28AM -0500, Jamal Hadi Salim wrote:
>
> On 2019-02-11 6:44 a.m., Edward Cree wrote:
>
> > But since the
> > other vendors don't seem to do that, I wondered if there was a
> > reason, or if perhaps the counter resources (and PCI bw to read
> > them) could be s
On Tue, Apr 24, 2018 at 10:18:09AM -0400, David Miller wrote:
> From: Tal Gilboa
> Date: Tue, 24 Apr 2018 13:36:00 +0300
>
> > Net DIM is a library designed for dynamic interrupt moderation. It was
> > implemented and optimized with receive side interrupts in mind, since these
> > are usually the
On Wed, Apr 18, 2018 at 09:26:34AM -0700, Jakub Kicinski wrote:
> On Wed, 18 Apr 2018 11:15:29 -0400, Andy Gospodarek wrote:
> > > A similar issue exists on multi-host for PFs, right? If one of the
> > > hosts is down do we still show their PF repr? IMHO yes.
> >
On Tue, Apr 17, 2018 at 04:19:15PM -0700, Jakub Kicinski wrote:
> On Tue, 17 Apr 2018 10:47:00 -0400, Andy Gospodarek wrote:
> > There is also a school of thought that the VF reps could be
> > pre-allocated on the SmartNIC so that any application processing that
> > traffic w
On Tue, Apr 17, 2018 at 09:46:38AM -0700, Samudrala, Sridhar wrote:
> On 4/17/2018 7:47 AM, Andy Gospodarek wrote:
> > On Tue, Apr 17, 2018 at 04:58:05PM +0300, Or Gerlitz wrote:
> > > On Tue, Apr 17, 2018 at 4:30 PM, Andy Gospodarek
> > > wrote:
> > > > O
On Tue, Apr 17, 2018 at 04:58:05PM +0300, Or Gerlitz wrote:
> On Tue, Apr 17, 2018 at 4:30 PM, Andy Gospodarek
> wrote:
> > On Mon, Apr 16, 2018 at 07:08:39PM -0700, Samudrala, Sridhar wrote:
> >>
> >> On 4/16/2018 5:39 AM, Andy Gospodarek wrote:
> >> >
On Mon, Apr 16, 2018 at 07:08:39PM -0700, Samudrala, Sridhar wrote:
>
> On 4/16/2018 5:39 AM, Andy Gospodarek wrote:
> > On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote:
> > > On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar
> > > wrote:
> >
On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote:
> On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar
> wrote:
>
> > I meant between PFs on 2 compute nodes.
>
> If the PF serves as uplink rep, it functions as a switch port -- applications
> don't run on switch ports. One way to get
On Wed, Apr 11, 2018 at 01:41:31PM -0700, Michael Chan wrote:
> On Wed, Apr 11, 2018 at 1:31 PM, Andy Gospodarek
> wrote:
> > On Wed, Apr 11, 2018 at 11:43:14AM -0700, Jakub Kicinski wrote:
> >> On Wed, 11 Apr 2018 11:50:14 -0400, Michael Chan wrote:
> >> >
On Wed, Apr 11, 2018 at 11:43:14AM -0700, Jakub Kicinski wrote:
> On Wed, 11 Apr 2018 11:50:14 -0400, Michael Chan wrote:
> > @@ -764,6 +788,41 @@ static bool bnxt_tc_can_offload(struct bnxt *bp,
> > struct bnxt_tc_flow *flow)
> > return false;
> > }
> >
> > + /* Currently sour
.
>
> Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to
> include/linux")
> Signed-off-by: Tal Gilboa
Reviewed-by: Andy Gospodarek
> ---
> include/linux/net_dim.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
onding: Check return of dev_set_promiscuity/allmulti")
> Signed-off-by: Xin Long
Acked-by: Andy Gospodarek
> ---
> drivers/net/bonding/bond_main.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bondi
s_primary) clause as an
> improvement.
Nice optimization. :-)
>
> Note team driver also has this issue, I will fix it in another patch.
>
> Fixes: 1f718f0f4f97 ("bonding: populate neighbour's private on enslave")
> Reported-by: Beniamino Galvani
> Signed-of
"bonding: change the bond's vlan syncing functions with
> the standard ones")
> Signed-off-by: Xin Long
Acked-by: Andy Gospodarek
> ---
> drivers/net/bonding/bond_main.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git
On Thu, Mar 22, 2018 at 01:10:38PM -0600, David Ahern wrote:
> On 3/22/18 11:49 AM, Jiri Pirko wrote:
> > Thu, Mar 22, 2018 at 04:34:07PM CET, dsah...@gmail.com wrote:
> >> On 3/22/18 4:55 AM, Jiri Pirko wrote:
> >>> From: Jiri Pirko
> >>>
> >>> This patchset resolves 2 issues we have right now:
>
mmary of how to integrate it with a driver. Thanks
for documenting DIM.
Acked-by: Andy Gospodarek
> ---
> Documentation/networking/net_dim.txt | 174
> +++
> 1 file changed, 174 insertions(+)
> create mode 100644 Documentation/networking
From: Andy Gospodarek
Make sure to cancel any pending work that might update driver coalesce
settings when taking down an interface.
Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt
moderation")
Signed-off-by: Andy Gospodarek
Cc: Michael Chan
---
d
On Fri, Jan 12, 2018 at 10:11:17AM -0800, Michael Chan wrote:
> On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote:
> > From: Colin Ian King
> >
> > In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the
> > exit return path is via label next_rx_no_prod and cpr->rx_bytes
> > is being updat
On Wed, Jan 10, 2018 at 12:49:53AM +0200, Tal Gilboa wrote:
> On 1/10/2018 12:46 AM, Florian Fainelli wrote:
> > Hey Andy,
> >
> > On 01/09/2018 01:06 PM, Andy Gospodarek wrote:
> > > From: Andy Gospodarek
> > >
> > > This converts the dyn
From: Andy Gospodarek
Create new header file to prepare to move code that handles irq
moderation to a library that lives in a header file.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 33
From: Andy Gospodarek
This converts the dynamic interrupt moderation library from the mlx5e
driver into a library so it can be used by any driver. The penultimate
patch in this set adds support for this new dynamic interrupt moderation
library in the bnxt_en driver and the last patch creates an
From: Andy Gospodarek
More movement to help make this code more generic.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26 ++
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 25
From: Andy Gospodarek
This makes mlx5e_am_sample more generic so that it can be called easily
from a driver that does not use the same data structure to store these
values in a single structure.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net
From: Andy Gospodarek
Move these to newly created file to prepare to move these functions to a
library.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
drivers/net/ethernet/mellanox/mlx5/core
From: Andy Gospodarek
These functions were identified as ones that could be made generic and
used by multiple drivers. Most of the contents of en_rx_am.c are moved
to net_dim.c.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox
From: Andy Gospodarek
This move allows drivers to add private structure elements to track the
number of packets, bytes, and interrupts events per ring. A driver
also defines a workqueue handler to act on this collected data once per
poll and modify the coalescing parameters per ring.
Signed
From: Andy Gospodarek
Simplify the arguments net_dim() by formatting them into a struct
net_dim_sample before calling the function.
Signed-off-by: Andy Gospodarek
Suggested-by: Tal Gilboa
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
From: Andy Gospodarek
This implements the changes needed for the bnxt_en driver to add support
for dynamic interrupt moderation per ring.
This does add additional counters in the receive path, but testing shows
that any additional instructions are offset by throughput gain when the
default
From: Andy Gospodarek
Signed-off-by: Andy Gospodarek
Signed-off-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e81d91f..1791e7b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4942,6 +4942,11
From: Andy Gospodarek
Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and
NET_DIM, respectively, in code that handles dynamic interrupt
moderation. Also change all references from 'am' to 'dim' when used as
local variables and add generic profile refere
On Tue, Jan 09, 2018 at 08:22:15PM +0200, Tal Gilboa wrote:
> On 1/9/2018 6:06 PM, Andy Gospodarek wrote:
> > On Mon, Jan 08, 2018 at 11:06:28PM -0800, Saeed Mahameed wrote:
> > >
> > >
> > > On 01/08/2018 10:13 PM, Andy Gospodarek wrote:
> > > >
On Mon, Jan 08, 2018 at 11:06:28PM -0800, Saeed Mahameed wrote:
>
>
> On 01/08/2018 10:13 PM, Andy Gospodarek wrote:
> > From: Andy Gospodarek
> >
> > Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and
> > NET_DIM, respectively, in co
From: Andy Gospodarek
Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and
NET_DIM, respectively, in code that handles dynamic interrupt
moderation. Also change all references from 'am' to 'dim' when used as
local variables and add generic profile refere
From: Andy Gospodarek
These functions were identified as ones that could be made generic and
used by multiple drivers. Most of the contents of en_rx_am.c are moved
to net_dim.c.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox
From: Andy Gospodarek
This makes mlx5e_am_sample more generic so that it can be called easily
from a driver that does not use the same data structure to store these
values in a single structure.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net
From: Andy Gospodarek
Move these to newly created file to prepare to move these functions to a
library.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
drivers/net/ethernet/mellanox/mlx5/core
From: Andy Gospodarek
Signed-off-by: Andy Gospodarek
Signed-off-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 753799d..178239dc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4944,6 +4944,11
From: Andy Gospodarek
Simplify the arguments net_dim() by formatting them into a struct
net_dim_sample before calling the function.
Signed-off-by: Andy Gospodarek
Suggested-by: Tal Gilboa
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
From: Andy Gospodarek
Create new header file to prepare to move code that handles irq
moderation to a library that lives in a header file.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 33
From: Andy Gospodarek
This move allows drivers to add private structure elements to track the
number of packets, bytes, and interrupts events per ring. A driver
also defines a workqueue handler to act on this collected data once per
poll and modify the coalescing parameters per ring.
Signed
From: Andy Gospodarek
This implements the changes needed for the bnxt_en driver to add support
for dynamic interrupt moderation per ring.
This does add additional counters in the receive path, but testing shows
that any additional instructions are offset by throughput gain when the
default
From: Andy Gospodarek
More movement to help make this code more generic.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26 ++
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 25
From: Andy Gospodarek
This converts the dynamic interrupt moderation library from the mlx5e
driver into a library so it can be used by any driver. The penultimate
patch in this set adds support for thiw new dynamic interrupt moderation
library in the bnxt_en driver and the last patch creates an
On Sun, Jan 07, 2018 at 11:44:48AM +0200, Tal Gilboa wrote:
>
>
> On 1/6/2018 12:58 AM, Andy Gospodarek wrote:
> > From: Andy Gospodarek
> >
> > Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and
> > NET_DIM, respectively, in co
On Mon, Jan 08, 2018 at 04:20:04PM +0530, Vasundhara Volam wrote:
> Hi Andy,
>
> If you are re-doing the patch, could you modify a minor comment below?
>
> On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek wrote:
>
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_
From: Andy Gospodarek
Move these to newly created file to prepare to move these functions to a
library.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
drivers/net/ethernet/mellanox/mlx5/core
From: Andy Gospodarek
This move allows drivers to add private structure elements to track the
number of packets, bytes, and interrupts events per ring. A driver
also defines a workqueue handler to act on this collected data once per
poll and modify the coalescing parameters per ring.
Signed
From: Andy Gospodarek
Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and
NET_DIM, respectively, in code that handles dynamic interrupt
moderation. Also change all references from 'am' to 'dim' when used as
local variables.
Signed-off-by: Andy Gospo
From: Andy Gospodarek
Simplify the arguments net_dim() by formatting them into a struct
net_dim_sample before calling the function.
Signed-off-by: Andy Gospodarek
Suggested-by: Tal Gilboa
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
From: Andy Gospodarek
This implements the changes needed for the bnxt_en driver to add support
for dynamic interrupt moderation per ring.
This does add additional counters in the receive path, but testing shows
that any additional instructions are offset by throughput gain when the
default
From: Andy Gospodarek
This converts the dynamic interrupt moderation library from the mlx5e
driver into a library so it can be used by any driver. The penultimate
patch in this set adds support for thiw new dynamic interrupt moderation
library in the bnxt_en driver and the last patch creates an
From: Andy Gospodarek
Create new header file to prepare to move code that handles irq
moderation to a library that lives in a header file.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 33
From: Andy Gospodarek
Signed-off-by: Andy Gospodarek
Signed-off-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 753799d..178239dc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4944,6 +4944,11
From: Andy Gospodarek
These functions were identified as ones that could be made generic and
used by multiple drivers. Most of the contents of en_rx_am.c are moved
to net_dim.c.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox
From: Andy Gospodarek
More movement to help make this code more generic.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26 ++
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 25
From: Andy Gospodarek
This makes mlx5e_am_sample more generic so that it can be called easily
from a driver that does not use the same data structure to store these
values in a single structure.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
Acked-by: Saeed Mahameed
---
drivers/net
On Fri, Jan 05, 2018 at 10:04:50AM +0200, Tal Gilboa wrote:
> On 1/4/2018 10:21 PM, Andy Gospodarek wrote:
> > From: Andy Gospodarek
> >
> > Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM,
> MLX_AM->MLX5_AM
>
&
On Fri, Jan 05, 2018 at 10:04:50AM +0200, Tal Gilboa wrote:
> On 1/4/2018 10:21 PM, Andy Gospodarek wrote:
> > From: Andy Gospodarek
> >
> > Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM,
> MLX_AM->MLX5_AM
>
&
On Fri, Jan 05, 2018 at 10:14:43AM +0200, Tal Gilboa wrote:
> Thanks Andy for your hard work. Looks great overall!
>
> On 1/4/2018 10:21 PM, Andy Gospodarek wrote:
> > From: Andy Gospodarek
> >
> > This converts the dynamic interrupt moderation library from the mlx
On Thu, Jan 04, 2018 at 02:16:26PM -0800, Michael Chan wrote:
> On Thu, Jan 4, 2018 at 12:21 PM, Andy Gospodarek wrote:
> > From: Andy Gospodarek
> >
> > This implements the changes needed for the bnxt_en driver to add support
> > for dynamic interrupt moderation per
On Thu, Jan 04, 2018 at 10:37:37PM +0200, Or Gerlitz wrote:
> > net/mlx5e: move interrupt moderation structs to new file
> > net/mlx5e: move interrupt moderation forward declarations
> > net/mlx5e: remove rq references in mlx5e_rx_am
> > net/mlx5e: move AM logic enums
> > net/mlx5e: move
On Thu, Jan 04, 2018 at 02:36:54PM -0800, Stephen Hemminger wrote:
> On Thu, 4 Jan 2018 15:21:30 -0500
> Andy Gospodarek wrote:
>
> > +DYNAMIC INTERRUPT MODERATION
> > +M: Tal Gilboa
> > +S: Mainained
>
> s/Mainained/Maintained/
Ugh. Thanks for noticing that, Stephen!
From: Andy Gospodarek
Create new header file to prepare to move code that handles irq
moderation to a library that lives in a header file.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 33 +--
drivers/net/ethernet/mellanox
From: Andy Gospodarek
This makes mlx5e_am_sample more generic so that it can be called easily
from a driver that does not use the same data structure to store these
values in a single structure.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core
From: Andy Gospodarek
Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM,
respectively, in code that handles dynamic interrupt moderation. Also
change all references from 'am' to 'dim' when used as local variables.
Signed-off-by: Andy Gospodarek
From: Andy Gospodarek
These functions were identified as ones that could be made generic and
used by multiple drivers. Most of the contents of en_rx_am.c are moved
to net_dim.c.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 4
From: Andy Gospodarek
Simplify the arguments net_dim() by formatting them into a struct
net_dim_sample before calling the function.
Signed-off-by: Andy Gospodarek
Suggested-by: Tal Gilboa
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c | 13 -
include
From: Andy Gospodarek
This implements the changes needed for the bnxt_en driver to add support
for dynamic interrupt moderation per ring.
This does add additional counters in the receive path, but testing shows
that any additional instructions are offset by throughput gain when the
default
From: Andy Gospodarek
Signed-off-by: Andy Gospodarek
Signed-off-by: Tal Gilboa
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 753799d..769857b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4944,6 +4944,11 @@ S: Maintained
F
From: Andy Gospodarek
More movement to help make this code more generic.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26 ++
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 25 -
2
From: Andy Gospodarek
Move these to newly created file to prepare to move these functions to a
library.
Signed-off-by: Andy Gospodarek
Acked-by: Tal Gilboa
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 5 +
2 files
From: Andy Gospodarek
This converts the dynamic interrupt moderation library from the mlx5_en driver
into a library so it can be used by any driver. The penultimatepatch in this
set adds support for interrupt moderation in the bnxt_en driver and the last
patch creates an entry in the
From: Andy Gospodarek
This move allows drivers to add private structure elements to track the
number of packets, bytes, and interrupts events per ring. A driver
also defines a workqueue handler to act on this collected data once per
poll and modify the coalescing parameters per ring.
Signed
On Tue, Dec 19, 2017 at 08:20:44PM +0200, Andy Shevchenko wrote:
> Replace sscanf() with mac_pton().
>
> Signed-off-by: Andy Shevchenko
Nice cleanup. Thanks!
Acked-by: Andy Gospodarek
> ---
> drivers/net/bonding/bond_options.c | 6 +-
> 1 file changed, 1 inserti
quot;net: ipv6 sysctl option to ignore routes when nexthop
> link is down")
> Signed-off-by: Ido Schimmel
Nice find. Looks good to me, as well.
Acked-by: Andy Gospodarek
> ---
> net/ipv6/route.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/ipv6/r
From: Andy Gospodarek
This takes the code that is not generically named to lib/.
This move allows drivers to add private structure elements to track the
number of packets, bytes, and interrupts events per ring. A driver
also defines a workqueue handler to act on this collected data once per
From: Andy Gospodarek
This makes mlx5e_am_sample more generic so that it can be called easily
from a driver that does not use the same data structure to store these
values in a single structure.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 22
From: Andy Gospodarek
These functions were identified as ones that could be made generic and
used by multiple drivers. Most of the contents of en_rx_am.c are moved
to net_rx_am.c.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
drivers/net
From: Andy Gospodarek
This is so net_rx_am.h can be easily moved out of mlx5/core.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.h | 108 -
.../net/ethernet/mellanox/mlx5
From: Andy Gospodarek
More movement to help make this code more generic.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 25 -
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.h | 26 ++
2 files changed, 26
From: Andy Gospodarek
This implements the changes needed for the bnxt_en driver to add support
for adaptive interrupt moderation per ring.
This does add additional counters in the receive path, but testing shows
that any additional instructions are offset by throughput gain when the
default
From: Andy Gospodarek
This takes the code that is not generically named to lib/.
This move allows drivers to add private structure elements to track the
number of packets, bytes, and interrupts events per ring. A driver
also defines a workqueue handler to act on this collected data once per
From: Andy Gospodarek
Remove all mlx5* and MLX* references to net_ and NET_, respectively in
code that handles software interrupt moderation.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 7 +-
.../net/ethernet/mellanox/mlx5/core/en_ethtool.c
From: Andy Gospodarek
Create new header file to prepare to move code that handles irq
moderation to a library.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 32 +-
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.h | 74
From: Andy Gospodarek
Move these to newly created file to prepare to move these functions to a
library.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.h | 4
2 files changed, 4 insertions
From: Andy Gospodarek
Move these to newly created file to prepare to move these functions to a
library.
Signed-off-by: Andy Gospodarek
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.h | 4
2 files changed, 4 insertions
From: Andy Gospodarek
This RFC converts the adaptive interrupt moderation library from the
mlx5_en driver into a library so it can be used by any driver. The last
patch in this set adds support for interrupt moderation in the bnxt_en
driver.
The main purpose of this code in the mlx5 driver is
From: Andy Gospodarek
This RFC converts the adaptive interrupt moderation library from the
mlx5_en driver into a library so it can be used by any driver. The last
patch in this set adds support for interrupt moderation in the bnxt_en
driver.
The main purpose of this code in the mlx5_en driver
ed in order vendors to share
>attributes among drivers.
>
> More nits inlined.
>
>
> >Signed-off-by: Steve Lin
> >Acked-by: Andy Gospodarek
> >---
> > include/net/devlink.h| 4 +
> > include/uapi/linux/devlink.h | 108 +
On Thu, Sep 28, 2017 at 1:59 AM, Waskiewicz Jr, Peter
wrote:
> On 9/26/17 10:21 AM, Andy Gospodarek wrote:
>> On Mon, Sep 25, 2017 at 08:50:28PM +0200, Daniel Borkmann wrote:
>>> On 09/25/2017 08:10 PM, Andy Gospodarek wrote:
>>> [...]
>>>> First, thanks
On Mon, Sep 25, 2017 at 08:50:28PM +0200, Daniel Borkmann wrote:
> On 09/25/2017 08:10 PM, Andy Gospodarek wrote:
> [...]
> > First, thanks for this detailed description. It was helpful to read
> > along with the patches.
> >
> > My only concern about this area bei
On Mon, Sep 25, 2017 at 02:25:51AM +0200, Daniel Borkmann wrote:
> This work enables generic transfer of metadata from XDP into skb. The
> basic idea is that we can make use of the fact that the resulting skb
> must be linear and already comes with a larger headroom for supporting
> bpf_xdp_adjust_
ent XDP_REDIRECT for xdp generic")
> Fixes: 24251c264798 ("samples/bpf: add option for native and skb mode for
> redirect apps")
> Signed-off-by: Jesper Dangaard Brouer
Acked-by: Andy Gospodarek
> ---
> net/core/filter.c | 29 +
&g
1 - 100 of 405 matches
Mail list logo
