Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Xuan Zhuo
On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang wrote: > On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo wrote: > > > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote: > > > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo > > > wrote: > > > > > > > > Now, we chain the pages of big mode by the page's

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Jason Wang
On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo wrote: > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote: > > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo > > wrote: > > > > > > Now, we chain the pages of big mode by the page's private variable. > > > But a subsequent patch aims to make the big

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Xuan Zhuo
On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote: > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote: > > > > Now, we chain the pages of big mode by the page's private variable. > > But a subsequent patch aims to make the big mode to support > > premapped mode. This requires additional space

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Jason Wang
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote: > > Now, we chain the pages of big mode by the page's private variable. > But a subsequent patch aims to make the big mode to support > premapped mode. This requires additional space to store the dma addr. > > Within the sub-struct that contains th

Re: [PATCH net-next v6 2/4] ethtool: provide customized dim profile management

2024-04-11 Thread kernel test robot
Hi Heng, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/linux-dim-move-useful-macros-to-h-file/20240411-221400 base: net-next/main patch link: https://lore.kernel.org/r

Re: [PATCH net-next v6 2/4] ethtool: provide customized dim profile management

2024-04-11 Thread kernel test robot
Hi Heng, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/linux-dim-move-useful-macros-to-h-file/20240411-221400 base: net-next/main patch link: https://lore.kernel.org/r

Re: [PATCH vhost 1/6] virtio_ring: introduce dma map api for page

2024-04-11 Thread Xuan Zhuo
On Thu, 11 Apr 2024 13:45:28 +0200, Alexander Lobakin wrote: > From: Xuan Zhuo > Date: Thu, 11 Apr 2024 10:51:22 +0800 > > > The virtio-net big mode sq will use these APIs to map the pages. > > > > dma_addr_t virtqueue_dma_map_page_attrs(struct virtqueue *_vq, struct page > > *page, > >

Re: [PATCH net-next v6 4/4] virtio-net: support dim profile fine-tuning

2024-04-11 Thread Heng Qi
在 2024/4/11 下午11:23, Brett Creeley 写道: On 4/11/2024 7:12 AM, Heng Qi wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Virtio-net has different types of back-end device implementations. In order to

Re: [PATCH net-next v6 2/4] ethtool: provide customized dim profile management

2024-04-11 Thread Heng Qi
在 2024/4/11 下午11:19, Brett Creeley 写道: On 4/11/2024 7:12 AM, Heng Qi wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. The NetDIM library, currently leveraged by an array of NICs, delivers excellen

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-11 Thread kernel test robot
Hi Xuan, kernel test robot noticed the following build warnings: [auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master v6.9-rc3 next-20240411] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH vhost 4/6] virtio_net: big mode support premapped

2024-04-11 Thread kernel test robot
Hi Xuan, kernel test robot noticed the following build warnings: [auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master v6.9-rc3 next-20240411] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH net-next v6 4/4] virtio-net: support dim profile fine-tuning

2024-04-11 Thread Brett Creeley
On 4/11/2024 7:12 AM, Heng Qi wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Virtio-net has different types of back-end device implementations. In order to effectively optimize the dim library's ga

Re: [PATCH net-next v6 2/4] ethtool: provide customized dim profile management

2024-04-11 Thread Brett Creeley
On 4/11/2024 7:12 AM, Heng Qi wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. The NetDIM library, currently leveraged by an array of NICs, delivers excellent acceleration benefits. Nevertheless, NIC

[PATCH net-next v6 3/4] virtio-net: refactor dim initialization/destruction

2024-04-11 Thread Heng Qi
Extract the initialization and destruction actions of dim for use in the next patch. Signed-off-by: Heng Qi --- drivers/net/virtio_net.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c

[PATCH net-next v6 0/4] ethtool: provide the dim profile fine-tuning channel

2024-04-11 Thread Heng Qi
The NetDIM library provides excellent acceleration for many modern network cards. However, the default profiles of DIM limits its maximum capabilities for different NICs, so providing a way which the NIC can be custom configured is necessary. Currently, interaction with the driver is still based o

[PATCH net-next v6 4/4] virtio-net: support dim profile fine-tuning

2024-04-11 Thread Heng Qi
Virtio-net has different types of back-end device implementations. In order to effectively optimize the dim library's gains for different device implementations, let's use the new interface params to fine-tune the profile list. Signed-off-by: Heng Qi --- drivers/net/virtio_net.c | 8 ++-- 1

[PATCH net-next v6 2/4] ethtool: provide customized dim profile management

2024-04-11 Thread Heng Qi
The NetDIM library, currently leveraged by an array of NICs, delivers excellent acceleration benefits. Nevertheless, NICs vary significantly in their dim profile list prerequisites. Specifically, virtio-net backends may present diverse sw or hw device implementation, making a one-size-fits-all par

[PATCH net-next v6 1/4] linux/dim: move useful macros to .h file

2024-04-11 Thread Heng Qi
These will be used in subsequent patches, including newly declared profile arrays. Signed-off-by: Heng Qi --- include/linux/dim.h | 13 + lib/dim/net_dim.c | 10 ++ 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/include/linux/dim.h b/include/linux/dim.h ind

Re: [PATCH net-next v5 1/4] ethtool: provide customized dim profile management

2024-04-11 Thread Simon Horman
On Wed, Apr 10, 2024 at 11:13:15AM +0800, Heng Qi wrote: > > > 在 2024/4/10 上午9:44, Jakub Kicinski 写道: > > On Tue, 9 Apr 2024 20:03:21 +0800 Heng Qi wrote: > > > +/** > > > + * coalesce_put_profile - fill reply with a nla nest with four child nla > > > nests. > > > + * @skb: socket buffer the me

Re: [PATCH vhost 1/6] virtio_ring: introduce dma map api for page

2024-04-11 Thread Alexander Lobakin
From: Xuan Zhuo Date: Thu, 11 Apr 2024 10:51:22 +0800 > The virtio-net big mode sq will use these APIs to map the pages. > > dma_addr_t virtqueue_dma_map_page_attrs(struct virtqueue *_vq, struct page > *page, >size_t offset, size_t size, >

Re: [PATCH net-next v2 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports

2024-04-11 Thread Paolo Abeni
On Mon, 2024-04-08 at 15:37 +0200, Luigi Leonardi wrote: > This patch introduce support for stream_bytes_unsent and > seqpacket_bytes_unsent ioctl for virtio_transport, vhost_vsock > and vsock_loopback. > > For all transports the unsent bytes counter is incremented > in virtio_transport_send_pkt_i