On Wed, Apr 10, 2024 at 11:13:15AM +0800, Heng Qi wrote: > > > 在 2024/4/10 上午9:44, Jakub Kicinski 写道: > > On Tue, 9 Apr 2024 20:03:21 +0800 Heng Qi wrote: > > > +/** > > > + * coalesce_put_profile - fill reply with a nla nest with four child nla > > > nests. > > > + * @skb: socket buffer the message is stored in > > > + * @attr_type: nest attr type ETHTOOL_A_COALESCE_*X_*QE_PROFILE > > > + * @profile: data passed to userspace > > > + * @supported_params: modifiable parameters supported by the driver > > > + * > > > + * Put a dim profile nest attribute. Refer to > > > ETHTOOL_A_MODERATIONS_MODERATION. > > unfortunately kdoc got more picky and it also wants us to document > > return values now, > > Will add it. > > > you gotta add something like > > > > * Returns: true if .. > > > > actually this functions seems to return negative error codes as bool.. > > This works, in its wrapper function its error will be passed.:)
Ok, but I think that in that case the function should return false on error. ...
