[PATCH rdma-next v2 5/5] net/bnxt: Use direct API instead of useless indirection

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky There is no need in any indirection complexity for one ULP user, remove all this complexity in favour of direct calls to the exported symbols. This allows us to greatly simplify the code. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/bnxt_re/main.c | 7

[PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * kbuild spotted that I didn't delete all code in patch #5, so deleted even more ulp_ops derefences. v1: https://lore.kernel.org/linux-rdma/20210329085212.257771-1-l...@kernel.org * Go much deeper and removed useless ULP indirection v0: https://lore.kerne

[PATCH rdma-next v2 3/5] RDMA/bnxt_re: Get rid of custom module reference counting

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky Instead of manually messing with parent driver module reference counting rely on export symbol mechanism to ensure that proper probe/remove chain is performed. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/bnxt_re/main.c | 16 ++-- 1 file changed, 2

[PATCH rdma-next v2 4/5] net/bnxt: Remove useless check of non-existent ULP id

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky There is no other bnxt ULP driver in the upstream and all checks for the ULP id are useless, so remove them and convert double array table to proper pointer structure. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 189 +++--

[PATCH rdma-next v2 2/5] RDMA/bnxt_re: Create direct symbolic link between bnxt modules

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky Convert indirect probe call to its direct equivalent to create symbols link between RDMA and netdev modules. This will give us an ability to remove custom module reference counting that doesn't belong to the driver. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw

[PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it

2021-03-31 Thread Leon Romanovsky
From: Leon Romanovsky The "select" kconfig keyword provides reverse dependency, however it doesn't check that selected symbol meets its own dependencies. Usually "select" is used for non-visible symbols, so instead of trying to keep dependencies in sync with BNXT ethernet driver, simply "depends

Re: [PATCH] linux/bpf-cgroup.h: Delete repeated struct declaration

2021-03-31 Thread Song Liu
> On Mar 31, 2021, at 11:46 PM, Wan Jiabing wrote: > > struct bpf_prog is declared twice. There is one declaration > which is independent on the MACRO at 18th line. > So the below one is not needed though. Remove the duplicate. > > Signed-off-by: Wan Jiabing Acked-by: Song Liu > --- > inc

[PATCH] linux/bpf-cgroup.h: Delete repeated struct declaration

2021-03-31 Thread Wan Jiabing
struct bpf_prog is declared twice. There is one declaration which is independent on the MACRO at 18th line. So the below one is not needed though. Remove the duplicate. Signed-off-by: Wan Jiabing --- include/linux/bpf-cgroup.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/bpf-

Re: [RFC Patch bpf-next] bpf: introduce bpf timer

2021-03-31 Thread Song Liu
> On Mar 31, 2021, at 9:26 PM, Cong Wang wrote: > > From: Cong Wang > > (This patch is still in early stage and obviously incomplete. I am sending > it out to get some high-level feedbacks. Please kindly ignore any coding > details for now and focus on the design.) Could you please explain

[PATCH net-next 1/1] net: stmmac: remove unnecessary pci_enable_msi() call

2021-03-31 Thread Wong Vee Khee
The commit d2a029bde37b ("stmmac: pci: add MSI support for Intel Quark X1000") introduced a pci_enable_msi() call in stmmac_pci.c. With the commit 58da0cfa6cf1 ("net: stmmac: create dwmac-intel.c to contain all Intel platform"), Intel Quark platform related codes have been moved to the newly creat

RE: [Patch bpf-next v8 14/16] sock_map: update sock type checks for UDP

2021-03-31 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > Now UDP supports sockmap and redirection, we can safely update > the sock type checks for it accordingly. > > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Jakub Sitnicki > Cc: Lorenz Bauer > Signed-off-by: Cong Wang > --- > net/core/sock_map.c | 5 +

RE: [Patch bpf-next v8 11/16] udp: implement ->read_sock() for sockmap

2021-03-31 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > This is similar to tcp_read_sock(), except we do not need > to worry about connections, we just need to retrieve skb > from UDP receive queue. > > Note, the return value of ->read_sock() is unused in > sk_psock_verdict_data_ready(), and UDP still does not >

[PATCH net-next 1/1] stmmac: intel: use managed PCI function on probe and resume

2021-03-31 Thread Wong Vee Khee
Update dwmac-intel to use managed function, i.e. pcim_enable_device(). This will allow devres framework to call resource free function for us. Signed-off-by: Wong Vee Khee --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

RE: [Patch bpf-next v8 09/16] sock_map: introduce BPF_SK_SKB_VERDICT

2021-03-31 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > Reusing BPF_SK_SKB_STREAM_VERDICT is possible but its name is > confusing and more importantly we still want to distinguish them > from user-space. So we can just reuse the stream verdict code but > introduce a new type of eBPF program, skb_verdict. Users ar

RE: [Patch bpf-next v8 07/16] sock_map: simplify sock_map_link() a bit

2021-03-31 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > sock_map_link() passes down map progs, but it is confusing > to see both map progs and psock progs. Make the map progs > more obvious by retrieving it directly with sock_map_progs() > inside sock_map_link(). Now it is aligned with > sock_map_link_no_progs()

[PATCH net] net: cls_api: Fix uninitialised struct field bo->unlocked_driver_cb

2021-03-31 Thread wangyunjian
From: Yunjian Wang The 'unlocked_driver_cb' struct field in 'bo' is not being initialized in tcf_block_offload_init(). The uninitialized 'unlocked_driver_cb' will be used when calling unlocked_driver_cb(). So initialize 'bo' to zero to avoid the issue. Addresses-Coverity: ("Uninitialized scalar

[PATCH] drivers: net: fix memory leak in atusb_probe

2021-03-31 Thread Pavel Skripkin
syzbot reported memory leak in atusb_probe()[1]. The problem was in atusb_alloc_urbs(). Since urb is anchored, we need to release the reference to correctly free the urb backtrace: [] kmalloc include/linux/slab.h:559 [inline] [] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74 [] atus

Re: [PATCHv3 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-03-31 Thread Hangbin Liu
On Wed, Mar 31, 2021 at 03:41:17PM +0200, Toke Høiland-Jørgensen wrote: > > @@ -1491,13 +1492,20 @@ static __always_inline int > > __bpf_xdp_redirect_map(struct bpf_map *map, u32 ifind > > */ > > ri->map_id = INT_MAX; /* Valid map id idr range: [1,INT_MAX[ */ > >

[RFC Patch bpf-next] bpf: introduce bpf timer

2021-03-31 Thread Cong Wang
From: Cong Wang (This patch is still in early stage and obviously incomplete. I am sending it out to get some high-level feedbacks. Please kindly ignore any coding details for now and focus on the design.) This patch introduces a bpf timer map and a syscall to create bpf timer from user-space.

[PATCH v2] ip-nexthop: support flush by id

2021-03-31 Thread Chunmei Xu
since id is unique for nexthop, it is heavy to dump all nexthops. use existing delete_nexthop to support flush by id Signed-off-by: Chunmei Xu --- ip/ipnexthop.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/ip/ipnexthop.c b/ip/ipnexthop.c index 20cde58

[RFC] add extack errors for iptoken

2021-03-31 Thread Stephen Hemminger
Perhaps the following (NOT TESTED) kernel patch will show you how such error messages could be added. Note: requires trickling down the extack parameter, but that is a good thing because other place like devconf could use it as well. diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.

Re: [syzbot] KASAN: vmalloc-out-of-bounds Read in bpf_trace_run2

2021-03-31 Thread syzbot
syzbot suspects this issue was fixed by commit: commit befe6d946551d65cddbd32b9cb0170b0249fd5ed Author: Steven Rostedt (VMware) Date: Wed Nov 18 14:34:05 2020 + tracepoint: Do not fail unregistering a probe due to memory failure bisection log: https://syzkaller.appspot.com/x/bisect.t

[PATCH net-next] net: ipv6: Refactor in rt6_age_examine_exception

2021-03-31 Thread Xu Jia
The logic in rt6_age_examine_exception is confusing. The commit is to refactor the code. Signed-off-by: Xu Jia --- net/ipv6/route.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index ebb7519bec2a..f15c7605b11d 100644 --- a/net/ipv6/r

[PATCH] Reduce IP_FRAG_TIME fragment-reassembly timeout to 1s, from 30s

2021-03-31 Thread Matt Corallo
The default IP reassembly timeout of 30 seconds predates git history (and cursory web searches turn up nothing related to it). The only relevant source cited in net/ipv4/ip_fragment.c is RFC 791 defining IPv4 in 1981. RFC 791 suggests allowing the timer to increase on the receipt of each fragment

Re: [PATCH AUTOSEL 5.11 10/38] net: correct sk_acceptq_is_full()

2021-03-31 Thread Sasha Levin
On Wed, Mar 31, 2021 at 06:17:27PM +0200, Eric Dumazet wrote: On 3/30/21 12:21 AM, Sasha Levin wrote: From: liuyacan [ Upstream commit f211ac154577ec9ccf07c15f18a6abf0d9bdb4ab ] The "backlog" argument in listen() specifies the maximom length of pending connections, so the accept queue shoul

[iproute2-next] tipc: use the libmnl functions in lib/mnl_utils.c

2021-03-31 Thread Hoang Le
To avoid code duplication, tipc should be converted to use the helper functions for working with libmnl in lib/mnl_utils.c Acked-by: Jon Maloy Signed-off-by: Hoang Le --- tipc/bearer.c| 38 ++ tipc/cmdl.c | 2 - tipc/link.c | 37 + tipc/media.c | 1

[net] tipc: fix unique bearer names sanity check

2021-03-31 Thread Hoang Le
When enabling a bearer by name, we don't sanity check its name with higher slot in bearer list. This may have the effect that the name of an already enabled bearer bypasses the check. To fix the above issue, we just perform an extra checking with all existing bearers. Fixes: cb30a63384bc9 ("tipc:

[PATCH net-next v4 6/6] net: stmmac: Add support for XDP_REDIRECT action

2021-03-31 Thread Ong Boon Leong
This patch adds the support of XDP_REDIRECT to another remote cpu for further action. It also implements ndo_xdp_xmit ops, enabling the driver to transmit packets forwarded to it by XDP program running on another interface. This patch has been tested using "xdp_redirect_cpu" for XDP_REDIRECT + dro

[PATCH net-next v4 5/6] net: stmmac: Add support for XDP_TX action

2021-03-31 Thread Ong Boon Leong
This patch adds support for XDP_TX action which enables XDP program to transmit back received frames. This patch has been tested with the "xdp2" app located in samples/bpf dir. The DUT receives burst traffic packet generated using pktgen script 'pktgen_sample03_burst_single_flow.sh'. v4: Moved st

[PATCH net-next v4 4/6] net: stmmac: Add initial XDP support

2021-03-31 Thread Ong Boon Leong
This patch adds the initial XDP support to stmmac driver. It supports XDP_PASS, XDP_DROP and XDP_ABORTED actions. Upcoming patches will add support for XDP_TX and XDP_REDIRECT. To support XDP headroom, this patch adds page_offset into RX buffer and change the dma_sync_single_for_device|cpu(). The

[PATCH net-next v4 2/6] net: stmmac: make SPH enable/disable to be configurable

2021-03-31 Thread Ong Boon Leong
SPH functionality splits header and payload according to split mode and offsef fields (SPLM and SPLOFST). It is beneficials for Linux network stack RX processing however it adds a lot of complexity in XDP processing. So, this patch makes the split-header (SPH) capability of the controller is store

[PATCH net-next v4 1/6] net: stmmac: set IRQ affinity hint for multi MSI vectors

2021-03-31 Thread Ong Boon Leong
Certain platform likes Intel mGBE has independent hardware IRQ resources for TX and RX DMA operation. In preparation to support XDP TX, we add IRQ affinity hint to group both RX and TX queue of the same queue ID to the same CPU. Changes in v2: - IRQ affinity hint need to set to null before IRQ is

[PATCH net-next v4 0/6] stmmac: Add XDP support

2021-03-31 Thread Ong Boon Leong
Hi, This is the v4 patch series for adding XDP native support to stmmac. Changes in v4: 5/6: Move TX clean timer setup to the end of NAPI RX process and group it under stmmac_finalize_xdp_rx(). Also, fixed stmmac_xdp_xmit_back() returns STMMAC_XDP_CONSUMED if XDP buffer conversion

Re: [PATCH] ip-nexthop: support flush by id

2021-03-31 Thread xuchunmei
Yes, I just refer to the support of protocol, not considering that id is unique. It is too heavy to get all. > 2021年3月31日 下午11:36,David Ahern 写道: > > On 3/31/21 5:53 AM, Ido Schimmel wrote: >>> @@ -124,6 +125,9 @@ static int flush_nexthop(struct nlmsghdr *nlh, void >>> *arg) >>> if (tb[NHA

Re: [PATCH net] net: fix hangup on napi_disable for threaded napi

2021-03-31 Thread Jakub Kicinski
On Thu, 1 Apr 2021 00:46:18 +0200 Paolo Abeni wrote: > I hit an hangup on napi_disable(), when the threaded > mode is enabled and the napi is under heavy traffic. > > If the relevant napi has been scheduled and the napi_disable() > kicks in before the next napi_threaded_wait() completes - so > th

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-31 Thread Bjorn Helgaas
[+cc Rafael, in case you're interested in the driver core issue here] On Wed, Mar 31, 2021 at 07:08:07AM +0300, Leon Romanovsky wrote: > On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > > On Tue, Mar 30, 2021 at 04:47:16PM -0300, Jason Gunthorpe wrote: > > > On Tue, Mar 30, 2021 at

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-03-31 Thread danilokrummrich
On 2021-03-31 20:35, Russell King - ARM Linux admin wrote: On Wed, Mar 31, 2021 at 07:58:33PM +0200, danilokrummr...@dk-develop.de wrote: For this cited change the only thing happening is that if get_phy_device() already failed for probing with is_c45==false (C22 devices) it tries to probe with

[syzbot] memory leak in bpf (2)

2021-03-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0f4498ce Merge tag 'for-5.12/dm-fixes-2' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1250e126d0 kernel config: https://syzkaller.appspot.com/x/.config?x=49f2683f4e7a4347 das

Re: [PATCH net-next] selftests/net: so_txtime multi-host support

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 1 Apr 2021 00:40:20 + you wrote: > SO_TXTIME hardware offload requires testing across devices, either > between machines or separate network namespaces. > > Split up SO_TXTIME test into tx and rx modes, so tra

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-31 Thread David Ahern
On 3/31/21 7:10 AM, Norman Maurer wrote: > Friendly ping… > > As this missing change was most likely an oversight in the original commit I > do think it should go into 5.12 and subsequently stable as well. That’s also > the reason why I didn’t send a v2 and changed the commit message / subject

RE: [PATCH net-next v3 5/6] net: stmmac: Add support for XDP_TX action

2021-03-31 Thread Ong, Boon Leong
>> +static int stmmac_xdp_xmit_back(struct stmmac_priv *priv, >> +struct xdp_buff *xdp) >> +{ >> +struct xdp_frame *xdpf = xdp_convert_buff_to_frame(xdp); >> +int cpu = smp_processor_id(); >> +struct netdev_queue *nq; >> +int queue; >> +int res; >> +

[PATCH net-next 12/15] ice: Refactor ice_set/get_rss into LUT and key specific functions

2021-03-31 Thread Tony Nguyen
From: Brett Creeley Currently ice_set/get_rss are used to set/get the RSS LUT and/or RSS key. However nearly everywhere these functions are called only the LUT or key are set/get. Also, making this change reduces how many things ice_set/get_rss are doing. Fix this by adding ice_set/get_rss_lut an

[PATCH net-next 15/15] ice: Correct comment block style

2021-03-31 Thread Tony Nguyen
The following is reported by checkpatch, correct it. --- drivers/net/ethernet/intel/ice/ice_adminq_cmd.h --- WARNING:NETWORKING_BLOCK_COMMENT_STYLE: networking block comments don't use an empty /* line, use /*

[PATCH net-next 11/15] ice: Refactor get/set RSS LUT to use struct parameter

2021-03-31 Thread Tony Nguyen
From: Brett Creeley Update ice_aq_get_rss_lut() and ice_aq_set_rss_lut() to take a new structure ice_aq_get_set_rss_params instead of passing individual parameters. This is done for 2 reasons: 1. Reduce the number of parameters passed to the functions. 2. Reduce the amount of change required if

[PATCH net-next 13/15] ice: Consolidate VSI state and flags

2021-03-31 Thread Tony Nguyen
From: Anirudh Venkataramanan struct ice_vsi has two fields, state and flags which seem to be serving the same purpose. Consolidate them into one field 'state'. enum ice_state is used to represent state information of the PF. While some of these enum values can be use to represent VSI state, it m

[PATCH net-next 14/15] ice: cleanup style issues

2021-03-31 Thread Tony Nguyen
From: Bruce Allan A few style issues reported by checkpatch have snuck into the code; resolve the style issues. COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses Signed-off-by: Bruce Allan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/etherne

[PATCH net-next 08/15] ice: correct memory allocation call

2021-03-31 Thread Tony Nguyen
From: Bruce Allan Use *malloc() instead of *calloc() when allocating only a single object as opposed to an array of objects. Signed-off-by: Bruce Allan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_switch.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH net-next 09/15] ice: rename ptype bitmap

2021-03-31 Thread Tony Nguyen
From: Qi Zhang Align all ptype bitmap to follow ice_ptypes_xxx prefix. Signed-off-by: Qi Zhang Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_flow.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/e

[PATCH net-next 05/15] ice: change link misconfiguration message

2021-03-31 Thread Tony Nguyen
From: Paul Greenwalt Change link misconfiguration message since the configuration could be intended by the user. Signed-off-by: Paul Greenwalt Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH net-next 06/15] ice: remove unnecessary duplicated AQ command flag setting

2021-03-31 Thread Tony Nguyen
From: Bruce Allan Commit a012dca9f7a2 ("ice: add ethtool -m support for reading i2c eeprom modules") unnecessarily added the ICE_AQ_FLAG_BUF flag to the descriptor when sending the indirect Read/Write SFF EEPROM AQ command. The flag is already added later in the code flow for all indirect AQ comm

[PATCH net-next 07/15] ice: Check for bail out condition early

2021-03-31 Thread Tony Nguyen
From: Anirudh Venkataramanan Check for bail out condition before calling ice_aq_sff_eeprom Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH net-next 01/15] ice: Add Support for XPS

2021-03-31 Thread Tony Nguyen
From: Benita Bose Enable and configure XPS. The driver code implemented sets up the Transmit Packet Steering Map, which in turn will be used by the kernel in queue selection during Tx. Signed-off-by: Benita Bose Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/in

[PATCH net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2021-03-31

2021-03-31 Thread Tony Nguyen
This series contains updates to ice driver only. Benita adds support for XPS. Ani moves netdev registration to the end of probe to prevent use before the interface is ready and moves up an error check to possibly avoid an unneeded call. He also consolidates the VSI state and flag fields to a sing

[PATCH net-next 10/15] ice: Change ice_vsi_setup_q_map() to not depend on RSS

2021-03-31 Thread Tony Nguyen
From: Brett Creeley Currently, ice_vsi_setup_q_map() depends on the VSI's rss_size. However, the Rx Queue Mapping section of the VSI context has no dependency on RSS. Instead, limit the maximum number of Rx queues per TC based on the Rx Queue mapping section of the VSI context, which currently al

[PATCH net-next 04/15] ice: handle increasing Tx or Rx ring sizes

2021-03-31 Thread Tony Nguyen
From: Paul M Stillwell Jr There is an issue when the Tx or Rx ring size increases using 'ethtool -L ...' where the new rings don't get the correct ITR values because when we rebuild the VSI we don't know that some of the rings may be new. Fix this by looking at the original number of rings and d

[PATCH net-next 02/15] ice: Delay netdev registration

2021-03-31 Thread Tony Nguyen
From: Anirudh Venkataramanan Once a netdev is registered, the corresponding network interface can be immediately used by userspace utilities (like say NetworkManager). This can be problematic if the driver technically isn't fully up yet. Move netdev registration to the end of probe, as by this t

[PATCH net-next 03/15] ice: Update to use package info from ice segment

2021-03-31 Thread Tony Nguyen
From: Dan Nowlin There are two package versions in the package binary. Today, these two version numbers are the same. However, in the future that may change. Update code to use the package info from the ice segment metadata section, which is the package information that is actually downloaded to

Re: [PATCH net-next 0/9] XDP for NXP ENETC

2021-03-31 Thread Vladimir Oltean
On Wed, Mar 31, 2021 at 10:20:18PM +, patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This series was applied to netdev/net-next.git (refs/heads/master): > > On Wed, 31 Mar 2021 23:08:48 +0300 you wrote: > > From: Vladimir Oltean > > > > This series adds support to the enetc driver for

[PATCH net] net: fix hangup on napi_disable for threaded napi

2021-03-31 Thread Paolo Abeni
I hit an hangup on napi_disable(), when the threaded mode is enabled and the napi is under heavy traffic. If the relevant napi has been scheduled and the napi_disable() kicks in before the next napi_threaded_wait() completes - so that the latter quits due to the napi_disable_pending() condition, t

[PATCH v2 2/2][next] wl3501_cs: Fix out-of-bounds warning in wl3501_mgmt_join

2021-03-31 Thread Gustavo A. R. Silva
Fix the following out-of-bounds warning by enclosing some structure members into new struct req: arch/x86/include/asm/string_32.h:182:25: warning: '__builtin_memcpy' offset [39, 108] from the object at 'sig' is out of the bounds of referenced subobject 'beacon_period' with type 'short unsigned i

[PATCH v2 1/2][next] wl3501_cs: Fix out-of-bounds warning in wl3501_send_pkt

2021-03-31 Thread Gustavo A. R. Silva
Fix the following out-of-bounds warning by enclosing structure members daddr and saddr into new struct addr: arch/x86/include/asm/string_32.h:182:25: warning: '__builtin_memcpy' offset [18, 23] from the object at 'sig' is out of the bounds of referenced subobject 'daddr' with type 'u8[6]' {aka '

Re: [PATCHv4 4/4] net: cdc_ether: record speed in status method

2021-03-31 Thread Andrew Lunn
On Mon, Mar 29, 2021 at 07:16:51PM -0700, Grant Grundler wrote: > From: Grant Grundler > > Until very recently, the usbnet framework only had support functions > for devices which reported the link speed by explicitly querying the > PHY over a MDIO interface. However, the cdc_ether devices send >

[PATCH v2 0/2][next] wl3501_cs: Fix out-of-bounds warnings

2021-03-31 Thread Gustavo A. R. Silva
Fix the a couple of out-of-bounds warnings by making the code a bit more structured. This helps with the ongoing efforts to enable -Warray-bounds and avoid confusing the compiler. Link: https://github.com/KSPP/linux/issues/109 Changes in v2: - Update changelog text in patch 1/2. - Replace a c

Re: [PATCHv4 3/4] net: cdc_ncm: record speed in status method

2021-03-31 Thread Andrew Lunn
On Mon, Mar 29, 2021 at 07:16:50PM -0700, Grant Grundler wrote: > From: Oliver Neukum > > Until very recently, the usbnet framework only had support functions > for devices which reported the link speed by explicitly querying the > PHY over a MDIO interface. However, the cdc_ncm devices send > no

Re: [PATCHv4 2/4] usbnet: add method for reporting speed without MII

2021-03-31 Thread Andrew Lunn
On Mon, Mar 29, 2021 at 07:16:49PM -0700, Grant Grundler wrote: > From: Oliver Neukum > > The old method for reporting link speed assumed a driver uses the > generic phy (mii) MDIO read/write functions. CDC devices don't > expose the phy. > > Add a primitive internal version reporting back direc

Re: [PATCHv4 1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings

2021-03-31 Thread Andrew Lunn
On Mon, Mar 29, 2021 at 07:16:48PM -0700, Grant Grundler wrote: > From: Oliver Neukum > > The generic functions assumed devices provided an MDIO interface (accessed > via older mii code, not phylib). This is true only for genuine ethernet. > > Devices with a higher level of abstraction or based

Re: [PATCH iproute2] iptoken: Add doc on the conditions of iptoken

2021-03-31 Thread Stephen Hemminger
On Sat, 27 Mar 2021 21:36:07 +0800 Hongren Zheng wrote: > `ip token set suffix dev interface' may be unsuccessful > with only the error 'RTNETLINK answers: Invalid argument' > prompted. For users this is mysterious and hard to debug. > Hence a more user-friendly prompt is added. > > This commit

Re: [PATCH net-next 0/9] inet: shrink netns_ipv{4|6}

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 31 Mar 2021 10:52:04 -0700 you wrote: > From: Eric Dumazet > > This patch series work on reducing footprint of netns_ipv4 > and netns_ipv6. Some sysctls are converted to bytes, > and some fields are moves to redu

Re: [PATCH net] Revert "net: correct sk_acceptq_is_full()"

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 31 Mar 2021 09:35:12 -0700 you wrote: > From: Eric Dumazet > > This reverts commit f211ac154577ec9ccf07c15f18a6abf0d9bdb4ab. > > We had similar attempt in the past, and we reverted it. > > History: > > [...] Here i

Re: [PATCH net-next 1/1] net: stmmac: enable MTL ECC Error Address Status Over-ride by default

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 1 Apr 2021 00:18:25 +0800 you wrote: > From: Voon Weifeng > > Turn on the MEEAO field of MTL_ECC_Control_Register by default. > > As the MTL ECC Error Address Status Over-ride(MEEAO) is set by default, > the fol

Re: [PATCH -next] net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 31 Mar 2021 16:36:02 +0800 you wrote: > Add the missing destroy_workqueue() before return from > tipc_crypto_start() in the error handling case. > > Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")

Re: [PATCH net-next 0/9] XDP for NXP ENETC

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 31 Mar 2021 23:08:48 +0300 you wrote: > From: Vladimir Oltean > > This series adds support to the enetc driver for the basic XDP primitives. > The ENETC is a network controller found inside the NXP LS1028A SoC, >

Re: [PATCH net-next] ipv6: remove extra dev_hold() for fallback tunnels

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 31 Mar 2021 14:38:11 -0700 you wrote: > From: Eric Dumazet > > My previous commits added a dev_hold() in tunnels ndo_init(), > but forgot to remove it from special functions setting up fallback tunnels. > > Fallb

Re: [PATCH net v2 1/1] xdp: fix xdp_return_frame() kernel BUG throw for page_pool memory model

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 31 Mar 2021 21:25:03 +0800 you wrote: > xdp_return_frame() may be called outside of NAPI context to return > xdpf back to page_pool. xdp_return_frame() calls __xdp_return() with > napi_direct = false. For page_pool memor

[PATCH 2/2][next] wl3501_cs: Fix out-of-bounds warning in wl3501_mgmt_join

2021-03-31 Thread Gustavo A. R. Silva
Fix the following out-of-bounds warning by enclosing some structure members into new struct req: arch/x86/include/asm/string_32.h:182:25: warning: '__builtin_memcpy' offset [39, 108] from the object at 'sig' is out of the bounds of referenced subobject 'beacon_period' with type 'short unsigned i

[PATCH 1/2][next] wl3501_cs: Fix out-of-bounds warning in wl3501_send_pkt

2021-03-31 Thread Gustavo A. R. Silva
Fix the following out-of-bounds warning by enclosing structure members daddr and saddr into new struct addr: arch/x86/include/asm/string_32.h:182:25: warning: '__builtin_memcpy' offset [18, 23] from the object at 'sig' is out of the bounds of referenced subobject 'daddr' with type 'u8[6]' {aka '

[PATCH 0/2][next] wl3501_cs: Fix out-of-bounds warnings

2021-03-31 Thread Gustavo A. R. Silva
Fix the a couple of out-of-bounds warnings by making the code a bit more structured. This helps with the ongoing efforts to enable -Warray-bounds and avoid confusing the compiler. Link: https://github.com/KSPP/linux/issues/109 Gustavo A. R. Silva (2): wl3501_cs: Fix out-of-bounds warning in w

RE: [Patch bpf-next v8 01/16] skmsg: lock ingress_skb when purging

2021-03-31 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > Currently we purge the ingress_skb queue only when psock > refcnt goes down to 0, so locking the queue is not necessary, > but in order to be called during ->close, we have to lock it > here. > > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Lorenz Bauer

Re: pull request (net): ipsec 2021-03-31

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Wed, 31 Mar 2021 10:18:36 +0200 you wrote: > 1) Fix ipv4 pmtu checks for xfrm anf vti interfaces. >From Eyal Birger. > > 2) There are situations where the socket passed to >xfrm_output_resume() is not the same

Re: [net 1/9] net/mlx5e: Fix mapping of ct_label zero

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 31 Mar 2021 13:14:16 -0700 you wrote: > From: Ariel Levkovich > > ct_label 0 is a default label each flow has and therefore > there can be rules that match on ct_label=0 without a prior > rule that set the ct_label to

Re: [PATCH 01/11] xfrm: interface: fix ipv4 pmtu check to honor ip header df

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 31 Mar 2021 10:18:37 +0200 you wrote: > From: Eyal Birger > > Frag needed should only be sent if the header enables DF. > > This fix allows packets larger than MTU to pass the xfrm interface > and be fragmented after

Re: [PATCH net-next 0/7] net: fix some coding style issues

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 31 Mar 2021 16:18:27 +0800 you wrote: > Do some cleanups according to the coding style of kernel, including wrong > print type, redundant and missing spaces and so on. > > Yangyang Li (1): > net: lpc_eth: fix fo

Re: [PATCH net-next v3 5/6] net: stmmac: Add support for XDP_TX action

2021-03-31 Thread Jakub Kicinski
On Wed, 31 Mar 2021 23:41:34 +0800 Ong Boon Leong wrote: > This patch adds support for XDP_TX action which enables XDP program to > transmit back received frames. > > This patch has been tested with the "xdp2" app located in samples/bpf > dir. The DUT receives burst traffic packet generated using

Re: [PATCH] qrtr: Convert qrtr_ports from IDR to XArray

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 31 Mar 2021 05:36:42 +0100 you wrote: > The XArray interface is easier for this driver to use. Also fixes a > bug reported by the improper use of GFP_ATOMIC. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > ne

Re: [PATCH net-next] ip6_tunnel: sit: proper dev_{hold|put} in ndo_[un]init methods

2021-03-31 Thread David Miller
From: Eric Dumazet Date: Wed, 31 Mar 2021 08:00:24 +0200 > Can you merge this patch so that I can send my global fix for fallback > tunnels, with a correct Fixes: tag for this patch ? Done.

[PATCH net-next] ipv6: remove extra dev_hold() for fallback tunnels

2021-03-31 Thread Eric Dumazet
From: Eric Dumazet My previous commits added a dev_hold() in tunnels ndo_init(), but forgot to remove it from special functions setting up fallback tunnels. Fallback tunnels do call their respective ndo_init() This leads to various reports like : unregister_netdevice: waiting for ip6gre0 to be

Re: [PATCH v2] net/rds: Fix a use after free in rds_message_map_pages

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 30 Mar 2021 18:59:59 -0700 you wrote: > In rds_message_map_pages, the rm is freed by rds_message_put(rm). > But rm is still used by rm->data.op_sg in return value. > > My patch assigns ERR_CAST(rm->data.op_sg) to err be

Re: [PATCH net-next] ip6_tunnel: sit: proper dev_{hold|put} in ndo_[un]init methods

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 23:45:51 -0700 you wrote: > From: Eric Dumazet > > Same reasons than for the previous commits : > 6289a98f0817 ("sit: proper dev_{hold|put} in ndo_[un]init methods") > 40cb881b5aaa ("ip6_vti: proper de

Re: [PATCH net-next 0/3] ethtool: support FEC configuration over netlink

2021-03-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 20:59:51 -0700 you wrote: > This series adds support for the equivalents of ETHTOOL_GFECPARAM > and ETHTOOL_SFECPARAM over netlink. > > As a reminder - this is an API which allows user to query current

Re: [syzbot] WARNING in ieee802154_del_seclevel

2021-03-31 Thread syzbot
syzbot has bisected this issue to: commit 416dacb819f59180e4d86a5550052033ebb6d72c Author: Alan Stern Date: Wed Aug 21 17:27:12 2019 + HID: hidraw: Fix invalid read in hidraw_ioctl bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=127430fcd0 start commit: 6e5a03bc eth

[net 6/9] net/mlx5e: kTLS, Fix RX counters atomicity

2021-03-31 Thread Saeed Mahameed
From: Tariq Toukan Some TLS RX counters increment per socket/connection, and are not protected against parallel modifications from several cores. Switch them to atomic counters by taking them out of the RQ stats into the global atomic TLS stats. In this patch, we touch 'rx_tls_ctx/del' that coun

[net 3/9] net/mlx5e: Fix ethtool indication of connector type

2021-03-31 Thread Saeed Mahameed
From: Aya Levin Use connector_type read from PTYS register when it's valid, based on corresponding capability bit. Fixes: 5b4793f81745 ("net/mlx5e: Add support for reading connector type from PTYS") Signed-off-by: Aya Levin Reviewed-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed --- .../

Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform soft reset and retain established link

2021-03-31 Thread Modi, Geet
Hi Andrew, If Link is present, the current reset will reset the registers including the link and Host will need to re-program all the registers. With the change proposed, it will reset the state machine while keeping the register content. My understanding is that below API is called to perform

Re: [PATCH v3 bpf-next] tools/resolve_btfids: Fix warnings

2021-03-31 Thread Andrii Nakryiko
On Mon, Mar 29, 2021 at 3:34 PM Stanislav Fomichev wrote: > > * make eprintf static, used only in main.c > * initialize ret in eprintf > * remove unused *tmp > > v3: > * remove another err (Song Liu) > > v2: > * remove unused 'int err = -1' > > Cc: Song Liu > Signed-off-by: Stanislav Fomichev >

[net 9/9] net/mlx5e: Guarantee room for XSK wakeup NOP on async ICOSQ

2021-03-31 Thread Saeed Mahameed
From: Tariq Toukan XSK wakeup flow triggers an IRQ by posting a NOP WQE and hitting the doorbell on the async ICOSQ. It maintains its state so that it doesn't issue another NOP WQE if it has an outstanding one already. For this flow to work properly, the NOP post must not fail. Make sure to rese

[net 7/9] net/mlx5: Don't request more than supported EQs

2021-03-31 Thread Saeed Mahameed
From: Daniel Jurgens Calculating the number of compeltion EQs based on the number of available IRQ vectors doesn't work now that all async EQs share one IRQ. Thus the max number of EQs can be exceeded on systems with more than approximately 256 CPUs. Take this into account when calculating the nu

[net 5/9] net/mlx5e: kTLS, Fix TX counters atomicity

2021-03-31 Thread Saeed Mahameed
From: Tariq Toukan Some TLS TX counters increment per socket/connection, and are not protected against parallel modifications from several cores. Switch them to atomic counters by taking them out of the SQ stats into the global atomic TLS stats. In this patch, we touch a single counter 'tx_tls_c

[net 8/9] net/mlx5e: Consider geneve_opts for encap contexts

2021-03-31 Thread Saeed Mahameed
From: Dima Chumak Current algorithm for encap keys is legacy from initial vxlan implementation and doesn't take into account all possible fields of a tunnel. For example, for a Geneve tunnel, which may have additional TLV options, they are ignored when comparing encap keys and a rule can be attac

[net 4/9] net/mlx5: E-switch, Create vport miss group only if src rewrite is supported

2021-03-31 Thread Saeed Mahameed
From: Maor Dickman Create send to vport miss group was added in order to support traffic recirculation to root table with metadata source rewrite. This group is created also in case source rewrite isn't supported. Fixed by creating send to vport miss group only if source rewrite is supported by

[net 1/9] net/mlx5e: Fix mapping of ct_label zero

2021-03-31 Thread Saeed Mahameed
From: Ariel Levkovich ct_label 0 is a default label each flow has and therefore there can be rules that match on ct_label=0 without a prior rule that set the ct_label to this value. The ct_label value is not used directly in the HW rules and instead it is mapped to some id within a defined range

  1   2   3   >