Thanks for the patch.
> -Original Message-
> From: Robert Hancock
> Sent: Friday, March 12, 2021 1:41 AM
> To: Radhey Shyam Pandey ; da...@davemloft.net;
> k...@kernel.org
> Cc: netdev@vger.kernel.org; devicet...@vger.kernel.org; Robert Hancock
>
> Subject: [PATCH net-next 1/2] dt-bindin
Noticed missing header when build bpfilter helper:
CC [U] net/bpfilter/main.o
In file included from /usr/include/linux/errno.h:1,
from /usr/include/bits/errno.h:26,
from /usr/include/errno.h:28,
from net/bpfilter/main.c:4:
tools/inc
The MPTCP_PUSH_PENDING define is 6 and these tests should be testing if
BIT(6) is set.
Fixes: c2e6048fa1cf ("mptcp: fix race in release_cb")
Signed-off-by: Dan Carpenter
---
net/mptcp/protocol.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/protocol.c b/net/mp
> On 11. Mar 2021, at 01:36, Pablo Neira Ayuso wrote:
>
> From: Felix Fietkau
>
> When using DSA, set the special tag in GDM ingress control to allow the MAC
> to parse packets properly earlier. This affects rx DMA source port reporting.
>
> Signed-off-by: Felix Fietkau
> Signed-off-by: Pa
On 11/03/2021 23:00, ChiaHao Hsu wrote:
In order to support live migration of guests between kernels
that do and do not support 'feature-dynamic-multicast-control',
we add a module parameter that allows the feature to be disabled
at run time, instead of using hardcode value.
The default value is
On 11/03/2021 22:59, ChiaHao Hsu wrote:
In order to support live migration of guests between kernels
that do and do not support 'feature-ctrl-ring', we add a
module parameter that allows the feature to be disabled
at run time, instead of using hardcode value.
The default value is enable.
Signed-
On Thu, Mar 11, 2021 at 08:42:16AM -0800, Alexander Duyck wrote:
> > @@ -4919,6 +4934,9 @@ static inline bool prepare_alloc_pages(gfp_t
> > gfp_mask, unsigned int order,
> > struct alloc_context *ac, gfp_t *alloc_mask,
> > unsigned int *alloc_flags)
> > {
> > +
All comment lines inside the comment block have been aligned.
Every line of comment starts with a * (uniformity in code).
Signed-off-by: Shubhankar Kuranagatti
---
net/ipv4/route.c | 97
1 file changed, 49 insertions(+), 48 deletions(-)
diff --gi
On 3/11/21 11:05 PM, Bhaskar Chowdhury wrote:
>
> Random spelling fixes throughout the file.
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> drivers/net/ethernet/dec/tulip/pnic2.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/pnic2
On Wed, Mar 10, 2021 at 1:02 AM Greg KH wrote:
>
> On Wed, Feb 10, 2021 at 11:54:03AM -0600, Mike Ximing Chen wrote:
> > Intel DLB is an accelerator for the event-driven programming model of
> > DPDK's Event Device Library[2]. The library is used in packet processing
> > pipelines that arrange for
On 3/12/2021 3:00 PM, Jason Wang wrote:
On 2021/3/12 2:40 下午, Zhu, Lingshan wrote:
On 3/12/2021 1:52 PM, Jason Wang wrote:
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote:
On 3/11/2021 2:20 PM, Jason Wang wrote:
On 2021/3/11 12:16 下午, Zhu Lingshan wrote:
On 3/11/2021 11:20 AM, Jason Wa
Random spelling fixes throughout the file.
Signed-off-by: Bhaskar Chowdhury
---
drivers/net/ethernet/dec/tulip/pnic2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/pnic2.c
b/drivers/net/ethernet/dec/tulip/pnic2.c
index 412adaa7fdf8
On 2021/3/12 2:40 下午, Zhu, Lingshan wrote:
On 3/12/2021 1:52 PM, Jason Wang wrote:
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote:
On 3/11/2021 2:20 PM, Jason Wang wrote:
On 2021/3/11 12:16 下午, Zhu Lingshan wrote:
On 3/11/2021 11:20 AM, Jason Wang wrote:
On 2021/3/10 5:00 下午, Zhu Lings
On Thu, Mar 11, 2021 at 09:41:03PM +0100, Loic Poulain wrote:
> This change introduces initial support for a WWAN subsystem. Given the
> complexity and heterogeneity of existing WWAN hardwares and interfaces,
> there is no strict definition of what a WWAN device is and how it should
> be represente
On 3/12/2021 1:52 PM, Jason Wang wrote:
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote:
On 3/11/2021 2:20 PM, Jason Wang wrote:
On 2021/3/11 12:16 下午, Zhu Lingshan wrote:
On 3/11/2021 11:20 AM, Jason Wang wrote:
On 2021/3/10 5:00 下午, Zhu Lingshan wrote:
vDPA requres VIRTIO_F_ACCESS_PLAT
syzbot has found a reproducer for the following issue on:
HEAD commit:47142ed6 net: dsa: bcm_sf2: Qualify phydev->dev_flags base..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=11ccd12ad0
kernel config: https://syzkaller.appspot.com/x/.config?x=eec733599e95
On 2021/3/11 9:52 下午, Stefano Garzarella wrote:
In vhost_vdpa_set_config_call() if eventfd_ctx_fdget() fails the
'v->config_ctx' contains an error instead of a valid pointer.
Since we consider 'v->config_ctx' valid if it is not NULL, we should
set it to NULL in this case to avoid to use an inv
On 2021/3/11 9:52 下午, Stefano Garzarella wrote:
When the 'v->config_ctx' eventfd_ctx reference is released we didn't
set it to NULL. So if the same character device (e.g. /dev/vhost-vdpa-0)
is re-opened, the 'v->config_ctx' is invalid and calling again
vhost_vdpa_config_put() causes use-after-f
On Thu, Mar 11, 2021 at 06:53:16PM -0800, Alexander Duyck wrote:
> On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote:
> >
> > On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote:
> > > > We don't need to invent new locks and new complexity for something
> > > > that is trivially so
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote:
On 3/11/2021 2:20 PM, Jason Wang wrote:
On 2021/3/11 12:16 下午, Zhu Lingshan wrote:
On 3/11/2021 11:20 AM, Jason Wang wrote:
On 2021/3/10 5:00 下午, Zhu Lingshan wrote:
vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit
examines this w
What is the reason for this change? Why is the new way better than the
old way?
Hi ishaangandhi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v5.12-rc2 next-20210311]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
icmp.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index 8b63f2853e7b9..8cd003f5c8f59 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -586,8 +586,8 @@ stat
On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote:
>
> On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote:
> > > We don't need to invent new locks and new complexity for something
> > > that is trivially solved already.
> >
> > I am not wanting a new lock. What I am wanting is a w
On Thu, Mar 11, 2021 at 7:47 PM ishaangandhi wrote:
>
> From: Ishaan Gandhi
>
> This patch identifies the interface a packet arrived on when sending
> ICMP time exceeded, destination unreachable, and parameter problem
> messages, in accordance with RFC 5837.
>
> It was tested by pinging a machine
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 10 Mar 2021 20:53:42 -0800 you wrote:
> Per the datasheet, when we clear the power down bit, the PHY remains in
> an internal reset state for 40us and then resume normal operation.
> Account for that delay to avoid any i
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 10 Mar 2021 23:27:55 -0500 you wrote:
> fix some coding style issues in the isdn header
>
> Signed-off-by: Tong Zhang
> ---
> drivers/isdn/hardware/mISDN/iohelper.h | 14 +++---
> 1 file changed, 7 insert
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 10 Mar 2021 20:01:40 -0800 you wrote:
> In qlcnic_83xx_get_minidump_template, fw_dump->tmpl_hdr was freed by
> vfree(). But unfortunately, it is used when extended is true.
>
> Fixes: 7061b2bdd620e ("qlogic: Deletion of
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 10 Mar 2021 23:27:35 -0500 you wrote:
> setup_fritz() in avmfritz.c might fail with -EIO and in this case the
> isac.type and isac.write_reg is not initialized and remains 0(NULL).
> A subsequent call to isac_release() w
Hi ishaangandhi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master sparc-next/master v5.12-rc2
next-20210311]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when
On 2021-03-10 14:33, subas...@codeaurora.org wrote:
On 2021-03-10 12:28, David Ahern wrote:
On 3/10/21 11:49 AM, Subash Abhinov Kasiviswanathan wrote:
Added new procfs flag to toggle the automatic addition of prefix
routes on a per device basis. The new flag is accept_ra_prefix_route.
A value
On Thu, Mar 11, 2021 at 08:56:19AM -0500, Steven Rostedt wrote:
> On Thu, 11 Mar 2021 17:44:15 +0800
> Tony Lu wrote:
>
> > ---
> > include/trace/events/net.h| 42 +--
> > include/trace/events/qdisc.h | 4 ++--
> > include/trace/events/sunrpc.h | 4 ++--
> >
This patch fixes the following warning from sparse:
net/tipc/monitor.c:263:35: warning: incorrect type in assignment (different
base types)
net/tipc/monitor.c:263:35:expected unsigned int
net/tipc/monitor.c:263:35:got restricted __be32 [usertype]
[...]
net/tipc/node.c:374:13: warning: con
From: Hoang Le
(struct tipc_link_info)->dest is in network order (__be32), so we must
convert the value to network order before assigning. The problem detected
by sparse:
net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment
(different base types)
net/tipc/netlink_compat.c:699
> +#define DRV_VERSION 1.19
> +static int mlxbf_gige_probe(struct platform_device *pdev)
> +{
> + unsigned int phy_int_gpio;
> + struct phy_device *phydev;
> + struct net_device *netdev;
> + struct resource *mac_res;
> + struct resource *llu_res;
> + struct resource *plu_re
Hi ishaangandhi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v5.12-rc2 next-20210311]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 10:33:22 +0700 you wrote:
> From: Hoang Le
>
> (struct tipc_link_info)->dest is in network order (__be32), so we must
> convert the value to network order before assigning. The problem detected
> by s
> +static void mlxbf_gige_get_pauseparam(struct net_device *netdev,
> + struct ethtool_pauseparam *pause)
> +{
> + struct mlxbf_gige *priv = netdev_priv(netdev);
> +
> + pause->autoneg = priv->aneg_pause;
> + pause->rx_pause = priv->tx_pause;
> + pa
Hi David,
May I ask what's the status of this patch? From patchwork[1] the state is
accepted. But I can't find the fix on net or net-next.
[1]
https://patchwork.kernel.org/project/netdevbpf/patch/20210309032214.2112438-1-liuhang...@gmail.com/
Thanks
Hangbin
On Tue, Mar 09, 2021 at 11:22:14AM +0
On Thu, 11 Mar 2021 16:28:47 -0800 Xie He wrote:
> On Thu, Mar 11, 2021 at 4:10 PM Jakub Kicinski wrote:
> >
> > And the "noqueue" queue is there because it's on top of hdlc_fr.c
> > somehow or some out of tree driver? Or do you install it manually?
>
> No, this driver is not related to "hdlc_f
On 3/11/2021 9:52 PM, Stefano Garzarella wrote:
When the 'v->config_ctx' eventfd_ctx reference is released we didn't
set it to NULL. So if the same character device (e.g. /dev/vhost-vdpa-0)
is re-opened, the 'v->config_ctx' is invalid and calling again
vhost_vdpa_config_put() causes use-after-
On Thu, Mar 11, 2021 at 6:42 AM Maxim Mikityanskiy wrote:
>
> The HTB offload feature introduced a few bugs in HTB. One affects the
> non-offload mode, preventing attaching qdiscs to HTB classes, and the
> other affects the error flow, when the netdev doesn't support the
> offload, but it was requ
> On Mar 11, 2021, at 5:15 AM, 'Wei Yongjun wrote:
>
> From: Wei Yongjun
>
> The sparse tool complains as follows:
>
> kernel/bpf/bpf_task_storage.c:23:1: warning:
> symbol '__pcpu_scope_bpf_task_storage_busy' was not declared. Should it be
> static?
>
> This symbol is not used outside of
Hi Björn,
[Cc'ing a few (maybe) interested parties]
On Thu, 11 Mar 2021 07:47:03 +0100 Björn Töpel wrote:
>
> On 2021-03-11 01:47, Stephen Rothwell wrote:
> >
> > After merging the bpf-next tree, today's linux-next build (perf) failed
> > like this:
> >
> > make[3]: *** No rule to make target
The PHY driver entry for BCM50160 and BCM50610M calls
bcm54xx_config_init() but does not call bcm54xx_config_clock_delay() in
order to configuration appropriate clock delays on the PHY, fix that.
Fixes: 76262b28 ("net: phy: Allow BCM5481x PHYs to setup internal TX/RX
clock delay")
Signed-off-
On Thu, Mar 11, 2021 at 3:42 AM Jakub Sitnicki wrote:
>
> On Wed, Mar 10, 2021 at 06:32 AM CET, Cong Wang wrote:
> > From: Cong Wang
> >
> > We only have skb_send_sock_locked() which requires callers
> > to use lock_sock(). Introduce a variant skb_send_sock()
> > which locks on its own, callers d
From: Ishaan Gandhi
This patch identifies the interface a packet arrived on when sending
ICMP time exceeded, destination unreachable, and parameter problem
messages, in accordance with RFC 5837.
It was tested by pinging a machine with a ttl of 1, and observing the
response in Wireshark.
Signed-
On Thu, Mar 11, 2021 at 3:28 AM Jakub Sitnicki wrote:
> > +
> > +static inline struct sk_msg *sk_psock_deque_msg(struct sk_psock *psock)
>
> Should be sk_psock_deque*ue*_msg()?
Right, it is better and less confusing to use "dequeue".
Thanks.
From: Dylan Hung
The interrupt handler may set the flag to reset the mac in the future,
but that flag is not cleared once the reset has occurred.
Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling")
Signed-off-by: Dylan Hung
Acked-by: Benjamin Herrenschmidt
Reviewed-by: Joel St
The WLAN NV firmware blob differs between platforms, and possibly
devices, so add support in the wcnss_ctrl driver for reading the path of
this file from DT in order to allow these files to live in a generic
file system (or linux-firmware).
The new property is optional and the code falls back to t
Enable the modem and WiFi subsystems and specify msm8916 specific
firmware path for these and the WCNSS control service.
Signed-off-by: Bjorn Andersson
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
2 files changed, 13 insertio
The WLAN NV firmware blob differs between platforms, and possibly
devices, so add support in the wcn36xx driver for reading the path of
this file from DT in order to allow these files to live in a generic
file system (or linux-firmware).
For some reason the parent (wcnss_ctrl) also needs to upload
Introduce a local variable to carry the struct device *, to reduce the
line lengths in the next patch.
Signed-off-by: Bjorn Andersson
---
drivers/soc/qcom/wcnss_ctrl.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wc
The WCNSS needs firmware which differs between platforms, and possibly
boards. Add a new property "firmware-name" to allow the DT to specify
the platform/board specific path to this firmware file.
Signed-off-by: Bjorn Andersson
---
Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.txt | 7 ++
The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others needs
platform-, and perhaps even board-, specific firmware. Add support for
providing this in devicetree.
Bjorn Andersson (5):
dt-bindings: soc: qcom: wcnss: Add firmware-name property
wcn36xx: Allow firmware name to be
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 14:24:10 +0200 you wrote:
> From: Ido Schimmel
>
> So far, sampling was implemented using a dedicated sampling mechanism
> that is available on all Spectrum ASICs. Spectrum-2 and later ASICs
> support
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 16:53:17 +0100 you wrote:
> Add support for IPv4 decapsulation in ipv6_srh_rcv() and
> ignore routing header with segments left equal to 0 for
> seg6local actions that doesn't perfom decapsulation.
>
>
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 19:03:11 +0100 you wrote:
> At this moment, there is only one type of next-hop group: an mpath group.
> Mpath groups implement the hash-threshold algorithm, described in RFC
> 2992[1].
>
> To select a
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 14:37:09 -0800 you wrote:
> From: Saeed Mahameed
>
> Users of mlx5_eswitch_get_vport() are required to check return value
> prior to passing mlx5_vport further. Fix all the places to do not skip
> tha
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Thu, 11 Mar 2021 10:09:09 -0800 you wrote:
> This series contains updates to igc and e1000e drivers.
>
> Sasha adds locking to reset task to prevent race condition for igc.
>
> Muhammad fixes reporting of supported pause f
On Thu, Mar 11, 2021 at 4:10 PM Jakub Kicinski wrote:
>
> And the "noqueue" queue is there because it's on top of hdlc_fr.c
> somehow or some out of tree driver? Or do you install it manually?
No, this driver is not related to "hdlc_fr.c" or any out-of-tree
driver. The default qdisc is "noqueue"
From: Joel Stanley
Date: Fri, 12 Mar 2021 00:26:43 +
> On Tue, 20 Oct 2020 at 04:14, Joel Stanley wrote:
>>
>> On Mon, 19 Oct 2020 at 08:57, Dylan Hung wrote:
>> >
>> > The interrupt handler may set the flag to reset the mac in the future,
>> > but that flag is not cleared once the reset ha
On Tue, 20 Oct 2020 at 04:14, Joel Stanley wrote:
>
> On Mon, 19 Oct 2020 at 08:57, Dylan Hung wrote:
> >
> > The interrupt handler may set the flag to reset the mac in the future,
> > but that flag is not cleared once the reset has occured.
> >
> > Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI &
On Thu, 11 Mar 2021 15:13:01 -0800 Xie He wrote:
> On Thu, Mar 11, 2021 at 2:52 PM Jakub Kicinski wrote:
> >
> > Normally driver's ndo_stop() calls netif_tx_disable() which takes TX
> > locks, so unless your driver is lockless (LLTX) there should be no xmit
> > calls after that point.
>
> Do yo
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 10:14:10 +0800 you wrote:
> This series includes two updates for the HNS3 ethernet driver.
>
> Yufeng Mo (2):
> net: hns3: use FEC capability queried from firmware
> net: hns3: use pause capability
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 15:11:01 +0800 you wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:874:5-8: Unneeded variable: "err". Return
> "0" on line 889.
>
> Reported-by: Abaci Robot
> Signed-
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 11 Mar 2021 10:57:36 +0800 you wrote:
> From: Tonghao Zhang
>
> Introduce the new function tw_prot_init (inspired by
> req_prot_init) to simplify "proto_register" function.
>
> tw_prot_cleanup will take care of a part
On Thu, 2021-03-11 at 14:11 -0600, Robert Hancock wrote:
> This driver was only enabling the first clock on the device, regardless
> of its name. However, this controller logic can have multiple clocks
> which should all be enabled. Add support for enabling additional clocks.
> The clock names used
The 03/11/2021 02:25, Vladimir Oltean wrote:
Hi Vladimir,
>
> On Wed, Mar 10, 2021 at 09:51:40PM +0100, Horatiu Vultur wrote:
> > This patch extends MRP support for Ocelot. It allows to have multiple
> > rings and when the node has the MRC role it forwards MRP Test frames in
> > HW. For MRM the
On Wed, 2021-03-03 at 09:54 +0200, Roi Dayan wrote:
>
>
> On 2021-03-03 4:40 AM, angkery wrote:
> > From: Junlin Yang
> >
> > It is allocated with kvzalloc(), the corresponding release function
> > should not be kfree(), use kvfree() instead.
> >
> > Generated by: scripts/coccinelle/api/kfree_
On Wed, 2021-03-03 at 08:52 +, Parav Pandit wrote:
> Hi Saeed,
>
> > From: Parav Pandit
> > Sent: Monday, February 22, 2021 3:32 PM
> >
> >
> > > From: Jiapeng Chong
> > > Sent: Monday, February 22, 2021 3:27 PM
> > >
> > > Fix the following coccicheck warnings:
> > >
> > > ./drivers/net
On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote:
> > We don't need to invent new locks and new complexity for something
> > that is trivially solved already.
>
> I am not wanting a new lock. What I am wanting is a way to mark the VF
> as being stale/offline while we are performing
On Thu, Mar 11, 2021 at 11:52:41PM +0100, Andrew Lunn wrote:
> On Thu, Mar 11, 2021 at 06:53:40PM +0100, Kurt Kanzenbach wrote:
> > Report the META data descriptor usage via devlink.
>
> Jakubs question is also relevant here. Please could you give a bit
> more background about what the meta data i
On Wed, 2021-03-10 at 03:04 +0100, Andrew Lunn wrote:
> On Tue, Mar 09, 2021 at 06:57:06PM +0100, Eric Dumazet wrote:
> >
> >
> > On 3/9/21 6:10 PM, Shay Agroskin wrote:
> > > The page cache holds pages we allocated in the past during napi
> > > cycle,
> > > and tracks their availability status u
On Thu, Mar 11, 2021 at 2:52 PM Jakub Kicinski wrote:
>
> Normally driver's ndo_stop() calls netif_tx_disable() which takes TX
> locks, so unless your driver is lockless (LLTX) there should be no xmit
> calls after that point.
Do you mean I should call "netif_tx_disable" inside my "ndo_stop"
func
> static int hellcreek_setup_devlink_regions(struct dsa_switch *ds)
> {
> struct hellcreek *hellcreek = ds->priv;
> struct devlink_region_ops *ops;
> struct devlink_region *region;
> u64 size;
> + int ret;
>
> + /* VLAN table */
> size = VLAN_N_VID * sizeof
On Thu, Mar 11, 2021 at 06:53:43PM +0100, Kurt Kanzenbach wrote:
> There are two functions which need to populate fdb entries. Move that to a
> helper function.
>
> Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
Andrew
On Thu, Mar 11, 2021 at 06:53:42PM +0100, Kurt Kanzenbach wrote:
> hellcreek_select_vlan() takes a boolean instead of an integer.
> So, use false accordingly.
>
> Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
Andrew
Currently tcp_check_req can be called with obsolete req socket for which big
socket have been already created (because of CPU race or early demux
assigning req socket to multiple packets in gro batch).
Commit e0f9759f530bf789e984 (\"tcp: try to keep packet if SYN_RCV race
is lost\") added retry in
In order to support live migration of guests between kernels
that do and do not support 'feature-dynamic-multicast-control',
we add a module parameter that allows the feature to be disabled
at run time, instead of using hardcode value.
The default value is enable.
Signed-off-by: ChiaHao Hsu
---
In order to support live migration of guests between kernels
that do and do not support 'feature-ctrl-ring', we add a
module parameter that allows the feature to be disabled
at run time, instead of using hardcode value.
The default value is enable.
Signed-off-by: ChiaHao Hsu
---
drivers/net/xen-
On Thu, Mar 11, 2021 at 06:53:40PM +0100, Kurt Kanzenbach wrote:
> Report the META data descriptor usage via devlink.
Jakubs question is also relevant here. Please could you give a bit
more background about what the meta data is?
Thanks
Andrew
On Thu, 11 Mar 2021 13:12:25 -0800 Xie He wrote:
> On Thu, Mar 11, 2021 at 12:43 PM Jakub Kicinski wrote:
> >
> > Is this a theoretical issues or do you see a path where it triggers?
> >
> > Who are the callers sending frames to a device which went down?
>
> This is a theoretical issue. I didn'
On Sun, 2021-03-07 at 10:50 +0200, Leon Romanovsky wrote:
> On Thu, Mar 04, 2021 at 06:18:14AM -0800, Jia-Ju Bai wrote:
> > When mlx5_is_fpga_lookaside() returns a non-zero value, no error
> > return code is assigned.
> > To fix this bug, err is assigned with -EINVAL as error return code.
> >
> >
On Mon, 2021-03-08 at 18:28 +0200, Tariq Toukan wrote:
>
>
> On 3/8/2021 5:32 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > Increasing the size of the indirection_rqt array from 128 to 256
> > bytes
> > pushed the stack usage of the mlx5e_hairpin_fill_rqt_rqns()
> > function
> > over
Hi Krzysztof,
On Thu, Mar 11, 2021 at 04:27:35PM +0100, Krzysztof Kozlowski wrote:
> ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the
> 32-bit ARM drivers to rely on new symbol.
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Moritz Fischer
> ---
> drivers/fpga/Kconfig | 6 ++
On Mon, 2021-03-08 at 20:23 +0200, Roi Dayan wrote:
>
>
> On 2021-03-08 5:31 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:1510:12:
> > error: implicit declaration of function 'fib_info_nh' [-Werror,-
> > Wimplicit-function-de
On Tue, 2021-03-09 at 11:44 +0200, Roi Dayan wrote:
>
>
> On 2021-03-09 10:32 AM, Jia-Ju Bai wrote:
> >
> >
> > On 2021/3/9 16:24, Roi Dayan wrote:
> > >
> > >
> > > On 2021-03-09 10:20 AM, Roi Dayan wrote:
> > > >
> > > >
> > > > On 2021-03-06 3:47 PM, Jia-Ju Bai wrote:
> > > > > When mlx5
On Thu, 2021-03-11 at 13:33 -0400, Jason Gunthorpe wrote:
> On Wed, Mar 10, 2021 at 11:09:12PM -0800, Saeed Mahameed wrote:
> > From: Mark Bloch
> >
> > Now that a pointer to the managing E-Switch is stored in the
> > representor
> > use it.
> >
> > Signed-off-by: Mark Bloch
> > Reviewed-by: Sa
From: Eli Cohen
fs_get_obj retrieves the container of fs_parent_node just to pass the
same value as &fs_ns->node. Just pass fs_parent_node to
init_root_tree_recursive() to get exactly the same effect.
Signed-off-by: Eli Cohen
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/n
From: Roi Dayan
Fix the following coccicheck warnings:
drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.h:50:8-9: WARNING:
return of 0/1 in function 'mlx5_sf_dev_allocated' with return type bool
Signed-off-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/c
From: Roi Dayan
flow spec is not small and we do allocate it using kvzalloc
in most places of the driver. fix rest of the places
to use kvzalloc to avoid failure in allocation when
memory is too fragmented.
Signed-off-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellan
From: Vlad Buslov
When CONFIG_IPV6 is disabled the header nexthop.h is not included by
fib_notifier.h which causes tc_tun_encap.c to fail to compile:
In file included from
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:5:
In file included from
drivers/net/ethernet/mellanox/mlx
From: Saeed Mahameed
There is no point of calculating reg_c1 or overriding reg_c0 if we are
going to abort the function.
Signed-off-by: Saeed Mahameed
Reviewed-by: Roi Dayan
---
drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
From: Leon Romanovsky
MLX5_INTERFACE_STATE_UP is far from being reliable check for success to
recover, because it can be changed any time and health logic doesn't
have any locks to protect from it.
The locks are not needed here because health recover is good to have,
but not must to success, so
From: Vlad Buslov
Some of the stubs for CONFIG_MLX5_CLS_ACT==disabled are missing "static
inline" in their definition which causes the following compilation
warnings:
In file included from
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:41:
>> drivers/net/ethernet/mellanox/mlx5/co
From: Saeed Mahameed
mlx5_tc_ct_init() either returns a valid pointer or a NULL, either way
the caller can continue, remove IS_ERR check from callers as it has no
effect.
Reported-by: Dan Carpenter
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 8
From: Arnd Bergmann
The alternative implementation of this function in a header file
is declared as a global symbol, and gets added to every .c file
that includes it, which leads to a link error:
arm-linux-gnueabi-ld: drivers/net/ethernet/mellanox/mlx5/core/en_rx.o: in
function `mlx5e_tc_tun_up
From: Roi Dayan
To avoid false lock dependency warning set the ct_entries_ht lock
class different than the lock class of the ht being used when deleting
last flow from a group and then deleting a group, we get into
del_sw_flow_group()
which call rhashtable_destroy on fg->ftes_hash which will tak
From: Leon Romanovsky
The mix between probe/unprobe and reload flows causes to have an extra
mutex lock intf_state_mutex that generates LOCKDEP warning between it
and devlink_mutex. As a preparation for the future removal, separate
those flows.
Reviewed-by: Moshe Shemesh
Signed-off-by: Leon Rom
1 - 100 of 348 matches
Mail list logo
