> static int hellcreek_setup_devlink_regions(struct dsa_switch *ds) > { > struct hellcreek *hellcreek = ds->priv; > struct devlink_region_ops *ops; > struct devlink_region *region; > u64 size; > + int ret; > > + /* VLAN table */ > size = VLAN_N_VID * sizeof(struct hellcreek_devlink_vlan_entry); > ops = &hellcreek_region_vlan_ops;
I think this comment belongs in the previous patch adding the VLAN region. Reviewed-by: Andrew Lunn <and...@lunn.ch> Andrew