Hello,
syzbot found the following issue on:
HEAD commit:d01b59c9 bpf: Add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_..
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1592bd66d0
kernel config: https://syzkaller.appspot.com/x/.config?x=66df2ca4f2dd3022
das
Hello,
syzbot found the following issue on:
HEAD commit:ad5d07f4 cipso,calipso: resolve a number of problems with ..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=12aca7cad0
kernel config: https://syzkaller.appspot.com/x/.config?x=402784bff477e1ac
dashboar
On 3/4/2021 5:08 PM, Vladimir Oltean wrote:
> On Tue, Mar 02, 2021 at 07:37:34PM -0800, Florian Fainelli wrote:
>> Took a while but for the 54210E reference board here are the numbers,
>> your mileage will vary depending on the supplies, regulator efficiency
>> and PCB design around the PHY obvi
On 3/5/2021 1:14 AM, Philipp Zabel wrote:
> As of commit bb475230b8e5 ("reset: make optional functions really
> optional"), the reset framework API calls use NULL pointers to describe
> optional, non-present reset controls.
>
> This allows to unconditionally return errors from
> devm_reset_cont
> I am proposing acceptance of a commonly used implementation for accessing
> SFPs because the one used by the netdev/netlink community does not fit the
> architecture of the white box NOS/switch community.
Please could you expand on this. I've given suggests as to how the new
netlink KAPI could b
In rmnet_map_ipv4_ul_csum_header() and rmnet_map_ipv6_ul_csum_header()
the offset within a packet at which checksumming should commence is
calculated. This calculation involves byte swapping and a forced type
conversion that makes it hard to understand.
Simplify this by computing the offset in ho
Replace the use of C bit-fields in the rmnet_map_ul_csum_header
structure with a single two-byte (big endian) structure member,
and use field masks to encode or get values within it.
Previously rmnet_map_ipv4_ul_csum_header() would update values in
the host byte-order fields, and then forcibly fix
The following macros, defined in "rmnet_map.h", assume a socket
buffer is provided as an argument without any real indication this
is the case.
RMNET_MAP_GET_MUX_ID()
RMNET_MAP_GET_CD_BIT()
RMNET_MAP_GET_PAD()
RMNET_MAP_GET_CMD_START()
RMNET_MAP_GET_LENGTH()
What they hide is pr
The fields in the checksum trailer structure used for QMAP protocol
RX packets are all big-endian format, so define them that way.
It turns out these fields are never actually used by the RMNet code.
The start offset is always assumed to be zero, and the length is
taken from the other packet heade
The actual layout of bits defined in C bit-fields (e.g. int foo : 3)
is implementation-defined. Structures defined in
address this by specifying all bit-fields twice, to cover two
possible layouts.
I think this pattern is repetitive and noisy, and I find the whole
notion of compiler "bitfield en
Version 2 of this series fixes the code in the final patch that
encoded the RMNet checksum offload header inserted for outgoing
packets. It was erroneously using be16_encode_bits() to generate
the value to be written into the header, where it should have been
using u16_encode_bits(). Bjorn notice
Replace the use of C bit-fields in the rmnet_map_dl_csum_trailer
structure with a single one-byte field, using constant field masks
to encode or get at embedded values.
Signed-off-by: Alex Elder
Reviewed-by: Bjorn Andersson
---
.../ethernet/qualcomm/rmnet/rmnet_map_data.c| 2 +-
include/li
Currently devlink health does not give user any clear information
of what kind of remediation ->recover callback will perform. This
makes it difficult to understand the impact of enabling auto-
-remediation, and the severity of the error itself.
To allow users to make more informed decision, as we
On Fri, 5 Mar 2021 2:55 PM -0800 Jakub Kicinski wrote:
> On Fri, 5 Mar 2021 11:07:08 -0800 Don Bollinger wrote:
> > Acknowledging your objections, I nonetheless request that optoe be
> > accepted into upstream as an eeprom driver in drivers/misc/eeprom. It
> > is a legitimate driver, with a legiti
Cong Wang wrote:
> On Fri, Mar 5, 2021 at 4:27 PM John Fastabend
> wrote:
> >
> > Cong Wang wrote:
> > > On Tue, Mar 2, 2021 at 10:23 AM Cong Wang
> > > wrote:
> > > >
> > > > On Tue, Mar 2, 2021 at 8:22 AM Lorenz Bauer wrote:
> > > > >
> > > > > On Tue, 2 Mar 2021 at 02:37, Cong Wang
> > >
It was reported ([0]) that having optional -m flag between source and
destination arguments in install command breaks bpftools cross-build on MacOS.
Move -m to the front to fix this issue.
[0] https://github.com/openwrt/openwrt/pull/3959
Fixes: 7110d80d53f4 ("libbpf: Makefile set specified perm
Cong Wang wrote:
> From: Cong Wang
>
> UDP already has udp_sendmsg() which takes lock_sock() inside.
> We have to build ->sendmsg_locked() on top of it, by adding
> a new parameter for whether the sock has been locked.
>
> Cc: John Fastabend
> Cc: Daniel Borkmann
> Cc: Jakub Sitnicki
> Cc: Lo
On Fri, Mar 5, 2021 at 4:27 PM John Fastabend wrote:
>
> Cong Wang wrote:
> > On Tue, Mar 2, 2021 at 10:23 AM Cong Wang wrote:
> > >
> > > On Tue, Mar 2, 2021 at 8:22 AM Lorenz Bauer wrote:
> > > >
> > > > On Tue, 2 Mar 2021 at 02:37, Cong Wang wrote:
> > > >
> > > > ...
> > > > > static inlin
On Sat, Mar 06, 2021 at 01:24:53AM +0100, Tobias Waldekranz wrote:
> The story here is basically:
>
> 1. Bridge port attributes should not be offloaded if an intermediate
>stacked device (a LAG) is not offloaded. (5696c8aedfcc)
>
> 2. (1) broke VLAN filtering events from being processed by DS
Cong Wang wrote:
> On Tue, Mar 2, 2021 at 10:23 AM Cong Wang wrote:
> >
> > On Tue, Mar 2, 2021 at 8:22 AM Lorenz Bauer wrote:
> > >
> > > On Tue, 2 Mar 2021 at 02:37, Cong Wang wrote:
> > >
> > > ...
> > > > static inline void sk_psock_restore_proto(struct sock *sk,
> > > >
This reverts commit 99b8202b179fc3dbbca69e8af6da660224c9d676.
DSA should indeed react to certain switchdev attributes where orig_dev
is the bridge master. But the fix was too broad, causing the driver to
misinterpret VLAN objects added to the bridge master as objects added
to the ports.
Signed-of
The story here is basically:
1. Bridge port attributes should not be offloaded if an intermediate
stacked device (a LAG) is not offloaded. (5696c8aedfcc)
2. (1) broke VLAN filtering events from being processed by DSA, we
must accept that orig_dev can be the bridge itself. (99b8202b179f)
3.
This is the second attempt to provide a fix for the issue described in
99b8202b179f, which was reverted in the previous commit.
When a change is made to some global bridge attribute, such as VLAN
filtering, accept events where orig_dev is the bridge master netdev.
Separate the validation of orig_
On Fri, Mar 05, 2021 at 03:07:02PM -0800, Jakub Kicinski wrote:
> On Fri, 5 Mar 2021 16:15:51 +0530 Sunil Kovvuri wrote:
> > Hi,
> >
> > We have a requirement where in we want RSS hashing to be done on packet
> > fields
> > which are not currently supported by the ethtool.
> >
> > Current option
On Sat, Mar 06, 2021 at 12:21:59AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso wrote:
> > > If I understand correctly, the connection tracking netlink interface
> > > is an exception here because it has its own handling of dealing with
> > > congestion ("more reliable"?) so you need to disa
On Mon, Mar 1, 2021 at 2:44 AM Christoph Hellwig wrote:
>
> Hi all,
>
> there are a bunch of IOMMU APIs that are entirely unused, or only used as
> a private communication channel between the FSL PAMU driver and it's only
> consumer, the qbman portal driver.
>
> So this series drops a huge chunk o
Hi David!
Thanks for your answer. Currently kernel version that i use is
5.4.0-54-generic. I tried to upgrade to 5.11.3-051103-generic but that
didn't help.
пт, 5 мар. 2021 г. в 16:37, David Ahern :
>
> What kernel version? If you have not tried 5.10 or 5.11, please do.
On Thursday 04 March 2021 17:33:01 Sasha Levin wrote:
> On Thu, Feb 25, 2021 at 08:03:06PM +0100, Pali Rohár wrote:
> > On Wednesday 24 February 2021 07:49:34 Sasha Levin wrote:
> > > From: Pali Rohár
> > >
> > > [ Upstream commit f0b4f847673299577c29b71d3f3acd3c313d81b7 ]
> >
> > Hello! This co
Pablo Neira Ayuso wrote:
> > If I understand correctly, the connection tracking netlink interface
> > is an exception here because it has its own handling of dealing with
> > congestion ("more reliable"?) so you need to disable the "default
> > congestion control"?
>
> In conntrack, you have to c
On 3/5/21 5:15 PM, Willem de Bruijn wrote:
On Fri, Mar 5, 2021 at 11:10 AM Daniel Borkmann wrote:
On 3/5/21 4:08 PM, Willem de Bruijn wrote:
On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote:
From: Xuesen Huang
Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which
encapsulates
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 16:24:45 -0600 you wrote:
> Trim all 4 bytes of the received FCS; not just 2 of them. Leaving 2
> bytes of the FCS on the frame breaks DSA tailing tag drivers.
>
> Fixes: a8db76d40e4d ("lan743x: boost perfor
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Wed, 3 Mar 2021 16:29:03 +0100 you wrote:
> Currently, veth_xmit() would call the skb_record_rx_queue() only when
> there is XDP program loaded on peer interface in native mode.
>
> If peer has XDP prog in generic mode, then n
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 14:17:29 -0800 you wrote:
> netif_device_attach() will unpause the queues so we can't call
> it before __alx_open(). This went undetected until
> commit b0999223f224 ("alx: add ability to allocate and free
>
On Fri, 5 Mar 2021 16:15:51 +0530 Sunil Kovvuri wrote:
> Hi,
>
> We have a requirement where in we want RSS hashing to be done on packet fields
> which are not currently supported by the ethtool.
>
> Current options:
> ehtool -n rx-flow-hash
> tcp4|udp4|ah4|esp4|sctp4|tcp6|udp6|ah6|esp6|sctp6 m|
On 3/5/21 6:11 PM, Björn Töpel wrote:
On 2021-03-05 16:44, Daniel Borkmann wrote:
On 2/27/21 1:21 PM, Björn Töpel wrote:
[...]
diff --git a/include/linux/filter.h b/include/linux/filter.h
index 008691fd3b58..a7752badc2ec 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -646,1
On Fri, 5 Mar 2021 11:07:08 -0800 Don Bollinger wrote:
> Acknowledging your objections, I nonetheless request that optoe be accepted
> into upstream as an eeprom driver in drivers/misc/eeprom. It is a
> legitimate driver, with a legitimate user community, which deserves the
> benefits of being man
Vladimir Oltean writes:
> On Tue, Mar 02, 2021 at 04:40:55PM -0800, Vinicius Costa Gomes wrote:
>> Hi Vladimir,
>>
>> Vladimir Oltean writes:
>>
>> > Hi Vinicius,
>> >
>> > On Fri, Jan 22, 2021 at 02:44:46PM -0800, Vinicius Costa Gomes wrote:
>> >> Frame preemption (described in IEEE 802.3br-201
On Fri, Mar 05, 2021 at 12:48:12PM -0800, David Miller wrote:
>
> Please resubmit these again when net-next opens back up, thank you.
Sure thing.
Thanks
--
Gustavo
Dmitry Vyukov writes:
> On Fri, Sep 4, 2020 at 8:49 PM syzbot
> wrote:
>>
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:0f091e43 netlabel: remove unused param from audit_log_form..
>> git tree: net-next
>> console output: https://syzkaller.appspot.com/x/log.txt
Trim all 4 bytes of the received FCS; not just 2 of them. Leaving 2
bytes of the FCS on the frame breaks DSA tailing tag drivers.
Fixes: a8db76d40e4d ("lan743x: boost performance on cpu archs w/o dma cache
snooping")
Signed-off-by: George McCollister
---
drivers/net/ethernet/microchip/lan743x_m
On Fri, 5 Mar 2021 14:17:29 -0800 Jakub Kicinski wrote:
> netif_device_attach() will unpause the queues so we can't call
> it before __alx_open(). This went undetected until
> commit b0999223f224 ("alx: add ability to allocate and free
> alx_napi structures") but now if stack tries to xmit immedia
On Fri, 5 Mar 2021 13:50:28 +0100 Zbynek Michl wrote:
> On Thu, Mar 4, 2021 at 6:51 PM Jakub Kicinski wrote:
>
> > Depends if kernel attempts to try to send a packet before __alx_open()
> > finishes. You can probably make it more likely by running trafgen, iperf
> > or such while suspending and r
netif_device_attach() will unpause the queues so we can't call
it before __alx_open(). This went undetected until
commit b0999223f224 ("alx: add ability to allocate and free
alx_napi structures") but now if stack tries to xmit immediately
on resume before __alx_open() we'll crash on the NAPI being
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 4 Mar 2021 20:52:52 +0100 you wrote:
> From: Michael Braun
>
> When using jumbo packets and overrunning rx queue with napi enabled,
> the following sequence is observed in gfar_add_rx_frag:
>
>| lstatus
On 3/5/21 12:38 PM, Roman Gushchin wrote:
On Thu, Mar 04, 2021 at 08:03:33PM +0100, Jiri Olsa wrote:
hi,
I'm getting attached BUG/crash when running in parralel selftests, like:
while :; do ./test_progs -t spinlock; done
while :; do ./test_progs ; done
it's the latest bpf-next/master,
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 19:26:22 +0300 you wrote:
> "len > sp->mtu" checked twice in a row in sp_encaps().
> Remove the second check.
>
> Signed-off-by: Denis Efremov
> ---
> drivers/net/hamradio/6pack.c | 5 -
> 1 file chang
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 09:33:06 + you wrote:
> fix semicolon.cocci warning:
> tools/testing/selftests/net/ipsec.c:1788:2-3: Unneeded semicolon
>
> Signed-off-by: Xu Wang
> ---
> tools/testing/selftests/net/ipsec.c | 2 +-
>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 17:34:41 +0800 you wrote:
> The (0xBAF7 & 0x00FFF000) << 6 should be (0xf70 << 18).
>
> Fixes: 561535b0f239 ("r8169: fix OCP access on RTL8117")
> Signed-off-by: Hayes Wang
> ---
> drivers/net/ethernet/
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 4 Mar 2021 19:10:10 -0800 you wrote:
> When iavf_process_config() fails, no error return code of
> iavf_init_get_resources() is assigned.
> To fix this bug, err is assigned with the return value of
> iavf_process_config
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 16:48:39 +0800 you wrote:
> From: Junlin Yang
>
> ibmvnic_remove locks multiple spinlocks while disabling interrupts:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock_irqsave(&adapter->rwi_lock
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 13:49:30 +0800 you wrote:
> For Intel mGbE controller, MAC VLAN filter delete operation will time-out
> if serdes power-down sequence happened first during driver remove() with
> below message.
>
> [82294.76
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 14:03:42 +0800 you wrote:
> From: Wong Vee Khee
>
> Issue seen when enumerating multiple Intel mGbE interfaces in EHL.
>
> [6.898141] intel-eth-pci :00:1d.2: enabling device ( -> 0002)
> [6
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 4 Mar 2021 18:06:48 -0800 you wrote:
> When bdx_read_mac() fails, no error return code of bdx_probe()
> is assigned.
> To fix this bug, err is assigned with -EFAULT as error return code.
>
> Reported-by: TOTE Robot
>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 20:02:12 +0300 you wrote:
> RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row
> in niu_xmac_interrupt(). Remove the second addition.
>
> Signed-off-by: Denis Efremov
> ---
> I don't know the code
On 3/4/21 10:07 PM, Bjorn Andersson wrote:
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote:
In rmnet_map_ipv4_ul_csum_header() and rmnet_map_ipv6_ul_csum_header()
the offset within a packet at which checksumming should commence is
calculated. This calculation involves byte swapping and a forced
Hello,
syzbot found the following issue on:
HEAD commit:d310ec03 Merge tag 'perf-core-2021-02-17' of git://git.ker..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1532e4c6d0
kernel config: https://syzkaller.appspot.com/x/.config?x=66df2ca4f2dd3022
das
Please resubmit these again when net-next opens back up, thank you.
On 3/4/21 11:26 PM, Bjorn Andersson wrote:
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote:
Replace the use of C bit-fields in the rmnet_map_ul_csum_header
structure with a single two-byte (big endian) structure member,
and use field masks to encode or get values within it.
Previously rmnet_map
On Thu, Mar 04, 2021 at 08:03:33PM +0100, Jiri Olsa wrote:
> hi,
> I'm getting attached BUG/crash when running in parralel selftests, like:
>
> while :; do ./test_progs -t spinlock; done
> while :; do ./test_progs ; done
>
> it's the latest bpf-next/master, I can send the .config if needed,
>
On Fri, Mar 05, 2021 at 02:43:05PM -0500, Alexander Ahring Oder Aring wrote:
> Hi Pablo,
>
> I appreciate your very detailed response. Thank you.
>
> On Thu, Mar 4, 2021 at 10:04 PM Pablo Neira Ayuso wrote:
> >
> > Hi Alexander,
> >
> > On Thu, Mar 04, 2021 at 03:57:28PM -0500, Alexander Aring w
Hi Vladimir,
On 3/4/21 17:01, Vladimir Oltean wrote:
> Hi Gustavo,
>
> On Thu, Mar 04, 2021 at 04:53:18PM -0600, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> It's been more than 3 months; who can take this, please? :)
>>
>> Thanks
>> --
>> Gustavo
>>
>> On Fri, Nov 20, 2020 at 12:31:13PM -0600, Gu
Hi Pablo,
I appreciate your very detailed response. Thank you.
On Thu, Mar 4, 2021 at 10:04 PM Pablo Neira Ayuso wrote:
>
> Hi Alexander,
>
> On Thu, Mar 04, 2021 at 03:57:28PM -0500, Alexander Aring wrote:
> > This patch adds a note to the netlink manpage that if NETLINK_NO_ENOBUFS
> > is set t
On Thu, Feb 11, 2021 at 06:50:15PM +0100, AngeloGioacchino Del Regno wrote:
> MSM8998 support has been added: document the new compatible.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> dif
On Thu, Feb 11, 2021 at 06:50:14PM +0100, AngeloGioacchino Del Regno wrote:
> The driver supports SC7180, but the binding was not documented.
> Just add it.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +-
> 1 file changed,
On Mon, Mar 1, 2021 at 12:46 PM-0800, Andrew Lunn wrote:
> > To be more specific, optoe is only replacing the functionality of
> > drivers/net/phy/sfp.c, the functions of sfp_i2c_read() and
sfp_i2c_write().
> > These are the routines at the very bottom of the ethtool stack that
> > actually execute
Lijun Pan [lijunp...@gmail.com] wrote:
> On Fri, Mar 5, 2021 at 12:44 PM Sukadev Bhattiprolu
> wrote:
> >
> > Lijun Pan [l...@linux.ibm.com] wrote:
> > > The reset path will call ibmvnic_cleanup->ibmvnic_napi_disable
> > > ->napi_disable(). This is supposed to stop the polling.
> > > Commit 21ecba
On Fri, Mar 5, 2021 at 12:44 PM Sukadev Bhattiprolu
wrote:
>
> Lijun Pan [l...@linux.ibm.com] wrote:
> > The reset path will call ibmvnic_cleanup->ibmvnic_napi_disable
> > ->napi_disable(). This is supposed to stop the polling.
> > Commit 21ecba6c48f9 ("ibmvnic: Exit polling routine correctly
> >
Lijun Pan [l...@linux.ibm.com] wrote:
> The reset path will call ibmvnic_cleanup->ibmvnic_napi_disable
> ->napi_disable(). This is supposed to stop the polling.
> Commit 21ecba6c48f9 ("ibmvnic: Exit polling routine correctly
> during adapter reset") reported that the during device reset,
> polling
On Wed, 2 Oct 2019 09:38:55 -0700 Eric Dumazet wrote:
> This began with a syzbot report. syzkaller was injecting
> IPv6 TCP SYN packets having a v4mapped source address.
>
> After an unsuccessful 4-tuple lookup, TCP creates a request
> socket (SYN_RECV) and calls reqsk_queue_hash_req()
>
> reqsk
On 2021-03-05 16:44, Daniel Borkmann wrote:
On 2/27/21 1:21 PM, Björn Töpel wrote:
[...]
diff --git a/include/linux/filter.h b/include/linux/filter.h
index 008691fd3b58..a7752badc2ec 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -646,11 +646,20 @@ struct bpf_redirect_info {
On 2021-03-05 16:55, Daniel Borkmann wrote:
On 2/27/21 1:21 PM, Björn Töpel wrote:
[...]
Look good. Small nits inline I had originally fixed up locally before
glancing at 2/2:
diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index 4c730863fa77..3d3e89a37e62 100644
--- a/include/linux/b
On 3/5/21 07:40, Kalle Valo wrote:
> "Gustavo A. R. Silva" writes:
>
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
>> multiple warnings by replacing /* fall through */ comments with
>> the new pseudo-keyword macro fallthrough; instead of letting the
>> code fall through to
On Fri, Mar 5, 2021 at 3:05 AM Sergey Nazarov wrote:
>
> We need to use put_unaligned when writing 32-bit DOI value
> in cipso_v4_gentag_hdr to avoid unaligned memory access.
>
> v2: unneeded type cast removed as Ondrej Mosnacek suggested.
>
> Signed-off-by: Sergey Nazarov
> ---
> net/ipv4/cipso
From: Junlin Yang
ibmvnic_remove locks multiple spinlocks while disabling interrupts:
spin_lock_irqsave(&adapter->state_lock, flags);
spin_lock_irqsave(&adapter->rwi_lock, flags);
As reported by coccinelle, the second _irqsave() overwrites the value
saved in 'flags' by the first _irqsave(), th
On Fri, Mar 5, 2021 at 11:10 AM Daniel Borkmann wrote:
>
> On 3/5/21 4:08 PM, Willem de Bruijn wrote:
> > On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote:
> >>
> >> From: Xuesen Huang
> >>
> >> Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which
> >> encapsulates the ethernet as t
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Thu, 4 Mar 2021 14:40:46 +0800 you wrote:
> From: Xuesen Huang
>
> bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets
> encapsulation. But that is not appropriate when pushing Ethernet header.
>
>
On 3/5/21 4:08 PM, Willem de Bruijn wrote:
On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote:
From: Xuesen Huang
Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which
encapsulates the ethernet as the inner l2 header.
Update a vxlan encapsulation test case.
Signed-off-by: Xuesen
On 2/27/21 1:21 PM, Björn Töpel wrote:
[...]
Look good. Small nits inline I had originally fixed up locally before glancing
at 2/2:
diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index 4c730863fa77..3d3e89a37e62 100644
--- a/include/linux/bpf.h
+++ b/include/linux/bpf.h
@@ -118,6 +118,
On 2/27/21 1:21 PM, Björn Töpel wrote:
[...]
diff --git a/include/linux/filter.h b/include/linux/filter.h
index 008691fd3b58..a7752badc2ec 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -646,11 +646,20 @@ struct bpf_redirect_info {
u32 flags;
u32 tgt_index;
On 3/2/21 3:57 AM, Greesha Mikhalkin wrote:
> Hi. I need a help to understand why VRF leaking doesn’t work in my situation.
> I want to set up leaking between 2 VRFs, that are set up by following
> commands:
>
> # Setup bridge
> sudo ip link add bridge type bridge
>
> # Setup V
On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote:
>
> From: Xuesen Huang
>
> Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which
> encapsulates the ethernet as the inner l2 header.
>
> Update a vxlan encapsulation test case.
>
> Signed-off-by: Xuesen Huang
> Signed-off-by: Li Wang
RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row
in niu_xmac_interrupt(). Remove the second addition.
Signed-off-by: Denis Efremov
---
I don't know the code of the dirver, but this looks like a real bug.
Otherwise, it's more readable as:
mp->rx_bcasts += RXMAC_BC_FRM_CNT_COUNT * 2;
On 2021/03/04 0:29, Maciej Fijalkowski wrote:
Currently, veth_xmit() would call the skb_record_rx_queue() only when
there is XDP program loaded on peer interface in native mode.
If peer has XDP prog in generic mode, then netif_receive_generic_xdp()
has a call to netif_get_rxqueue(skb), so for mu
From: Junlin Yang
Fixes coccicheck warnings:
./drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:110:8-15:
WARNING opportunity for kmemdup
Signed-off-by: Junlin Yang
---
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/w
From: Junlin Yang
Fixes coccicheck warnings:
./drivers/net/ethernet/freescale/ucc_geth.c:3594:11-18:
WARNING opportunity for kmemdup
Signed-off-by: Junlin Yang
---
drivers/net/ethernet/freescale/ucc_geth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethern
"len > sp->mtu" checked twice in a row in sp_encaps().
Remove the second check.
Signed-off-by: Denis Efremov
---
drivers/net/hamradio/6pack.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 71d6629e65c9..9f5b5614a150 10064
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net
for vDPA.
C5000X-PL vendor id 0x1AF4, device id 0x1000,
subvendor id 0x8086, sub device id 0x0001
To distinguish C5000X-PL from other ifcvf driven devices,
the original ifcvf device is named "N3000".
Signed-off-by: Zhu Lingshan
---
dr
This commit bumps ifcvf driver version string to 1.0
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index fd5befc5cbcc..56a0974cf93c 100644
--- a
In this commit, ifcvf_get_vendor_id() will return
a device specific vendor id of the probed pci device
than a hard code.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drive
This series enabled Intel FGPA SmartNIC C5000X-PL virtio-net
for vDPA
Zhu Lingshan (3):
vDPA/ifcvf: get_vendor_id returns a device specific vendor id
vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA
vDPA/ifcvf: bump version string to 1.0
drivers/vdpa/ifcvf/ifcvf_base.h | 13 +
Hello,
syzbot found the following issue on:
HEAD commit:fe07bfda Linux 5.12-rc1
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=12020056d0
kernel config: https://syzkaller.appspot.com/x/
Björn Töpel writes:
> This two-patch series introduces load-acquire/store-release barriers
> for the AF_XDP rings.
>
> For most contemporary architectures, this is more effective than a
> SPSC ring based on smp_{r,w,}mb() barriers. More importantly,
> load-acquire/store-release semantics make the
When testing uprobes we the test gets GEP (Global Entry Point)
address from kallsyms, but then the function is called locally
so the uprobe is not triggered.
Fixing this by adjusting the address to LEP (Local Entry Point)
for powerpc arch plus instruction check stolen from ppc_function_entry
funct
"Gustavo A. R. Silva" writes:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> multiple warnings by replacing /* fall through */ comments with
> the new pseudo-keyword macro fallthrough; instead of letting the
> code fall through to the next case.
>
> Notice that Clang doesn't r
On Thu, Mar 04, 2021 at 07:04:59AM +0530, Naveen N. Rao wrote:
SNIP
> > > static inline unsigned long ppc_function_entry(void *func)
> > > {
> > > #ifdef PPC64_ELF_ABI_v2
> > > u32 *insn = func;
> > >
> > > /*
> > >* A PPC64 ABIv2 function may have a local and a global entry
> > >* p
From: Di Zhu
I use the similar test method described in link below with KASAN enabled:
https://lore.kernel.org/netdev/4c5e467e07fb410ab4135b391d663...@huawei.com/
soon after, KASAN reports:
[ 9041.977110]
==
[ 9041.977151] BUG: KASA
t; https://github.com/0day-ci/linux/commits/Alex-Elder/net-qualcomm-rmnet-stop-using-C-bit-fields/20210305-064128
> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> d310ec03a34e92a77302edb804f7d68ee4f01ba0
> config: riscv-randconfig-s031-20210305 (attached as
On Thu, Mar 4, 2021 at 6:51 PM Jakub Kicinski wrote:
> Depends if kernel attempts to try to send a packet before __alx_open()
> finishes. You can probably make it more likely by running trafgen, iperf
> or such while suspending and resuming?
I've tried "ping -f " first, but there was no effect -
The iavf watchdog task overrides adapter->state to __IAVF_RESETTING
when it detects a pending reset. Then schedules iavf_reset_task() which
takes care of the reset.
The reset task is capable of handling the reset without changing
adapter->state. In fact we lose the state information when the watch
From: Marek Vasut
[ Upstream commit 287431463e786766e05e4dc26d0a11d5f8ac8815 ]
The interrupt handling of the RS911x is particularly heavy. For each RX
packet, the card does three SDIO transactions, one to read interrupt
status register, one to RX buffer length, one to read the RX packet(s).
This
1 - 100 of 152 matches
Mail list logo
