On Fri, 5 Mar 2021 13:50:28 +0100 Zbynek Michl wrote:
> On Thu, Mar 4, 2021 at 6:51 PM Jakub Kicinski <k...@kernel.org> wrote:
> 
> > Depends if kernel attempts to try to send a packet before __alx_open()
> > finishes. You can probably make it more likely by running trafgen, iperf
> > or such while suspending and resuming?  
> 
> I've tried "ping -f <GW>" first, but there was no effect - PC woke up
> successfully.
> 
> Then I've tried TCP connection, like "wget -O /dev/null
> https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-5.11.3.tar.xz"; and
> this kills the kernel on resume reliably.
> 
> So perphaps ICMP and TCP behave differently?
> 
> Anyway, I'm happy to be able to finally enforce the kernel crash this way :)
> 
> > I didn't look too closely to find out if things indeed worked 100%
> > correctly before, but now they will reliably crash on a NULL pointer
> > dereference if transmission comes before open is done.  
> 
> I can confirm that the fix really works and I cannot enforce the
> kernel crash anymore.
> 
> So can we merge the patch to the mainline, and ideally also to the 5.10?

Great, I submitted the patch and marked it for stable inclusion!

It should percolate through the trees in a couple of weeks.

Reply via email to