Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support injecting virtqueue's interrupt to the specified cpu. How userspace know which CPU is this irq for? It looks to me we need to do it at different level. E.g introduce some API in sys to all

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces a workqueue to support injecting virtqueue's interrupt asynchronously. This is mainly for performance considerations which makes sure the push() and pop() for used vring can be asynchronous. Do you have pref numbers for this patch

[PATCH] selftests_bpf: extend test_tc_tunnel test with vxlan

2021-03-03 Thread Xuesen Huang
From: Xuesen Huang Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which encapsulates the ethernet as the inner l2 header. Update a vxlan encapsulation test case. Signed-off-by: Xuesen Huang Signed-off-by: Li Wang Signed-off-by: Willem de Bruijn --- tools/testing/selftests/bpf/pr

Re: [RFC v4 09/11] Documentation: Add documentation for VDUSE

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: VDUSE (vDPA Device in Userspace) is a framework to support implementing software-emulated vDPA devices in userspace. This document is intended to clarify the VDUSE design and usage. Signed-off-by: Xie Yongji --- Documentation/userspace-api/index.rst |

[PATCH/v5] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-03 Thread Xuesen Huang
From: Xuesen Huang bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets encapsulation. But that is not appropriate when pushing Ethernet header. Add an option to further specify encap L2 type and set the inner_protocol as ETH_P_TEB. Suggested-by: Willem de Bruijn Signed-off

Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the control path, the VDUSE driver will make use of message mechnism to forward the config opera

Re: [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk

2021-03-03 Thread Kai-Heng Feng
On Sat, Feb 27, 2021 at 2:17 AM Bjorn Helgaas wrote: > > On Fri, Feb 26, 2021 at 02:31:31PM +0100, Heiner Kallweit wrote: > > On 26.02.2021 13:18, Kai-Heng Feng wrote: > > > On Fri, Feb 26, 2021 at 8:10 PM Heiner Kallweit > > > wrote: > > >> > > >> On 26.02.2021 08:12, Kalle Valo wrote: > > >>>

[PATCH] net: sctp: trivial: fix typo in comment

2021-03-03 Thread Drew Fustini
Fix typo of 'overflow' for comment in sctp_tsnmap_check(). Reported-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- net/sctp/tsnmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/tsnmap.c b/net/sctp/tsnmap.c index a9c6af5795d8..5ba456727f63 100644 --- a/n

Re: Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Yongji Xie
On Thu, Mar 4, 2021 at 11:07 AM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This patch introduces an attribute for vDPA device to indicate > > whether virtual address can be used. If vDPA device driver set > > it, vhost-vdpa bus driver will not pin user page and transfer >

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-03 Thread Yongji Xie
On Thu, Mar 4, 2021 at 12:21 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This implements a MMU-based IOMMU driver to support mapping > > kernel dma buffer into userspace. The basic idea behind it is > > treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set > > u

Re: general protection fault in crypto_destroy_tfm

2021-03-03 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:d310ec03 Merge tag 'perf-core-2021-02-17' of git://git.ker.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=13e7a292d0 kernel config: https://syzkaller.appspot.com/x/.config?x=2b83073

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This implements a MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set up MMU mapping instead of IOMMU mapping for the DMA transfer so that t

Re: [PATCH/v4] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-03 Thread Willem de Bruijn
> > Instead of untyped macros, I'd define encap_ipv4 as a function that > > calls __encap_ipv4. > > > > And no need for encap_ipv4_with_ext_proto equivalent to __encap_ipv4. > > > I defined these macros to try to keep the existing invocation for > encap_ipv4/6 > as the same, if we define this as

[PATCH] gianfar: fix jumbo packets+napi+rx overrun crash

2021-03-03 Thread michael-dev
From: Michael Braun When using jumbo packets and overrunning rx queue with napi enabled, the following sequence is observed in gfar_add_rx_frag: | lstatus | | skb | t | lstatus, size, flags| first | len, data_len, *ptr |

Re: [PATCH/v4] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-03 Thread Xuesen Huang
> 2021年3月4日 上午2:53,Willem de Bruijn 写道: > > On Wed, Mar 3, 2021 at 7:33 AM Xuesen Huang wrote: >> >> From: Xuesen Huang >> >> bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets >> encapsulation. But that is not appropriate when pushing Ethernet header. >> >> Add an o

linux-next: Fixes tag needs some work in the net tree

2021-03-03 Thread Stephen Rothwell
Hi all, In commit b12422362ce9 ("net: macb: Add default usrio config to default gem config") Fixes tag Fixes: edac63861db7 ("add userio bits as platform configuration") has these problem(s): - Subject does not match target commit subject Just use git log -1 --format='Fixes:

Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Jason Wang
On 2021/2/23 7:50 下午, Xie Yongji wrote: This patch introduces an attribute for vDPA device to indicate whether virtual address can be used. If vDPA device driver set it, vhost-vdpa bus driver will not pin user page and transfer userspace virtual address instead of physical address during DMA ma

Re: [PATCH v2] net: 9p: advance iov on empty read

2021-03-03 Thread asmadeus
patchwork-bot+netdev...@kernel.org wrote on Thu, Mar 04, 2021 at 01:10:07AM +: > This patch was applied to netdev/net.git thanks for taking the patch, I didn't take the time to reply yesterday after my bisect finally finished. I've got the culprit now, could you add the following? Signed-

[PATCH v1 2/3] i40e: use minimal rx and tx ring buffers for kdump

2021-03-03 Thread Coiby Xu
Use the minimum of the number of descriptors thus we will allocate the minimal ring buffers for kdump. Signed-off-by: Coiby Xu --- drivers/net/ethernet/intel/i40e/i40e_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ether

[PATCH v1 3/3] i40e: use minimal admin queue for kdump

2021-03-03 Thread Coiby Xu
The minimum size of admin send/receive queue is 1 and 2 respectively. The admin send queue can't be set to 1 because in that case, the firmware would fail to init. Signed-off-by: Coiby Xu --- drivers/net/ethernet/intel/i40e/i40e.h | 2 ++ drivers/net/ethernet/intel/i40e/i40e_main.c | 9

[PATCH v1 0/3] Reducing memory usage of i40e for kdump

2021-03-03 Thread Coiby Xu
Currently, i40e consumes lots of memory and causes the failure of kdump. After reducing the allocation of tx/rx/arg/asq ring buffers to the minimum, the memory consumption is significantly reduced, - x86_64: 85.1MB to 1.2MB - POWER9: 15368.5MB to 20.8MB After applying this patch set, we

[PATCH v1 1/3] i40e: use minimal tx and rx pairs for kdump

2021-03-03 Thread Coiby Xu
Set the number of the MSI-X vectors to 1. When MSI-X is enabled, it's not allowed to use more TC queue pairs than MSI-X vectors (pf->num_lan_msix) exist. Thus the number of tx and rx pairs (vsi->num_queue_pairs) will be equal to the number of MSI-X vectors, i.e., 1. Signed-off-by: Coiby Xu --- d

Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-03 Thread Alexander Duyck
On Wed, Mar 3, 2021 at 4:07 PM Jakub Kicinski wrote: > > On Wed, 3 Mar 2021 13:35:53 -0800 Alexander Duyck wrote: > > On Tue, Mar 2, 2021 at 1:37 PM Eric Dumazet wrote: > > > On Tue, Mar 2, 2021 at 7:08 AM Jakub Kicinski wrote: > > > > When receiver does not accept TCP Fast Open it will only ack

Re: [PATCH] net: mac802154: Fix null pointer dereference

2021-03-03 Thread Alexander Aring
Hi, On Wed, 3 Mar 2021 at 11:28, Pavel Skripkin wrote: > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > It was caused by wrong clean up loop in llsec_key_alloc(). > If one of the tfm array members won't be initialized it will cause > NULL dereference in crypto_destroy_tfm()

Re: [PATCH] rtnetlink: using dev_base_seq from target net

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 18:16:07 +0800 you wrote: > Signed-off-by: zhang kai > --- > net/core/rtnetlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - rtnetlink: using dev_base_seq f

Re: [PATCH v2] net: 9p: advance iov on empty read

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 17:19:32 +0800 you wrote: > I met below warning when cating a small size(about 80bytes) txt file > on 9pfs(msize=2097152 is passed to 9p mount option), the reason is we > miss iov_iter_advance() if the read co

[PATCH net 1/3] net: ethernet: ixgbe: don't propagate -ENODEV from ixgbe_mii_bus_init()

2021-03-03 Thread Tony Nguyen
From: Bartosz Golaszewski It's a valid use-case for ixgbe_mii_bus_init() to return -ENODEV - we still want to finalize the registration of the ixgbe device. Check the error code and don't bail out if err == -ENODEV. This fixes an issue on C3000 family of SoCs where four ixgbe devices share a sin

[PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2021-03-03

2021-03-03 Thread Tony Nguyen
This series contains updates to ixgbe and ixgbevf drivers. Bartosz Golaszewski does not error on -ENODEV from ixgbe_mii_bus_init() as this is valid for some devices with a shared bus for ixgbe. Antony Antony adds a check to fail for non transport mode SA with offload as this is not supported for

[PATCH net 2/3] ixgbe: fail to create xfrm offload of IPsec tunnel mode SA

2021-03-03 Thread Tony Nguyen
From: Antony Antony Based on talks and indirect references ixgbe IPsec offlod do not support IPsec tunnel mode offload. It can only support IPsec transport mode offload. Now explicitly fail when creating non transport mode SA with offload to avoid false performance expectations. Fixes: 63a67fe22

Re: [PATCH v4] net: macb: Add default usrio config to default gem config

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Mar 2021 11:55:49 -0800 you wrote: > There is no usrio config defined for default gem config leading to > a kernel panic devices that don't define a data. This issue can be > reprdouced with microchip polar fire soc w

[PATCH net 3/3] ixgbe: Fix memleak in ixgbe_configure_clsu32

2021-03-03 Thread Tony Nguyen
From: Dinghao Liu When ixgbe_fdir_write_perfect_filter_82599() fails, input allocated by kzalloc() has not been freed, which leads to memleak. Signed-off-by: Dinghao Liu Reviewed-by: Paul Menzel Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_

Re: [PATCH net] Revert "r8152: adjust the settings about MAC clock speed down for RTL8153"

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Mar 2021 16:39:47 +0800 you wrote: > This reverts commit 134f98bcf1b898fb9d6f2b91bc85dd2e5478b4b8. > > The r8153_mac_clk_spd() is used for RTL8153A only, because the register > table of RTL8153B is different from RTL8

Re: [PATCH net v2] net: l2tp: reduce log level of messages in receive path, add counter instead

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Mar 2021 16:50:49 +0100 you wrote: > Commit 5ee759cda51b ("l2tp: use standard API for warning log messages") > changed a number of warnings about invalid packets in the receive path > so that they are always shown, in

Re: pull-request: wireless-drivers-2021-03-03

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Wed, 3 Mar 2021 17:26:32 + (UTC) you wrote: > Hi, > > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. > > Kalle > > [...] Here is the summary with links:

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-03 Thread Michael Ellerman
"Naveen N. Rao" writes: > On 2021/03/02 11:35AM, Jiri Olsa wrote: >> On Mon, Mar 01, 2021 at 02:58:53PM -0800, Yonghong Song wrote: >> > >> > >> > On 3/1/21 11:04 AM, Jiri Olsa wrote: >> > > When testing uprobes we the test gets GEP (Global Entry Point) >> > > address from kallsyms, but then the

seqlock lockdep false positives?

2021-03-03 Thread Jakub Kicinski
Hi Ahmed! Erhard is reporting a lockdep splat in drivers/net/ethernet/realtek/8139too.c https://bugzilla.kernel.org/show_bug.cgi?id=211575 I can't quite grasp how that happens it looks like it's the Rx lock/syncp on one side and the Tx lock on the other side :S

Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-03 Thread Jakub Kicinski
On Wed, 3 Mar 2021 13:35:53 -0800 Alexander Duyck wrote: > On Tue, Mar 2, 2021 at 1:37 PM Eric Dumazet wrote: > > On Tue, Mar 2, 2021 at 7:08 AM Jakub Kicinski wrote: > > > When receiver does not accept TCP Fast Open it will only ack > > > the SYN, and not the data. We detect this and immediate

Re: [PATCH net v2] net: l2tp: reduce log level of messages in receive path, add counter instead

2021-03-03 Thread Tom Parkin
On Wed, Mar 03, 2021 at 16:50:49 +0100, Matthias Schiffer wrote: > Commit 5ee759cda51b ("l2tp: use standard API for warning log messages") > changed a number of warnings about invalid packets in the receive path > so that they are always shown, instead of only when a special L2TP debug > flag is s

linux-next: manual merge of the ipsec tree with the net tree

2021-03-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the ipsec tree got conflicts in: net/ipv4/ip_vti.c net/ipv6/ip6_vti.c between commit: 4372339efc06 ("net: always use icmp{,v6}_ndo_send from ndo_start_xmit") from the net tree and commits: c7c1abfd6d42 ("vti: fix ipv4 pmtu check to honor ip header d

Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete

2021-03-03 Thread Marc Kleine-Budde
On 02.03.2021 13:24:23, Martin Willi wrote: > When a non-initial netns is destroyed, the usual policy is to delete > all virtual network interfaces contained, but move physical interfaces > back to the initial netns. This keeps the physical interface visible > on the system. > > CAN devices are so

Re: [RFC PATCH net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data

2021-03-03 Thread Andrew Lunn
> > > + * struct ethtool_eeprom_data - EEPROM dump from specified page > > > + * @offset: Offset within the specified EEPROM page to begin read, in > > > bytes. > > > + * @length: Number of bytes to read. On successful return, number of > > > bytes > > > + * actually read. > > > + * @page:

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-03-03 Thread Xie He
On Wed, Mar 3, 2021 at 5:26 AM Martin Schiller wrote: > > On 2021-03-03 00:30, Jakub Kicinski wrote: > > > > Hard question to answer, existing users seem happy and Xie's driver > > isn't upstream, so the justification for potentially breaking backward > > compatibility isn't exactly "strong". > >

[PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Paul E. McKenney
drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() The following build error is emitted by rcutorture builds of v5.12-rc1: drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined but not used [-Wunused-function] drivers/net/phy/phy_device.c:273:12: warning:

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-03 Thread Naveen N. Rao
On 2021/03/02 09:19AM, Yonghong Song wrote: > > > On 3/2/21 3:14 AM, Jiri Olsa wrote: > > On Mon, Mar 01, 2021 at 04:34:24PM -0800, Andrii Nakryiko wrote: > > > On Mon, Mar 1, 2021 at 11:11 AM Jiri Olsa wrote: > > > > > > > > When testing uprobes we the test gets GEP (Global Entry Point) > > >

Re: KASAN: use-after-free Write in cipso_v4_doi_putdef

2021-03-03 Thread Paul Moore
On Wed, Mar 3, 2021 at 11:20 AM Paul Moore wrote: > On Wed, Mar 3, 2021 at 10:53 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:7a7fd0de Merge branch 'kmap-conversion-for-5.12' of git://.. > > git tree: upstream > > console output: htt

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-03 Thread Jiri Olsa
On Wed, Mar 03, 2021 at 12:10:43PM +0530, Naveen N. Rao wrote: > On 2021/03/02 11:35AM, Jiri Olsa wrote: > > On Mon, Mar 01, 2021 at 02:58:53PM -0800, Yonghong Song wrote: > > > > > > > > > On 3/1/21 11:04 AM, Jiri Olsa wrote: > > > > When testing uprobes we the test gets GEP (Global Entry Point)

Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-03 Thread Alexander Duyck
On Tue, Mar 2, 2021 at 1:37 PM Eric Dumazet wrote: > > On Tue, Mar 2, 2021 at 7:08 AM Jakub Kicinski wrote: > > > > When receiver does not accept TCP Fast Open it will only ack > > the SYN, and not the data. We detect this and immediately queue > > the data for (re)transmission in tcp_rcv_fastope

Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete,Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete

2021-03-03 Thread Marc Kleine-Budde
On 03.03.2021 13:12:31, David Miller wrote: > From: Marc Kleine-Budde > Date: Wed, 3 Mar 2021 21:29:39 +0100 > > > Acked-by: Marc Kleine-Budde > > > > David, Jakub are you taking this patch? > > Nope, please take via the can tree, thanks! Will do. Thanks, Marc -- Pengutronix e.K.

Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete,Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete

2021-03-03 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 3 Mar 2021 21:29:39 +0100 > Acked-by: Marc Kleine-Budde > > David, Jakub are you taking this patch? Nope, please take via the can tree, thanks!

Re: [PATCH] Bluetooth: Allow scannable adv with extended MGMT APIs

2021-03-03 Thread Marcel Holtmann
Hi Daniel, > An issue was found, where if a bluetooth client requests a broadcast > advertisement with scan response data, it will not be properly > registered with the controller. This is because at the time that the > hci_cp_le_set_scan_param structure is created, the scan response will > not ye

Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete

2021-03-03 Thread Marc Kleine-Budde
On 3/2/21 1:24 PM, Martin Willi wrote: > When a non-initial netns is destroyed, the usual policy is to delete > all virtual network interfaces contained, but move physical interfaces > back to the initial netns. This keeps the physical interface visible > on the system. > > CAN devices are somewha

[PATCH v4] net: macb: Add default usrio config to default gem config

2021-03-03 Thread Atish Patra
There is no usrio config defined for default gem config leading to a kernel panic devices that don't define a data. This issue can be reprdouced with microchip polar fire soc where compatible string is defined as "cdns,macb". Fixes: edac63861db7 ("add userio bits as platform configuration") Signe

Re: [RFC PATCH 2/12] x86/Hyper-V: Add new hvcall guest address host visibility support

2021-03-03 Thread Vitaly Kuznetsov
Tianyu Lan writes: > From: Tianyu Lan > > Add new hvcall guest address host visibility support. Mark vmbus > ring buffer visible to host when create gpadl buffer and mark back > to not visible when tear down gpadl buffer. > > Signed-off-by: Sunil Muthuswamy > Co-Developed-by: Sunil Muthuswamy

Re: [PATCH/v4] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-03 Thread Willem de Bruijn
On Wed, Mar 3, 2021 at 7:33 AM Xuesen Huang wrote: > > From: Xuesen Huang > > bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets > encapsulation. But that is not appropriate when pushing Ethernet header. > > Add an option to further specify encap L2 type and set the inner_pr

Re: [Patch bpf-next v2 8/9] sock_map: update sock type checks for UDP

2021-03-03 Thread Yonghong Song
On 3/3/21 10:02 AM, Cong Wang wrote: On Tue, Mar 2, 2021 at 10:37 PM Yonghong Song wrote: On 3/1/21 6:37 PM, Cong Wang wrote: From: Cong Wang Now UDP supports sockmap and redirection, we can safely update the sock type checks for it accordingly. Cc: John Fastabend Cc: Daniel Borkmann

Re: [Intel-wired-lan] [PATCH intel-net 0/3] intel: Rx headroom fixes

2021-03-03 Thread Jesse Brandeburg
Maciej Fijalkowski wrote: > Fix Rx headroom by calling *_rx_offset() after the build_skb Rx ring > flag is set. > > It was reported by Jesper in [0] that XDP_REDIRECT stopped working after > [1] patch in i40e. Looks good to me, thanks for the fixes Maciej, and especially to Jesper for the report

Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 06:04:22PM +, Russell King - ARM Linux admin wrote: > On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote: > > drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() > > > > The following build error is emitted by rcutorture builds of v5.12-r

Re: [Patch bpf-next v2 2/9] sock: introduce sk_prot->update_proto()

2021-03-03 Thread Cong Wang
On Wed, Mar 3, 2021 at 1:35 AM Lorenz Bauer wrote: > > On Tue, 2 Mar 2021 at 18:23, Cong Wang wrote: > > > > > if the function returned a struct proto * like it does at the moment. > > > That way we keep sk->sk_prot manipulation confined to the sockmap code > > > and don't have to copy paste it i

Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Russell King - ARM Linux admin
On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote: > drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() > > The following build error is emitted by rcutorture builds of v5.12-rc1: > > drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined >

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-03 Thread Naveen N. Rao
On 2021/03/02 11:35AM, Jiri Olsa wrote: > On Mon, Mar 01, 2021 at 02:58:53PM -0800, Yonghong Song wrote: > > > > > > On 3/1/21 11:04 AM, Jiri Olsa wrote: > > > When testing uprobes we the test gets GEP (Global Entry Point) > > > address from kallsyms, but then the function is called locally > > >

Re: [Patch bpf-next v2 8/9] sock_map: update sock type checks for UDP

2021-03-03 Thread Cong Wang
On Tue, Mar 2, 2021 at 10:37 PM Yonghong Song wrote: > > > > On 3/1/21 6:37 PM, Cong Wang wrote: > > From: Cong Wang > > > > Now UDP supports sockmap and redirection, we can safely update > > the sock type checks for it accordingly. > > > > Cc: John Fastabend > > Cc: Daniel Borkmann > > Cc: Jak

pull-request: wireless-drivers-2021-03-03

2021-03-03 Thread Kalle Valo
Hi, here's a pull request to net tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit c490492f15f656340b35cb9e36b9bfdea3539e19: mt76: mt7915: fix unused 'mode' variable (2021-02-26 17:35:15 +0200) are available in the git repository at

Re: [PATCH net] docs: networking: drop special stable handling

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 18:46:43 -0800 you wrote: > Leave it to Greg. > > Signed-off-by: Jakub Kicinski > --- > Documentation/networking/netdev-FAQ.rst | 72 ++- > Documentation/process/stable-kernel-rules.r

Re: [PATCH net 1/1] net: stmmac: fix incorrect DMA channel intr enable setting of EQoS v4.10

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Mar 2021 20:38:40 +0530 you wrote: > From: Ong Boon Leong > > We introduce dwmac410_dma_init_channel() here for both EQoS v4.10 and > above which use different DMA_CH(n)_Interrupt_Enable bit definitions for > NIE an

Re: [PATCH v3 1/1] Bluetooth: Remove unneeded commands for suspend

2021-03-03 Thread Marcel Holtmann
Hi Abhishek, > During suspend, there are a few scan enable and set event filter > commands that don't need to be sent unless there are actual BR/EDR > devices capable of waking the system. Check the HCI_PSCAN bit before > writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED > to

Re: [PATCH] ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 20:47:47 +0100 you wrote: > GCC 7.5 reports: > ../drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset_init': > ../drivers/net/ethernet/ibm/ibmvnic.c:5373:51: warning: 'old_num_tx_queues' > may be

Re: [PATCH net] octeontx2-af: cn10k: fix an array overflow in is_lmac_valid()

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 14:21:54 +0300 you wrote: > The value of "lmac_id" can be controlled by the user and if it is larger > then the number of bits in long then it reads outside the bitmap. > The highest valid value is less than M

Re: [PATCH bpf-next 2/2] libbpf, xsk: add libbpf_smp_store_release libbpf_smp_load_acquire

2021-03-03 Thread Björn Töpel
On 2021-03-03 16:39, Will Deacon wrote: On Tue, Mar 02, 2021 at 10:13:21AM +0100, Daniel Borkmann wrote: [...] Would also be great to get Will's ACK on that when you have a v2. :) Please stick me on CC for that and I'll take a look as I've forgotten pretty much everything about this since

[PATCH v3 1/1] Bluetooth: Remove unneeded commands for suspend

2021-03-03 Thread Abhishek Pandit-Subedi
During suspend, there are a few scan enable and set event filter commands that don't need to be sent unless there are actual BR/EDR devices capable of waking the system. Check the HCI_PSCAN bit before writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED to control whether to clea

[PATCH v3 0/1] Bluetooth: Suspend improvements

2021-03-03 Thread Abhishek Pandit-Subedi
Hi Marcel (and linux bluetooth), Here are a few suspend improvements based on user reports we saw on ChromeOS and feedback from Hans de Goede on the mailing list. I have tested this using our ChromeOS suspend/resume automated tests (full SRHealth test coverage and some suspend resume stress tes

Re: [RFC PATCH 1/12] x86/Hyper-V: Add visibility parameter for vmbus_establish_gpadl()

2021-03-03 Thread Vitaly Kuznetsov
Tianyu Lan writes: > From: Tianyu Lan > > Add visibility parameter for vmbus_establish_gpadl() and prepare > to change host visibility when create gpadl for buffer. > "No functional change" as you don't actually use the parameter. > Signed-off-by: Sunil Muthuswamy > Co-Developed-by: Sunil Mut

[PATCH] net: mac802154: Fix null pointer dereference

2021-03-03 Thread Pavel Skripkin
syzbot found general protection fault in crypto_destroy_tfm()[1]. It was caused by wrong clean up loop in llsec_key_alloc(). If one of the tfm array members won't be initialized it will cause NULL dereference in crypto_destroy_tfm(). Call Trace: crypto_free_aead include/crypto/aead.h:191 [inline]

Re: [RFC PATCH net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data

2021-03-03 Thread Vladyslav Tarasiuk
On 28-Feb-21 02:45, Andrew Lunn wrote: On Wed, Feb 24, 2021 at 05:41:10PM +0200, Moshe Shemesh wrote: From: Vladyslav Tarasiuk Define get_module_eeprom_data_by_page() ethtool callback and implement netlink infrastructure. get_module_eeprom_data_by_page() allows network drivers to dump a par

Re: KASAN: use-after-free Write in cipso_v4_doi_putdef

2021-03-03 Thread Paul Moore
On Wed, Mar 3, 2021 at 10:53 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:7a7fd0de Merge branch 'kmap-conversion-for-5.12' of git://.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=164a74dad0 > kernel config:

Re: [PATCH] iwlwifi: ensure that DMI scan table is properly terminated

2021-03-03 Thread Kalle Valo
Jens Axboe writes: > On 3/2/21 8:49 PM, Jens Axboe wrote: >> On 3/2/21 11:34 AM, Coelho, Luciano wrote: >> >>> Thanks for the report and patch! And I'm sorry that we broke your >>> laptop's boot... >>> >>> We already have a patch to fix this: >>> >>> https://patchwork.kernel.org/project/linux-wir

Re: [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues

2021-03-03 Thread Pablo Neira Ayuso
Hi, On Wed, Mar 03, 2021 at 02:59:53PM +0200, Oz Shlomo wrote: > Currently the flow table offload replace, destroy and stats work items are > executed on a single workqueue. As such, DESTROY and STATS commands may > be backloged after a burst of REPLACE work items. This scenario can bloat > up mem

Re: [PATCH] selftests/bpf: Simplify the calculation of variables

2021-03-03 Thread Yonghong Song
On 3/2/21 11:52 PM, Jiapeng Chong wrote: Fix the following coccicheck warnings: ./tools/testing/selftests/bpf/test_sockmap.c:735:35-37: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Acked-by: Yonghong Song

Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings

2021-03-03 Thread Kalle Valo
Pierre-Louis Bossart wrote: > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > Signed-off-by: Pierre-Louis Bossart > Acked-by: Luca Coelho Patch applied to wireless-drivers.git, thanks. 436

[PATCH v4] net: phy: add Marvell 88X2222 transceiver support

2021-03-03 Thread Ivan Bornyakov
Add basic support for the Marvell 88X multi-speed ethernet transceiver. This PHY provides data transmission over fiber-optic as well as Twinax copper links. The 88X supports 2 ports of 10GBase-R and 1000Base-X on the line-side interface. The host-side interface supports 4 ports of 10GBase-

Re: iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-03-03 Thread Kalle Valo
Wei Yongjun wrote: > Make sure dmi_system_id tables are NULL terminated. This crashed when LTO was > enabled: > > BUG: KASAN: global-out-of-bounds in dmi_check_system+0x5a/0x70 > Read of size 1 at addr c16af750 by task NetworkManager/1913 > > CPU: 4 PID: 1913 Comm: NetworkManager Not t

KASAN: use-after-free Write in cipso_v4_doi_putdef

2021-03-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7a7fd0de Merge branch 'kmap-conversion-for-5.12' of git://.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=164a74dad0 kernel config: https://syzkaller.appspot.com/x/.config?x=779a2568b654c1c6 das

[PATCH bpf] veth: store queue_mapping independently of XDP prog presence

2021-03-03 Thread Maciej Fijalkowski
Currently, veth_xmit() would call the skb_record_rx_queue() only when there is XDP program loaded on peer interface in native mode. If peer has XDP prog in generic mode, then netif_receive_generic_xdp() has a call to netif_get_rxqueue(skb), so for multi-queue veth it will not be possible to grab a

[PATCH intel-net 1/3] i40e: move headroom initialization to i40e_configure_rx_ring

2021-03-03 Thread Maciej Fijalkowski
i40e_rx_offset(), that is supposed to initialize the Rx buffer headroom, relies on I40E_RXR_FLAGS_BUILD_SKB_ENABLED flag. Currently, the callsite of mentioned function is placed incorrectly within i40e_setup_rx_descriptors() where Rx ring's build skb flag is not set yet. This causes the XDP_REDIRE

[PATCH intel-net 3/3] ixgbe: move headroom initialization to ixgbe_configure_rx_ring

2021-03-03 Thread Maciej Fijalkowski
ixgbe_rx_offset(), that is supposed to initialize the Rx buffer headroom, relies on __IXGBE_RX_BUILD_SKB_ENABLED flag. Currently, the callsite of mentioned function is placed incorrectly within ixgbe_setup_rx_resources() where Rx ring's build skb flag is not set yet. This causes the XDP_REDIRECT t

[PATCH net v2] net: l2tp: reduce log level of messages in receive path, add counter instead

2021-03-03 Thread Matthias Schiffer
Commit 5ee759cda51b ("l2tp: use standard API for warning log messages") changed a number of warnings about invalid packets in the receive path so that they are always shown, instead of only when a special L2TP debug flag is set. Even with rate limiting these warnings can easily cause significant lo

[PATCH intel-net 2/3] ice: move headroom initialization to ice_setup_rx_ctx

2021-03-03 Thread Maciej Fijalkowski
ice_rx_offset(), that is supposed to initialize the Rx buffer headroom, relies on ICE_RX_FLAGS_RING_BUILD_SKB flag as well as XDP prog presence. Currently, the callsite of mentioned function is placed incorrectly within ice_setup_rx_ring() where Rx ring's build skb flag is not set yet. This causes

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-03-03 Thread Martin Schiller
On 2021-03-03 00:30, Jakub Kicinski wrote: On Tue, 02 Mar 2021 08:04:20 +0100 Martin Schiller wrote: On 2021-03-01 09:56, Xie He wrote: > On Sun, Feb 28, 2021 at 10:56 PM Martin Schiller wrote: >> I mean the change from only one hdlc interface to both hdlc and >> hdlc_x25. >> >> I can't estimat

Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Mika Penttilä
On 3.3.2021 14.45, Yongji Xie wrote: On Wed, Mar 3, 2021 at 6:52 PM Mika Penttilä wrote: On 23.2.2021 13.50, Xie Yongji wrote: This patch introduces an attribute for vDPA device to indicate whether virtual address can be used. If vDPA device driver set it, vhost-vdpa bus driver will not p

[PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues

2021-03-03 Thread Oz Shlomo
Currently the flow table offload replace, destroy and stats work items are executed on a single workqueue. As such, DESTROY and STATS commands may be backloged after a burst of REPLACE work items. This scenario can bloat up memory and may cause active connections to age. Instatiate add, del and st

Re: [PATCH/v4] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-03 Thread Xuesen Huang
Thanks Cong! Thanks to your suggestion, I try to add a simple test case to test_tc_tunnel. It works for me :) Thanks for your review. > 2021年3月3日 下午8:33,Xuesen Huang 写道: > > From: Xuesen Huang > > bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets > encapsulation. But

net: usb: lan78xx: Problem with ERR_STS

2021-03-03 Thread Sven Schuchmann
Hello Woojung, I am currently working on a project where we use a LAN7801 together with a DP83TC811R phy. The Problem is that if we change link state of the phy to down and up again the LAN7801 is not receiving anything anymore, while sending still works. I already discussed this on the TI Forums

[PATCH/v4] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-03 Thread Xuesen Huang
From: Xuesen Huang bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets encapsulation. But that is not appropriate when pushing Ethernet header. Add an option to further specify encap L2 type and set the inner_protocol as ETH_P_TEB. Update test_tc_tunnel to verify adding vxl

Re: Re: [RFC v4 05/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-03 Thread Yongji Xie
On Wed, Mar 3, 2021 at 6:52 PM Mika Penttilä wrote: > > > > On 23.2.2021 13.50, Xie Yongji wrote: > > This patch introduces an attribute for vDPA device to indicate > > whether virtual address can be used. If vDPA device driver set > > it, vhost-vdpa bus driver will not pin user page and transfer

Re: [RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET

2021-03-03 Thread Arseny Krasnov
On 03.03.2021 01:25, Steven Rostedt wrote: > On Thu, 18 Feb 2021 08:42:15 +0300 > Arseny Krasnov wrote: > > Not sure if this was pulled in yet, but I do have a small issue with this > patch. No, it is in RFC state. > >> @@ -69,14 +82,19 @@ TRACE_EVENT(virtio_transport_alloc_pkt, >>

[PATCH iproute2] q_cake: Fix incorrect printing of signed values in class statistics

2021-03-03 Thread Toke Høiland-Jørgensen
The deficit returned from the kernel is signed, but was printed with a %u specifier in the format string, leading to negative values to be printed as high unsigned values instead. In addition, we passed a negative value to sprint_time() even though that expects an unsigned value. Fix this by changi

RE: [PATCH 4/4] nfc: Avoid endless loops caused by repeated llcp_sock_connect()(Internet mail)

2021-03-03 Thread 尹亮
Hi xiaoming, the path can only fix the endless loop problem. it can't fix the meaningless llcp_sock->service_name problem. if we set llcp_sock->service_name to meaningless string, the connect will be failed. and sk->sk_state will not be LLCP_CONNECTED. then we can call llcp_sock_connect() ma

RE: [PATCH] net/mlx5: remove unneeded semicolon

2021-03-03 Thread Parav Pandit
Hi Saeed, > From: Parav Pandit > Sent: Monday, February 22, 2021 3:32 PM > > > > From: Jiapeng Chong > > Sent: Monday, February 22, 2021 3:27 PM > > > > Fix the following coccicheck warnings: > > > > ./drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c:495:2-3: > > Unneeded semicolon. > > >

Re: [PATCH 4/5] net: page_pool: refactor dma_map into own function page_pool_dma_map

2021-03-03 Thread Mel Gorman
On Tue, Mar 02, 2021 at 08:49:06PM +0200, Ilias Apalodimas wrote: > Hi Mel, > > Can you please CC me in future revisions. I almost missed that! > Will do. > On Mon, Mar 01, 2021 at 04:11:59PM +, Mel Gorman wrote: > > From: Jesper Dangaard Brouer > > > > In preparation for next patch, move

Re: [PATCH v3] net: phy: add Marvell 88X2222 transceiver support

2021-03-03 Thread Russell King - ARM Linux admin
Hi, Mostly great, but just a couple more points. On Wed, Mar 03, 2021 at 01:57:57PM +0300, Ivan Bornyakov wrote: > + adv = 0; > + > + if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT, > + priv->supported)) > + adv |= ADVERTISE_1000XFULL; > +

Re: [PATCH v2 1/1] Bluetooth: Remove unneeded commands for suspend

2021-03-03 Thread Marcel Holtmann
Hi Abhishek, > During suspend, there are a few scan enable and set event filter > commands that don't need to be sent unless there are actual BR/EDR > devices capable of waking the system. Check the HCI_PSCAN bit before > writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED > to

  1   2   >