drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() The following build error is emitted by rcutorture builds of v5.12-rc1:
drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined but not used [-Wunused-function] drivers/net/phy/phy_device.c:273:12: warning: ‘mdio_bus_phy_suspend’ defined but not used [-Wunused-function] The problem is that these functions are only used by SIMPLE_DEV_PM_OPS(), which creates a dev_pm_ops structure only in CONFIG_PM_SLEEP=y kernels. Therefore, the mdio_bus_phy_suspend() and mdio_bus_phy_suspend() functions will be used only in CONFIG_PM_SLEEP=y kernels. This commit therefore wraps them in #ifdef CONFIG_PM_SLEEP. Cc: Andrew Lunn <and...@lunn.ch> Cc: Heiner Kallweit <hkallwe...@gmail.com> Cc: Russell King <li...@armlinux.org.uk> Cc: "David S. Miller" <da...@davemloft.net> Cc: Jakub Kicinski <k...@kernel.org> Cc: <netdev@vger.kernel.org> Signed-off-by: Paul E. McKenney <paul...@kernel.org> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index ce49547..d6fb6e7 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -270,6 +270,8 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev) return !phydev->suspended; } +#ifdef CONFIG_PM_SLEEP + static int mdio_bus_phy_suspend(struct device *dev) { struct phy_device *phydev = to_phy_device(dev); @@ -314,6 +316,8 @@ static int mdio_bus_phy_resume(struct device *dev) return 0; } +#endif + static SIMPLE_DEV_PM_OPS(mdio_bus_phy_pm_ops, mdio_bus_phy_suspend, mdio_bus_phy_resume); #endif /* CONFIG_PM */