[PATCH net] net: psample: Fix netlink skb length with tunnel info

2021-02-24 Thread Chris Mi
Currently, the psample netlink skb is allocated with a size that does not account for the nested 'PSAMPLE_ATTR_TUNNEL' attribute and the padding required for the 64-bit attribute 'PSAMPLE_TUNNEL_KEY_ATTR_ID'. This can result in failure to add attributes to the netlink skb due to insufficient tail r

Re: [PATCH V3 2/5] ARM: dts: renesas: Add fck to etheravb-rcar-gen2 clock-names list

2021-02-24 Thread Geert Uytterhoeven
Hi Andrew, On Wed, Feb 24, 2021 at 2:45 PM Andrew Lunn wrote: > On Wed, Feb 24, 2021 at 05:51:42AM -0600, Adam Ford wrote: > > The bindings have been updated to support two clocks, but the > > original clock now requires the name fck. Add a clock-names > > list in the device tree with fck in it.

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-24 Thread Jan Beulich
On 24.02.2021 17:39, Paul Durrant wrote: > On 23/02/2021 16:29, Jan Beulich wrote: >> When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the >> special considerations for the head of the SKB no longer apply. Don't >> mistakenly report ERROR to the frontend for the first entry in th

Re: [PATCH] net: dsa: sja1105: Remove unneeded cast in sja1105_crc32()

2021-02-24 Thread Geert Uytterhoeven
Hi Vladimir, On Wed, Feb 24, 2021 at 11:44 PM Vladimir Oltean wrote: > On Tue, Feb 23, 2021 at 12:20:03PM +0100, Geert Uytterhoeven wrote: > > sja1105_unpack() takes a "const void *buf" as its first parameter, so > > there is no need to cast away the "const" of the "buf" variable before > > calli

Re: [PATCH 5/6] can: c_can: prepare to up the message objects number

2021-02-24 Thread Marc Kleine-Budde
Hey Dario, just a quick note... On 24.02.2021 23:52:45, Dario Binacchi wrote: > -struct net_device *alloc_c_can_dev(void) > +struct net_device *alloc_c_can_dev(int msg_obj_num) > { > struct net_device *dev; > struct c_can_priv *priv; > + int msg_obj_tx_num = msg_obj_num / 2; >

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Heiner Kallweit
On 25.02.2021 00:54, Daniel González Cabanelas wrote: > El mié, 24 feb 2021 a las 23:01, Florian Fainelli > () escribió: >> >> >> >> On 2/24/2021 1:44 PM, Heiner Kallweit wrote: >>> On 24.02.2021 16:44, Daniel González Cabanelas wrote: The current bcm63xx_enet driver doesn't asign the internal

Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

2021-02-24 Thread Kalle Valo
writes: > On 24/02/21 10:13 pm, Kalle Valo wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> Marcus Folkesson writes: >> >>> Write the value instead of reading it twice. >>> >>> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' p

[PATCH] kallsyms: make arch_get_kallsym static

2021-02-24 Thread Jiapeng Chong
Fix the following sparse warning: kernel/kallsyms.c:457:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static? Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- kernel/kallsyms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kallsyms.

[PATCH] qtnfmac: remove meaningless goto statement and labels

2021-02-24 Thread samirweng1979
From: wengjianfeng some function's label meaningless, the label statement follows the goto statement, no other statements, so just remove it. Signed-off-by: wengjianfeng --- drivers/net/wireless/quantenna/qtnfmac/commands.c | 68 --- 1 file changed, 68 deletions(-) diff --

Re: [PATCH bpf-next v3 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-02-24 Thread Björn Töpel
On 2021-02-25 00:38, Daniel Borkmann wrote: On 2/21/21 9:09 PM, Björn Töpel wrote: From: Björn Töpel Currently the bpf_redirect_map() implementation dispatches to the correct map-lookup function via a switch-statement. To avoid the dispatching, this change adds one bpf_redirect_map() implement

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Martin Zaharinov
Hi Wei, Jakub and Eric I have attached the new crash log below. @Wei I try to use external driver from sourceforge ixgbe and build in kernel internel driver. With external driver when machine boot immediately crashed and reboot system. With internal driver in kernel 5.11.1 one time get Bug info

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Jason Wang
On 2021/2/24 7:12 下午, Cornelia Huck wrote: On Wed, 24 Feb 2021 17:29:07 +0800 Jason Wang wrote: On 2021/2/23 6:58 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 18:31:07 +0800 Jason Wang wrote: On 2021/2/23 6:04 下午, Cornelia Huck wrote: On Tue, 23 Feb 2021 17:46:20 +0800 Jason Wang wro

Re: WARNING in nbd_dev_add

2021-02-24 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:6fbd15c0 Merge branch '100GbE' of git://git.kernel.org/pub.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=17a009a8d0 kernel config: https://syzkaller.appspot.com/x/.config?x=2b8307379601

Re: [PATCH AUTOSEL 5.11 05/67] can: flexcan: add CAN wakeup function for i.MX8QM

2021-02-24 Thread Fabio Estevam
Hi Sasha, On Wed, Feb 24, 2021 at 10:35 PM Sasha Levin wrote: > > From: Joakim Zhang > > [ Upstream commit 812f0116c66a3ebaf0b6062226aa85574dd79f67 ] > > The System Controller Firmware (SCFW) is a low-level system function > which runs on a dedicated Cortex-M core to provide power, clock, and >

Re: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-24 Thread Andrew Lunn
> Hi Andrew, > > I don't have experience with Ethernet switch, according to your > points, you mean we can connect STMMAC to an Ethernet switch, and > then Ethernet switch managed STMMAC by the MDIO bus but without > checking whether STMMAC interface is opened or not, so STMMAC needs > clocks for

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-24 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年2月24日 21:02 > To: Jakub Kicinski > Cc: Joakim Zhang ; peppe.cavall...@st.com; > alexandre.tor...@st.com; joab...@synopsys.com; da...@davemloft.net; > netdev@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH V1 net-next 0/3] net: st

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Thu, 25 Feb 2021 01:22:08 + Alexander Duyck wrote: > Yeah, that was the patch Wei had done earlier. Eric complained about the > extra set_bit atomic operation in the threaded path. That is when I came up > with the idea of just adding a bit to the busy poll logic so that the only > extra

Re: [PATCH v3 net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081

2021-02-24 Thread Andrew Lunn
On Wed, Feb 24, 2021 at 09:55:36PM +0100, Christian Melki wrote: > Following a similar reinstate for the KSZ9031. > > Older kernels would use the genphy_soft_reset if the PHY did not implement > a .soft_reset. > > Bluntly removing that default may expose a lot of situations where various > PHYs/b

Re: [RFC PATCH net-next 11/12] Documentation: networking: switchdev: clarify device driver behavior

2021-02-24 Thread Andrew Lunn
> +devices and unsolicited multicast must be filtered as early as possible into > +the hardware. 'into' sounds wrong here. Probably just 'in'. > +- with VLAN filtering turned off: the bridge is strictly VLAN unaware and its > + data path will only process untagged Ethernet frames. Frames ingress

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-24 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年2月24日 11:54 > To: Joakim Zhang ; Jakub Kicinski > > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V1 net-next 0/3]

Re: [RFC PATCH net-next 10/12] Documentation: networking: dsa: add paragraph for the HSR/PRP offload

2021-02-24 Thread Andrew Lunn
> +IEC 62439-3 (HSR/PRP) > +- > + > +The Parallel Redundancy Protocol (PRP) is a network redundancy protocol which > +works by duplicating and sequence numbering packets through two independent > L2 > +networks (which are unaware of the PRP tail tags carried in the packets), an

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 17:06:13 -0800 Wei Wang wrote: > I really have a hard time reproducing the warning Martin was seeing in > his setup. The difference between my setup and his is that mine uses > mlx4 driver, while Martin is using ixgbe driver. > > To keep everyone up to date with Martin's previo

Re: [RFC PATCH net-next 09/12] Documentation: networking: dsa: add paragraph for the MRP offload

2021-02-24 Thread Andrew Lunn
> +implemented as a function of the bridge driver. MRP uses management PDUs > +(Test, Topology, LinkDown/Up, Option) sent at a multicast destination MAC "sent to", or "sent with" > +address range of 01:15:4e:00:00:0x and with an EtherType of 0x88e3. address in the range. Andrew

Re: [RFC PATCH net-next 08/12] Documentation: networking: dsa: add paragraph for the LAG offload

2021-02-24 Thread Andrew Lunn
On Sun, Feb 21, 2021 at 11:33:51PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Add a short summary of the methods that a driver writer must implement > for offloading a link aggregation group, and what is still missing. > > Cc: Tobias Waldekranz > Signed-off-by: Vladimir Oltean >

RE: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Alexander Duyck
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, February 24, 2021 4:21 PM > To: Alexander Duyck > Cc: Eric Dumazet ; Wei Wang > ; David S . Miller ; netdev > ; Paolo Abeni ; Hannes > Frederic Sowa ; Martin Zaharinov > > Subject: Re: [PATCH net] net: fix race between nap

Re: [RFC PATCH net-next 07/12] Documentation: networking: dsa: mention integration with devlink

2021-02-24 Thread Andrew Lunn
On Sun, Feb 21, 2021 at 11:33:50PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Add a short summary of the devlink features supported by the DSA core. > > Signed-off-by: Vladimir Oltean > --- > Documentation/networking/dsa/dsa.rst | 27 +++ > 1 file changed

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-24 Thread Kefeng Wang
On 2021/2/25 2:54, Jakub Kicinski wrote: On Wed, 24 Feb 2021 23:38:03 +0800 Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead of HAVE_JUMP_LABLE. Fixes: 971502d77faa ("bridge: netfilter:

Re: [RFC PATCH net-next 06/12] Documentation: networking: dsa: document the port_bridge_flags method

2021-02-24 Thread Andrew Lunn
> + the bridge port flags for the CPU port. The assumption is that address > + learning should be statically enabled (if supported by the hardware) on the > + CPU port, and flooding towards the CPU port should also be enabled, in lack > + of an explicit address filtering mechanism in the DSA co

[PATCH stable-5.11.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable-5.9.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable-5.10.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable-5.8.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable-5.4.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable-4.19.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable-4.14.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable-4.9.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
Standalone ports should not have learning enabled since all the frames are always copied to the CPU port. This is particularly important in case an user-facing port intentionally spoofs the CPU port's MAC address. With learning enabled we would end up with the switch having incorrectly learned the

[PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
From: Florian Fainelli Hi Greg, Sasha, Jaakub and David, This patch series contains backports for a change that recently made it upstream as: commit f3f9be9c58085d11f4448ec199bf49dc2f9b7fb9 Merge: 18755e270666 f9b3827ee66c Author: Jakub Kicinski Date: Tue Feb 23 12:23:06 2021 -0800 Merg

[PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-24 Thread Punit Agrawal
From: Corinna Vinschen commit 2643e6e90210e16c978919617170089b7c2164f7 upstream TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 secs on 80576 (45 bit SYSTIM). This wrap event sets the TSICR.SysWrap bit uncondi

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 16:44:55 -0800 Wei Wang wrote: > On Wed, Feb 24, 2021 at 4:33 PM Jakub Kicinski wrote: > > > > On Wed, 24 Feb 2021 16:16:58 -0800 Wei Wang wrote: > > > On Wed, Feb 24, 2021 at 4:11 PM Alexander Duyck > > > wrote: > [...] > > > > > > Please help hold on to the patch for

Re: [PATCH v8 bpf-next 0/5] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-24 Thread Daniel Borkmann
On 2/18/21 9:49 PM, Alexander Lobakin wrote: This series introduces XSK generic zerocopy xmit by adding XSK umem pages as skb frags instead of copying data to linear space. The only requirement for this for drivers is to be able to xmit skbs with skb_headlen(skb) == 0, i.e. all data including har

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-24 Thread Jakub Kicinski
On Thu, 25 Feb 2021 08:21:01 +0800 Coiby Xu wrote: > On Wed, Feb 24, 2021 at 08:48:41AM -0800, Jakub Kicinski wrote: > >On Wed, 24 Feb 2021 19:41:41 +0800 Coiby Xu wrote: > >> I'm not sure if I understand you correctly. Do you mean we shouldn't > >> disable i40iw for kdump? > > > >Forgive my ig

Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-24 Thread Punit Agrawal
Jakub Kicinski writes: > On Wed, 24 Feb 2021 11:28:59 +0900 Punit Agrawal wrote: >> > It makes sense to me for htis to apply to those stable trees as well. >> >> Thanks Jake. >> >> Networking maintainers - It's been a couple of weeks this patch is on >> the list. Is there anything else that n

Re: [PATCH net v4 1/1] ibmvnic: fix a race between open and reset

2021-02-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 23 Feb 2021 21:02:29 -0800 you wrote: > __ibmvnic_reset() currently reads the adapter->state before getting the > rtnl and saves that state as the "target state" for the reset. If this > read occurs when adapter is in PR

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 16:16:58 -0800 Wei Wang wrote: > On Wed, Feb 24, 2021 at 4:11 PM Alexander Duyck wrote: > > > > The problem with adding a bit for SCHED_THREADED is that you would > > have to heavily modify napi_schedule_prep so that it would add the > > bit. That is the reason for going with a

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-24 Thread Coiby Xu
On Wed, Feb 24, 2021 at 08:48:41AM -0800, Jakub Kicinski wrote: On Wed, 24 Feb 2021 19:41:41 +0800 Coiby Xu wrote: On Tue, Feb 23, 2021 at 12:22:07PM -0800, Jakub Kicinski wrote: >On Mon, 22 Feb 2021 15:07:01 +0800 Coiby Xu wrote: >> i40iw consumes huge amounts of memory. For example, on a x86_6

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Thu, 25 Feb 2021 00:11:34 + Alexander Duyck wrote: > > > We were trying to not pollute the list (with about 40 different emails > > > so far) > > > > > > (Note this was not something I initiated, I only hit Reply all button) > > > > > > OK, I will shut up, since you seem to take over this ma

Re: [PATCH] net: stmmac: Fix missing spin_lock_init in visconti_eth_dwmac_probe()

2021-02-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 23 Feb 2021 10:48:03 + you wrote: > The driver allocates the spinlock but not initialize it. > Use spin_lock_init() on it to initialize it correctly. > > Fixes: b38dd98ff8d0 ("net: stmmac: Add Toshiba Visconti SoCs

Re: [PATCH net v4 1/1] net: introduce CAN specific pointer in the struct net_device

2021-02-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 23 Feb 2021 08:01:26 +0100 you wrote: > Since 20dd3850bcf8 ("can: Speed up CAN frame receiption by using > ml_priv") the CAN framework uses per device specific data in the AF_CAN > protocol. For this purpose the struct n

RE: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Alexander Duyck
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, February 24, 2021 4:07 PM > To: Eric Dumazet > Cc: Wei Wang ; David S . Miller > ; netdev ; Paolo Abeni > ; Hannes Frederic Sowa > ; Alexander Duyck > ; Martin Zaharinov > Subject: Re: [PATCH net] net: fix race between nap

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Thu, 25 Feb 2021 00:59:25 +0100 Eric Dumazet wrote: > On Thu, Feb 25, 2021 at 12:52 AM Jakub Kicinski wrote: > > Interesting, vger seems to be CCed but it isn't appearing on the ML. > > Perhaps just a vger delay :S > > > > Not really upsetting. I'm just trying to share what I learned devising >

Re: [PATCH V2] init/Kconfig: Fix a typo in CC_VERSION_TEXT help text

2021-02-24 Thread Nathan Chancellor
On Thu, Feb 25, 2021 at 04:03:25AM +0530, Bhaskar Chowdhury wrote: > > s/compier/compiler/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Nathan Chancellor > --- > Changes from V1: > Nathan and Randy, suggested better subject line texts,so incorporated. > > init/Kconfig | 2 +- > 1 fi

Re: [RFC PATCH net-next 05/12] Documentation: networking: dsa: remove TODO about porting more vendor drivers

2021-02-24 Thread Andrew Lunn
On Sun, Feb 21, 2021 at 11:33:48PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > On one hand, the link is dead and therefore useless. > > On the other hand, there are always more drivers to port, but at this > stage, DSA does not need to affirm itself as the driver model to use for >

Re: [RFC PATCH net-next 04/12] Documentation: networking: dsa: remove references to switchdev prepare/commit

2021-02-24 Thread Andrew Lunn
On Sun, Feb 21, 2021 at 11:33:47PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > After the recent series containing commit bae33f2b5afe ("net: switchdev: > remove the transaction structure from port attributes"), there aren't > prepare/commit transactional phases anymore in most of th

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Daniel González Cabanelas
El mié, 24 feb 2021 a las 23:01, Florian Fainelli () escribió: > > > > On 2/24/2021 1:44 PM, Heiner Kallweit wrote: > > On 24.02.2021 16:44, Daniel González Cabanelas wrote: > >> The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > >> result of this it works in polling mode. >

Re: [RFC PATCH net-next 02/12] Documentation: networking: dsa: rewrite chapter about tagging protocol

2021-02-24 Thread Andrew Lunn
> +It is desirable that all tagging protocols are testable with the ``dsa_loop`` > +mockup driver, which can be attached to any network interface. The goal is > that > +any network interface should be able of transmitting the same packet in the should be _capable_ of ?? Reviewed-by: Andrew Lunn

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 23:30:23 +0100 Eric Dumazet wrote: > On Wed, Feb 24, 2021 at 10:30 PM Jakub Kicinski wrote: > > Just to find out what the LoC is I sketched this out: > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index ddf4cfc12615..77f09ced9ee4 100644 > > --- a

Re: [PATCH bpf-next v3 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-02-24 Thread Daniel Borkmann
On 2/21/21 9:09 PM, Björn Töpel wrote: From: Björn Töpel Currently the bpf_redirect_map() implementation dispatches to the correct map-lookup function via a switch-statement. To avoid the dispatching, this change adds one bpf_redirect_map() implementation per map. Correct function is automatica

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 14:29:21 -0800 Wei Wang wrote: > On Wed, Feb 24, 2021 at 1:30 PM Jakub Kicinski wrote: > > On Wed, 24 Feb 2021 21:37:36 +0100 Eric Dumazet wrote: > > > On Wed, Feb 24, 2021 at 8:48 PM Jakub Kicinski wrote: > > > > On Tue, 23 Feb 2021 15:41:30 -0800 Wei Wang wrote: > > >

Re: [PATCH V3 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-24 Thread Andreas Roeseler
On Sun, 2021-02-21 at 23:49 -0500, Willem de Bruijn wrote: On Wed, Feb 17, 2021 at 1:14 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check for PROBE messages and call > icmp_echo if a PROBE request is detected. > > Modify the existing icmp_echo function to respond to both ping

[PATCH 1/6] can: c_can: remove unused code

2021-02-24 Thread Dario Binacchi
Commit 9d23a9818cb1 ("can: c_can: Remove unused inline function") left behind C_CAN_MSG_OBJ_TX_LAST constant. Commit fa39b54ccf28 ("can: c_can: Get rid of pointless interrupts") left behind C_CAN_MSG_RX_LOW_LAST and C_CAN_MSG_OBJ_RX_SPLIT constants. The removed code also made a comment useless an

[PATCH 6/6] can: c_can: add support to 64 messages objects

2021-02-24 Thread Dario Binacchi
D_CAN controller supports 16, 32, 64 or 128 messages objects, comparing to 32 on C_CAN. AM335x/AM437x Sitara processors and DRA7 SOC all instantiate a D_CAN controller with 64 message objects, as described in the "DCAN features" subsection of the CAN chapter of their technical reference manuals. T

[PATCH 4/6] can: c_can: use 32-bit write to set arbitration register

2021-02-24 Thread Dario Binacchi
The arbitration register is already set up with 32-bit writes in the other parts of the code except for this point. Signed-off-by: Dario Binacchi --- drivers/net/can/c_can/c_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/c

[PATCH 0/6] can: c_can: add support to 64 messages objects

2021-02-24 Thread Dario Binacchi
The D_CAN controller supports up to 128 messages. Until now the driver only managed 32 messages although Sitara processors and DRA7 SOC can handle 64. The series was tested on a beaglebone board. Note: I have not changed the type of tx_field (belonging to the c_can_priv structure) to atomic64_t

[PATCH 5/6] can: c_can: prepare to up the message objects number

2021-02-24 Thread Dario Binacchi
As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") the "driver casts the 16 message objects in stone, which is completely braindead as contemporary hardware has up to 128 message objects". The patch prepares the module to extend the number of message objects beyond the 32 cur

[PATCH 3/6] can: c_can: fix control interface used by c_can_do_tx

2021-02-24 Thread Dario Binacchi
According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX). Signed-off-by: Dario Binacchi --- drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/

[PATCH 2/6] can: c_can: fix indentation

2021-02-24 Thread Dario Binacchi
Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Signed-off-by: Dario Binacchi --- drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/c_can/c_can.c b/dr

Re: [PATCH] net: dsa: sja1105: Remove unneeded cast in sja1105_crc32()

2021-02-24 Thread Vladimir Oltean
On Tue, Feb 23, 2021 at 12:20:03PM +0100, Geert Uytterhoeven wrote: > sja1105_unpack() takes a "const void *buf" as its first parameter, so > there is no need to cast away the "const" of the "buf" variable before > calling it. > > Drop the cast, as it prevents the compiler performing some checks.

Re: [PATCH V2] init/Kconfig: Fix a typo in CC_VERSION_TEXT help text

2021-02-24 Thread Randy Dunlap
On 2/24/21 2:33 PM, Bhaskar Chowdhury wrote: > > s/compier/compiler/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > Nathan and Randy, suggested better subject line texts,so incorporated. > > init/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH V2] init/Kconfig: Fix a typo in CC_VERSION_TEXT help text

2021-02-24 Thread Bhaskar Chowdhury
s/compier/compiler/ Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Nathan and Randy, suggested better subject line texts,so incorporated. init/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/Kconfig b/init/Kconfig index ba8bd5256980..2cfed79cc6ec 100

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Florian Fainelli
On 2/24/2021 1:44 PM, Heiner Kallweit wrote: > On 24.02.2021 16:44, Daniel González Cabanelas wrote: >> The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a >> result of this it works in polling mode. >> >> Fix it using the phy_device structure to assign the platform IRQ. >>

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-24 Thread Heiner Kallweit
On 24.02.2021 16:44, Daniel González Cabanelas wrote: > The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > result of this it works in polling mode. > > Fix it using the phy_device structure to assign the platform IRQ. > > Tested under a BCM6348 board. Kernel dmesg before t

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-24 Thread Don Dutile
On 2/24/21 3:09 AM, Greg Kroah-Hartman wrote: On Tue, Feb 23, 2021 at 03:07:43PM -0600, Bjorn Helgaas wrote: On Sun, Feb 21, 2021 at 08:59:18AM +0200, Leon Romanovsky wrote: On Sat, Feb 20, 2021 at 01:06:00PM -0600, Bjorn Helgaas wrote: On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hart

Re: [PATCH bpf-next 0/8] PROG_TEST_RUN support for sk_lookup programs

2021-02-24 Thread Daniel Borkmann
On 2/23/21 8:29 AM, Andrii Nakryiko wrote: On Tue, Feb 16, 2021 at 2:58 AM Lorenz Bauer wrote: We don't have PROG_TEST_RUN support for sk_lookup programs at the moment. So far this hasn't been a problem, since we can run our tests in a separate network namespace. For benchmarking it's nice to

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 21:37:36 +0100 Eric Dumazet wrote: > On Wed, Feb 24, 2021 at 8:48 PM Jakub Kicinski wrote: > > On Tue, 23 Feb 2021 15:41:30 -0800 Wei Wang wrote: > > > Currently, napi_thread_wait() checks for NAPI_STATE_SCHED bit to > > > determine if the kthread owns this napi and could cal

[PATCH 2/2] tools, bpf_asm: exit non-zero on errors.

2021-02-24 Thread Ian Denhardt
...so callers can correctly detect failure. Signed-off-by: Ian Denhardt --- tools/bpf/bpf_exp.y | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/bpf/bpf_exp.y b/tools/bpf/bpf_exp.y index 8d03e5245da5..dfb7254a24e8 100644 --- a/tools/bpf/bpf_exp.y +++ b/tools/bpf/

[PATCH 1/2] tools, bpf_asm: Hard error on out of range jumps.

2021-02-24 Thread Ian Denhardt
Per discussion at: https://lore.kernel.org/bpf/c964892195a6b91d20a67691448567ef528ffa6d.ca...@linux.ibm.com/T/#t ...this was originally introduced as a warning due to concerns about breaking existing code, but a hard error probably makes more sense, especially given that concerns about breakage w

[PATCH 0/2] More strict error checking in bpf_asm (v3).

2021-02-24 Thread Ian Denhardt
Gah, managed to typo my own name in the v2 patch >.< This one should be good :/ Ian Denhardt (2): tools, bpf_asm: Hard error on out of range jumps. tools, bpf_asm: exit non-zero on errors. tools/bpf/bpf_exp.y | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) -- 2.30.1

[PATCH 2/2] tools, bpf_asm: exit non-zero on errors.

2021-02-24 Thread Ian Denhardt
...so callers can correctly detect failure. Signed-off-by: Ian Denhardt --- tools/bpf/bpf_exp.y | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/bpf/bpf_exp.y b/tools/bpf/bpf_exp.y index 8d03e5245da5..dfb7254a24e8 100644 --- a/tools/bpf/bpf_exp.y +++ b/tools/bpf/

[PATCH 0/2] More strict error checking in bpf_asm (v2).

2021-02-24 Thread Ian Denhardt
Second pass at the patches from: https://lore.kernel.org/bpf/ef747c45-a68c-2a87-202c-5fd9faf70...@iogearbox.net/T/#t. Patches are the same, this just addes the Signed-off-by: lines as requested by Daniel Borkmann Ian Denhardt (2): tools, bpf_asm: Hard error on out of range jumps. tools, bpf_

[PATCH 1/2] tools, bpf_asm: Hard error on out of range jumps.

2021-02-24 Thread Ian Denhardt
Per discussion at: https://lore.kernel.org/bpf/c964892195a6b91d20a67691448567ef528ffa6d.ca...@linux.ibm.com/T/#t ...this was originally introduced as a warning due to concerns about breaking existing code, but a hard error probably makes more sense, especially given that concerns about breakage w

Re: [PATCH net v3 1/1] can: can_skb_set_owner(): fix ref counting if socket was closed before setting skb ownership

2021-02-24 Thread Marc Kleine-Budde
On 24.02.2021 21:32:29, Oliver Hartkopp wrote: > > > To fix this problem, only set skb ownership to sockets which have still > > > a ref count > 0. > > > > > > Cc: Oliver Hartkopp > > > Cc: Andre Naujoks > > > Suggested-by: Eric Dumazet > > > Fixes: 0ae89beb283a ("can: add destructor for self g

[PATCH v3 net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081

2021-02-24 Thread Christian Melki
Following a similar reinstate for the KSZ9031. Older kernels would use the genphy_soft_reset if the PHY did not implement a .soft_reset. Bluntly removing that default may expose a lot of situations where various PHYs/board implementations won't recover on various changes. Like with this implement

Re: [PATCH net] selftest/bpf: no need to drop the packet when there is no geneve opt

2021-02-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Wed, 24 Feb 2021 16:14:03 +0800 you wrote: > In bpf geneve tunnel test we set geneve option on tx side. On rx side we > only call bpf_skb_get_tunnel_opt(). Since commit 9c2e14b48119 ("ip_tunnels: > Set tunnel option flag when tu

Re: [PATCH 0/2] More strict error checking in bpf_asm.

2021-02-24 Thread Daniel Borkmann
Hi Ian, On 2/24/21 3:36 AM, Ian Denhardt wrote: Hi, Enclosed are two patches related to my earlier message, which make the error checking in the bpf_asm tool more strict, the first by upgrading a warning to an error, the second by using non-zero exit codes when aborting. These could be concept

Re: [PATCH net v3 1/1] can: can_skb_set_owner(): fix ref counting if socket was closed before setting skb ownership

2021-02-24 Thread Oliver Hartkopp
On 24.02.21 09:53, Eric Dumazet wrote: On Wed, Feb 24, 2021 at 8:59 AM Oleksij Rempel wrote: There are two ref count variables controlling the free()ing of a socket: - struct sock::sk_refcnt - which is changed by sock_hold()/sock_put() - struct sock::sk_wmem_alloc - which accounts the memor

Re: [PATCH] ipv6: Honor route mtu if it is within limit of dev mtu

2021-02-24 Thread David Ahern
On 2/22/21 9:32 AM, Kaustubh Pandey wrote: > When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised. > > addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route -> > fib6_nh_mtu_change > > As part of handling NETDEV_CHANGEMTU notification we land up on a > condition where if rout

Re: [PATCH RFC net-next 2/3] net: page_pool: use alloc_pages_bulk in refill code path

2021-02-24 Thread Ilias Apalodimas
Hi Jesper, On Wed, Feb 24, 2021 at 07:56:46PM +0100, Jesper Dangaard Brouer wrote: > There are cases where the page_pool need to refill with pages from the > page allocator. Some workloads cause the page_pool to release pages > instead of recycling these pages. > > For these workload it can impr

Re: [PATCH RFC net-next 1/3] net: page_pool: refactor dma_map into own function page_pool_dma_map

2021-02-24 Thread Ilias Apalodimas
On Wed, Feb 24, 2021 at 07:56:41PM +0100, Jesper Dangaard Brouer wrote: > In preparation for next patch, move the dma mapping into its own > function, as this will make it easier to follow the changes. > > Signed-off-by: Jesper Dangaard Brouer > --- > net/core/page_pool.c | 49

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-24 Thread Jakub Kicinski
On Tue, 23 Feb 2021 15:41:30 -0800 Wei Wang wrote: > Currently, napi_thread_wait() checks for NAPI_STATE_SCHED bit to > determine if the kthread owns this napi and could call napi->poll() on > it. However, if socket busy poll is enabled, it is possible that the > busy poll thread grabs this SCHED b

Re: [PATCH net-next] avoid fragmenting page memory with netdev_alloc_cache

2021-02-24 Thread Ronak Doshi
On 2/11/21, 4:18 PM, "Ronak Doshi" wrote: >From: Todd Sabin > >Linux network stack uses an allocation page cache for skbs. The > purpose is to reduce the number of page allocations that it needs to >make, and it works by allocating a group of pages, and then >sub-allocating s

Re: [PATCH net] selftest/bpf: no need to drop the packet when there is no geneve opt

2021-02-24 Thread William Tu
On Wed, Feb 24, 2021 at 12:37 AM Hangbin Liu wrote: > > In bpf geneve tunnel test we set geneve option on tx side. On rx side we > only call bpf_skb_get_tunnel_opt(). Since commit 9c2e14b48119 ("ip_tunnels: > Set tunnel option flag when tunnel metadata is present") geneve_rx() will > not add TUNNE

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 23:38:03 +0800 Kefeng Wang wrote: > HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move > 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead > of HAVE_JUMP_LABLE. > > Fixes: 971502d77faa ("bridge: netfilter: unroll NF_HOOK helper in bridge > i

Re: [PATCH bpf-next] bpf: fix missing * in bpf.h

2021-02-24 Thread Andrii Nakryiko
On Wed, Feb 24, 2021 at 7:55 AM Daniel Borkmann wrote: > > On 2/23/21 3:43 PM, Jesper Dangaard Brouer wrote: > > On Tue, 23 Feb 2021 20:45:54 +0800 > > Hangbin Liu wrote: > > > >> Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") lost a * > >> in bpf.h. This will make bpf_helpers_doc.p

[PATCH RFC net-next 3/3] mm: make zone->free_area[order] access faster

2021-02-24 Thread Jesper Dangaard Brouer
Avoid multiplication (imul) operations when accessing: zone->free_area[order].nr_free This was really tricky to find. I was puzzled why perf reported that rmqueue_bulk was using 44% of the time in an imul operation: │ del_page_from_free_list(): 44,54 │ e2: imul $0x58,%rax,%rax T

[PATCH RFC net-next 2/3] net: page_pool: use alloc_pages_bulk in refill code path

2021-02-24 Thread Jesper Dangaard Brouer
There are cases where the page_pool need to refill with pages from the page allocator. Some workloads cause the page_pool to release pages instead of recycling these pages. For these workload it can improve performance to bulk alloc pages from the page-allocator to refill the alloc cache. For XDP

[PATCH RFC net-next 0/3] Use bulk order-0 page allocator API for page_pool

2021-02-24 Thread Jesper Dangaard Brouer
This is a followup to Mel Gorman's patchset: - Message-Id: <20210224102603.19524-1-mgor...@techsingularity.net> - https://lore.kernel.org/netdev/20210224102603.19524-1-mgor...@techsingularity.net/ Showing page_pool usage of the API for alloc_pages_bulk(). --- Jesper Dangaard Brouer (3):

[PATCH RFC net-next 1/3] net: page_pool: refactor dma_map into own function page_pool_dma_map

2021-02-24 Thread Jesper Dangaard Brouer
In preparation for next patch, move the dma mapping into its own function, as this will make it easier to follow the changes. Signed-off-by: Jesper Dangaard Brouer --- net/core/page_pool.c | 49 + 1 file changed, 29 insertions(+), 20 deletions(-)

Re: [PATCH] ipv6: Honor route mtu if it is within limit of dev mtu

2021-02-24 Thread Jakub Kicinski
On Mon, 22 Feb 2021 22:02:35 +0530 Kaustubh Pandey wrote: > When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised. > > addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route -> > fib6_nh_mtu_change > > As part of handling NETDEV_CHANGEMTU notification we land up on a > conditio

[PATCH] ath9k:remove unneeded variable in ath9k_dump_legacy_btcoex

2021-02-24 Thread zhangkun4jr
From: Zhang Kun Remove unneeded variable 'len' in ath9k_dump_legacy_btcoex. Signed-off-by: Zhang Kun --- drivers/net/wireless/ath/ath9k/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c i

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-24 Thread Si-Wei Liu
On 2/23/2021 9:04 PM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S.

  1   2   3   >