Re: [PATCH v2 0/2] of: of_device.h cleanups

2021-02-11 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 05:27:43PM -0600, Rob Herring wrote: > This is a couple of cleanups for of_device.h. They fell out from my > attempt at decoupling of_device.h and of_platform.h which is a mess > and I haven't finished, but there's no reason to wait on these. Reviewed-by: Greg Kroah-Hartman

Re: [EXT] Re: [PATCH v2 net-next 1/2] samples: pktgen: allow to specify delay parameter via new opt

2021-02-11 Thread Jesper Dangaard Brouer
On Thu, 11 Feb 2021 17:39:35 + Igor Russkikh wrote: > >> +echo " -w : (\$DELAY) Tx Delay value (us)" > >This is not in "us" it is in "ns" (nanosec). (Like I pointed out last > >time...) > > Ah, sorry lost that. Will fix. Also remember that you made similar mistake in next patc

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2021-02-11 Thread Marek Majtyka
On Fri, Feb 12, 2021 at 3:05 AM Alexei Starovoitov wrote: > > On Thu, Feb 11, 2021 at 5:26 PM Jakub Kicinski wrote: > > > > Perhaps I had seen one too many vendor incompatibility to trust that > > adding a driver API without a validation suite will result in something > > usable in production set

Re: [PATCH bpf-next] libbpf: use AF_LOCAL instead of AF_INET in xsk.c

2021-02-11 Thread Björn Töpel
On Tue, 9 Feb 2021 at 23:50, Stanislav Fomichev wrote: > > We have the environments where usage of AF_INET is prohibited > (cgroup/sock_create returns EPERM for AF_INET). Let's use > AF_LOCAL instead of AF_INET, it should perfectly work with SIOCETHTOOL. > > Signed-off-by: Stanislav Fomichev Sta

Re: [PATCH] rtw88: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-02-11 Thread Felix Fietkau
On 2021-02-12 03:13, Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix rtw_rx_addr_match_iter() to hold RCU read lock before it calls > ieee80211_find_sta_by_ifaddr() and release it when th

Re: [PATCH 1/2] ath9k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-02-11 Thread Felix Fietkau
On 2021-02-12 03:13, Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix ath_tx_process_buffer() to hold RCU read lock before it calls > ieee80211_find_sta_by_ifaddr() and release it when the

Re: [RFC PATCH v4 00/17] virtio/vsock: introduce SOCK_SEQPACKET support

2021-02-11 Thread Arseny Krasnov
On 11.02.2021 17:57, Stefano Garzarella wrote: > Hi Arseny, > > On Mon, Feb 08, 2021 at 09:32:59AM +0300, Arseny Krasnov wrote: >> On 07.02.2021 19:20, Michael S. Tsirkin wrote: >>> On Sun, Feb 07, 2021 at 06:12:56PM +0300, Arseny Krasnov wrote: This patchset impelements support of SOCK_S

Re: [PATCH] mt76: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-02-11 Thread Felix Fietkau
On 2021-02-12 03:13, Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix mt76_check_sta() to hold RCU read lock before it calls > ieee80211_find_sta_by_ifaddr() and release it when the resu

[PATCH] appletalk: Fix skb allocation size in loopback case

2021-02-11 Thread Doug Brown
If a DDP broadcast packet is sent out to a non-gateway target, it is also looped back. There is a potential for the loopback device to have a longer hardware header length than the original target route's device, which can result in the skb not being created with enough room for the loopback device

Re: [PATCH v4 net-next 00/21] nvme-tcp receive offloads

2021-02-11 Thread Boris Pismenny
On 11/02/2021 23:32, Randy Dunlap wrote: > > Hi, > Did vger.kernel.org eat patch 21/21? > > and does that patch contain the Documentation updates? > > thanks. > It seems the error was on my end, thanks for raising this, I've resent that patch now.

[PATCH v4 net-next 21/21] Documentation: add TCP DDP offload documentation

2021-02-11 Thread Boris Pismenny
Signed-off-by: Boris Pismenny Signed-off-by: Ben Ben-Ishay Signed-off-by: Or Gerlitz Signed-off-by: Yoray Zack --- Documentation/networking/index.rst | 1 + Documentation/networking/tcp-ddp-offload.rst | 296 +++ 2 files changed, 297 insertions(+) create mode 10064

[PATCH net-next 2/2] ptp: ptp_clockmatrix: Add alignment of 1 PPS to idtcm_perout_enable.

2021-02-11 Thread vincent.cheng.xh
From: Vincent Cheng When enabling output using PTP_CLK_REQ_PEROUT, need to align the output clock to the internal 1 PPS clock. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clockmatrix.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_cl

[PATCH net-next 1/2] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-11 Thread vincent.cheng.xh
From: Vincent Cheng Part of the device initialization aligns the rising edge of the output clock to the internal 1 PPS clock. If the system APLL and DPLL is not locked, then the alignment will fail and there will be a fixed offset between the internal 1 PPS clock and the output clock. After load

[PATCH net-next 0/2] ptp: ptp_clockmatrix: Fix output 1 PPS alignment.

2021-02-11 Thread vincent.cheng.xh
From: Vincent Cheng This series fixes a race condition that may result in the output clock not aligned to internal 1 PPS clock. Part of device initialization is to align the rising edge of output clocks to the internal rising edge of the 1 PPS clock. If the system APLL and DPLL are not locked w

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread kernel test robot
Hi Sharath, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipvs/master] [also build test ERROR on linus/master sparc-next/master v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH v6 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2021-02-11 Thread Alexei Starovoitov
On Thu, Feb 11, 2021 at 05:42:29PM -0800, Song Liu wrote: > +static int __task_vma_seq_show(struct seq_file *seq, bool in_stop) > +{ > + struct bpf_iter_seq_task_vma_info *info = seq->private; > + struct bpf_iter__task_vma ctx; > + struct bpf_iter_meta meta; > + struct bpf_prog *pro

Re: [PATCH bpf-next 4/4] kbuild: Add resolve_btfids clean to root clean target

2021-02-11 Thread Masahiro Yamada
On Thu, Feb 11, 2021 at 9:17 PM Jiri Olsa wrote: > > On Wed, Feb 10, 2021 at 11:26:28AM -0800, Andrii Nakryiko wrote: > > SNIP > > > > > > Can't reproduce it. It works in all kinds of variants (relative and > > > > > absolute O=, clean and not clean trees, etc). Jiri, please check as > > > > > wel

Re: [PATCH v5 net-next 06/11] skbuff: remove __kfree_skb_flush()

2021-02-11 Thread Alexander Duyck
On Thu, Feb 11, 2021 at 10:57 AM Alexander Lobakin wrote: > > This function isn't much needed as NAPI skb queue gets bulk-freed > anyway when there's no more room, and even may reduce the efficiency > of bulk operations. > It will be even less needed after reusing skb cache on allocation path, > s

[PATCH V2 net-next 11/13] net: hns3: refactor out hclge_set_rss_tuple()

2021-02-11 Thread Huazhong Tan
To make it more readable and maintainable, split hclge_set_rss_tuple() into two parts. Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_main.c| 42 +-- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3p

[PATCH V2 net-next 09/13] net: hns3: split out hclge_cmd_send()

2021-02-11 Thread Huazhong Tan
From: Yufeng Mo hclge_cmd_send() is bloated, so split it into separate functions for readability and maintainability. Signed-off-by: Yufeng Mo Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_cmd.c | 100 +++--- 1 file changed, 59 insertions(+), 41 deletions

[PATCH V2 net-next 13/13] net: hns3: refactor out hclge_rm_vport_all_mac_table()

2021-02-11 Thread Huazhong Tan
From: Hao Chen hclge_rm_vport_all_mac_table() is bloated, so split it into separate functions for readability and maintainability. Signed-off-by: Hao Chen Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_main.c| 67 --- 1 file changed, 43 insertions(+),

[PATCH V2 net-next 12/13] net: hns3: refactor out hclgevf_set_rss_tuple()

2021-02-11 Thread Huazhong Tan
To make it more readable and maintainable, split hclgevf_set_rss_tuple() into two parts. Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3vf/hclgevf_main.c | 47 +-- 1 file changed, 32 insertions(+), 15 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns

[PATCH V2 net-next 10/13] net: hns3: split out hclgevf_cmd_send()

2021-02-11 Thread Huazhong Tan
From: Yufeng Mo hclgevf_cmd_send() is bloated, so split it into separate functions for readability and maintainability. Signed-off-by: Yufeng Mo Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3vf/hclgevf_cmd.c | 141 ++ 1 file changed, 81 insertions(+), 60 deletio

[PATCH V2 net-next 05/13] net: hns3: refactor out hclge_set_vf_vlan_common()

2021-02-11 Thread Huazhong Tan
From: Peng Li To improve code readability and maintainability, separate the command handling part and the status parsing part from bloated hclge_set_vf_vlan_common(). Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_main.c| 73 ---

[PATCH V2 net-next 04/13] net: hns3: use ipv6_addr_any() helper

2021-02-11 Thread Huazhong Tan
From: Jiaran Zhang Use common ipv6_addr_any() to determine if an addr is ipv6 any addr. Signed-off-by: Jiaran Zhang Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net

[PATCH V2 net-next 08/13] net: hns3: split out hclge_dbg_dump_qos_buf_cfg()

2021-02-11 Thread Huazhong Tan
From: Jian Shen hclge_dbg_dump_qos_buf_cfg() is bloated, so split it into separate functions for readability and maintainability. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_debugfs.c | 158 +- 1 file changed, 115 insertions(+),

[PATCH V2 net-next 07/13] net: hns3: refactor out hclgevf_get_rss_tuple()

2021-02-11 Thread Huazhong Tan
From: Jian Shen To improve code readability and maintainability, separate the flow type parsing part and the converting part from bloated hclgevf_get_rss_tuple(). Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3vf/hclgevf_main.c | 67 --- 1

[PATCH V2 net-next 03/13] net: hns3: clean up hns3_dbg_cmd_write()

2021-02-11 Thread Huazhong Tan
From: Peng Li As more commands are added, hns3_dbg_cmd_write() is going to get more bloated, so move the part about command check into a separate function. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../ethernet/hisilicon/hns3/hns3_debugfs.c| 44 +++ 1 file cha

[PATCH V2 net-next 00/13] net: hns3: some cleanups for -next

2021-02-11 Thread Huazhong Tan
To improve code readability and maintainability, the series refactor out some bloated functions in the HNS3 ethernet driver. change log: V2: remove an unused variable in #5 previous version: V1: https://patchwork.kernel.org/project/netdevbpf/cover/1612943005-59416-1-git-send-email-tanhuazh...@hu

[PATCH V2 net-next 06/13] net: hns3: refactor out hclge_get_rss_tuple()

2021-02-11 Thread Huazhong Tan
From: Jian Shen To improve code readability and maintainability, separate the flow type parsing part and the converting part from bloated hclge_get_rss_tuple(). Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_main.c| 59 --- 1 f

[PATCH V2 net-next 01/13] net: hns3: refactor out hclge_cmd_convert_err_code()

2021-02-11 Thread Huazhong Tan
From: Peng Li To improve code readability and maintainability, refactor hclge_cmd_convert_err_code() with an array of imp_errcode and common_errno mapping, instead of a bloated switch/case. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3pf/hclge_cmd.c |

[PATCH V2 net-next 02/13] net: hns3: refactor out hclgevf_cmd_convert_err_code()

2021-02-11 Thread Huazhong Tan
From: Peng Li To improve code readability and maintainability, refactor hclgevf_cmd_convert_err_code() with an array of imp_errcode and common_errno mapping, instead of a bloated switch/case. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../hisilicon/hns3/hns3vf/hclgevf_cmd.c

Re: [PATCH v4 net-next 1/9] net: switchdev: propagate extack to port attributes

2021-02-11 Thread Florian Fainelli
On 2/11/2021 5:05 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > When a struct switchdev_attr is notified through switchdev, there is no > way to report informational messages, unlike for struct switchdev_obj. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ido Schimmel Reviewed-

Re: [PATCH v5 net-next 09/11] skbuff: allow to optionally use NAPI cache from __alloc_skb()

2021-02-11 Thread Alexander Duyck
On Thu, Feb 11, 2021 at 11:00 AM Alexander Lobakin wrote: > > Reuse the old and forgotten SKB_ALLOC_NAPI to add an option to get > an skbuff_head from the NAPI cache instead of inplace allocation > inside __alloc_skb(). > This implies that the function is called from softirq or BH-off > context, n

Re: [net-next] tcp: Sanitize CMSG flags and reserved args in tcp_zerocopy_receive.

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 13:21:07 -0800 you wrote: > From: Arjun Roy > > Explicitly define reserved field and require it and any subsequent > fields to be zero-valued for now. Additionally, limit the valid CMSG > flags that tc

[PATCH v2 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-11 Thread Nobuhiro Iwamatsu
Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. This patch contains only the basic function of the device. There is no clock control, PM, etc. yet. These will be added in the future. Signed-off-by: Nobuhiro Iwamatsu --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 +

[PATCH v2 1/4] dt-bindings: net: Add DT bindings for Toshiba Visconti TMPV7700 SoC

2021-02-11 Thread Nobuhiro Iwamatsu
Add device tree bindings for ethernet controller of Toshiba Visconti TMPV7700 SoC series. Signed-off-by: Nobuhiro Iwamatsu --- .../bindings/net/toshiba,visconti-dwmac.yaml | 87 +++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/toshi

[PATCH v2 0/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-11 Thread Nobuhiro Iwamatsu
Hi, This series is the ethernet driver for Toshiba's ARM SoC, Visconti[0]. This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files. Best regards, Nobuhiro [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processor

[PATCH v2 3/4] MAINTAINERS: Add entries for Toshiba Visconti ethernet controller

2021-02-11 Thread Nobuhiro Iwamatsu
Add entries for Toshiba Visconti ethernet controller binding and driver. Signed-off-by: Nobuhiro Iwamatsu --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cbf4b94f89d4..6be4bdaabf32 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2641,8 +2641,1

[PATCH v2 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller

2021-02-11 Thread Nobuhiro Iwamatsu
Add the ethernet controller node in Toshiba Visconti5 SoC-specific DT file. And enable this node in TMPV7708 RM main board's board-specific DT file. Signed-off-by: Nobuhiro Iwamatsu --- .../boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 18 ++ arch/arm64/boot/dts/toshiba/tmpv7708.dtsi

[net 15/15] net/mlx5e: Check tunnel offload is required before setting SWP

2021-02-11 Thread Saeed Mahameed
From: Moshe Shemesh Check that tunnel offload is required before setting Software Parser offsets to get Geneve HW offload. In case of Geneve packet we check HW offload support of SWP in mlx5e_tunnel_features_check() and set features accordingly, this should be reflected in skb offload requested b

[net 14/15] net/mlx5e: CT: manage the lifetime of the ct entry object

2021-02-11 Thread Saeed Mahameed
From: Oz Shlomo The ct entry object is accessed by the ct add, del, stats and restore methods. In addition, it is referenced from several hash tables. The lifetime of the ct entry object was not managed which triggered race conditions as in the following kasan dump: [ 3374.973945] =

[net 13/15] net/mlx5: Disable devlink reload for lag devices

2021-02-11 Thread Saeed Mahameed
From: Shay Drory Devlink reload can't be allowed on lag devices since reloading one lag device will cause traffic on the bond to get stucked. Users who wish to reload a lag device, need to remove the device from the bond, and only then reload it. Fixes: 4383cfcc65e7 ("net/mlx5: Add devlink reloa

[net 09/15] net/mlx5e: kTLS, Use refcounts to free kTLS RX priv context

2021-02-11 Thread Saeed Mahameed
From: Maxim Mikityanskiy wait_for_resync is unreliable - if it timeouts, priv_rx will be freed anyway. However, mlx5e_ktls_handle_get_psv_completion will be called sooner or later, leading to use-after-free. For example, it can happen if a CQ error happened, and ICOSQ stopped, but later on the qu

[net 12/15] net/mlx5: Disallow RoCE on lag device

2021-02-11 Thread Saeed Mahameed
From: Shay Drory In lag mode, setting roce enabled/disable of lag device have no effect. e.g.: bond device (roce/vf_lag) roce status remain unchanged. Therefore disable it and add an error message. Fixes: cc9defcbb8fa ("net/mlx5: Handle "enable_roce" devlink param") Signed-off-by: Shay Drory Re

[net 11/15] net/mlx5: Disallow RoCE on multi port slave device

2021-02-11 Thread Saeed Mahameed
From: Shay Drory In dual port mode, setting roce enabled/disable for the slave device have no effect. e.g.: the slave device roce status remain unchanged. Therefore disable it and add an error message. Enable or disable roce of the master device affect both master and slave devices. Fixes: cc9de

[net 10/15] net/mlx5: Disable devlink reload for multi port slave device

2021-02-11 Thread Saeed Mahameed
From: Shay Drory Devlink reload can't be allowed on a multi port slave device, because reload of slave device doesn't take effect. The right flow is to disable devlink reload for multi port slave device. Hence, disabling it in mlx5_core probing. Fixes: 4383cfcc65e7 ("net/mlx5: Add devlink reloa

[net 01/15] net/mlx5e: E-switch, Fix rate calculation for overflow

2021-02-11 Thread Saeed Mahameed
From: Parav Pandit rate_bytes_ps is a 64-bit field. It passed as 32-bit field to apply_police_params(). Due to this when police rate is higher than 4Gbps, 32-bit calculation ignores the carry. This results in incorrect rate configurationn the device. Fix it by performing 64-bit calculation. Fix

[net 07/15] net/mlx5e: Replace synchronize_rcu with synchronize_net

2021-02-11 Thread Saeed Mahameed
From: Maxim Mikityanskiy The commit cited below switched from using napi_synchronize to synchronize_rcu to have a guarantee that it will finish in finite time. However, on average, synchronize_rcu takes more time than napi_synchronize. Given that it's called multiple times per channel on deactiva

[net 08/15] net/mlx5e: Fix CQ params of ICOSQ and async ICOSQ

2021-02-11 Thread Saeed Mahameed
From: Maxim Mikityanskiy The commit mentioned below has split the parameters of ICOSQ and async ICOSQ, but it contained a typo: the CQ parameters were swapped for ICOSQ and async ICOSQ. Async ICOSQ is longer than the normal ICOSQ, and the CQ size must be the same as the size of the corresponding

[net 05/15] net/mlx5e: Change interrupt moderation channel params also when channels are closed

2021-02-11 Thread Saeed Mahameed
From: Maxim Mikityanskiy struct mlx5e_params contains fields ({rx,tx}_cq_moderation) that depend on two things: whether DIM is enabled and the state of a private flag (MLX5E_PFLAG_{RX,TX}_CQE_BASED_MODER). Whenever the DIM state changes, mlx5e_reset_{rx,tx}_moderation is called to update the fiel

[pull request][net 00/15] mlx5 fixes 2021-02-11

2021-02-11 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series introduces some fixes to mlx5 driver. Please pull and let me know if there is any problem. For -stable v5.4 ('net/mlx5e: E-switch, Fix rate calculation for overflow')i For -stable v5.10 ('net/mlx5: Disallow RoCE on multi port slave device') (

[net 02/15] net/mlx5e: Enable striding RQ for Connect-X IPsec capable devices

2021-02-11 Thread Saeed Mahameed
From: Raed Salem This limitation was inherited by previous Innova (FPGA) IPsec implementation, it uses its private set of RQ handlers which does not support striding rq, for Connect-X this is no longer true. Fix by keeping this limitation only for Innova IPsec supporting devices, as otherwise th

[net 06/15] net/mlx5: Fix health error state handling

2021-02-11 Thread Saeed Mahameed
From: Shay Drory Currently, when we discover a fatal error, we are queueing a work that will wait for a lock in order to enter the device to error state. Meanwhile, FW commands are still being processed, and gets timeouts. This can block the driver for few minutes before the work will manage to g

[net 04/15] net/mlx5e: Don't change interrupt moderation params when DIM is enabled

2021-02-11 Thread Saeed Mahameed
From: Maxim Mikityanskiy When mlx5e_ethtool_set_coalesce doesn't change DIM state (enabled/disabled), it calls mlx5e_set_priv_channels_coalesce unconditionally, which in turn invokes a firmware command to set interrupt moderation parameters. It shouldn't happen while DIM manages those parameters

[net 03/15] net/mlx5e: Enable XDP for Connect-X IPsec capable devices

2021-02-11 Thread Saeed Mahameed
From: Raed Salem This limitation was inherited by previous Innova (FPGA) IPsec implementation, it uses its private set of RQ handlers which does not support XDP, for Connect-X this is no longer true. Fix by keeping this limitation only for Innova IPsec supporting devices, as otherwise this limit

Re: [PATCH net 0/6] mptcp: Miscellaneous fixes

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 11 Feb 2021 15:30:36 -0800 you wrote: > Here are some MPTCP fixes for the -net tree, addressing various issues > we have seen thanks to syzkaller and other testing: > > Patch 1 correctly propagates errors at connection

Re: [PATCH net] dpaa2-eth: fix memory leak in XDP_REDIRECT

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 11 Feb 2021 21:51:22 +0200 you wrote: > From: Ioana Ciornei > > If xdp_do_redirect() fails, the calling driver should handle recycling > or freeing of the page associated with the frame. The dpaa2-eth driver > didn't d

Re: [PATCH net] net: phy: consider that suspend2ram may cut off PHY power

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 11 Feb 2021 22:32:52 +0100 you wrote: > Claudiu reported that on his system S2R cuts off power to the PHY and > after resuming certain PHY settings are lost. The PM folks confirmed > that cutting off power to selected co

Re: [PATCH 3/3] net:ethernet:rmnet: Add support for Mapv5 Uplink packet

2021-02-11 Thread kernel test robot
Hi Sharath, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipvs/master] [also build test WARNING on linus/master sparc-next/master v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v2] enetc: auto select PHYLIB and MDIO_DEVRES

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 11 Feb 2021 12:54:11 -0500 you wrote: > FSL_ENETC_MDIO use symbols from PHYLIB (MDIO_BUS) and MDIO_DEVRES, > however there are no dependency specified in Kconfig > > ERROR: modpost: "__mdiobus_register" > [drivers/net/

Re: [PATCH net-next] r8169: handle tx before rx in napi poll

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 21:20:08 +0100 you wrote: > Cleaning up tx descriptors first increases the chance that > rtl_rx() can allocate new skb's from the cache. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet

Re: [Patch net-next v3] net: fix dev_ifsioc_locked() race condition

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 11:34:10 -0800 you wrote: > From: Cong Wang > > dev_ifsioc_locked() is called with only RCU read lock, so when > there is a parallel writer changing the mac address, it could > get a partially updated

[PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-11 Thread Shuah Khan
ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() return pointer (sta) outside null check. Fix it by moving the code block under the null check. This problem was found while reviewing code to debug RCU warn from ath10k_wmi_tlv_parse_peer_stats_info() and a subsequent manual audit o

[PATCH] rtw88: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-02-11 Thread Shuah Khan
ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and the resulting pointer is only valid under RCU lock as well. Fix rtw_rx_addr_match_iter() to hold RCU read lock before it calls ieee80211_find_sta_by_ifaddr() and release it when the resulting pointer is no longer needed. This pr

[PATCH 1/2] ath9k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-02-11 Thread Shuah Khan
ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and the resulting pointer is only valid under RCU lock as well. Fix ath_tx_process_buffer() to hold RCU read lock before it calls ieee80211_find_sta_by_ifaddr() and release it when the resulting pointer is no longer needed. This pro

[PATCH] mt76: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-02-11 Thread Shuah Khan
ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and the resulting pointer is only valid under RCU lock as well. Fix mt76_check_sta() to hold RCU read lock before it calls ieee80211_find_sta_by_ifaddr() and release it when the resulting pointer is no longer needed. This problem wa

[PATCH v2 bpf 2/2] bpf: selftests: Add non function pointer test to struct_ops

2021-02-11 Thread Martin KaFai Lau
This patch adds a "void *owner" member. The existing bpf_tcp_ca test will ensure the bpf_cubic.o and bpf_dctcp.o can be loaded. Acked-by: Andrii Nakryiko Signed-off-by: Martin KaFai Lau --- tools/testing/selftests/bpf/bpf_tcp_helpers.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/

[PATCH v2 bpf 1/2] libbpf: Ignore non function pointer member in struct_ops

2021-02-11 Thread Martin KaFai Lau
When libbpf initializes the kernel's struct_ops in "bpf_map__init_kern_struct_ops()", it enforces all pointer types must be a function pointer and rejects others. It turns out to be too strict. For example, when directly using "struct tcp_congestion_ops" from vmlinux.h, it has a "struct module *o

Re: [PATCH v2 0/4] net: ti: am65-cpsw-nuss: Add switchdev driver

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 16:26:40 +0530 you wrote: > This series adds switchdev support for AM65 CPSW NUSS driver to support > multi port CPSW present on J721e and AM64 SoCs. > It adds devlink hook to switch b/w switch mode and

Re: [net-next] tcp: Sanitize CMSG flags and reserved args in tcp_zerocopy_receive.

2021-02-11 Thread Jakub Kicinski
On Thu, 11 Feb 2021 13:21:07 -0800 Arjun Roy wrote: > + if (unlikely(len > sizeof(zc))) { > + err = check_zeroed_user(optval + sizeof(zc), > + len - sizeof(zc)); > + if (err < 1) > +

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2021-02-11 Thread Alexei Starovoitov
On Thu, Feb 11, 2021 at 5:26 PM Jakub Kicinski wrote: > > Perhaps I had seen one too many vendor incompatibility to trust that > adding a driver API without a validation suite will result in something > usable in production settings. I agree with Jakub. I don't see how extra ethtool reporting wil

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread Jakub Kicinski
On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: > +/* MAP CSUM headers */ > +struct rmnet_map_v5_csum_header { > + u8 next_hdr:1; > + u8 header_type:7; > + u8 hw_reserved:5; > + u8 priority:1; > + u8 hw_reserved_bit:1; > + u8 csum_valid_required:1; >

Re: [PATCH net-next 0/3] Compile-flag for sock RX queue mapping

2021-02-11 Thread Jakub Kicinski
On Thu, 11 Feb 2021 13:35:50 +0200 Tariq Toukan wrote: > Socket's RX queue mapping logic is useful also for non-XPS use cases. > This series breaks the dependency between the two, introducing a new > kernel config flag SOCK_RX_QUEUE_MAPPING. > > Here we select this new kernel flag from TLS_DEVICE,

Re: [PATCH net-next] avoid fragmenting page memory with netdev_alloc_cache

2021-02-11 Thread kernel test robot
Hi Ronak, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Ronak-Doshi/avoid-fragmenting-page-memory-with-netdev_alloc_cache/20210212-082217 base: https://git.kernel.org/pub/scm/linux/kernel/gi

linux-next: manual merge of the net-next tree with the net tree

2021-02-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/uapi/linux/pkt_cls.h between commit: 1bcc51ac0731 ("net/sched: cls_flower: Reject invalid ct_state flags rules") from the net tree and commits: 7baf2429a1a9 ("net/sched: cls_flower add CT_FLAGS_INVALID flag

[PATCH v6 bpf-next 4/4] selftests/bpf: add test for bpf_iter_task_vma

2021-02-11 Thread Song Liu
The test dumps information similar to /proc/pid/maps. The first line of the output is compared against the /proc file to make sure they match. Acked-by: Yonghong Song Signed-off-by: Song Liu --- .../selftests/bpf/prog_tests/bpf_iter.c | 118 -- tools/testing/selftests/bpf/

Re: Refcount mismatch when unregistering netdevice from kernel

2021-02-11 Thread Alexei Starovoitov
On Thu, Feb 11, 2021 at 5:28 PM Jakub Kicinski wrote: > > On Thu, 11 Feb 2021 11:21:26 -0800 Alexei Starovoitov wrote: > > On Tue, Jan 5, 2021 at 11:11 AM Wei Wang wrote: > > > On Mon, Jan 4, 2021 at 8:58 PM David Ahern wrote: > > > > On 1/4/21 8:05 PM, stran...@codeaurora.org wrote: > > > Ah, I

[PATCH v6 bpf-next 3/4] libbpf: introduce section "iter.s/" for sleepable bpf_iter program

2021-02-11 Thread Song Liu
Sleepable iterator program have access to helper functions like bpf_d_path. Acked-by: Yonghong Song Acked-by: KP Singh Signed-off-by: Song Liu --- tools/lib/bpf/libbpf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 2abbc38005684

[PATCH v6 bpf-next 0/4] introduce bpf_iter for task_vma

2021-02-11 Thread Song Liu
This set introduces bpf_iter for task_vma, which can be used to generate information similar to /proc/pid/maps. Patch 4/4 adds an example that mimics /proc/pid/maps. Current /proc//maps and /proc//smaps provide information of vma's of a process. However, these information are not flexible enough t

[PATCH v6 bpf-next 2/4] bpf: allow bpf_d_path in sleepable bpf_iter program

2021-02-11 Thread Song Liu
task_file and task_vma iter programs have access to file->f_path. Enable bpf_d_path to print paths of these file. bpf_iter programs are generally called in sleepable context. However, it is still necessary to diffientiate sleepable and non-sleepable bpf_iter programs: sleepable programs have acces

Re: [PATCH v5 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2021-02-11 Thread Song Liu
> On Feb 10, 2021, at 3:02 PM, Yonghong Song wrote: > > > > On 2/9/21 7:00 PM, Alexei Starovoitov wrote: >> On 2/9/21 2:08 PM, Song Liu wrote: >>> >>> On Feb 9, 2021, at 1:30 PM, Alexei Starovoitov wrote: On Mon, Feb 08, 2021 at 02:52:52PM -0800, Song Liu wrote:

[PATCH v6 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2021-02-11 Thread Song Liu
Introduce task_vma bpf_iter to print memory information of a process. It can be used to print customized information similar to /proc//maps. Current /proc//maps and /proc//smaps provide information of vma's of a process. However, these information are not flexible enough to cover all use cases. Fo

Re: [net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

2021-02-11 Thread Jakub Kicinski
On Thu, 11 Feb 2021 19:12:57 + Vadim Fedorenko wrote: > On 09.02.2021 13:54, Vadim Fedorenko wrote: > > As udp_port_cfg struct changes its members with dependency on IPv6 > > configuration, the code in rxrpc should also check for IPv6. > > Looks like this patch was mistakely tagged as supers

Re: [PATCH v4] Bluetooth: Keep MSFT ext info throughout a hci_dev's life cycle

2021-02-11 Thread Miao-chen Chou
Hi Marcel, A friendly ping on this patch. :) Regards, Miao On Wed, Jan 27, 2021 at 9:17 AM Miao-chen Chou wrote: > > This moves msft_do_close() from hci_dev_do_close() to > hci_unregister_dev() to avoid clearing MSFT extension info. This also > re-reads MSFT info upon every msft_do_open() even

Re: [PATCH net-next v2 1/5] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-11 Thread Sergej Bauer
On Friday, February 12, 2021 3:27:40 AM MSK you wrote: > Hi Sergej, thank you for testing this ! Don't mention it, it's just a small assistance > On Thu, Feb 11, 2021 at 7:18 PM Sergej Bauer wrote: > > although whole set of tests might be an overly extensive, but after > > applying patch v2 [1/5

Re: Refcount mismatch when unregistering netdevice from kernel

2021-02-11 Thread Jakub Kicinski
On Thu, 11 Feb 2021 11:21:26 -0800 Alexei Starovoitov wrote: > On Tue, Jan 5, 2021 at 11:11 AM Wei Wang wrote: > > On Mon, Jan 4, 2021 at 8:58 PM David Ahern wrote: > > > On 1/4/21 8:05 PM, stran...@codeaurora.org wrote: > > Ah, I see now. rt6_flush_exceptions is called by fib6_del_route, but

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2021-02-11 Thread Jakub Kicinski
On Wed, 10 Feb 2021 23:52:39 +0100 Toke Høiland-Jørgensen wrote: > Jakub Kicinski writes: > > On Wed, 10 Feb 2021 11:53:53 +0100 Toke Høiland-Jørgensen wrote: > >> While I do agree that that kind of conformance test would be great, I > >> don't think it has to hold up this series (the perfect be

[PATCH v4 net-next 8/9] net: mscc: ocelot: offload bridge port flags to device

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean We should not be unconditionally enabling address learning, since doing that is actively detrimential when a port is standalone and not offloading a bridge. Namely, if a port in the switch is standalone and others are offloading the bridge, then we could enter a situation wh

[PATCH v4 net-next 9/9] net: dsa: sja1105: offload bridge port flags to device

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean The chip can configure unicast flooding, broadcast flooding and learning. Learning is per port, while flooding is per {ingress, egress} port pair and we need to configure the same value for all possible ingress ports towards the requested one. While multicast flooding is no

[PATCH v4 net-next 6/9] net: dsa: act as ass passthrough for bridge port flags

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean There are multiple ways in which a PORT_BRIDGE_FLAGS attribute can be expressed by the bridge through switchdev, and not all of them can be emulated by DSA mid-layer API at the same time. One possible configuration is when the bridge offloads the port flags using a mask tha

[PATCH v4 net-next 7/9] net: mscc: ocelot: use separate flooding PGID for broadcast

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean In preparation of offloading the bridge port flags which have independent settings for unknown multicast and for broadcast, we should also start reserving one destination Port Group ID for the flooding of broadcast packets, to allow configuring it individually. Signed-off-b

[PATCH v4 net-next 4/9] net: dsa: configure better brport flags when ports leave the bridge

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean For a DSA switch port operating in standalone mode, address learning doesn't make much sense since that is a bridge function. In fact, address learning even breaks setups such as this one: +-+ |

[PATCH v4 net-next 5/9] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean This switchdev attribute offers a counterproductive API for a driver writer, because although br_switchdev_set_port_flag gets passed a "flags" and a "mask", those are passed piecemeal to the driver, so while the PRE_BRIDGE_FLAGS listener knows what changed because it has the

[PATCH v4 net-next 3/9] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean For the netlink interface, propagate errors through extack rather than simply printing them to the console. For the sysfs interface, we still print to the console, but at least that's one layer higher than in switchdev, which also allows us to silently ignore the offloading

[PATCH v4 net-next 2/9] net: bridge: offload all port flags at once in br_setport

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean If for example this command: ip link set swp0 type bridge_slave flood off mcast_flood off learning off succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at BR_LEARNING, there would be no attempt to revert the partial state in any way. Arguably, if the user chang

[PATCH v4 net-next 1/9] net: switchdev: propagate extack to port attributes

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean When a struct switchdev_attr is notified through switchdev, there is no way to report informational messages, unlike for struct switchdev_obj. Signed-off-by: Vladimir Oltean Reviewed-by: Ido Schimmel --- Changes in v3: None. Changes in v2: Patch is new. .../ethernet/ma

[PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA

2021-02-11 Thread Vladimir Oltean
From: Vladimir Oltean The initial goal of this series was to have better support for standalone ports mode on the DSA drivers like ocelot/felix and sja1105. This turned out to require some API adjustments in both directions: to the information presented to and by the switchdev notifier, and to th

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-11 Thread Saeed Mahameed
On Thu, 2021-02-11 at 23:59 +0200, Ido Schimmel wrote: > On Wed, Feb 10, 2021 at 09:09:41PM -0800, Saeed Mahameed wrote: > > This won't solve anything other than compilation time dependency > > between built-in modules to external modules, this is not the case. > > > > our case is when both mlx5 a

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-11 Thread Nobuhiro Iwamatsu
Hi, Thanks for your comment. On Thu, Feb 11, 2021 at 02:13:07PM -0800, David Miller wrote: > From: Nobuhiro Iwamatsu > Date: Thu, 11 Feb 2021 01:29:52 +0900 > > > +static int visconti_eth_init_hw(struct platform_device *pdev, struct > > plat_stmmacenet_data *plat_dat) > > +{ > > + struct vis

  1   2   3   4   >