Hi Sharath, Thank you for the patch! Yet something to improve:
[auto build test ERROR on ipvs/master] [also build test ERROR on linus/master sparc-next/master v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sharath-Chandra-Vurukala/docs-networking-Add-documentation-for-MAP-v5/20210212-063547 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/293142d706c02bf2e6ce7acb4e04ebb6cf4a2a63 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sharath-Chandra-Vurukala/docs-networking-Add-documentation-for-MAP-v5/20210212-063547 git checkout 293142d706c02bf2e6ce7acb4e04ebb6cf4a2a63 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> Note: the linux-review/Sharath-Chandra-Vurukala/docs-networking-Add-documentation-for-MAP-v5/20210212-063547 HEAD 7f0a1e35c1d1c17de5873aded88d5dadfedce2fb builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c: In function 'rmnet_map_egress_handler': >> drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:153:15: error: too few >> arguments to function 'rmnet_map_add_map_header' 153 | map_header = rmnet_map_add_map_header(skb, additional_header_len, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:14: drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h:66:26: note: declared here 66 | struct rmnet_map_header *rmnet_map_add_map_header(struct sk_buff *skb, | ^~~~~~~~~~~~~~~~~~~~~~~~ At top level: drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h:76:11: warning: 'rmnet_map_get_next_hdr_type' defined but not used [-Wunused-function] 76 | static u8 rmnet_map_get_next_hdr_type(struct sk_buff *skb) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- >> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:270:26: error: >> conflicting types for 'rmnet_map_add_map_header' 270 | struct rmnet_map_header *rmnet_map_add_map_header(struct sk_buff *skb, | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:12: drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h:66:26: note: previous declaration of 'rmnet_map_add_map_header' was here 66 | struct rmnet_map_header *rmnet_map_add_map_header(struct sk_buff *skb, | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +/rmnet_map_add_map_header +153 drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 129 ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 130 static int rmnet_map_egress_handler(struct sk_buff *skb, 56470c927f1ba1 Subash Abhinov Kasiviswanathan 2017-10-11 131 struct rmnet_port *port, u8 mux_id, ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 132 struct net_device *orig_dev) ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 133 { ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 134 int required_headroom, additional_header_len; ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 135 struct rmnet_map_header *map_header; ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 136 ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 137 additional_header_len = 0; ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 138 required_headroom = sizeof(struct rmnet_map_header); ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 139 14452ca3b5ce30 Subash Abhinov Kasiviswanathan 2018-03-21 140 if (port->data_format & RMNET_FLAGS_EGRESS_MAP_CKSUMV4) { 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 141 additional_header_len = sizeof(struct rmnet_map_ul_csum_header); 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 142 required_headroom += additional_header_len; 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 143 } 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 144 ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 145 if (skb_headroom(skb) < required_headroom) { 6392ff3c8e4c23 Subash Abhinov Kasiviswanathan 2018-10-02 146 if (pskb_expand_head(skb, required_headroom, 0, GFP_ATOMIC)) 1eece799d3f611 Subash Abhinov Kasiviswanathan 2018-05-15 147 return -ENOMEM; ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 148 } ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 149 14452ca3b5ce30 Subash Abhinov Kasiviswanathan 2018-03-21 150 if (port->data_format & RMNET_FLAGS_EGRESS_MAP_CKSUMV4) 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 151 rmnet_map_checksum_uplink_packet(skb, orig_dev); 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 152 ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 @153 map_header = rmnet_map_add_map_header(skb, additional_header_len, 0); ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 154 if (!map_header) 1eece799d3f611 Subash Abhinov Kasiviswanathan 2018-05-15 155 return -ENOMEM; ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 156 56470c927f1ba1 Subash Abhinov Kasiviswanathan 2017-10-11 157 map_header->mux_id = mux_id; ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 158 ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 159 skb->protocol = htons(ETH_P_MAP); ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 160 cf2fe57b0cc220 Subash Abhinov Kasiviswanathan 2017-12-11 161 return 0; ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 162 } ceed73a2cf4aff Subash Abhinov Kasiviswanathan 2017-08-29 163 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
