[PATCH net-next v2 3/3] xsk: build skb by page

2021-01-19 Thread Xuan Zhuo
This patch is used to construct skb based on page to save memory copy overhead. This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to directly construct skb. If this feature is not supported, it is still necessar

Re: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-19 Thread Michael S. Tsirkin
On Mon, Jan 18, 2021 at 06:03:57PM +, Parav Pandit wrote: > Hi Michael, Jason, > > > From: Jason Wang > > Sent: Friday, January 15, 2021 11:09 AM > > > > > > Thanks for the clarification. I think we'd better document the above in the > > patch that introduces the mac setting from management

[PATCH net-next v2 2/3] virtio-net: support IFF_TX_SKB_NO_LINEAR

2021-01-19 Thread Xuan Zhuo
Virtio net supports the case where the skb linear space is empty, so add priv_flags. Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index ba8e637..f2ff6c3 100644 --- a

Re: Re: [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 2:24 PM Jason Wang wrote: > > > On 2021/1/19 下午12:59, Xie Yongji wrote: > > Add an opaque pointer for vhost IOTLB to store the > > corresponding vma->vm_file and offset on the DMA mapping. > > > Let's split the patch into two. > > 1) opaque pointer > 2) vma stuffs > OK. >

[PATCH v2 net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-19 Thread Heiner Kallweit
The comment is quite weird, there is no such thing as a vendor-specific VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are doing here is simply checking whether the byte at VPD address VPD_BASE is a valid string LRDT, same as what is done a few lines later in the code. LRDT = Large

[PATCH] rtlwifi: Assign boolean values to a bool variable

2021-01-19 Thread Jiapeng Zhong
Fix the following coccicheck warnings: ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c: 892:1-10: WARNING: Assignment of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +- 1 file

Re: [PATCH net-next v2 14/17] ethernet: ucc_geth: replace kmalloc_array()+for loop by kcalloc()

2021-01-19 Thread Christophe Leroy
Can you detail a bit the change ? At least tell that the loop was a zeroising loop and that kcalloc() already zeroises the allocated memory ? Le 19/01/2021 à 16:07, Rasmus Villemoes a écrit : Signed-off-by: Rasmus Villemoes --- drivers/net/ethernet/freescale/ucc_geth.c | 14 --

Re: [PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

2021-01-19 Thread Kurt Kanzenbach
On Tue Jan 19 2021, Jakub Kicinski wrote: > On Sat, 16 Jan 2021 13:49:22 +0100 Kurt Kanzenbach wrote: >> +if (base_time_ns - current_ns < (s64)8 * NSEC_PER_SEC) >> +return true; >> + >> +return false; > > nit: > return base_time_ns - current_ns < (s64)8 * NSEC_PER_SEC; Su

Re: [PATCH net-next v2 13/17] ethernet: ucc_geth: remove bd_mem_part and all associated code

2021-01-19 Thread Christophe Leroy
Le 19/01/2021 à 16:07, Rasmus Villemoes a écrit : The bd_mem_part member of ucc_geth_info always has the value MEM_PART_SYSTEM, and AFAICT, there has never been any code setting it to any other value. Moreover, muram is a somewhat precious resource, so there's no point using that when normal m

[PATCH] net/bluetooth: Fix the follow coccicheck warnings

2021-01-19 Thread Jiapeng Zhong
./net/bluetooth/hci_debugfs.c: WARNING: sniff_min_interval_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Signed-off-by: Jiapeng Zhong Reported-by: Abaci Robot --- net/bluetooth/hci_debugfs.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) di

Re: Re: [RFC v3 05/11] vdpa: shared virtual addressing support

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 1:55 PM Jason Wang wrote: > > > On 2021/1/19 下午12:59, Xie Yongji wrote: > > This patches introduces SVA (Shared Virtual Addressing) > > support for vDPA device. During vDPA device allocation, > > vDPA device driver needs to indicate whether SVA is > > supported by the devic

Re: [PATCH net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-19 Thread Heiner Kallweit
On 19.01.2021 23:02, Jakub Kicinski wrote: > On Sat, 16 Jan 2021 14:45:25 +0100 Heiner Kallweit wrote: >> The comment is quite weird, there is no such thing as a vendor-specific >> VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are >> doing here is simply checking whether the byte

Re: [PATCH net-next v2 11/17] ethernet: ucc_geth: don't statically allocate eight ucc_geth_info

2021-01-19 Thread Christophe Leroy
Le 19/01/2021 à 16:07, Rasmus Villemoes a écrit : struct ucc_geth_info is somewhat large, and on systems with only one or two UCC instances, that just wastes a few KB of memory. So allocate and populate a chunk of memory at probe time instead of initializing them all during driver init. Note

[PATCH] cxgb4: Assign boolean values to a bool variable

2021-01-19 Thread Jiapeng Zhong
Fix the following coccicheck warnings: ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5142:2-33: WARNING: Assignment of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH net-next v2 08/17] ethernet: ucc_geth: remove {rx,tx}_glbl_pram_offset from struct ucc_geth_private

2021-01-19 Thread Christophe Leroy
Le 19/01/2021 à 16:07, Rasmus Villemoes a écrit : These fields are only used within ucc_geth_startup(), so they might as well be local variables in that function rather than being stashed in struct ucc_geth_private. Aside from making that struct a tiny bit smaller, it also shortens some lines

RE: [PATCH net v2] udp: ipv4: manipulate network header of NATed UDP GRO fraglist

2021-01-19 Thread Dongseok Yi
On 2021-01-18 22:27, Steffen Klassert wrote: > On Fri, Jan 15, 2021 at 10:20:35PM +0900, Dongseok Yi wrote: > > UDP/IP header of UDP GROed frag_skbs are not updated even after NAT > > forwarding. Only the header of head_skb from ip_finish_output_gso -> > > skb_gso_segment is updated but following f

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: > > > On 2021/1/19 下午12:59, Xie Yongji wrote: > > Now we have a global percpu counter to limit the recursion depth > > of eventfd_signal(). This can avoid deadlock or stack overflow. > > But in stack overflow case, it should be OK to increase the

Re: [PATCH v2 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-19 Thread praveen chaudhary
> On Jan 19, 2021, at 8:22 PM, David Ahern wrote: > > On 1/19/21 3:17 PM, praveen chaudhary wrote: For IPv4: Config in etc/network/interfa

Re: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 11:47 AM Jason Wang wrote: > > > On 2021/1/19 下午12:59, Xie Yongji wrote: > > With VDUSE, we should be able to support all kinds of virtio devices. > > > > Signed-off-by: Xie Yongji > > --- > > drivers/vhost/vdpa.c | 29 +++-- > > 1 file changed,

Re: Re: [RFC v3 04/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 11:44 AM Jason Wang wrote: > > > On 2021/1/19 下午12:59, Xie Yongji wrote: > > Introduce a mutex to protect vhost device iotlb from > > concurrent access. > > > > Fixes: 4c8cf318("vhost: introduce vDPA-based backend") > > Signed-off-by: Xie Yongji > > --- > > drivers/vhost

[PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-19 Thread Pawel Dembicki
This patch adds support for vlan filtering in vsc73xx driver. After vlan filtering enable, CPU_PORT is configured as trunk, without non-tagged frames. This allows to avoid problems with transmit untagged frames because vsc73xx is DSA_TAG_PROTO_NONE. Signed-off-by: Pawel Dembicki --- drivers/net

Re: [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB

2021-01-19 Thread Jason Wang
On 2021/1/19 下午12:59, Xie Yongji wrote: Add an opaque pointer for vhost IOTLB to store the corresponding vma->vm_file and offset on the DMA mapping. Let's split the patch into two. 1) opaque pointer 2) vma stuffs It will be used in VDUSE case later. Suggested-by: Jason Wang Signed-off

[PATCH] igc: Assign boolean values to a bool variable

2021-01-19 Thread Jiapeng Zhong
Fix the following coccicheck warnings: ./drivers/net/ethernet/intel/igc/igc_main.c:4961:2-14: WARNING: Assignment of 0/1 to bool variable. ./drivers/net/ethernet/intel/igc/igc_main.c:4955:2-14: WARNING: Assignment of 0/1 to bool variable. ./drivers/net/ethernet/intel/igc/igc_main.c:4933:1-13: WA

Re: [PATCH net-next v4] bonding: add a vlan+srcmac tx hashing option

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 18 Jan 2021 20:09:27 -0500 you wrote: > This comes from an end-user request, where they're running multiple VMs on > hosts with bonded interfaces connected to some interest switch topologies, > where 802.3ad isn't a

Re: [PATCH net] tcp: fix TCP socket rehash stats mis-accounting

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 19 Jan 2021 11:26:19 -0800 you wrote: > The previous commit 32efcc06d2a1 ("tcp: export count for rehash attempts") > would mis-account rehashing SNMP and socket stats: > > a. During handshake of an active open, only c

Re: [PATCH AUTOSEL 5.10 28/45] net: stmmac: Fixed mtu channged by cache aligned

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 20:25:45 -0500 Sasha Levin wrote: > From: David Wu > > [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ] > > Since the original mtu is not used when the mtu is updated, > the mtu is aligned with cache, this will get an incorrect. > For example, if you want to confi

Re: [RFC v3 05/11] vdpa: shared virtual addressing support

2021-01-19 Thread Jason Wang
On 2021/1/19 下午12:59, Xie Yongji wrote: This patches introduces SVA (Shared Virtual Addressing) support for vDPA device. During vDPA device allocation, vDPA device driver needs to indicate whether SVA is supported by the device. Then vhost-vdpa bus driver will not pin user page and transfer use

Re: [PATCH v1] vdpa/mlx5: Fix memory key MTT population

2021-01-19 Thread Eli Cohen
On Fri, Jan 08, 2021 at 04:38:55PM +0800, Jason Wang wrote: Hi Michael, this patch is a fix. Are you going to merge it? > > On 2021/1/7 下午3:18, Eli Cohen wrote: > > map_direct_mr() assumed that the number of scatter/gather entries > > returned by dma_map_sg_attrs() was equal to the number of seg

[PATCH] Revert "octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers"

2021-01-19 Thread sundeep . lkml
From: Subbaraya Sundeep Octeontx2 hardware needs buffer pointers which are 128 byte aligned. napi_alloc_frag() returns buffer pointers which are not 128 byte aligned sometimes because if napi_alloc_skb() is called when a packet is received then subsequent napi_alloc_frag() returns buffer which is

Re: [PATCH] net: systemport: free dev before on error path

2021-01-19 Thread Florian Fainelli
On 1/19/2021 8:44 PM, Pan Bian wrote: > On the error path, it should goto the error handling label to free > allocated memory rather than directly return. > > Fixes: 6328a126896e ("net: systemport: Manage Wake-on-LAN clock") > Signed-off-by: Pan Bian The change is correct, but not the Fixes t

"WARNING: locking bug in finish_task_switch" and "WARNING: locking bug in finish_lock_switch" should share the same root cause

2021-01-19 Thread 慕冬亮
Dear kernel developers, I found that on the syzbot dashboard, “WARNING: locking bug in finish_task_switch”[1] and "WARNING: locking bug in finish_lock_switch"[2] should share the same root cause. The reasons for the above statement: 1) the stack trace is the same, and this title difference is due

[PATCH] net: systemport: free dev before on error path

2021-01-19 Thread Pan Bian
On the error path, it should goto the error handling label to free allocated memory rather than directly return. Fixes: 6328a126896e ("net: systemport: Manage Wake-on-LAN clock") Signed-off-by: Pan Bian --- drivers/net/ethernet/broadcom/bcmsysport.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH v2] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

2021-01-19 Thread Giacinto Cifelli
Bus 003 Device 009: ID 1e2d:006f Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 239 Miscellaneous Device bDeviceSubClass 2 ? bDeviceProtocol 1 Interface Association bMaxPacketSize064 idVe

Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

2021-01-19 Thread Giacinto Cifelli
Hi Reinhard, > > AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply > be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8 > ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201") > and commit 97dc47a1308a3af46a09b1546cfb869f2e382a

Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-19 Thread Jason Wang
On 2021/1/19 下午12:59, Xie Yongji wrote: Now we have a global percpu counter to limit the recursion depth of eventfd_signal(). This can avoid deadlock or stack overflow. But in stack overflow case, it should be OK to increase the recursion depth if needed. So we add a percpu counter in eventfd_c

Re: [PATCH v2 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-19 Thread David Ahern
On 1/19/21 3:17 PM, praveen chaudhary wrote: >>> >>> For IPv4: >>> >>> >>> Config in etc/network/interfaces >>> -

Re: commit 4c7ea3c0791e (net: dsa: mv88e6xxx: disable SA learning for DSA and CPU ports)

2021-01-19 Thread Horatiu Vultur
The 01/18/2021 23:07, Rasmus Villemoes wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 18/01/2021 22.19, Vladimir Oltean wrote: > > On Sat, Jan 16, 2021 at 02:42:12AM +0100, Tobias Waldekranz wrote: > >>> What I'm _really_ trying to do

Re: [PATCHv8 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2021-01-19 Thread Hangbin Liu
On Tue, Jan 19, 2021 at 03:51:27PM +0100, Jesper Dangaard Brouer wrote: > > @@ -73,13 +90,63 @@ int xdp_redirect_map_prog(struct xdp_md *ctx) > > > > /* count packet in global counter */ > > value = bpf_map_lookup_elem(&rxcnt, &key); > > - if (value) > > + if (value) { > >

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

2021-01-19 Thread Roman Gushchin
On Tue, Jan 19, 2021 at 07:31:51PM -0800, Arjun Roy wrote: > On Wed, Jan 13, 2021 at 11:55 AM Shakeel Butt wrote: > > > > On Wed, Jan 13, 2021 at 11:49 AM Yang Shi wrote: > > > > > > On Wed, Jan 13, 2021 at 11:13 AM Shakeel Butt wrote: > > > > > > > > On Wed, Jan 13, 2021 at 10:43 AM Roman Gushc

[PATCHv15 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-01-19 Thread Hangbin Liu
From: Jesper Dangaard Brouer This changes the devmap XDP program support to run the program when the bulk queue is flushed instead of before the frame is enqueued. This has a couple of benefits: - It "sorts" the packets by destination devmap entry, and then runs the same BPF program on all the

Re: [RFC v3 04/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-01-19 Thread Jason Wang
On 2021/1/19 下午12:59, Xie Yongji wrote: Introduce a mutex to protect vhost device iotlb from concurrent access. Fixes: 4c8cf318("vhost: introduce vDPA-based backend") Signed-off-by: Xie Yongji --- drivers/vhost/vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vhost/vd

[PATCH AUTOSEL 5.10 28/45] net: stmmac: Fixed mtu channged by cache aligned

2021-01-19 Thread Sasha Levin
From: David Wu [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ] Since the original mtu is not used when the mtu is updated, the mtu is aligned with cache, this will get an incorrect. For example, if you want to configure the mtu to be 1500, but mtu 1536 is configured in fact. Fixed:

[PATCH AUTOSEL 5.10 21/45] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-19 Thread Sasha Levin
From: Leon Schuermann [ Upstream commit cb82a54904a99df9e8f9e9d282046055dae5a730 ] This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to use the cdc_ether driver. However, using this driver, with the system suspended the device constantly sends pause-frames as soon as the receive

Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices

2021-01-19 Thread Jason Wang
On 2021/1/19 下午12:59, Xie Yongji wrote: With VDUSE, we should be able to support all kinds of virtio devices. Signed-off-by: Xie Yongji --- drivers/vhost/vdpa.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-19 Thread Parav Pandit
> From: Virtualization On > Behalf Of Parav Pandit > > > From: Jason Wang > > Sent: Tuesday, January 19, 2021 4:39 PM > > To: Parav Pandit ; Michael S. Tsirkin > > > > Cc: virtualizat...@lists.linux-foundation.org; Eli Cohen > > ; netdev@vger.kernel.org; Sean Mooney > > > > Subject: Re: [PAT

[PATCHv15 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2021-01-19 Thread Hangbin Liu
Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. Signed-off-by: Hangbin Liu --- v13-v15: no update v11-v12: rebase the patch to latest

[PATCHv15 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2021-01-19 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

Re: [PATCH net-next v2 5/7] virtio-net, xsk: realize the function of xsk packet sending

2021-01-19 Thread Jason Wang
On 2021/1/18 下午8:03, Xuan Zhuo wrote: On Mon, 18 Jan 2021 17:10:24 +0800, Jason Wang wrote: On 2021/1/16 上午10:59, Xuan Zhuo wrote: virtnet_xsk_run will be called in the tx interrupt handling function virtnet_poll_tx. The sending process gets desc from the xsk tx queue, and assembles it to s

RE: [PATCH net] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Hayes Wang
Grant Grundler > Sent: Wednesday, January 20, 2021 9:12 AM > Subject: [PATCH net] net: usb: cdc_ncm: don't spew notifications > > RTL8156 sends notifications about every 32ms. > Only display/log notifications when something changes. > > This issue has been reported by others: > https://bug

[PATCHv15 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test

2021-01-19 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test we have 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. We will also test both DEVMAP and DEVMAP_HASH

RE: [net-next V7 03/14] devlink: Support add and delete devlink port

2021-01-19 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, January 20, 2021 8:58 AM > > On Mon, 18 Jan 2021 12:12:20 -0800 Saeed Mahameed wrote: > > From: Parav Pandit > > Saeed, this is closed to being merged - when you post the next version please > make sure to CC appropriate folks, in particular anyone w

Re: [PATCH net] net: dsa: b53: fix an off by one in checking "vlan->vid"

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 09:14:03 -0800 Florian Fainelli wrote: > On 1/19/2021 6:48 AM, Dan Carpenter wrote: > > The > comparison should be >= to prevent accessing one element beyond > > the end of the dev->vlans[] array in the caller function, b53_vlan_add(). > > The "dev->vlans" array is allocated in

Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-19 Thread David Ahern
On 1/19/21 1:55 PM, Jakub Kicinski wrote: >> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c >> index e53e43aef785..d5d88f7c5c11 100644 >> --- a/net/ipv4/nexthop.c >> +++ b/net/ipv4/nexthop.c >> @@ -36,6 +36,10 @@ static const struct nla_policy rtm_nh_policy[NHA_MAX + 1] >> = { >> [NHA_F

[PATCH AUTOSEL 5.10 27/45] net: stmmac: use __napi_schedule() for PREEMPT_RT

2021-01-19 Thread Sasha Levin
From: Seb Laveze [ Upstream commit 1f02efd1bb35bee95feed6aab46d1217f29d555b ] Use of __napi_schedule_irqoff() is not safe with PREEMPT_RT in which hard interrupts are not disabled while running the threaded interrupt. Using __napi_schedule() works for both PREEMPT_RT and mainline Linux, just at

[PATCH AUTOSEL 5.4 12/26] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-19 Thread Sasha Levin
From: Leon Schuermann [ Upstream commit cb82a54904a99df9e8f9e9d282046055dae5a730 ] This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to use the cdc_ether driver. However, using this driver, with the system suspended the device constantly sends pause-frames as soon as the receive

Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-19 Thread Jakub Kicinski
On Wed, 20 Jan 2021 02:13:36 + Venkataramanan, Anirudh wrote: > > > As per the current logic, if the driver does not get the number of > > > MSI- > > > X vectors it needs, it will immediately drop to "Do I have at least > > > two > > > (ICE_MIN_LAN_VECS) MSI-X vectors?". If yes, the driver will

[PATCH AUTOSEL 5.4 16/26] net: stmmac: Fixed mtu channged by cache aligned

2021-01-19 Thread Sasha Levin
From: David Wu [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ] Since the original mtu is not used when the mtu is updated, the mtu is aligned with cache, this will get an incorrect. For example, if you want to configure the mtu to be 1500, but mtu 1536 is configured in fact. Fixed:

Re: [net-next V7 03/14] devlink: Support add and delete devlink port

2021-01-19 Thread Jakub Kicinski
On Mon, 18 Jan 2021 12:12:20 -0800 Saeed Mahameed wrote: > From: Parav Pandit Saeed, this is closed to being merged - when you post the next version please make sure to CC appropriate folks, in particular anyone who ever commented on previous versions. Alex, DSA, Edwin, at a quick look but maybe

Re: [PATCH net-next v2 2/7] virtio-net, xsk: distinguish XDP_TX and XSK XMIT ctx

2021-01-19 Thread Jason Wang
On 2021/1/18 下午7:54, Xuan Zhuo wrote: On Mon, 18 Jan 2021 14:45:16 +0800, Jason Wang wrote: On 2021/1/16 上午10:59, Xuan Zhuo wrote: If support xsk, a new ptr will be recovered during the process of freeing the old ptr. In order to distinguish between ctx sent by XDP_TX and ctx sent by xsk, a

[PATCH net-next] vmxnet3: Remove buf_info from device accessible structures

2021-01-19 Thread Ronak Doshi
From: Petr Vandrovec vmxnet3: Remove buf_info from device accessible structures buf_info structures in RX & TX queues are private driver data that do not need to be visible to the device. Although there is physical address and length in the queue descriptor that points to these structures, thei

[PATCHv15 bpf-next 0/6] xdp: add a new helper for dev map multicast support

2021-01-19 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 19:28:40 -0700 David Ahern wrote: > On 1/19/21 1:55 PM, Jakub Kicinski wrote: > >> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c > >> index e53e43aef785..d5d88f7c5c11 100644 > >> --- a/net/ipv4/nexthop.c > >> +++ b/net/ipv4/nexthop.c > >> @@ -36,6 +36,10 @@ static const s

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-19 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, January 19, 2021 4:39 PM > To: Parav Pandit ; Michael S. Tsirkin > Cc: virtualizat...@lists.linux-foundation.org; Eli Cohen ; > netdev@vger.kernel.org; Sean Mooney > Subject: Re: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user > supported devices

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-19 Thread Yongji Xie
On Wed, Jan 20, 2021 at 1:54 AM Randy Dunlap wrote: > > Hi, > > Documentation comments only: > Will fix it. Thanks, Yongji > On 1/18/21 9:07 PM, Xie Yongji wrote: > > > > Signed-off-by: Xie Yongji > > --- > > Documentation/driver-api/vduse.rst | 85 ++ > > > > diff --git a/D

Re: [PATCH v2 net-next] net: fix GSO for SG-enabled devices.

2021-01-19 Thread Jakub Kicinski
On Wed, 20 Jan 2021 10:17:44 +0800 Xin Long wrote: > On Wed, Jan 20, 2021 at 12:57 AM Paolo Abeni wrote: > > > > The commit dbd50f238dec ("net: move the hsize check to the else > > block in skb_segment") introduced a data corruption for devices > > supporting scatter-gather. > > > > The problem bo

Re: [PATCH bpf-next v2] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

2021-01-19 Thread Nick Desaulniers
On Mon, Jan 18, 2021 at 11:56 PM Tiezhu Yang wrote: > > The current llvm/clang build procedure in samples/bpf/README.rst is > out of date. See below that the links are not accessible any more. > > $ git clone http://llvm.org/git/llvm.git > Cloning into 'llvm'... > fatal: unable to access 'http://l

RE: [PATCH 0/2] thermal: Replace thermal_notify_framework with thermal_zone_device_update

2021-01-19 Thread Zhang, Rui
Hi, Thara, Thanks for the cleanup. I've proposed similar patches previously. https://patchwork.kernel.org/project/linux-pm/patch/20200430063229.6182-2-rui.zh...@intel.com/ https://patchwork.kernel.org/project/linux-pm/patch/20200430063229.6182-3-rui.zh...@intel.com/ can you please also address the

Re: [PATCHv3 net-next 1/2] udp: call udp_encap_enable for v6 sockets when enabling encap

2021-01-19 Thread Xin Long
On Wed, Jan 20, 2021 at 6:17 AM Alexander Duyck wrote: > > On Fri, Jan 15, 2021 at 8:34 PM Xin Long wrote: > > > > When enabling encap for a ipv6 socket without udp_encap_needed_key > > increased, UDP GRO won't work for v4 mapped v6 address packets as > > sk will be NULL in udp4_gro_receive(). >

[PATCH iproute2-next v2] tc: flower: add tc conntrack inv ct_state support

2021-01-19 Thread wenxu
From: wenxu Matches on conntrack inv ct_state. Signed-off-by: wenxu --- v2: change the description include/uapi/linux/pkt_cls.h | 1 + man/man8/tc-flower.8 | 2 ++ tc/f_flower.c| 1 + 3 files changed, 4 insertions(+) diff --git a/include/uapi/linux/pkt_cls.h b/include

Re: [PATCH bpf-next v2] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

2021-01-19 Thread Yonghong Song
On 1/19/21 6:32 PM, Tiezhu Yang wrote: On 01/20/2021 05:58 AM, Fangrui Song wrote: On 2021-01-19, Tiezhu Yang wrote: The current llvm/clang build procedure in samples/bpf/README.rst is out of date. See below that the links are not accessible any more. $ git clone http://llvm.org/git/llvm.g

Re: [PATCH bpf-next v2] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

2021-01-19 Thread Tiezhu Yang
On 01/20/2021 10:43 AM, Nick Desaulniers wrote: On Mon, Jan 18, 2021 at 11:56 PM Tiezhu Yang wrote: The current llvm/clang build procedure in samples/bpf/README.rst is out of date. See below that the links are not accessible any more. $ git clone http://llvm.org/git/llvm.git Cloning into 'llvm

[PATCH net-next V2] net: dsa: microchip: Adjust reset release timing to match reference reset circuit

2021-01-19 Thread Marek Vasut
KSZ8794CNX datasheet section 8.0 RESET CIRCUIT describes recommended circuit for interfacing with CPU/FPGA reset consisting of 10k pullup resistor and 10uF capacitor to ground. This circuit takes ~100 ms to rise enough to release the reset. For maximum supply voltage VDDIO=3.3V VIH=2.0V R=10kR C=1

Re: [PATCH bpf-next v2 1/3] net: add priv_flags for allow tx skb without linear

2021-01-19 Thread Jason Wang
On 2021/1/19 下午5:45, Xuan Zhuo wrote: In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support th

Re: [PATCH bpf-next v2] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

2021-01-19 Thread Tiezhu Yang
On 01/20/2021 05:58 AM, Fangrui Song wrote: On 2021-01-19, Tiezhu Yang wrote: The current llvm/clang build procedure in samples/bpf/README.rst is out of date. See below that the links are not accessible any more. $ git clone http://llvm.org/git/llvm.git Cloning into 'llvm'... fatal: unable to a

[PATCHv15 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test

2021-01-19 Thread Hangbin Liu
This is a sample for xdp multicast. In the sample we could forward all packets between given interfaces. There is also an option -X that could enable 2nd xdp_prog on egress interface. Signed-off-by: Hangbin Liu --- v15: use bpf_object__find_program_by_name() instead of bpf_object__find_prog

[PATCHv15 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL

2021-01-19 Thread Hangbin Liu
Use helper bpf_redirect_map() and bpf_redirect_map_multi() to test bpf arg ARG_CONST_MAP_PTR and ARG_CONST_MAP_PTR_OR_NULL. Make sure the map arg could be verified correctly when it is NULL or valid map pointer. Add devmap and devmap_hash in struct bpf_test due to bpf_redirect_{map, map_multi} lim

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-19 Thread Yongji Xie
On Tue, Jan 19, 2021 at 10:54 PM Jonathan Corbet wrote: > > X-Gm-Spam: 0 > X-Gm-Phishy: 0 > > On Tue, 19 Jan 2021 13:07:53 +0800 > Xie Yongji wrote: > > > diff --git a/Documentation/driver-api/vduse.rst > > b/Documentation/driver-api/vduse.rst > > new file mode 100644 > > index ..941

[PATCH AUTOSEL 4.19 08/15] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-19 Thread Sasha Levin
From: Leon Schuermann [ Upstream commit cb82a54904a99df9e8f9e9d282046055dae5a730 ] This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to use the cdc_ether driver. However, using this driver, with the system suspended the device constantly sends pause-frames as soon as the receive

[PATCH AUTOSEL 5.10 03/45] SUNRPC: Handle TCP socket sends with kernel_sendpage() again

2021-01-19 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 4a85a6a3320b4a622315d2e0ea91a1d2b013bce4 ] Daire Byrne reports a ~50% aggregrate throughput regression on his Linux NFS server after commit da1661b93bf4 ("SUNRPC: Teach server to use xprt_sock_sendmsg for socket sends"), which replaced kernel_send_page() calls

Re: [PATCH net-next v2 6/8] igc: Add support for tuning frame preemption via ethtool

2021-01-19 Thread Jakub Kicinski
On Mon, 18 Jan 2021 16:40:26 -0800 Vinicius Costa Gomes wrote: > + NL_SET_ERR_MSG(extack, "Invalid value for add-frag-size"); NL_SET_ERR_MSG_MOD

Re: [PATCH net-next v2 2/8] taprio: Add support for frame preemption offload

2021-01-19 Thread Jakub Kicinski
On Mon, 18 Jan 2021 16:40:22 -0800 Vinicius Costa Gomes wrote: > Adds a way to configure which traffic classes are marked as > preemptible and which are marked as express. > > Even if frame preemption is not a "real" offload, because it can't be > executed purely in software, having this informati

[PATCH net-next] vmxnet3: Remove buf_info from device accessible structures

2021-01-19 Thread Ronak Doshi
From: Petr Vandrovec vmxnet3: Remove buf_info from device accessible structures buf_info structures in RX & TX queues are private driver data that do not need to be visible to the device. Although there is physical address and length in the queue descriptor that points to these structures, thei

[PATCH AUTOSEL 4.14 4/9] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-19 Thread Sasha Levin
From: Leon Schuermann [ Upstream commit cb82a54904a99df9e8f9e9d282046055dae5a730 ] This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to use the cdc_ether driver. However, using this driver, with the system suspended the device constantly sends pause-frames as soon as the receive

Re: [PATCH v2 net-next] net: fix GSO for SG-enabled devices.

2021-01-19 Thread Xin Long
On Wed, Jan 20, 2021 at 12:57 AM Paolo Abeni wrote: > > The commit dbd50f238dec ("net: move the hsize check to the else > block in skb_segment") introduced a data corruption for devices > supporting scatter-gather. > > The problem boils down to signed/unsigned comparison given > unexpected results

Re: [PATCH net-next v2 1/8] ethtool: Add support for configuring frame preemption

2021-01-19 Thread Jakub Kicinski
On Mon, 18 Jan 2021 16:40:21 -0800 Vinicius Costa Gomes wrote: > + == == > + ``ETHTOOL_A_CHANNELS_HEADER`` nested request header ETHTOOL_A_PREEMPT_HEADER > + == ==

[PATCH AUTOSEL 4.14 6/9] net: stmmac: Fixed mtu channged by cache aligned

2021-01-19 Thread Sasha Levin
From: David Wu [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ] Since the original mtu is not used when the mtu is updated, the mtu is aligned with cache, this will get an incorrect. For example, if you want to configure the mtu to be 1500, but mtu 1536 is configured in fact. Fixed:

Re: [PATCH net-next 1/1] ice: Improve MSI-X vector enablement fallback logic

2021-01-19 Thread Venkataramanan, Anirudh
On Tue, 2021-01-19 at 16:41 -0800, Jakub Kicinski wrote: > On Wed, 20 Jan 2021 00:12:26 + Venkataramanan, Anirudh wrote: > > > > Attempt [0]: Enable the best-case scenario MSI-X vectors. > > > > > > > > Attempt [1]: Enable MSI-X vectors with the number of pf- > > > > > num_lan_msix > > > >

Re: [PATCH net] tcp: do not mess with cloned skbs in tcp_add_backlog()

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 19 Jan 2021 08:49:00 -0800 you wrote: > From: Eric Dumazet > > Heiner Kallweit reported that some skbs were sent with > the following invalid GSO properties : > - gso_size > 0 > - gso_type == 0 > > [...] Here is the

Re: [PATCH net-next] net: dsa: microchip: Adjust reset release timing to match reference reset circuit

2021-01-19 Thread Florian Fainelli
On 1/19/2021 6:01 PM, Marek Vasut wrote: > KSZ8794CNX datasheet section 8.0 RESET CIRCUIT describes recommended > circuit for interfacing with CPU/FPGA reset consisting of 10k pullup > resistor and 10uF capacitor to ground. This circuit takes ~100 mS to > rise enough to release the reset. > > F

Re: [PATCH 2/3] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values

2021-01-19 Thread Andrii Nakryiko
On Tue, Jan 19, 2021 at 2:16 PM Jiri Olsa wrote: > > For very large ELF objects (with many sections), we could > get special value SHN_XINDEX (65535) for symbol's st_shndx. > > This patch is adding code to detect the optional extended > section index table and use it to resolve symbol's section >

[PATCH net-next] net: dsa: microchip: Adjust reset release timing to match reference reset circuit

2021-01-19 Thread Marek Vasut
KSZ8794CNX datasheet section 8.0 RESET CIRCUIT describes recommended circuit for interfacing with CPU/FPGA reset consisting of 10k pullup resistor and 10uF capacitor to ground. This circuit takes ~100 mS to rise enough to release the reset. For maximum supply voltage VDDIO=3.3V VIH=2.0V R=10kR C=1

Re: [PATCH] taprio: boolean values to a bool variable

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 18 Jan 2021 16:31:02 +0800 you wrote: > Fix the following coccicheck warnings: > > ./net/sched/sch_taprio.c:393:3-16: WARNING: Assignment of 0/1 to bool > variable. > > ./net/sched/sch_taprio.c:375:2-15: WARNING:

Re: [PATCH][next] selftests: forwarding: Fix spelling mistake "succeded" -> "succeeded"

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 18 Jan 2021 11:19:02 + you wrote: > From: Colin Ian King > > There are two spelling mistakes in check_fail messages. Fix them. > > Signed-off-by: Colin Ian King > --- > tools/testing/selftests/net/forwardin

Re: [PATCH] net: smsc911x: Make Runtime PM handling more fine-grained

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 18 Jan 2021 16:08:57 +0100 you wrote: > Currently the smsc911x driver has mininal power management: during > driver probe, the device is powered up, and during driver remove, it is > powered down. > > Improve power

Re: [PATCH] octeontx2-af: Remove unneeded semicolon

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 07:50:59 + Xu Wang wrote: > fix semicolon.cocci warnings: > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3: Unneeded > semicolon > > Signed-off-by: Xu Wang I squashed your 3 patches for octeontx2-af and applied them to net-next. Thanks.

Re: [net-next 0/6] net: ethernet: ti: am65-cpsw-nuss: introduce support for am64x cpsw3g

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 21:28:47 +0200 you wrote: > Hi > > This series introduces basic support for recently introduced TI K3 AM642x SoC > [1] > which contains 3 port (2 external ports) CPSW3g module. The CPSW3g integrated >

Re: [PATCH net-next] net: tun: fix misspellings using codespell tool

2021-01-19 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 18 Jan 2021 03:15:39 -0800 you wrote: > From: Menglong Dong > > Some typos are found out by codespell tool: > > $ codespell -w -i 3 ./drivers/net/tun.c > aovid ==> avoid > > [...] Here is the summary with link

[PATCH AUTOSEL 4.19 10/15] net: stmmac: Fixed mtu channged by cache aligned

2021-01-19 Thread Sasha Levin
From: David Wu [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ] Since the original mtu is not used when the mtu is updated, the mtu is aligned with cache, this will get an incorrect. For example, if you want to configure the mtu to be 1500, but mtu 1536 is configured in fact. Fixed:

Re: [PATCH 1/3] elf_symtab: Add support for SHN_XINDEX index to elf_section_by_name

2021-01-19 Thread Andrii Nakryiko
On Tue, Jan 19, 2021 at 2:16 PM Jiri Olsa wrote: > > In case the elf's header e_shstrndx contains SHN_XINDEX, > we need to call elf_getshdrstrndx to get the proper > string table index. > > Signed-off-by: Jiri Olsa > --- > dutil.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >

Re: [PATCH bpf-next 3/3] libbpf: Use string table index from index table if needed

2021-01-19 Thread Andrii Nakryiko
On Tue, Jan 19, 2021 at 2:15 PM Jiri Olsa wrote: > > For very large ELF objects (with many sections), we could > get special value SHN_XINDEX (65535) for elf object's string > table index - e_shstrndx. > > In such case we need to call elf_getshdrstrndx to get the > proper string table index. > > S

  1   2   3   4   >