[PATCH bpf-next v2] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

2021-01-18 Thread Tiezhu Yang
The current llvm/clang build procedure in samples/bpf/README.rst is out of date. See below that the links are not accessible any more. $ git clone http://llvm.org/git/llvm.git Cloning into 'llvm'... fatal: unable to access 'http://llvm.org/git/llvm.git/': Maximum (20) redirects followed $ git clo

Re: [PATCH] can: mcp251xfd: mcp251xfd_handle_ivmif(): fix wrong NULL pointer check

2021-01-18 Thread Marc Kleine-Budde
On 1/19/21 3:02 AM, angkery wrote: > From: Junlin Yang > > if alloc_can_err_skb() returns NULL, we should check skb instead of cf. Have a look at the function, there is a check for cf several times before this. But as cf is initialized as NULL this is should be no problem. While in: | ca4c6ebe

Re: [PATCH v2] rtlwifi: rtl8192se: Simplify bool comparison.

2021-01-18 Thread Pkshih
On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote: > Fix the follow coccicheck warnings: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: > WARNING: Comparison of 0/1 to bool variable. > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: > WARNING: Compari

RE: [PATCH] cfg80211: Fix "suspicious RCU usage in wiphy_apply_custom_regulatory" warning/backtrace

2021-01-18 Thread Peer, Ilan
> -Original Message- > From: Hans de Goede > Sent: Monday, January 18, 2021 23:09 > To: Peer, Ilan ; Johannes Berg > ; David S . Miller ; > Jakub Kicinski ; Rojewski, Cezary > ; Pierre-Louis Bossart louis.boss...@linux.intel.com>; Liam Girdwood > ; Jie Yang ; > Mark Brown > Cc: linux-wir

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Magnus Karlsson
On Mon, Jan 18, 2021 at 5:38 PM Alexander Lobakin wrote: > > > From: Magnus Karlsson > > Date: Mon, 18 Jan 2021 16:10:40 +0100 > > > > On Mon, Jan 18, 2021 at 3:47 PM Alexander Lobakin wrote: > > > > > > From: Alexander Lobakin > > > Date: Mon, 18 Jan 2021 13:00:17 + > > > > > > > From: Yun

Re: [PATCH bpf] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

2021-01-18 Thread Yonghong Song
On 1/18/21 7:53 PM, Tiezhu Yang wrote: In the current samples/bpf/README.rst, the url of llvm and clang git may be out of date, they are unable to access: Let us just rephrase the above more clearly, something like below. The current clang/llvm build procedure in samples/bpf/README.rst is o

Re: [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence

2021-01-18 Thread Paul Menzel
Dear Jakub, dear Greg, Am 05.01.21 um 18:25 schrieb Greg KH: On Tue, Jan 05, 2021 at 06:16:59PM +0100, Paul Menzel wrote: Am 03.11.20 um 19:39 schrieb Jakub Kicinski: On Tue, 3 Nov 2020 08:35:09 +0100 Paul Menzel wrote: According to *Developer's Certificate of Origin 1.1* [3], it’s my unde

Re: [PATCH mlx5-next v2 0/5] Dynamically assign MSI-X vectors count

2021-01-18 Thread Leon Romanovsky
On Mon, Jan 18, 2021 at 10:07:32AM -0800, Jakub Kicinski wrote: > On Sun, 17 Jan 2021 09:24:41 +0200 Leon Romanovsky wrote: > > On Sun, Jan 17, 2021 at 07:44:09AM +0200, Leon Romanovsky wrote: > > > On Thu, Jan 14, 2021 at 09:51:28AM -0800, Jakub Kicinski wrote: > > > > On Thu, 14 Jan 2021 12:31:35

Re: [PATCH] net: hns: fix variable used when DEBUG is defined

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 17 Jan 2021 11:10:44 -0800 you wrote: > From: Tom Rix > > When DEBUG is defined this error occurs > > drivers/net/ethernet/hisilicon/hns/hns_enet.c:1505:36: error: > ‘struct net_device’ has no member named ‘ae_

Re: [PATCH net-next V3 0/8] TLS device offload for Bond

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 17 Jan 2021 16:59:41 +0200 you wrote: > Hi, > > This series opens TX and RX TLS device offload for bond interfaces. > This allows bond interfaces to benefit from capable lower devices. > > We add a new ndo_sk_get

[PATCH v2] rtlwifi: rtl8192se: Simplify bool comparison.

2021-01-18 Thread Jiapeng Zhong
Fix the follow coccicheck warnings: ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: WARNING: Comparison of 0/1 to bool variable. ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: WARNING: Comparison of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by:

Re: [PATCH] arcnet: fix macro name when DEBUG is defined

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 17 Jan 2021 10:15:19 -0800 you wrote: > From: Tom Rix > > When DEBUG is defined this error occurs > > drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’ > undeclared (first use in this func

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

2021-01-18 Thread Leon Romanovsky
On Mon, Jan 18, 2021 at 10:21:03AM -0800, Alexander Duyck wrote: > On Mon, Jan 18, 2021 at 5:28 AM Leon Romanovsky wrote: > > > > On Mon, Jan 18, 2021 at 09:20:08AM +0200, Leon Romanovsky wrote: > > > On Sun, Jan 17, 2021 at 07:16:30PM -0800, Alexander Duyck wrote: > > > > On Sat, Jan 16, 2021 at

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

2021-01-18 Thread Leon Romanovsky
On Mon, Jan 18, 2021 at 06:03:22PM +0100, Greg KH wrote: > On Sun, Jan 10, 2021 at 05:07:24PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Some SR-IOV capable devices provide an ability to configure specific > > number of MSI-X vectors on their VF prior driver is probed on that

[RFC v3 11/11] vduse: Introduce a workqueue for irq injection

2021-01-18 Thread Xie Yongji
This patch introduces a dedicated workqueue for irq injection so that we are able to do some performance tuning for it. Signed-off-by: Xie Yongji --- drivers/vdpa/vdpa_user/eventfd.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa_user/eventfd.c b/

[RFC v3 10/11] vduse: grab the module's references until there is no vduse device

2021-01-18 Thread Xie Yongji
The module should not be unloaded if any vduse device exists. So increase the module's reference count when creating vduse device. And the reference count is kept until the device is destroyed. Signed-off-by: Xie Yongji --- drivers/vdpa/vdpa_user/vduse_dev.c | 2 ++ 1 file changed, 2 insertions(

[RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-18 Thread Xie Yongji
This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the control path, the VDUSE driver will make use of message mechnism to forward the config operation from vdpa bus driver to userspace. User

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-18 Thread Edwin Peer
On Mon, Jan 18, 2021 at 6:39 PM David Ahern wrote: > > Indeed, this is what we ended up doing, although we still need to > > confirm Network Manager, systemd and whatever else our customers might > > use do the necessary to satisfy the user requirement to handle the > > delayed init. > > I am not

[RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-18 Thread Xie Yongji
Now we have a global percpu counter to limit the recursion depth of eventfd_signal(). This can avoid deadlock or stack overflow. But in stack overflow case, it should be OK to increase the recursion depth if needed. So we add a percpu counter in eventfd_ctx to limit the recursion depth for deadlock

[RFC v3 00/11] Introduce VDUSE - vDPA Device in Userspace

2021-01-18 Thread Xie Yongji
This series introduces a framework, which can be used to implement vDPA Devices in a userspace program. The work consist of two parts: control path forwarding and data path offloading. In the control path, the VDUSE driver will make use of message mechnism to forward the config operation from vdpa

RE: [EXT] Re: [PATCH net-next,1/3] octeontx2-af: Mailbox changes for 98xx CPT block

2021-01-18 Thread Srujana Challa
> On Wed, 2021-01-13 at 20:50 +0530, Srujana Challa wrote: > > This patch changes CPT mailbox message format to support new block > > CPT1 in 98xx silicon. > > > > cpt_rd_wr_reg -> > > Modify cpt_rd_wr_reg mailbox and its handler to > > accommodate new block CPT1. > > cpt_lf_alloc -> > >

Re: [PATCH net-next v2 6/7] virtio-net, xsk: implement xsk wakeup callback

2021-01-18 Thread Jason Wang
On 2021/1/16 上午10:59, Xuan Zhuo wrote: Since I did not find an interface to directly notify virtio to generate a tx interrupt, I sent some data to trigger a new tx interrupt. Another advantage of this is that the transmission delay will be relatively small, and there is no need to wait for the

Re: [PATCH net v2] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-18 Thread Enke Chen
On Mon, Jan 18, 2021 at 08:02:21PM -0800, Jakub Kicinski wrote: > On Fri, 15 Jan 2021 14:30:58 -0800 Enke Chen wrote: > > From: Enke Chen > > > > The TCP session does not terminate with TCP_USER_TIMEOUT when data > > remain untransmitted due to zero window. > > > > The number of unanswered zero-

Re: [PATCH v1] ipv4: add iPv4_is_multicast() check in ip_mc_leave_group().

2021-01-18 Thread Jakub Kicinski
On Sun, 17 Jan 2021 05:34:16 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > There is no iPv4_is_multicast() check added to ip_mc_leave_group() > to check if imr->imr_multiaddr.s_addr is a multicast address. > If not a multicast address, it may result in an error. Could you please sa

Re: [PATCH v2 net-next 19/21] net/mlx5e: NVMEoTCP, data-path for DDP offload

2021-01-18 Thread David Ahern
On 1/17/21 1:42 AM, Boris Pismenny wrote: > This is needed for a few reasons that are explained in detail > in the tcp-ddp offload documentation. See patch 21 overview > and rx-data-path sections. Our reasons are as follows: I read the documentation patch, and it does not explain it and really sho

Re: [PATCH] net/qla3xxx: switch from 'pci_' to 'dma_' API

2021-01-18 Thread Jakub Kicinski
On Sun, 17 Jan 2021 09:15:42 +0100 Christophe JAILLET wrote: > @@ -2525,9 +2519,8 @@ static int ql_alloc_net_req_rsp_queues(struct > ql3_adapter *qdev) > wmb(); > > qdev->req_q_virt_addr = > - pci_alloc_consistent(qdev->pdev, > - (size_t) qdev->re

Re: [PATCH net-next 0/3] net: make udp tunnel devices support fraglist

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 17:47:44 +0800 you wrote: > Like GRE device, UDP tunnel devices should also support fraglist, so > that some protocol (like SCTP) HW GSO that requires NETIF_F_FRAGLIST > in the dev can work. Especially

Re: [Patch net-next] net_sched: fix RTNL deadlock again caused by request_module()

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 16 Jan 2021 16:56:57 -0800 you wrote: > From: Cong Wang > > tcf_action_init_1() loads tc action modules automatically with > request_module() after parsing the tc action names, and it drops RTNL > lock and re-hold

Re: [PATCH] net: phy: national: remove definition of DEBUG

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 15:53:46 -0800 you wrote: > From: Tom Rix > > Defining DEBUG should only be done in development. > So remove DEBUG. > > Signed-off-by: Tom Rix > > [...] Here is the summary with links: - net: phy

RE: [PATCH 0/7] Introduce vdpa management tool

2021-01-18 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Wednesday, December 9, 2020 4:17 AM > > On 11/26/20 8:53 PM, Jason Wang wrote: > > 1. Where does userspace vdpa tool reside which users can use? > > Ans: vdpa tool can possibly reside in iproute2 [1] as it enables user > > to create vdpa net devices. > > ip

Re: [PATCH v2 net-next 07/21] nvme-tcp: Add DDP data-path

2021-01-18 Thread David Ahern
On 1/14/21 8:10 AM, Boris Pismenny wrote: > @@ -664,8 +753,15 @@ static int nvme_tcp_process_nvme_cqe(struct > nvme_tcp_queue *queue, > return -EINVAL; > } > > - if (!nvme_try_complete_req(rq, cqe->status, cqe->result)) > - nvme_complete_rq(rq); > + req =

Re: [net-next PATCH v3 14/15] net: phylink: Refactor phylink_of_phy_connect()

2021-01-18 Thread Calvin Johnson
On Tue, Jan 12, 2021 at 05:57:01PM +0200, Andy Shevchenko wrote: > On Tue, Jan 12, 2021 at 3:43 PM Calvin Johnson > wrote: > > > > Refactor phylink_of_phy_connect() to use phylink_fwnode_phy_connect(). > > Same Q as per previous patch. If it's indeed a bug in the existing > code, should be fixed

Re: [net-next PATCH v3 13/15] phylink: introduce phylink_fwnode_phy_connect()

2021-01-18 Thread Calvin Johnson
On Tue, Jan 12, 2021 at 05:55:54PM +0200, Andy Shevchenko wrote: > On Tue, Jan 12, 2021 at 3:43 PM Calvin Johnson > wrote: > > > > Define phylink_fwnode_phy_connect() to connect phy specified by > > a fwnode to a phylink instance. > > ... > > > + phy_dev = fwnode_phy_find_device(phy_fwnode

Re: [PATCH net v2] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-18 Thread Jakub Kicinski
On Fri, 15 Jan 2021 14:30:58 -0800 Enke Chen wrote: > From: Enke Chen > > The TCP session does not terminate with TCP_USER_TIMEOUT when data > remain untransmitted due to zero window. > > The number of unanswered zero-window probes (tcp_probes_out) is > reset to zero with incoming acks irrespect

Re: [PATCH v2] hv_netvsc: Add (more) validation for untrusted Hyper-V values

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 14 Jan 2021 21:26:28 +0100 you wrote: > For additional robustness in the face of Hyper-V errors or malicious > behavior, validate all values that originate from packets that Hyper-V > has sent to the guest. Ensure

Re: [PATCH net 0/2] ipv6: fixes for the multicast routes

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 15 Jan 2021 19:42:07 +0100 you wrote: > From: Matteo Croce > > Fix two wrong flags in the IPv6 multicast routes created > by the autoconf code. > > Matteo Croce (2): > ipv6: create multicast route with RTPROT_KERNE

[PATCH bpf] samples/bpf: Update README.rst and Makefile for manually compiling LLVM and clang

2021-01-18 Thread Tiezhu Yang
In the current samples/bpf/README.rst, the url of llvm and clang git may be out of date, they are unable to access: $ git clone http://llvm.org/git/llvm.git Cloning into 'llvm'... fatal: unable to access 'http://llvm.org/git/llvm.git/': Maximum (20) redirects followed $ git clone --depth 1 http:/

Re: [PATCH v2 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-01-18 Thread David Ahern
On 1/14/21 8:10 AM, Boris Pismenny wrote: > +static > +int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue) > +{ > + struct net_device *netdev = get_netdev_for_sock(queue->sock->sk, true); > + struct nvme_tcp_ddp_config config = {}; > + int ret; > + > + if (!netdev) { > +

Re: [PATCH net-next] net: hns3: debugfs add dump tm info of nodes, priority and qset

2021-01-18 Thread Jakub Kicinski
On Tue, 19 Jan 2021 11:14:51 +0800 Huazhong Tan wrote: > On 2021/1/19 3:48, Jakub Kicinski wrote: > > On Mon, 18 Jan 2021 19:20:23 +0800 Huazhong Tan wrote: > >> On 2021/1/17 10:23, Jakub Kicinski wrote: > >>> On Fri, 15 Jan 2021 15:09:29 +0800 Huazhong Tan wrote: > From: Guangbin Huang

Re: [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support

2021-01-18 Thread DENG Qingfang
Hi Linus, On Mon, Jan 18, 2021 at 10:55 PM Linus Walleij wrote: > > So for offset 0..14 this becomes bits > 0, 1, 2, 4, 5, 6, 8, 9, 10, 12 ... 18 > > What is the logic in this and is it what you intend? Yes. Bit 0..2 are phy 0's LED 0..2, bit 4..6 are phy 1's LED 0..2, etc. > Please add a comm

Re: [PATCH net-next] net: hns3: debugfs add dump tm info of nodes, priority and qset

2021-01-18 Thread Huazhong Tan
On 2021/1/19 3:48, Jakub Kicinski wrote: On Mon, 18 Jan 2021 19:20:23 +0800 Huazhong Tan wrote: On 2021/1/17 10:23, Jakub Kicinski wrote: On Fri, 15 Jan 2021 15:09:29 +0800 Huazhong Tan wrote: From: Guangbin Huang To increase methods to dump more tm info, adds three debugfs commands to dum

[PATCHv8 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2021-01-18 Thread Hangbin Liu
This patch add a xdp program on egress to show that we can modify the packet on egress. In this sample we will set the pkt's src mac to egress's mac address. The xdp_prog will be attached when -X option supplied. Acked-by: Yonghong Song Signed-off-by: Hangbin Liu --- v8: Fix some checkpatch iss

Re: [PATCH net] selftests/net/fib_tests: remove duplicate log test

2021-01-18 Thread David Ahern
On 1/18/21 7:59 PM, Hangbin Liu wrote: > The previous test added an address with a specified metric and check if > correspond route was created. I somehow added two logs for the same > test. Remove the duplicated one. > > Reported-by: Antoine Tenart > Fixes: 0d29169a708b ("selftests/net/fib_tests

[PATCH net] selftests/net/fib_tests: remove duplicate log test

2021-01-18 Thread Hangbin Liu
The previous test added an address with a specified metric and check if correspond route was created. I somehow added two logs for the same test. Remove the duplicated one. Reported-by: Antoine Tenart Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")

Re: [PATCH] rtlwifi/rtl8192se: Simplify bool comparison.

2021-01-18 Thread Pkshih
On Fri, 2021-01-15 at 10:06 +, Jiapeng Zhong wrote: > Fix the follow coccicheck warnings: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: > WARNING: Comparison of 0/1 to bool variable. > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: > WARNING: Compari

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-18 Thread David Ahern
On 1/18/21 4:40 PM, Edwin Peer wrote: > On Mon, Jan 18, 2021 at 2:57 PM David Ahern wrote: > >> On 1/18/21 11:01 AM, Edwin Peer wrote: >>> I'm facing a similar issue with NIC firmware that isn't yet ready by >>> device open time, but have been resisting the urge to lie to the stack >> >> why not

Re: [PATCH net-next] net/sched: cls_flower add CT_FLAGS_INVALID flag support

2021-01-18 Thread wenxu
On 1/19/2021 2:21 AM, Marcelo Ricardo Leitner wrote: > On Mon, Jan 18, 2021 at 01:18:47PM +0800, we...@ucloud.cn wrote: > ... >> --- a/net/sched/cls_flower.c >> +++ b/net/sched/cls_flower.c >> @@ -305,6 +305,9 @@ static int fl_classify(struct sk_buff *skb, const struct >> tcf_proto *tp, >>

Re: how to determine if buffers are in user-space/kernel-space

2021-01-18 Thread Stephen Hemminger
On Mon, 18 Jan 2021 23:56:37 +0530 Raju Rangoju wrote: > Hi, > > We have an out-of-tree kernel module which was using > segment_eq(get_fs(), KERNEL_DS) to determine whether buffers are in > Kernel space vs User space. However, with the get_fs() and its friends > removed[1], we are out of ideas o

[PATCH] can: mcp251xfd: mcp251xfd_handle_ivmif(): fix wrong NULL pointer check

2021-01-18 Thread angkery
From: Junlin Yang if alloc_can_err_skb() returns NULL, we should check skb instead of cf. Signed-off-by: Junlin Yang --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/

RE: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-18 Thread Hayes Wang
Grant Grundler > Sent: Tuesday, January 19, 2021 6:03 AM > Subject: Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications [...] > > RTL8156 sends notifications about every 32ms. > > Only display/log notifications when something changes. > > > > This issue has been reported by others: > >

Re: mdio: access c22 registers via debugfs

2021-01-18 Thread Pavel Šimerda
My mdio acces script attached. Regards, Pavel On 1/19/21 2:08 AM, Pavel Šimerda wrote: Hi Tobias, given the reasons stated in the mailing list, I'd like to discuss the situation off-list. I would be more than happy to join your effort and provide an OpenWRT package. I understand the motiva

[PATCH net-next v4] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
This comes from an end-user request, where they're running multiple VMs on hosts with bonded interfaces connected to some interest switch topologies, where 802.3ad isn't an option. They're currently running a proprietary solution that effectively achieves load-balancing of VMs and bandwidth utiliza

mdio: access c22 registers via debugfs

2021-01-18 Thread Pavel Šimerda
Hi Tobias, given the reasons stated in the mailing list, I'd like to discuss the situation off-list. I would be more than happy to join your effort and provide an OpenWRT package. I understand the motivation to reject that, and I do use it partially also for the “bad purpose” and therefore I'd

Re: [PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
On Mon, Jan 18, 2021 at 04:10:38PM -0700, David Ahern wrote: > On 1/15/21 12:21 PM, Jarod Wilson wrote: > > diff --git a/Documentation/networking/bonding.rst > > b/Documentation/networking/bonding.rst > > index adc314639085..36562dcd3e1e 100644 > > --- a/Documentation/networking/bonding.rst > > ++

Re: [PATCH net-next] net: mdio: access c22 registers via debugfs

2021-01-18 Thread Pavel Šimerda
On 1/19/21 12:27 AM, Tobias Waldekranz wrote: On Sat, Jan 16, 2021 at 22:19, Pavel Šimerda wrote: Provide a debugging interface to read and write MDIO registers directly without the need for a device driver. This is extremely useful when debugging switch hardware and phy hardware issues. The i

Re: [PATCH net-next v2 1/8] ethtool: Add support for configuring frame preemption

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 04:40:21PM -0800, Vinicius Costa Gomes wrote: > +int ethnl_set_preempt(struct sk_buff *skb, struct genl_info *info) > +{ > + struct ethnl_req_info req_info = {}; > + struct nlattr **tb = info->attrs; > + struct ethtool_fp preempt = {}; > + struct net_device *

Re: [PATCH v3 net-next 10/15] net: mscc: ocelot: refactor ocelot_port_inject_frame out of ocelot_port_xmit

2021-01-18 Thread kernel test robot
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/tag_8021q-for-Ocelot-switches/20210119-004520 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 213b97b

[PATCH net-next v2 2/8] taprio: Add support for frame preemption offload

2021-01-18 Thread Vinicius Costa Gomes
Adds a way to configure which traffic classes are marked as preemptible and which are marked as express. Even if frame preemption is not a "real" offload, because it can't be executed purely in software, having this information near where the mapping of traffic classes to queues is specified, make

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Tue, Jan 19, 2021 at 12:42:04AM +0200, Nikolay Aleksandrov wrote: > No, it shouldn't be a problem to change that. We should be careful about the > way it's changed though because reporting it for all ports might become a > scale > issue with 4k vlans, and also today you can't add the same mac f

[PATCH net-next v2 7/8] igc: Add support for Frame Preemption offload

2021-01-18 Thread Vinicius Costa Gomes
After the set of queues that are marked as preemptible are exposed to the driver we can configure the hardware to enable the frame preemption functionality. Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/igc_main.c | 32 +++ 1 file changed, 32 insertio

[PATCH net-next v2 8/8] igc: Separate TSN configurations that can be updated

2021-01-18 Thread Vinicius Costa Gomes
Some TSN features can be enabled during runtime, but most of the features need an adapter reset to be disabled. To better keep track of this, separate the process into an "_apply" and a "reset" functions, "_apply" will run with the adapter in potencially "dirty" state, and if necessary will reques

[PATCH net-next v2 3/8] igc: Set the RX packet buffer size for TSN mode

2021-01-18 Thread Vinicius Costa Gomes
In preparation for supporting frame preemption, when entering TSN mode set the receive packet buffer to 16KB for the Express MAC, 16KB for the Preemptible MAC and 2KB for the BMC, according to the datasheet section 7.1.3.2. Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/i

[PATCH net-next v2 6/8] igc: Add support for tuning frame preemption via ethtool

2021-01-18 Thread Vinicius Costa Gomes
The tc subsystem sets which queues are marked as preemptible, it's the role of ethtool to control more hardware specific parameters. These parameters include: - enabling the frame preemption hardware: As enabling frame preemption may have other requirements before it can be enabled, it's expose

[PATCH net-next v2 4/8] igc: Only dump registers if configured to dump HW information

2021-01-18 Thread Vinicius Costa Gomes
To avoid polluting the users logs with register dumps, only dump the adapter's registers if configured to do so. If users want to enable HW status messages they can do: $ ethtool -s IFACE msglvl hw on Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igc/igc_dump.c | 3 +++ 1

[PATCH net-next v2 5/8] igc: Avoid TX Hangs because long cycles

2021-01-18 Thread Vinicius Costa Gomes
Avoid possible TX Hangs caused by using long Qbv cycles. In some cases, using long cycles (more than 1 second) can cause transmissions to be blocked for that time. As the TX Hang timeout is close to 1 second, we may need to reduce the cycle time to something more reasonable: the value chosen is 1ms

[PATCH net-next v2 1/8] ethtool: Add support for configuring frame preemption

2021-01-18 Thread Vinicius Costa Gomes
Frame preemption (described in IEEE 802.3br-2016) defines the concept of preemptible and express queues. It allows traffic from express queues to "interrupt" traffic from preemptible queues, which are "resumed" after the express traffic has finished transmitting. Frame preemption can only be used

[PATCH net-next v2 0/8] ethtool: Add support for frame preemption

2021-01-18 Thread Vinicius Costa Gomes
Changes from v1: - The minimum fragment size configuration was changed to be configured in bytes to be more future proof, in case the standard changes this (the previous definition was '(X + 1) * 64', X being [0..3]) (Michal Kubecek); - In taprio, frame preemption is now configured by tr

Re: [PATCH net] net: mrp: use stp state as substitute for unimplemented mrp state

2021-01-18 Thread Horatiu Vultur
The 01/18/2021 19:46, Vladimir Oltean wrote: > > On Mon, Jan 18, 2021 at 07:56:18PM +0100, Horatiu Vultur wrote: > > The reason was to stay away from STP, because you can't run these two > > protocols at the same time. Even though in SW, we reuse port's state. > > In our driver(which is not upstre

Re: [PATCH v3 net-next 04/15] net: dsa: felix: add new VLAN-based tagger

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 06:17:20PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > There are use cases for which the existing tagger, based on the NPI > (Node Processor Interface) functionality, is insufficient. > > Namely: > - Frames injected through the NPI port bypass the frame anal

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-18 Thread Edwin Peer
On Mon, Jan 18, 2021 at 2:57 PM David Ahern wrote: > On 1/18/21 11:01 AM, Edwin Peer wrote: > > I'm facing a similar issue with NIC firmware that isn't yet ready by > > device open time, but have been resisting the urge to lie to the stack > > why not have the ndo_open return -EBUSY or -EAGAIN to

Re: [PATCH net-next] net: mdio: access c22 registers via debugfs

2021-01-18 Thread Tobias Waldekranz
On Sat, Jan 16, 2021 at 22:19, Pavel Šimerda wrote: > Provide a debugging interface to read and write MDIO registers directly > without the need for a device driver. > > This is extremely useful when debugging switch hardware and phy hardware > issues. The interface provides proper locking for com

Re: [PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread David Ahern
On 1/15/21 12:21 PM, Jarod Wilson wrote: > diff --git a/Documentation/networking/bonding.rst > b/Documentation/networking/bonding.rst > index adc314639085..36562dcd3e1e 100644 > --- a/Documentation/networking/bonding.rst > +++ b/Documentation/networking/bonding.rst > @@ -951,6 +951,19 @@ xmit_hash

Re: [PATCH for bpf-next] docs: bpf: add minimal markup to address doc warning

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 18 Jan 2021 09:00:04 +0100 you wrote: > Commit 91c960b00566 ("bpf: Rename BPF_XADD and prepare to encode other > atomics in .imm") modified the BPF documentation, but missed some ReST > markup. > > Hence, make htmldoc

Re: commit 4c7ea3c0791e (net: dsa: mv88e6xxx: disable SA learning for DSA and CPU ports)

2021-01-18 Thread Tobias Waldekranz
On Mon, Jan 18, 2021 at 23:07, Rasmus Villemoes wrote: > On 18/01/2021 22.19, Vladimir Oltean wrote: >> On Sat, Jan 16, 2021 at 02:42:12AM +0100, Tobias Waldekranz wrote: What I'm _really_ trying to do is to get my mv88e6250 to participate in an MRP ring, which AFAICT will require that

Re: [PATCH bpf-next] samples/bpf: add BPF_ATOMIC_OP macro for BPF samples

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 18 Jan 2021 10:17:53 +0100 you wrote: > From: Björn Töpel > > Brendan Jackman added extend atomic operations to the BPF instruction > set in commit 7064a7341a0d ("Merge branch 'Atomics for eBPF'"), which > introduces

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-18 Thread David Ahern
On 1/18/21 11:01 AM, Edwin Peer wrote: > I'm facing a similar issue with NIC firmware that isn't yet ready by > device open time, but have been resisting the urge to lie to the stack why not have the ndo_open return -EBUSY or -EAGAIN to tell S/W to try again 'later'? > about the state of the devi

Re: [PATCH net] net: mrp: use stp state as substitute for unimplemented mrp state

2021-01-18 Thread Horatiu Vultur
The 01/18/2021 19:13, Rasmus Villemoes wrote: > Hi Rasmus, > When using MRP with hardware that does understand the concept of > blocked or forwarding ports, but not the full MRP offload, we > currently fail to tell the hardware what state it should put the port > in when the ring is closed - res

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-18 Thread David Ahern
On 1/18/21 6:00 AM, Jiri Pirko wrote: > >> Reconfiguring routing is not the end of the world. > Well, yes, but you don't really want netdevices to come and go then you > plug in/out cables/modules. That's why we have split implemented as we And you don't want a routing daemon to use netdevices wh

Re: pull-request: mac80211 2021-01-18.2

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Mon, 18 Jan 2021 21:47:49 +0100 you wrote: > Hi, > > New try, dropped the 160 MHz CSA patch for now that has the sparse > issue since people are waiting for the kernel-doc fixes. > > Please pull and let me know if th

Re: [PATCHv7 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2021-01-18 Thread Daniel Borkmann
On 1/15/21 7:24 AM, Hangbin Liu wrote: This patch add a xdp program on egress to show that we can modify the packet on egress. In this sample we will set the pkt's src mac to egress's mac address. The xdp_prog will be attached when -X option supplied. Signed-off-by: Hangbin Liu This has a bun

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 19/01/2021 00:06, Vladimir Oltean wrote: > On Mon, Jan 18, 2021 at 11:53:18PM +0200, Nikolay Aleksandrov wrote: >> On 18/01/2021 23:50, Vladimir Oltean wrote: >>> On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: Apologies for the multiple emails, but wanted to leave an e

Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails

2021-01-18 Thread Jakub Kicinski
On Fri, 15 Jan 2021 12:46:20 +0800 wangyunjian wrote: > From: Yunjian Wang > > Currently the driver doesn't drop a packet which can't be sent by tun > (e.g bad packet). In this case, the driver will always process the > same packet lead to the tx queue stuck. > > To fix this issue: > 1. in the c

Re: [PATCH v2 bpf-next 0/2] add xdp_build_skb_from_frame utility routine

2021-01-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 12 Jan 2021 19:26:11 +0100 you wrote: > Introduce __xdp_build_skb_from_frame and xdp_build_skb_from_frame routines > to build the skb from a xdp_frame. Respect to __xdp_build_skb_from_frame, > xdp_build_skb_from_frame

Re: [PATCH v4 net-next] net: bridge: check vlan with eth_type_vlan() method

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 13:55:11 +0200 Nikolay Aleksandrov wrote: > On 17/01/2021 10:09, menglong8.d...@gmail.com wrote: > > From: Menglong Dong > > > > Replace some checks for ETH_P_8021Q and ETH_P_8021AD with > > eth_type_vlan(). > > > > Signed-off-by: Menglong Dong > > Acked-by: Nikolay Aleksan

Re: [PATCH v12 bpf-next] bpf/selftests: fold test_current_pid_tgid_new_ns into test_progs.

2021-01-18 Thread Daniel Borkmann
On 1/14/21 3:10 PM, Carlos Neira wrote: Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs. This change folds test cases into test_progs. Changes from v11: - Fixed test failure is not detected. - Removed EXIT(3) call as it will stop test_progs execution. Signed-off-by

Re: [net-next PATCH v3 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-01-18 Thread Randy Dunlap
Hi, On 1/12/21 5:40 AM, Calvin Johnson wrote: > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > provide them to be connected to MAC. > > Describe properties "phy-handle" and "phy-mode". > > Signed-off-by: Calvin Johnson > --- > > Changes in v3: None > Changes in v2: > - Upd

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Tue, Jan 19, 2021 at 12:06:16AM +0200, Vladimir Oltean wrote: > And these: > > $ ip link add br0 type bridge > $ ip link set swp3 master br0 > $ ip link set swp2 master br0 > $ ip link set swp1 master br0 > $ ip link set swp0 master br0 > $ bridge fdb | grep permanent > 00:04:9f:05:de:0a dev sw

Re: commit 4c7ea3c0791e (net: dsa: mv88e6xxx: disable SA learning for DSA and CPU ports)

2021-01-18 Thread Rasmus Villemoes
On 18/01/2021 22.19, Vladimir Oltean wrote: > On Sat, Jan 16, 2021 at 02:42:12AM +0100, Tobias Waldekranz wrote: >>> What I'm _really_ trying to do is to get my mv88e6250 to participate in >>> an MRP ring, which AFAICT will require that the master device's MAC gets >>> added as a static entry in th

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 11:53:18PM +0200, Nikolay Aleksandrov wrote: > On 18/01/2021 23:50, Vladimir Oltean wrote: > > On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: > >> Apologies for the multiple emails, but wanted to leave an example: > >> > >> 00:11:22:33:44:55 dev ens16 m

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-18 Thread Grant Grundler
+nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote: > > RTL8156 sends notifications about every 32ms. > Only display/log notifications when something changes. > > This issue has been reported by others: > https://bugs.launchpad.net/u

Re: [PATCH 2/3] net: usb: log errors to dmesg/syslog

2021-01-18 Thread Grant Grundler
+nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote: > > Errors in protocol should be logged when the driver aborts operations. > If the driver can carry on and "humor" the device, then emitting > the message as debug output level is fine. >

Re: [PATCH 1/3] net: usb: cdc_ncm: emit dev_err on error paths

2021-01-18 Thread Grant Grundler
+nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:26 AM Grant Grundler wrote: > > Several error paths in bind/probe code will only emit > output using dev_dbg. But if we are going to fail the > bind/probe, emit related output with "err" priority. > > Signed-off-by: G

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:50, Vladimir Oltean wrote: > On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: >> Apologies for the multiple emails, but wanted to leave an example: >> >> 00:11:22:33:44:55 dev ens16 master bridge permanent >> >> This must always exist and user-space must be able

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: > Apologies for the multiple emails, but wanted to leave an example: > > 00:11:22:33:44:55 dev ens16 master bridge permanent > > This must always exist and user-space must be able to create it, which > might be against what you

Re: [RESEND PATCH] net: core: devlink: use right genl user_ptr when handling port param get/set

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 19:39:54 +0200 Vadym Kochan wrote: > From: Oleksandr Mazur > > Fix incorrect user_ptr dereferencing when handling port param get/set: > > idx [0] stores the 'struct devlink' pointer; > idx [1] stores the 'struct devlink_port' pointer; > > Fixes: f4601dee25d5 ("devlin

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:22, Nikolay Aleksandrov wrote: > On 18/01/2021 23:17, Nikolay Aleksandrov wrote: >> On 18/01/2021 22:19, Tobias Waldekranz wrote: >>> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: > Ah I see, no I

Re: [PATCH net] net: nfc: nci: fix the wrong NCI_CORE_INIT parameters

2021-01-18 Thread Jakub Kicinski
On Tue, 19 Jan 2021 06:19:23 +0900 Bongsu Jeon wrote: > On Tue, Jan 19, 2021 at 6:01 AM Jakub Kicinski wrote: > > > > On Tue, 19 Jan 2021 05:55:22 +0900 Bongsu Jeon wrote: > > > From: Bongsu Jeon > > > > > > Fix the code because NCI_CORE_INIT_CMD includes two parameters in NCI2.0 > > > but ther

Re: [PATCH net-next] net: core: Namespace-ify sysctl_wmem_default and sysctl_rmem_default

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 13:15:28 -0800 Jakub Kicinski wrote: > On Mon, 18 Jan 2021 12:15:18 +0100 Christian Brauner wrote: > > On Sun, Jan 17, 2021 at 06:23:19PM +0800, menglong8.d...@gmail.com wrote: > > > From: Menglong Dong > > > > > > For now, sysctl_wmem_default and sysctl_rmem_default are glo

Re: [PATCH v3 12/21] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 02:08:39 + Andre Przywara wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index 58e0511badba..00c10ec7b693 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/et

Re: [PATCH net] net: mrp: use stp state as substitute for unimplemented mrp state

2021-01-18 Thread Vladimir Oltean
On Mon, Jan 18, 2021 at 09:20:36PM +0100, Horatiu Vultur wrote: > The 01/18/2021 19:46, Vladimir Oltean wrote: > > > > On Mon, Jan 18, 2021 at 07:56:18PM +0100, Horatiu Vultur wrote: > > > The reason was to stay away from STP, because you can't run these two > > > protocols at the same time. Even t

  1   2   3   4   >