On Mon, 18 Jan 2021 02:08:39 +0000 Andre Przywara wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index 58e0511badba..00c10ec7b693 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -1129,6 +1129,8 @@ static int sun8i_dwmac_probe(struct platform_device > *pdev) > struct stmmac_priv *priv; > struct net_device *ndev; > struct regmap *regmap; > + struct reg_field syscon_field; > + u32 syscon_idx = 0;
nit: please keep the longest-to-shortest line ordering of variables