Re: [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line discipline

2021-01-04 Thread Gaoyan
Hi Greg KH: On Fri, 1 Jan 2021 09:18:48 +0100, Greg KH wrote: >On Fri, Jan 01, 2021 at 11:37:18AM +0800, Gao Yan wrote: >> In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops >> including ppp_sync_ldisc. So I think tty->ldisc_sem can also protect >> tty->disc_data, and the disc_d

RE: [PATCH net] macvlan: fix null pointer dereference in macvlan_changelink_sources()

2021-01-04 Thread wangyunjian
> -Original Message- > From: Jakub Kicinski [mailto:k...@kernel.org] > Sent: Tuesday, January 5, 2021 5:35 AM > To: wangyunjian > Cc: netdev@vger.kernel.org; da...@davemloft.net; Lilijun (Jerry) > ; xudingke > Subject: Re: [PATCH net] macvlan: fix null pointer dereference in > macvlan_cha

RE: [PATCH linux-next v2 4/7] vdpa: Define vdpa mgmt device, ops and a netlink interface

2021-01-04 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, January 5, 2021 9:40 AM > > On 2021/1/4 下午3:24, Parav Pandit wrote: > > > >> From: Jason Wang > >> Sent: Monday, January 4, 2021 12:33 PM > >> > >> On 2021/1/4 上午11:31, Parav Pandit wrote: > >>> To add one or more VDPA devices, define a management device whi

[PATCH net v2] macvlan: remove redundant null check on data

2021-01-04 Thread wangyunjian
From: Yunjian Wang Because macvlan_common_newlink() and macvlan_changelink() already checked NULL data parameter, so the additional check is unnecessary, just remove it. Fixes: 79cf79abce71 ("macvlan: add source mode") Signed-off-by: Yunjian Wang --- v2: * change code styles and commit log su

RE: [PATCH linux-next v2 7/7] vdpa_sim_net: Add support for user supported devices

2021-01-04 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, January 5, 2021 9:36 AM > > > On 2021/1/4 下午3:21, Parav Pandit wrote: > > > >> From: Jason Wang > >> Sent: Monday, January 4, 2021 12:35 PM > >> > >> On 2021/1/4 上午11:31, Parav Pandit wrote: > >>>static int __init vdpasim_net_init(void) > >>>{ > >>>

Re: [PATCH net] net: bareudp: add missing error handling for bareudp_link_config()

2021-01-04 Thread Cong Wang
On Mon, Jan 4, 2021 at 9:49 AM Jakub Kicinski wrote: > > On Sat, 2 Jan 2021 15:49:54 -0800 Cong Wang wrote: > > On Wed, Dec 30, 2020 at 7:46 PM Jakub Kicinski wrote: > > > @@ -661,9 +662,14 @@ static int bareudp_newlink(struct net *net, struct > > > net_device *dev, > > > > > > err = bar

Re: linux-next: build warnings after merge of the net-next tree

2021-01-04 Thread Stephen Rothwell
Hi all, On Mon, 21 Dec 2020 12:28:39 +1100 Stephen Rothwell wrote: > > On Mon, 14 Dec 2020 20:10:25 +1100 Stephen Rothwell > wrote: > > > > After merging the net-next tree, today's linux-next build (htmldocs) > > produced these warnings: > > > > include/net/cfg80211.h:1759: warning: Cannot un

Re: [PATCH] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-04 Thread Qinglang Miao
I sent a v2 on this one because of the redundant braces in qrtr_proto_init, sorry for the noise. 在 2021/1/5 10:40, Qinglang Miao 写道: A null-ptr-deref bug is reported by Hulk Robot like this: -- KASAN: null-ptr-deref in range [0x0128-0x012f] Call Trace: qrtr_n

[PATCH v2] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-04 Thread Qinglang Miao
A null-ptr-deref bug is reported by Hulk Robot like this: -- KASAN: null-ptr-deref in range [0x0128-0x012f] Call Trace: qrtr_ns_remove+0x22/0x40 [ns] qrtr_proto_fini+0xa/0x31 [qrtr] __x64_sys_delete_module+0x337/0x4e0 do_syscall_64+0x34/0x80 entry_SYSCALL_64_afte

Re: [PATCH v2 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2021-01-04 Thread Song Liu
> On Jan 4, 2021, at 5:46 PM, Alexei Starovoitov > wrote: > > On Fri, Dec 18, 2020 at 05:23:25PM +, Song Liu wrote: >> >> >>> On Dec 18, 2020, at 8:38 AM, Yonghong Song wrote: >>> >>> >>> >>> On 12/17/20 9:23 PM, Alexei Starovoitov wrote: On Thu, Dec 17, 2020 at 8:33 PM Song Li

Re: [RFC PATCH v3 00/12] Generic zcopy_* functions

2021-01-04 Thread Jonathan Lemon
On Mon, Jan 04, 2021 at 11:22:35PM -0500, Willem de Bruijn wrote: > On Mon, Jan 4, 2021 at 11:17 PM Jonathan Lemon > wrote: > > > > On Mon, Jan 04, 2021 at 12:39:35PM -0500, Willem de Bruijn wrote: > > > On Wed, Dec 30, 2020 at 2:12 PM Jonathan Lemon > > > wrote: > > > > > > > > From: Jonathan

Re: [PATCH V2 2/2] net: ks8851: Register MDIO bus and the internal PHY

2021-01-04 Thread kernel test robot
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on ipvs/master net-next/master linus/master v5.11-rc2 next-20210104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH bpf-next 3/3] selftests/bpf: add tests for user- and non-CO-RE BPF_CORE_READ() variants

2021-01-04 Thread Andrii Nakryiko
On Mon, Jan 4, 2021 at 7:46 PM Alexei Starovoitov wrote: > > On Fri, Dec 18, 2020 at 03:56:14PM -0800, Andrii Nakryiko wrote: > > + > > +/* shuffled layout for relocatable (CO-RE) reads */ > > +struct callback_head___shuffled { > > + void (*func)(struct callback_head___shuffled *head); > > +

Re: Refcount mismatch when unregistering netdevice from kernel

2021-01-04 Thread David Ahern
On 1/4/21 8:05 PM, stran...@codeaurora.org wrote: > > We're able to reproduce the refcount mismatch after some experimentation > as well. > Essentially, it consists of > 1) adding a default route (ip -6 route add dev XXX default) > 2) forcing the creation of an exception route via manually injecti

[PATCH net,stable v3] net: cdc_ncm: correct overhead in delayed_ndp_size

2021-01-04 Thread Jouni Seppänen
From: Jouni K. Seppänen Aligning to tx_ndp_modulus is not sufficient because the next align call can be cdc_ncm_align_tail, which can add up to ctx->tx_modulus + ctx->tx_remainder - 1 bytes. This used to lead to occasional crashes on a Huawei 909s-120 LTE module as follows: - the condition marke

Re: [RFC PATCH v3 00/12] Generic zcopy_* functions

2021-01-04 Thread Jonathan Lemon
On Mon, Jan 04, 2021 at 12:39:35PM -0500, Willem de Bruijn wrote: > On Wed, Dec 30, 2020 at 2:12 PM Jonathan Lemon > wrote: > > > > From: Jonathan Lemon > > > > This is set of cleanup patches for zerocopy which are intended > > to allow a introduction of a different zerocopy implementation. > >

Re: [RFC PATCH v3 00/12] Generic zcopy_* functions

2021-01-04 Thread Willem de Bruijn
On Mon, Jan 4, 2021 at 11:17 PM Jonathan Lemon wrote: > > On Mon, Jan 04, 2021 at 12:39:35PM -0500, Willem de Bruijn wrote: > > On Wed, Dec 30, 2020 at 2:12 PM Jonathan Lemon > > wrote: > > > > > > From: Jonathan Lemon > > > > > > This is set of cleanup patches for zerocopy which are intended >

Re: [PATCH 06/21] vdpa: introduce virtqueue groups

2021-01-04 Thread Jason Wang
On 2021/1/4 下午6:04, Stefan Hajnoczi wrote: On Wed, Dec 16, 2020 at 02:48:03PM +0800, Jason Wang wrote: This patch introduces virtqueue groups to vDPA device. The virtqueue group is the minimal set of virtqueues that must share an address space. And the adddress space identifier could only be a

Re: [PATCH linux-next v2 4/7] vdpa: Define vdpa mgmt device, ops and a netlink interface

2021-01-04 Thread Jason Wang
On 2021/1/4 下午3:24, Parav Pandit wrote: From: Jason Wang Sent: Monday, January 4, 2021 12:33 PM On 2021/1/4 上午11:31, Parav Pandit wrote: To add one or more VDPA devices, define a management device which allows adding or removing vdpa device. A management device defines set of callbacks to

Re: [PATCH linux-next v2 7/7] vdpa_sim_net: Add support for user supported devices

2021-01-04 Thread Jason Wang
On 2021/1/4 下午3:21, Parav Pandit wrote: From: Jason Wang Sent: Monday, January 4, 2021 12:35 PM On 2021/1/4 上午11:31, Parav Pandit wrote: static int __init vdpasim_net_init(void) { int ret = 0; @@ -176,6 +264,8 @@ static int __init vdpasim_net_init(void) if (default_d

Re: [PATCH bpf-next 3/3] selftests/bpf: add tests for user- and non-CO-RE BPF_CORE_READ() variants

2021-01-04 Thread Alexei Starovoitov
On Fri, Dec 18, 2020 at 03:56:14PM -0800, Andrii Nakryiko wrote: > + > +/* shuffled layout for relocatable (CO-RE) reads */ > +struct callback_head___shuffled { > + void (*func)(struct callback_head___shuffled *head); > + struct callback_head___shuffled *next; > +}; > + > +struct callback_h

[PATCH net 2/3] net: hns3: fix the number of queues actually used by ARQ

2021-01-04 Thread Huazhong Tan
From: Yufeng Mo HCLGE_MBX_MAX_ARQ_MSG_NUM is used to apply memory for the number of queues used by ARQ(Asynchronous Receive Queue), so the head and tail pointers should also use this macro. Fixes: 07a0556a3a73 ("net: hns3: Changes to support ARQ(Asynchronous Receive Queue)") Signed-off-by: Yufe

[PATCH net 3/3] net: hns3: fix incorrect handling of sctp6 rss tuple

2021-01-04 Thread Huazhong Tan
From: Jian Shen For DEVICE_VERSION_V2, the hardware only supports src-ip, dst-ip and verification-tag for rss tuple set of sctp6 packet. For DEVICE_VERSION_V3, the hardware supports src-port and dst-port as well. Currently, when user queries the sctp6 rss tuples info, some unsupported informatio

[PATCH net 1/3] net: hns3: fix a phy loopback fail issue

2021-01-04 Thread Huazhong Tan
From: Yonglong Liu When phy driver does not implement the set_loopback interface, phy loopback test will return -EOPNOTSUPP, and the loopback test will fail. So when phy driver does not implement the set_loopback interface, don't do phy loopback test. Fixes: c9765a89d142 ("net: hns3: add phy sel

[PATCH net 0/3] net: hns3: fixes for -net

2021-01-04 Thread Huazhong Tan
There are some bugfixes for the HNS3 ethernet driver. Jian Shen (1): net: hns3: fix incorrect handling of sctp6 rss tuple Yonglong Liu (1): net: hns3: fix a phy loopback fail issue Yufeng Mo (1): net: hns3: fix the number of queues actually used by ARQ drivers/net/ethernet/hisilicon/hns3

Re: [PATCH] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-04 Thread weiyongjun (A)
A null-ptr-deref bug is reported by Hulk Robot like this: -- KASAN: null-ptr-deref in range [0x0128-0x012f] Call Trace: qrtr_ns_remove+0x22/0x40 [ns] qrtr_proto_fini+0xa/0x31 [qrtr] __x64_sys_delete_module+0x337/0x4e0 do_syscall_64+0x34/0x80 entry_SYSCALL_64_

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 5:53 PM Jason Gunthorpe wrote: > > On Mon, Jan 04, 2021 at 04:51:51PM -0800, Dan Williams wrote: > > On Mon, Jan 4, 2021 at 4:14 PM Jason Gunthorpe wrote: > > > > > > On Mon, Jan 04, 2021 at 09:19:30PM +, Mark Brown wrote: > > > > > > > > > > > Regardless of the shortcu

Re: Refcount mismatch when unregistering netdevice from kernel

2021-01-04 Thread stranche
On 2020-12-11 09:10, David Ahern wrote: Could we further distinguish between dst added to the uncached list by icmp6_dst_alloc() and xfrm6_fill_dst(), and confirm which ones are the ones leaking reference? I suspect it would be the xfrm ones, but I think it is worth verifying. After diggi

Re: bonding driver issue when configured for active/backup and using ARP monitoring

2021-01-04 Thread Jay Vosburgh
Finer, Howard wrote: >Please advise if there is any update here, and if not how we can go about >getting an update to the driver to rectify the issue. As it happens, I've been looking at this today, and have a couple of questions about your configuration: - Is there an IP addres

Re: [PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-04 Thread Andrew Lunn
On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote: > Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() > into error") the ppc32_allmodconfig build fails with: > > ERROR: modpost: missing MODULE_LICENSE() in > drivers/net/ethernet/freescale/fs_enet/mii-fec.o > E

[PATCH] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-04 Thread Qinglang Miao
A null-ptr-deref bug is reported by Hulk Robot like this: -- KASAN: null-ptr-deref in range [0x0128-0x012f] Call Trace: qrtr_ns_remove+0x22/0x40 [ns] qrtr_proto_fini+0xa/0x31 [qrtr] __x64_sys_delete_module+0x337/0x4e0 do_syscall_64+0x34/0x80 entry_SYSCALL_64_afte

[PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-04 Thread Michael Ellerman
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_

Re: [RFC PATCH bpf-next] ksnoop: kernel argument/return value tracing/display using BTF

2021-01-04 Thread Alexei Starovoitov
On Mon, Jan 04, 2021 at 03:26:31PM +, Alan Maguire wrote: > > ksnoop can be used to show function signatures; for example: > > $ ksnoop info ip_send_skb > int ip_send_skb(struct net * net, struct sk_buff * skb); > > Then we can trace the function, for example: > > $ ksnoop trace ip_send_

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Jason Gunthorpe
On Mon, Jan 04, 2021 at 04:51:51PM -0800, Dan Williams wrote: > On Mon, Jan 4, 2021 at 4:14 PM Jason Gunthorpe wrote: > > > > On Mon, Jan 04, 2021 at 09:19:30PM +, Mark Brown wrote: > > > > > > > > Regardless of the shortcut to make everything a struct > > > > platform_device, I think it was a

Re: [PATCH v2 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2021-01-04 Thread Alexei Starovoitov
On Fri, Dec 18, 2020 at 05:23:25PM +, Song Liu wrote: > > > > On Dec 18, 2020, at 8:38 AM, Yonghong Song wrote: > > > > > > > > On 12/17/20 9:23 PM, Alexei Starovoitov wrote: > >> On Thu, Dec 17, 2020 at 8:33 PM Song Liu wrote: > > ahh. I missed that. Makes sense. > vm_fi

[PATCH net v2] docs: net: fix documentation on .ndo_get_stats

2021-01-04 Thread Jakub Kicinski
Fix calling context. Signed-off-by: Jakub Kicinski --- Documentation/networking/netdevices.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst index 5a85fcc80c76..e65665c5ab50 100644 --- a/

Re: [PATCH net] docs: net: fix documentation on .ndo_get_stats

2021-01-04 Thread Jakub Kicinski
On Tue, 5 Jan 2021 03:03:27 +0200 Vladimir Oltean wrote: > On Mon, Jan 04, 2021 at 09:53:09AM -0800, Jakub Kicinski wrote: > > On Mon, 4 Jan 2021 12:42:27 +0200 Vladimir Oltean wrote: > > > And what happened to dev_base_lock? Did it suddenly go away? > > > > I thought all callers switched to RC

Re: [PATCH V2 2/2] net: ks8851: Register MDIO bus and the internal PHY

2021-01-04 Thread Jakub Kicinski
On Mon, 4 Jan 2021 13:30:17 +0100 Marek Vasut wrote: > The KS8851 has a reduced internal PHY, which is accessible through its > registers at offset 0xe4. The PHY is compatible with KS886x PHY present > in Micrel switches, except the PHY ID Low/High registers are swapped. > Register MDIO bus so thi

Re: [PATCH net] docs: net: fix documentation on .ndo_get_stats

2021-01-04 Thread Vladimir Oltean
On Mon, Jan 04, 2021 at 09:53:09AM -0800, Jakub Kicinski wrote: > On Mon, 4 Jan 2021 12:42:27 +0200 Vladimir Oltean wrote: > > On Wed, Dec 30, 2020 at 07:45:24PM -0800, Jakub Kicinski wrote: > > > Fix calling context. > > > > > > Signed-off-by: Jakub Kicinski > > > --- > > > Documentation/network

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Dan Williams
On Mon, Jan 4, 2021 at 4:14 PM Jason Gunthorpe wrote: > > On Mon, Jan 04, 2021 at 09:19:30PM +, Mark Brown wrote: > > > > > Regardless of the shortcut to make everything a struct > > > platform_device, I think it was a mistake to put OF devices on > > > platform_bus. Those should have remained

[GIT PULL] Networking for 5.11-rc3

2021-01-04 Thread Jakub Kicinski
The following changes since commit d64c6f96ba86bd8b97ed8d6762a8c8cc1770d214: Merge tag 'net-5.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2020-12-17 13:45:24 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Florian Fainelli
On 1/4/21 10:43 AM, Ioana Ciornei wrote: > On Mon, Jan 04, 2021 at 06:31:05PM +0100, Andrew Lunn wrote: >>> The basic rules here should be, if the MDIO bus is registered, it is >>> usable. There are things like PHY statistics, HWMON temperature >>> sensors, etc, DSA switches, all which have a life

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Jason Gunthorpe
On Mon, Jan 04, 2021 at 09:19:30PM +, Mark Brown wrote: > > Regardless of the shortcut to make everything a struct > > platform_device, I think it was a mistake to put OF devices on > > platform_bus. Those should have remained on some of_bus even if they > > Like I keep saying the same thing

Re: [PATCH bpf-next v2 1/2] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt

2021-01-04 Thread Martin KaFai Lau
On Mon, Jan 04, 2021 at 02:14:53PM -0800, Stanislav Fomichev wrote: > When we attach a bpf program to cgroup/getsockopt any other getsockopt() > syscall starts incurring kzalloc/kfree cost. While, in general, it's > not an issue, sometimes it is, like in the case of TCP_ZEROCOPY_RECEIVE. > TCP_ZERO

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2021-01-04 Thread Andrii Nakryiko
On Sat, Jan 2, 2021 at 3:07 PM Jiri Olsa wrote: > > On Sat, Jan 02, 2021 at 02:25:34PM -0800, Andrii Nakryiko wrote: > > SNIP > > > > > > > so your .config has > > > CONFIG_CRYPTO_DEV_BCM_SPU=y > > > > > > and that defines 'struct device_private' which > > > clashes with the same struct defined

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-04 Thread Martin Blumenstingl
Hi Jakub, On Mon, Jan 4, 2021 at 10:52 PM Jakub Kicinski wrote: > > On Sun, 3 Jan 2021 03:12:21 +0100 Martin Blumenstingl wrote: > > Hi Andrew, > > > > On Sun, Jan 3, 2021 at 3:09 AM Andrew Lunn wrote: > > > > > > On Sun, Jan 03, 2021 at 02:25:43AM +0100, Martin Blumenstingl wrote: > > > > Enab

Re: [Aspeed, v1 1/1] net: ftgmac100: Change the order of getting MAC address

2021-01-04 Thread Heiner Kallweit
On 04.01.2021 18:28, Hongwei Zhang wrote: > >> From: Jakub Kicinski >> Sent: Monday, December 28, 2020 5:01 PM >> >> On Tue, 22 Dec 2020 22:00:34 +0100 Andrew Lunn wrote: >>> On Tue, Dec 22, 2020 at 09:46:52PM +0100, Heiner Kallweit wrote: On 22.12.2020 21:14, Hongwei Zhang wrote: > Dear

Re: [PATCH v11 bpf-next] bpf/selftests: fold test_current_pid_tgid_new_ns into test_progs.

2021-01-04 Thread Andrii Nakryiko
On Mon, Dec 28, 2020 at 7:48 AM Carlos Neira wrote: > > Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs. > This change folds test cases into test_progs. > > Changes from v10: > > - Code style fixes. > - Remove redundant code. > > Signed-off-by: Carlos Neira > --- > too

Re: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-04 Thread Willem de Bruijn
On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > skbs in frag_list could be shared by pskb_expand_head() from BPF. Can you elaborate on the BPF connection? > While tcpdump, sk_receive_queue of PF_PACKET has the original frag_list. > But the same frag_list is queued to PF_INET (or PF_INET6)

RE: bonding driver issue when configured for active/backup and using ARP monitoring

2021-01-04 Thread Finer, Howard
Please advise if there is any update here, and if not how we can go about getting an update to the driver to rectify the issue. Thanks, Howard From: Jay Vosburgh Sent: Friday, December 4, 2020 3:43 PM To: Finer, Howard Cc: a...@greyhouse.net; vfal...@gmail.com; netdev@vger.kernel.org Subject:

Re: [PATCH net 0/3] Netfilter fixes for net

2021-01-04 Thread Jakub Kicinski
On Sun, 3 Jan 2021 20:29:17 +0100 Pablo Neira Ayuso wrote: > Hi Jakub, David, > > The following patchset contains Netfilter fixes for net: > > 1) Missing sanitization of rateest userspace string, bug has been >triggered by syzbot, patch from Florian Westphal. > > 2) Report EOPNOTSUPP on mis

[PATCH] dt-bindings: Add missing array size constraints

2021-01-04 Thread Rob Herring
DT properties which can have multiple entries need to specify what the entries are and define how many entries there can be. In the case of only a single entry, just 'maxItems: 1' is sufficient. Add the missing entry constraints. These were found with a modified meta-schema. Unfortunately, there a

[PATCH] crypto: Rename struct device_private to bcm_device_private

2021-01-04 Thread Jiri Olsa
Renaming 'struct device_private' to 'struct bcm_device_private', because it clashes with 'struct device_private' from 'drivers/base/base.h'. While it's not a functional problem, it's causing two distinct type hierarchies in BTF data. It also breaks build with options: CONFIG_DEBUG_INFO_BTF=y C

Re: [PATCH net,stable v2] net: cdc_ncm: correct overhead in delayed_ndp_size

2021-01-04 Thread Jakub Kicinski
On Sun, 3 Jan 2021 22:23:09 +0200 Jouni Seppänen wrote: > if (ctx->drvflags & CDC_NCM_FLAG_NDP_TO_END) > - delayed_ndp_size = ALIGN(ctx->max_ndp_size, > ctx->tx_ndp_modulus); > + delayed_ndp_size = ctx->max_ndp_size + > + max((u32)ctx->tx_ndp_modu

Re: [PATCH net-next v3 2/4] sch_htb: Hierarchical QoS hardware offload

2021-01-04 Thread Maxim Mikityanskiy
On 2020-12-22 03:17, Jakub Kicinski wrote: On Tue, 15 Dec 2020 09:42:11 +0200 Maxim Mikityanskiy wrote: + q->offload = nla_get_flag(tb[TCA_HTB_OFFLOAD]); + + if (q->offload) { + if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc) + return -

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-04 Thread Jakub Kicinski
On Sun, 3 Jan 2021 03:12:21 +0100 Martin Blumenstingl wrote: > Hi Andrew, > > On Sun, Jan 3, 2021 at 3:09 AM Andrew Lunn wrote: > > > > On Sun, Jan 03, 2021 at 02:25:43AM +0100, Martin Blumenstingl wrote: > > > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. > > > Without t

Re: [PATCH net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 31 Dec 2020 09:43:31 -0800 you wrote: > In lapb_device_event, lapb_devtostruct is called to get a reference to > an object of "struct lapb_cb". lapb_devtostruct increases the refcount > of the object and returns a pointe

Re: [PATCH net] r8169: work around power-saving bug on some chip versions

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 30 Dec 2020 19:33:34 +0100 you wrote: > A user reported failing network with RTL8168dp (a quite rare chip > version). Realtek confirmed that few chip versions suffer from a PLL > power-down hw bug. > > Fixes: 07df5bd874

Re: [PATCH net,stable] net: usb: qmi_wwan: add Quectel EM160R-GL

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 30 Dec 2020 16:24:51 +0100 you wrote: > New modem using ff/ff/30 for QCDM, ff/00/00 for AT and NMEA, > and ff/ff/ff for RMNET/QMI. > > T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 > D: Ver= 3.20 Cls

Re: [PATCH net] selftests: mlxsw: Set headroom size of correct port

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 30 Dec 2020 13:42:51 +0200 you wrote: > From: Ido Schimmel > > The test was setting the headroom size of the wrong port. This was not > visible because of a firmware bug that canceled this bug. > > Set the headroom si

Re: [PATCH net] macvlan: fix null pointer dereference in macvlan_changelink_sources()

2021-01-04 Thread Jakub Kicinski
On Wed, 30 Dec 2020 18:38:15 +0800 wangyunjian wrote: > From: Yunjian Wang > > Currently pointer data is dereferenced when declaring addr before > pointer data is null checked. This could lead to a null pointer > dereference. Fix this by checking if pointer data is null first. > > Fixes: 79cf79a

Re: [PATCH net v6] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 29 Dec 2020 10:01:48 +0800 you wrote: > From: Yunjian Wang > > Currently the vhost_zerocopy_callback() maybe be called to decrease > the refcount when sendmsg fails in tun. The error handling in vhost > handle_tx_zeroc

Re: [PATCH] ibmvnic: fix: NULL pointer dereference.

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 30 Dec 2020 15:23:14 +0800 you wrote: > The error is due to dereference a null pointer in function > reset_one_sub_crq_queue(): > > if (!scrq) { > netdev_dbg(adapter->netdev, >"Invalid scrq reset. ir

Re: [PATCH v2 1/2] docs: networking: packet_mmap: fix formatting for C macros

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 29 Dec 2020 11:08:38 +0200 you wrote: > The citation of macro definitions should appear in a code block. > > Signed-off-by: Baruch Siach > --- > Documentation/networking/packet_mmap.rst | 2 +- > 1 file changed, 1 in

Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Jakub Kicinski
On Mon, 4 Jan 2021 15:18:50 +0100 Andrew Lunn wrote: > On Mon, Jan 04, 2021 at 10:38:02AM +, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > - if (!clk) > > + if (!bp->tx_clk || !(bp->

Re: [PATCH v1] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-04 Thread Jakub Kicinski
On Tue, 29 Dec 2020 23:24:26 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > In rvu_mbox_handler_cgx_mac_addr_get() and > rvu_mbox_handler_cgx_mac_addr_set(), > the msg is expected only from PFs that are mapped to CGX LMACs. > It should be checked before mapping, so we add the is_cgx

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Mark Brown
On Mon, Jan 04, 2021 at 02:08:31PM -0400, Jason Gunthorpe wrote: > On Mon, Dec 21, 2020 at 06:51:40PM +, Mark Brown wrote: > > BTW I did have a bit of a scan through some of the ACPI devices and > > for a good proportion of them it seems fairly clear that they are > > not platform devices at a

Re: [PATCH net v2 0/2] bareudp: fix several issues

2021-01-04 Thread Jakub Kicinski
On Mon, 28 Dec 2020 15:21:21 + Taehee Yoo wrote: > This patchset is to fix problems when bareudp is used nestedly. > > 1. If the NETIF_F_LLTX flag is not set, the lockdep warns about > a possible deadlock scenario when bareudp interfaces are used nestedly. > But, like other tunneling interface

Re: [PATCH bpf-next 1/2] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt

2021-01-04 Thread Martin KaFai Lau
On Thu, Dec 31, 2020 at 12:14:13PM -0800, s...@google.com wrote: > On 12/30, Martin KaFai Lau wrote: > > On Mon, Dec 21, 2020 at 02:22:41PM -0800, Song Liu wrote: > > > On Thu, Dec 17, 2020 at 9:24 AM Stanislav Fomichev > > wrote: > > > > > > > > When we attach a bpf program to cgroup/getsockopt a

Re: [PATCH] mlx4: style: replace zero-length array with flexible-array member.

2021-01-04 Thread Jakub Kicinski
On Wed, 30 Dec 2020 14:28:51 +0800 YANG LI wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use "flexible array members"[1] for these > cases. The older style of one-element o

Re: [PATCH V2 2/2] net: ks8851: Register MDIO bus and the internal PHY

2021-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2021 at 01:30:17PM +0100, Marek Vasut wrote: > The KS8851 has a reduced internal PHY, which is accessible through its > registers at offset 0xe4. The PHY is compatible with KS886x PHY present > in Micrel switches, except the PHY ID Low/High registers are swapped. > Register MDIO bus

Re: [PATCH 2/2] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access

2021-01-04 Thread Florian Fainelli
On 1/2/21 5:25 PM, Martin Blumenstingl wrote: > There is one GSWIP_MII_CFG register for each switch-port except the CPU > port. The register offset for the first port is 0x0, 0x02 for the > second, 0x04 for the third and so on. > > Update the driver to not only restrict the GSWIP_MII_CFG registers

Re: [PATCH V2 1/2] net: phy: micrel: Add KS8851 PHY support

2021-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2021 at 01:30:16PM +0100, Marek Vasut wrote: > The KS8851 has a reduced internal PHY, which is accessible through its > registers at offset 0xe4. The PHY is compatible with KS886x PHY present > in Micrel switches, including the PHY ID Low/High registers swap, which > is present both

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-04 Thread Florian Fainelli
On 1/2/21 5:25 PM, Martin Blumenstingl wrote: > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. > Without this the PHY link is detected properly and ethtool statistics > for TX are increasing but there's no RX traffic coming in. > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq

Re: [PATCH net-next] nfc: Add a virtual nci device driver

2021-01-04 Thread Jakub Kicinski
On Thu, 31 Dec 2020 14:22:45 +0900 Bongsu Jeon wrote: > On Tue, Dec 29, 2020 at 6:16 AM Jakub Kicinski wrote: > > > > On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote: > > > From: Bongsu Jeon > > > > > > A NCI virtual device can be made to simulate a NCI device in user space. > > > Using th

Re: [PATCH] CDC-NCM: remove "connected" log message

2021-01-04 Thread Roland Dreier
> > to preserve the legacy behavior rather than changing the behavior of > > every usbnet driver all at once? Like make a new > > usbnet_get_link_ksettings_nonmdio and update only cdc_ncm to use it? > > Then I would have to touch them all. The problem is that the MDIO > stuff really is pretty much

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
On Mon, Jan 04, 2021 at 06:31:05PM +0100, Andrew Lunn wrote: > > The basic rules here should be, if the MDIO bus is registered, it is > > usable. There are things like PHY statistics, HWMON temperature > > sensors, etc, DSA switches, all which have a life cycle separate to > > the interface being u

[ANNOUNCE] igmpproxy 0.3

2021-01-04 Thread Pali Rohár
Hello! I would like to announce a new version of igmpproxy 0.3 https://github.com/pali/igmpproxy/releases/tag/0.3 Changes since previous version: * Show error message when maximum number of multicast groups were exceeded and hint for linux systems how to increase this limit * Improve downstream

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2021-01-04 Thread Jason Gunthorpe
On Mon, Dec 21, 2020 at 06:51:40PM +, Mark Brown wrote: > > with some kind of inheritance scheme where platform device remained as > > only instantiated directly in board files, while drivers could bind to > > OF/DT/ACPI/FPGA/etc device instantiations with minimal duplication & > > boilerplate

Re: [PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Claudiu.Beznea
Hi Charles, On 04.01.2021 12:38, Charles Keepax wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > macb_set_tx_clk were gated on the presence of this flag. > > - if (!clk) > +

Re: [PATCH net] docs: net: fix documentation on .ndo_get_stats

2021-01-04 Thread Jakub Kicinski
On Mon, 4 Jan 2021 12:42:27 +0200 Vladimir Oltean wrote: > On Wed, Dec 30, 2020 at 07:45:24PM -0800, Jakub Kicinski wrote: > > Fix calling context. > > > > Signed-off-by: Jakub Kicinski > > --- > > Documentation/networking/netdevices.rst | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions

Re: [RFC ipsec-next] xfrm: interface: enable TSO on xfrm interfaces

2021-01-04 Thread Eyal Birger
Hi Steffen, On Mon, Jan 4, 2021 at 10:44 AM Steffen Klassert wrote: > > On Wed, Dec 23, 2020 at 09:15:38AM +0200, Eyal Birger wrote: > > Underlying xfrm output supports gso packets. > > Declare support in hw_features and adapt the xmit MTU check to pass GSO > > packets. > > > > Signed-off-by: Eya

Re: [PATCH net] net: bareudp: add missing error handling for bareudp_link_config()

2021-01-04 Thread Jakub Kicinski
On Sat, 2 Jan 2021 15:49:54 -0800 Cong Wang wrote: > On Wed, Dec 30, 2020 at 7:46 PM Jakub Kicinski wrote: > > @@ -661,9 +662,14 @@ static int bareudp_newlink(struct net *net, struct > > net_device *dev, > > > > err = bareudp_link_config(dev, tb); > > if (err) > > -

Re: [RFC PATCH v3 00/12] Generic zcopy_* functions

2021-01-04 Thread Willem de Bruijn
On Wed, Dec 30, 2020 at 2:12 PM Jonathan Lemon wrote: > > From: Jonathan Lemon > > This is set of cleanup patches for zerocopy which are intended > to allow a introduction of a different zerocopy implementation. > > The top level API will use the skb_zcopy_*() functions, while > the current TCP s

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Andrew Lunn
> The basic rules here should be, if the MDIO bus is registered, it is > usable. There are things like PHY statistics, HWMON temperature > sensors, etc, DSA switches, all which have a life cycle separate to > the interface being up. [Goes and looks at the code] Yes, this is runtime PM which is br

[Aspeed, v1 1/1] net: ftgmac100: Change the order of getting MAC address

2021-01-04 Thread Hongwei Zhang
> From: Jakub Kicinski > Sent: Monday, December 28, 2020 5:01 PM > > On Tue, 22 Dec 2020 22:00:34 +0100 Andrew Lunn wrote: > > On Tue, Dec 22, 2020 at 09:46:52PM +0100, Heiner Kallweit wrote: > > > On 22.12.2020 21:14, Hongwei Zhang wrote: > > > > Dear Reviewer, > > > > > > > > Use native MAC ad

Re: [PATCH v11 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2021-01-04 Thread Steen Hegelund
Hi Leon, On Mon, 2021-01-04 at 14:15 +0200, Leon Romanovsky wrote: > > <...> > > > +struct sparx5_sd10g28_args { > > + bool skip_cmu_cfg; /* Enable/disable CMU cfg > > */ > > + bool no_pwrcycle;  /* Omit initial power- > > cycle */ > > + bool 

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Andrew Lunn
> Ok, so this does not have anything to do with interrupts explicitly but > rather with the fact that any PHY access will cause a crash when the > sh_eth device is powered down. > > If the device is powered-down before the actual .ndo_open() how is the > probe actually setting up the device? Or is

[PATCH] cfg80211: Fix "suspicious RCU usage in wiphy_apply_custom_regulatory" warning/backtrace

2021-01-04 Thread Hans de Goede
Commit beee24695157 ("cfg80211: Save the regulatory domain when setting custom regulatory") adds a get_wiphy_regdom call to wiphy_apply_custom_regulatory. But as the comment above wiphy_apply_custom_regulatory says: "/* Used by drivers prior to wiphy registration */" this function is used by driver

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
On Mon, Jan 04, 2021 at 04:11:02PM +0100, Geert Uytterhoeven wrote: > Hi Ioana, > > On Mon, Jan 4, 2021 at 3:53 PM Ioana Ciornei wrote: > > On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > > > Wolfram reports that his R-Car H2-based Lager board can no longer be > > > rebooted

Missed schedule_napi()?

2021-01-04 Thread Alex Elder
I have a question about whether it's possible to effectively miss a schedule_napi() call when a disable_napi() is underway. I'm going to try to represent the code in question here in an interleaved way to explain the scenario; I hope it's clear. Suppose the SCHED flag is clear. And suppose two

Re: [PATCH iproute2] build: Fix link errors on some systems

2021-01-04 Thread Petr Machata
Roi Dayan writes: > Since moving get_rate() and get_size() from tc to lib, on some > systems we fail to link because of missing the math lib. > Move the link flag from tc makefile to the main makefile. Hmm, yeah, it gets optimized out on x86-64. The issue is reproducible on any platform with -

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2021-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2021 at 05:24:11PM +0200, Vladyslav Tarasiuk wrote: > > On 30-Dec-20 17:36, Andrew Lunn wrote: > > On Wed, Dec 30, 2020 at 03:55:02PM +0200, Vladyslav Tarasiuk wrote: > > > On 29-Dec-20 18:25, Andrew Lunn wrote: > > > > > Hi Andrew, > > > > > > > > > > Following this conversation,

[RFC PATCH bpf-next] ksnoop: kernel argument/return value tracing/display using BTF

2021-01-04 Thread Alan Maguire
BPF Type Format (BTF) provides a description of kernel data structures and of the types kernel functions utilize as arguments and return values. A helper was recently added - bpf_snprintf_btf() - that uses that description to create a string representation of the data provided, using the BTF id of

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2021-01-04 Thread Vladyslav Tarasiuk
On 30-Dec-20 17:36, Andrew Lunn wrote: On Wed, Dec 30, 2020 at 03:55:02PM +0200, Vladyslav Tarasiuk wrote: On 29-Dec-20 18:25, Andrew Lunn wrote: Hi Andrew, Following this conversation, I wrote some pseudocode checking if I'm on right path here. Please review: struct eeprom_page {    

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Geert Uytterhoeven
Hi Ioana, On Mon, Jan 4, 2021 at 3:53 PM Ioana Ciornei wrote: > On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > > Wolfram reports that his R-Car H2-based Lager board can no longer be > > rebooted in v5.11-rc1, as it crashes with an imprecise external abort. > > The issue can

Re: [PATCH] rxrpc: fix handling of an unsupported token type in rxrpc_read()

2021-01-04 Thread Tom Rix
On 1/4/21 4:50 AM, David Howells wrote: > t...@redhat.com wrote: > >> -switch (token->security_index) { >> -case RXRPC_SECURITY_RXKAD: >> ... >> -switch (token->security_index) { >> -case RXRPC_SECURITY_RXKAD: > These switches need to be kept. Ther

Re: [PATCH] CDC-NCM: remove "connected" log message

2021-01-04 Thread Oliver Neukum
Am Donnerstag, den 31.12.2020, 10:51 -0800 schrieb Roland Dreier: > I haven't tried these patches yet but they don't look quite right to > me. inlining the first 0001 patch: OK, let's see. > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > > index 1447da1d5729..bcd17f6d6de6

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
Hi Geert, On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > Wolfram reports that his R-Car H2-based Lager board can no longer be > rebooted in v5.11-rc1, as it crashes with an imprecise external abort. > The issue can be reproduced on other boards (e.g. Koelsch with R-Car > M

Re: [PATCH v3 09/24] wfx: add hwio.c/hwio.h

2021-01-04 Thread Johan Hovold
On Mon, Jan 04, 2021 at 03:34:10PM +0300, Dan Carpenter wrote: > There is a Smatch warning for this, but I hadn't looked at the results > in a while. :/ I'm not sure how many are valid. Some kind of > annotation would be nice. > drivers/usb/class/usblp.c:593 usblp_ioctl() error: doing dma on th

  1   2   >