From: Yunjian Wang <wangyunj...@huawei.com>

Because macvlan_common_newlink() and macvlan_changelink() already
checked NULL data parameter, so the additional check is unnecessary,
just remove it.

Fixes: 79cf79abce71 ("macvlan: add source mode")
Signed-off-by: Yunjian Wang <wangyunj...@huawei.com>
---
v2:
  * change code styles and commit log suggested by Jakub Kicinski
---
 drivers/net/macvlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index fb51329f8964..9a9a5cf36a4b 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -1385,7 +1385,7 @@ static int macvlan_changelink_sources(struct macvlan_dev 
*vlan, u32 mode,
                                return ret;
                }
 
-               if (!data || !data[IFLA_MACVLAN_MACADDR_DATA])
+               if (!data[IFLA_MACVLAN_MACADDR_DATA])
                        return 0;
 
                head = nla_data(data[IFLA_MACVLAN_MACADDR_DATA]);
-- 
2.23.0

Reply via email to