Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()

2020-11-13 Thread James Morris
On Fri, 13 Nov 2020, Paul Moore wrote: > Static checking revealed that a previous fix to > netlbl_unlabel_staticlist() leaves a stack variable uninitialized, > this patches fixes that. > > Fixes: 866358ec331f ("netlabel: fix our progress tracking in > netlbl_unlabel_staticlist()") > Reported-by:

Re: [RFC bpf-next 1/3] bpf: add module support to btf display helpers

2020-11-13 Thread Andrii Nakryiko
On Fri, Nov 13, 2020 at 10:11 AM Alan Maguire wrote: > > bpf_snprintf_btf and bpf_seq_printf_btf use a "struct btf_ptr *" > argument that specifies type information about the type to > be displayed. Augment this information to include a module > name, allowing such display to support module types

Re: [RFC bpf-next 3/3] selftests/bpf: verify module-specific types can be shown via bpf_snprintf_btf

2020-11-13 Thread Andrii Nakryiko
On Fri, Nov 13, 2020 at 10:11 AM Alan Maguire wrote: > > Verify that specifying a module name in "struct btf_ptr *" along > with a type id of a module-specific type will succeed. > > veth_stats_rx() is chosen because its function signature consists > of a module-specific type "struct veth_stats" a

Re: [RFC bpf-next 2/3] libbpf: bpf__find_by_name[_kind] should use btf__get_nr_types()

2020-11-13 Thread Andrii Nakryiko
On Fri, Nov 13, 2020 at 10:11 AM Alan Maguire wrote: > > When operating on split BTF, btf__find_by_name[_kind] will not > iterate over all types since they use btf->nr_types to show > the number of types to iterate over. For split BTF this is > the number of types _on top of base BTF_, so it will

RE: [PATCH RESEND net-next 18/18] net: phy: adin: remove the use of the .ack_interrupt()

2020-11-13 Thread Ardelean, Alexandru
> -Original Message- > From: Ioana Ciornei > Sent: Friday, November 13, 2020 6:52 PM > To: Andrew Lunn ; Heiner Kallweit ; > Russell King ; Florian Fainelli ; > Jakub Kicinski ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: Ioana Ciornei ; Ardelean, Alexandru > > Subjec

RE: [PATCH RESEND net-next 17/18] net: phy: adin: implement generic .handle_interrupt() callback

2020-11-13 Thread Ardelean, Alexandru
> -Original Message- > From: Ioana Ciornei > Sent: Friday, November 13, 2020 6:52 PM > To: Andrew Lunn ; Heiner Kallweit ; > Russell King ; Florian Fainelli ; > Jakub Kicinski ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: Ioana Ciornei ; Ardelean, Alexandru > > Subjec

Re: [PATCH net] sctp: change to hold/put transport for proto_unreach_timer

2020-11-13 Thread Xin Long
On Fri, Nov 13, 2020 at 8:35 PM Marcelo Ricardo Leitner wrote: > > Hi, > > On Fri, Nov 13, 2020 at 05:18:24PM +0800, Xin Long wrote: > ... > > diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c > > index 813d307..0a51150 100644 > > --- a/net/sctp/sm_sideeffect.c > > +++ b/net/sctp/sm

[PATCHv2 net] sctp: change to hold/put transport for proto_unreach_timer

2020-11-13 Thread Xin Long
A call trace was found in Hangbin's Codenomicon testing with debug kernel: [ 2615.981988] ODEBUG: free active (active state 0) object type: timer_list hint: sctp_generate_proto_unreach_event+0x0/0x3a0 [sctp] [ 2615.995050] WARNING: CPU: 17 PID: 0 at lib/debugobjects.c:328 debug_print_object+

[net] net/tls: fix corrupted data in recvmsg

2020-11-13 Thread Vadim Fedorenko
If tcp socket has more data than Encrypted Handshake Message then tls_sw_recvmsg will try to decrypt next record instead of returning full control message to userspace as mentioned in comment. The next message - usually Application Data - gets corrupted because it uses zero copy for decryption that

[PATCH net-next 1/3] drivers: net: cpsw: ale: add broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
The CPSW ALE supports feature to rate limit number ingress broadcast(BC)/multicast(MC) packets per/sec which main purpose is BC/MC storm prevention. The ALE BC/MC packet rate limit configuration consist of two parts: - global ALE_CONTROL.ENABLE_RATE_LIMIT bit 0 which enables rate limiting global

[PATCH net-next 2/3] net: ethernet: ti: cpsw_new: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
This patch enables support for ingress broadcast(BC)/multicast(MC) rate limiting in TI CPSW switchdev driver (the corresponding ALE support was added in previous patch) by implementing HW offload for simple tc-flower policer with matches on dst_mac: - ff:ff:ff:ff:ff:ff has to be used for BC rate l

[PATCH net-next 0/3] net: ethernet: ti: cpsw: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
Hi This series first adds supports for the ALE feature to rate limit number ingress broadcast(BC)/multicast(MC) packets per/sec which main purpose is BC/MC storm prevention. And then enables corresponding support for ingress broadcast(BC)/multicast(MC) rate limiting for TI CPSW switchdev and AM65

[PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
This patch enables support for ingress broadcast(BC)/multicast(MC) rate limiting in TI AM65x CPSW driver (the corresponding ALE support was added in previous patch) by implementing HW offload for simple tc-flower policer with matches on dst_mac: - ff:ff:ff:ff:ff:ff has to be used for BC rate limit

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread David Ahern
On 11/13/20 12:00 PM, Nathan Chancellor wrote: > On Fri, Nov 13, 2020 at 10:05:56AM -0700, David Ahern wrote: >> On 11/13/20 9:57 AM, Jakub Kicinski wrote: >>> Good people of build bot, >>> >>> would you mind shedding some light on this one? It was also reported on >>> v1, and Andrea said it's imp

Re: [PATCHv4 iproute2-next 1/5] configure: add check_libbpf() for later libbpf support

2020-11-13 Thread David Ahern
On 11/9/20 12:07 AM, Hangbin Liu wrote: > This patch adds a check to see if we have libbpf support. By default the > system libbpf will be used, but static linking against a custom libbpf > version can be achieved by passing LIBBPF_DIR to configure. > > Add another variable LIBBPF_FORCE to control

[PATCH v2 net-next 2/3] icmp: define probe message types

2020-11-13 Thread Andreas Roeseler
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are defined in sections 2 and 3 of RFC8335. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree --- include/linux/icmp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/icmp

[PATCH v2 net-next 3/3] ICMPv6: define probe message types

2020-11-13 Thread Andreas Roeseler
The types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply are defined in sections 2 and 3 of RFC8335. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree --- include/linux/icmpv6.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/l

Re: [PATCHv4 iproute2-next 2/5] lib: rename bpf.c to bpf_legacy.c

2020-11-13 Thread David Ahern
On 11/9/20 12:07 AM, Hangbin Liu wrote: > diff --git a/lib/bpf_glue.c b/lib/bpf_glue.c > new file mode 100644 > index ..7626a893 > --- /dev/null > +++ b/lib/bpf_glue.c ... > + > +int bpf_program_load(enum bpf_prog_type type, const struct bpf_insn *insns, > + size_t size_i

[PATCH v2 net-next 1/3] net: add support for sending probe messages

2020-11-13 Thread Andreas Roeseler
Modifying the ping_supported function to support probe message types allows the user to send probe requests through the existing framework for sending ping requests. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree --- net/ipv4/ping.c | 2 +- 1 file changed, 1

[PATCH v2 net-next 0/3] Add support for sending RFC8335 PROBE

2020-11-13 Thread Andreas Roeseler
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the new utility PROBE which is a spec

Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing

2020-11-13 Thread David Ahern
On 11/10/20 12:53 AM, Zahari Doychev wrote: > Currently the icmp and arp parsing functions are called with incorrect > ethtype in case of vlan or cvlan filter options. In this case either > cvlan_ethtype or vlan_ethtype has to be used. The ethtype is now updated > each time a vlan ethtype is matche

Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()

2020-11-13 Thread Richard Cochran
On Fri, Nov 13, 2020 at 11:10:58AM -0800, Vinicius Costa Gomes wrote: > I am proposing a series that adds support for PCIe PTM (for the igc > driver), exporting the values via the PTP_SYS_OFFSET_PRECISE ioctl(). > > The way PTM works in the NIC I have, kind of forces me to start the PTM > dialogs

Re: [PATCH iproute2-next v5 00/11] Add a tool for configuration of DCB

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to iproute2/iproute2-next.git (refs/heads/main): On Thu, 12 Nov 2020 23:24:37 +0100 you wrote: > The Linux DCB interface allows configuration of a broad range of > hardware-specific attributes, such as TC scheduling, flow control, per-port > buffer configuration, TC

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread David Ahern
On 11/13/20 7:29 PM, Andrea Mayer wrote: > Hi Jakub, > > On Fri, 13 Nov 2020 18:01:26 -0800 > Jakub Kicinski wrote: > >>> UAPI solution 2 >>> >>> we turn "table" into an optional parameter and we add the "vrftable" >>> optional >>> parameter. DT4 can only be used with the "vrftable" (hence it i

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread Andrea Mayer
Hi Jakub, On Fri, 13 Nov 2020 18:01:26 -0800 Jakub Kicinski wrote: > > UAPI solution 2 > > > > we turn "table" into an optional parameter and we add the "vrftable" > > optional > > parameter. DT4 can only be used with the "vrftable" (hence it is a required > > parameter for DT4). > > DT6 can b

Re: [PATCH net-next] net: phy: mscc: Add PTP support for 2 more VSC PHYs

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 12 Nov 2020 10:22:50 +0100 you wrote: > Add VSC8572 and VSC8574 in the PTP configuration > as they also support PTP. > > The relevant datasheets can be found here: > - VSC8572: https://www.microchip.com/wwwproduc

答复: [PATCH] ipv6: Fix error path to cancel the meseage

2020-11-13 Thread zhangqilong
> > On Thu, 12 Nov 2020 16:09:50 +0800 Zhang Qilong wrote: > > genlmsg_cancel() needs to be called in the error path of > > inet6_fill_ifmcaddr and inet6_fill_ifacaddr to cancel the message. > > > > Fixes: 203651b665f72 ("ipv6: add inet6_fill_args") > > Reported-by: Hulk Robot > > Signed-off-by:

Re: [PATCH] ipv6: Fix error path to cancel the meseage

2020-11-13 Thread Jakub Kicinski
On Thu, 12 Nov 2020 16:09:50 +0800 Zhang Qilong wrote: > genlmsg_cancel() needs to be called in the error path of > inet6_fill_ifmcaddr and inet6_fill_ifacaddr to cancel > the message. > > Fixes: 203651b665f72 ("ipv6: add inet6_fill_args") > Reported-by: Hulk Robot > Signed-off-by: Zhang Qilong

Re: [PATCH v2 net-next 2/2] net: dsa: tag_dsa: Use a consistent comment style

2020-11-13 Thread Andrew Lunn
On Wed, Nov 11, 2020 at 02:11:53PM +0100, Tobias Waldekranz wrote: > Use a consistent style of one-line/multi-line comments throughout the > file. > > Signed-off-by: Tobias Waldekranz Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-13 Thread Andrew Lunn
Hi Tobias > +/** > + * enum dsa_cmd - DSA Command > + * @DSA_CMD_TO_CPU: Set on packets that were trapped or mirrored to > + * the CPU port. This is needed to implement control protocols, > + * e.g. STP and LLDP, that must not allow those control packets to > + * be switched according

pull-request: bpf-next 2020-11-14

2020-11-13 Thread Daniel Borkmann
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net-next* tree. We've added 66 non-merge commits during the last 22 day(s) which contain a total of 83 files changed, 3908 insertions(+), 1271 deletions(-). The main changes are: 1) Add BTF generation for kernel modul

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread Jakub Kicinski
On Sat, 14 Nov 2020 02:50:58 +0100 Andrea Mayer wrote: > Hi Jakub, > Please see my responses inline: > > On Fri, 13 Nov 2020 15:54:37 -0800 > Jakub Kicinski wrote: > > > On Sat, 14 Nov 2020 00:00:24 +0100 Andrea Mayer wrote: > > > On Fri, 13 Nov 2020 13:40:10 -0800 > > > Jakub Kicinski wrote:

RE: [EXT] Re: Fwd: net: fec: rx descriptor ring out of order

2020-11-13 Thread Andy Duan
From: Kegl Rohit Sent: Friday, November 13, 2020 8:21 PM > On Fri, Nov 13, 2020 at 8:33 AM Kegl Rohit wrote: > > > > > What are the addresses of the ring entries? > > > I bet there is something wrong with the cache coherency and/or > > > flushing. > > > > > > So the MAC hardware has done the writ

Re: [PATCH net-next,v3 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-13 Thread Jakub Kicinski
On Wed, 11 Nov 2020 20:37:28 +0100 Pablo Neira Ayuso wrote: > The following patchset augments the Netfilter flowtable fastpath [1] to > support for network topologies that combine IP forwarding, bridge and > VLAN devices. > > A typical scenario that can benefit from this infrastructure is composed

Re: [net-next v2 03/15] ice: initialize ACL table

2020-11-13 Thread Alexander Duyck
On Fri, Nov 13, 2020 at 4:16 PM Nguyen, Anthony L wrote: > > On Fri, 2020-11-13 at 14:59 -0800, Alexander Duyck wrote: > > On Fri, Nov 13, 2020 at 1:36 PM Tony Nguyen < > > anthony.l.ngu...@intel.com> wrote: > > > > > > From: Real Valiquette > > > > > > ACL filtering can be utilized to expand sup

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread Andrea Mayer
Hi Jakub, Please see my responses inline: On Fri, 13 Nov 2020 15:54:37 -0800 Jakub Kicinski wrote: > On Sat, 14 Nov 2020 00:00:24 +0100 Andrea Mayer wrote: > > On Fri, 13 Nov 2020 13:40:10 -0800 > > Jakub Kicinski wrote: > > > > I can tackle the v6 version but how do we face the compatibility

Re: [PATCH RFC] bpf, x64: allow not-converged images when BPF_JIT_ALWAYS_ON is set

2020-11-13 Thread Alexei Starovoitov
On Fri, Nov 13, 2020 at 12:40 AM Gary Lin wrote: > > The x64 bpf jit expects the bpf images converge within the given passes. > However there is a corner case: > > l0: ldh [4] > l1: jeq #0x537d, l2, l40 > l2: ld [0] > l3: jeq #0xfa163e0d, l4, l40 > l4: ldh [12] > l5

Re: [PATCH net-next,v3 3/9] net: resolve forwarding path from virtual netdevice and HW destination address

2020-11-13 Thread Jakub Kicinski
On Wed, 11 Nov 2020 20:37:31 +0100 Pablo Neira Ayuso wrote: > +int dev_fill_forward_path(const struct net_device *dev, const u8 *daddr, > + struct net_device_path_stack *stack) > +{ > + const struct net_device *last_dev; > + struct net_device_path_ctx ctx; > + stru

Re: [net-next v3 08/15] ice: don't always return an error for Get PHY Abilities AQ command

2020-11-13 Thread Alexander Duyck
On Fri, Nov 13, 2020 at 1:49 PM Tony Nguyen wrote: > > From: Paul M Stillwell Jr > > There are times when the driver shouldn't return an error when the Get > PHY abilities AQ command (0x0600) returns an error. Instead the driver > should log that the error occurred and continue on. This allows th

Good Morning,

2020-11-13 Thread Mr Bill T Winters
-- Greetings, I Mr Bill T, did you Receive the (FUND), that was paid to you? please, do not hesitate to Let me know with your full name:.. for immediate verification notice, Sincerely Yours, Respectfully, Mr Bill T Winters, Group Chief Executive Officer & Executive Director,

Re: [PATCH v2 08/10] ARM: dts: NSP: Add a SRAB compatible string for each board

2020-11-13 Thread Vladimir Oltean
On Wed, Nov 11, 2020 at 08:50:18PM -0800, Florian Fainelli wrote: > Provide a valid compatible string for the Ethernet switch node based on > the board including the switch. This allows us to have sane defaults and > silences the following warnings: > > arch/arm/boot/dts/bcm958522er.dt.yaml: >

[PATCH net-next] net: linux/skbuff.h: combine NET + KCOV handling

2020-11-13 Thread Randy Dunlap
r.kernel.org --- include/linux/skbuff.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-next-20201113.orig/include/linux/skbuff.h +++ linux-next-20201113/include/linux/skbuff.h @@ -4151,7 +4151,7 @@ enum skb_ext_id { #if IS_ENABLED(CONFIG_MPTCP) SKB_EXT_MPTCP

Re: [PATCH v2 09/10] ARM: dts: NSP: Provide defaults ports container node

2020-11-13 Thread Vladimir Oltean
On Wed, Nov 11, 2020 at 08:50:19PM -0800, Florian Fainelli wrote: > Provide an empty 'ports' container node with the correct #address-cells > and #size-cells properties. This silences the following warning: > > arch/arm/boot/dts/bcm958522er.dt.yaml: > ethernet-switch@36000: 'oneOf' conditional fai

Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-13 Thread Vladimir Oltean
On Wed, Nov 11, 2020 at 02:11:52PM +0100, Tobias Waldekranz wrote: > Ethertype DSA encodes exactly the same information in the DSA tag as > the non-ethertype variety. So refactor out the common parts and reuse > them for both protocols. > > This is ensures tag parsing and generation is always cons

Re: [PATCH v2 net-next 2/2] net: dsa: tag_dsa: Use a consistent comment style

2020-11-13 Thread Vladimir Oltean
On Wed, Nov 11, 2020 at 02:11:53PM +0100, Tobias Waldekranz wrote: > Use a consistent style of one-line/multi-line comments throughout the > file. > > Signed-off-by: Tobias Waldekranz > --- Reviewed-by: Vladimir Oltean

Re: [PATCH] ip_tunnels: Set tunnel option flag when tunnel metadata is present

2020-11-13 Thread Jakub Kicinski
On Sat, 14 Nov 2020 01:46:04 +0100 Daniel Borkmann wrote: > On 11/14/20 1:13 AM, Jakub Kicinski wrote: > > On Tue, 10 Nov 2020 16:16:40 -0800 Yi-Hung Wei wrote: > >> Currently, we may set the tunnel option flag when the size of metadata > >> is zero. For example, we set TUNNEL_GENEVE_OPT in the

Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-13 Thread Vladimir Oltean
On Fri, Nov 13, 2020 at 04:27:09PM -0800, Jakub Kicinski wrote: > On Wed, 11 Nov 2020 14:11:52 +0100 Tobias Waldekranz wrote: > > Ethertype DSA encodes exactly the same information in the DSA tag as > > the non-ethertype variety. So refactor out the common parts and reuse > > them for both protocol

Re: [PATCH net-next v2 09/11] net: dsa: microchip: ksz9477: add hardware time stamping support

2020-11-13 Thread Vladimir Oltean
On Fri, Nov 13, 2020 at 07:57:32PM +0100, Christian Eggers wrote: > On Friday, 13 November 2020, 03:40:20 CET, Vladimir Oltean wrote: > > On Thu, Nov 12, 2020 at 04:35:35PM +0100, Christian Eggers wrote: > [...] > > > @@ -103,6 +108,10 @@ static int ksz9477_ptp_adjtime(struct ptp_clock_info > > > *

Re: [PATCH] ip_tunnels: Set tunnel option flag when tunnel metadata is present

2020-11-13 Thread Daniel Borkmann
On 11/14/20 1:13 AM, Jakub Kicinski wrote: On Tue, 10 Nov 2020 16:16:40 -0800 Yi-Hung Wei wrote: Currently, we may set the tunnel option flag when the size of metadata is zero. For example, we set TUNNEL_GENEVE_OPT in the receive function no matter the geneve option is present or not. As this

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Andrew Lunn
> One question that still has not been answered is how many actual > platforms were fixed by backporting Realtek's follow up fix to > -stable. My suspicion is none. That by itself should be enough > justification to revert the backport of that change. I think i've already said that would be a goo

Re: [PATCH net-next 3/3] ICMPv6: define probe message types

2020-11-13 Thread Jakub Kicinski
On Fri, 13 Nov 2020 13:59:45 -0800 Andreas Roeseler wrote: > The types of ICMPv6 Extended Echo Request and ICMPv6 Extended Echo Reply > messages are defined by sections 2 adn 3 of RFC8335. > > Signed-off-by: Andreas Roeseler > --- > include/uapi/linux/icmpv6.h | 6 ++ > 1 file changed, 6 ins

Re: [PATCH net-next] r8169: improve rtl_tx

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 11 Nov 2020 22:56:29 +0100 you wrote: > We can simplify the for() condition and eliminate variable tx_left. > The change also considers that tp->cur_tx may be incremented by a > racing rtl8169_start_xmit(). > In add

Re: [PATCH net-next] r8169: use READ_ONCE in rtl_tx_slots_avail

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 11 Nov 2020 22:14:27 +0100 you wrote: > tp->dirty_tx and tp->cur_tx may be changed by a racing rtl_tx() or > rtl8169_start_xmit(). Use READ_ONCE() to annotate the races and ensure > that the compiler doesn't use cac

Re: [PATCH v2 net-next] net: stmmac: platform: use optional clk/reset get APIs

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 12 Nov 2020 09:27:37 +0800 you wrote: > Use the devm_reset_control_get_optional() and devm_clk_get_optional() > rather than open coding them. > > Signed-off-by: Jisheng Zhang > --- > Since v1: > - keep wrapped as

Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-13 Thread Jakub Kicinski
On Wed, 11 Nov 2020 14:11:52 +0100 Tobias Waldekranz wrote: > Ethertype DSA encodes exactly the same information in the DSA tag as > the non-ethertype variety. So refactor out the common parts and reuse > them for both protocols. > > This is ensures tag parsing and generation is always consistent

[PATCH net-next 3/3] nfc: s3fwrn5: Change the error code.

2020-11-13 Thread Bongsu Jeon
ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/s3fwrn5.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h index 9d5f34759225..bb8f936d13a2 100644

[PATCH net-next 2/3] nfc: s3fwrn5: Fix the misspelling in a comment

2020-11-13 Thread Bongsu Jeon
Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c index ec930ee2c847..4cde6dd5c019 100644 --- a/drivers/nfc/s3fwrn5/firmware.c +++ b/drivers/nfc/s3fwrn

Re: [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy

2020-11-13 Thread Jakub Kicinski
On Fri, 13 Nov 2020 09:27:30 + Antoine Tenart wrote: > Quoting Steen Hegelund (2020-11-13 10:11:16) > > Selecting VSC8575 as a MACSec PHY was not correct > > > > The relevant datasheet can be found here: > > - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575 > > > > History: > > v1 -

[PATCH net-next 1/3] nfc: s3fwrn5: Remove the max_payload.

2020-11-13 Thread Bongsu Jeon
max_payload is unused. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/core.c| 3 +-- drivers/nfc/s3fwrn5/i2c.c | 4 +--- drivers/nfc/s3fwrn5/s3fwrn5.h | 3 +-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c ind

Re: [net-next v2 03/15] ice: initialize ACL table

2020-11-13 Thread Nguyen, Anthony L
On Fri, 2020-11-13 at 14:59 -0800, Alexander Duyck wrote: > On Fri, Nov 13, 2020 at 1:36 PM Tony Nguyen < > anthony.l.ngu...@intel.com> wrote: > > > > From: Real Valiquette > > > > ACL filtering can be utilized to expand support of ntuple rules by > > allowing > > mask values to be specified for

Re: [PATCH] ip_tunnels: Set tunnel option flag when tunnel metadata is present

2020-11-13 Thread Jakub Kicinski
On Tue, 10 Nov 2020 16:16:40 -0800 Yi-Hung Wei wrote: > Currently, we may set the tunnel option flag when the size of metadata > is zero. For example, we set TUNNEL_GENEVE_OPT in the receive function > no matter the geneve option is present or not. As this may result in > issues on the tunnel fla

[net-next 2/4] i40e: remove redundant assignment

2020-11-13 Thread Tony Nguyen
From: Marek Majtyka Remove a redundant assignment of the software ring pointer in the i40e driver. The variable is assigned twice with no use in between, so just get rid of the first occurrence. Fixes: 3b4f0b66c2b3 ("i40e, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL") Signed-off-by: Marek Majtyka

[net-next 1/4] i40e: add support for PTP external synchronization clock

2020-11-13 Thread Tony Nguyen
From: Piotr Kwapulinski Add support for external synchronization clock via GPIOs. 1PPS signals are handled via the dedicated 3 GPIOs: SDP3_2, SDP3_3 and GPIO_4. Previously it was not possible to use the external PTP synchronization clock. Reviewed-by: Aleksandr Loktionov Reviewed-by: Arkadiusz

[net-next 3/4] i40e: report correct VF link speed when link state is set to enable

2020-11-13 Thread Tony Nguyen
From: Stefan Assmann When the virtual link state was set to "enable" ethtool would report link speed as 4Mb/s regardless of the underlying device. Report the correct link speed. Example from a XXV710 NIC. Before: $ ip link set ens3f0 vf 0 state auto $ ethtool enp8s2 | grep Speed Spe

[net-next 4/4] igbvf: Refactor traces

2020-11-13 Thread Tony Nguyen
From: Karen Sornek Refactoring "PF still resetting" and changing "Failed to add vlan id" to "Vlan id is not added" messages because previous version looked like a bug - it informed about changes that worked as designed but might confuse users Signed-off-by: Karen Sornek Reviewed-by: Aleksandr

[net-next 0/4][pull request] 40GbE Intel Wired LAN Driver Updates 2020-11-13

2020-11-13 Thread Tony Nguyen
This series contains updates to i40e and igbvf drivers. Piotr adds support for PTP external clock synchronization to i40e via GPIO pins. Marek removes a redundant assignment for i40e. Stefan Assmann corrects reporting of VF link speed for i40e. Karen revises a couple of error messages to warnin

Fw: [Bug 210195] New: Security scanner crashes kernel post 4.19.13 ade446403bfb

2020-11-13 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 13 Nov 2020 23:01:48 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 210195] New: Security scanner crashes kernel post 4.19.13 ade446403bfb https://bugzilla.kernel.org/show_bug.cgi?id=210195 Bug ID:

Re: [net-next v3 05/15] ice: create flow profile

2020-11-13 Thread Alexander Duyck
On Fri, Nov 13, 2020 at 1:46 PM Tony Nguyen wrote: > > From: Real Valiquette > > Implement the initial steps for creating an ACL filter to support ntuple > masks. Create a flow profile based on a given mask rule and program it to > the hardware. Though the profile is written to hardware, no actio

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread Jakub Kicinski
On Sat, 14 Nov 2020 00:00:24 +0100 Andrea Mayer wrote: > On Fri, 13 Nov 2020 13:40:10 -0800 > Jakub Kicinski wrote: > > > On Fri, 13 Nov 2020 11:40:36 -0800 Jakub Kicinski wrote: > > > > agreed. The v6 variant has existed for a while. The v4 version is > > > > independent. > > > > > > Okay

Re: [net-next v2 PATCH] devlink: move request_firmware out of driver

2020-11-13 Thread Shannon Nelson
On 11/13/20 2:45 PM, Jacob Keller wrote: All drivers which implement the devlink flash update support, with the exception of netdevsim, use either request_firmware or request_firmware_direct to locate the firmware file. Rather than having each driver do this separately as part of its .flash_updat

Re: [PATCH net-next 0/2] net: ipa: two fixes

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 12 Nov 2020 06:11:55 -0600 you wrote: > This small series makes two fixes to the IPA code: > - While reviewing something else I found that one of the resource > limits on the SDM845 used the wrong value. The

Re: [PATCH net-next 0/3] sfc: further EF100 encap TSO features

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 12 Nov 2020 15:18:01 + you wrote: > This series adds support for GRE and GRE_CSUM TSO on EF100 NICs, as > well as improving the handling of UDP tunnel TSO. > > Edward Cree (3): > sfc: extend bitfield macros

Re: [PATCH v5] net: ethernet: ti: am65-cpts: update ret when ptp_clock is ERROR

2020-11-13 Thread Jakub Kicinski
On Thu, 12 Nov 2020 18:45:41 +0200 Grygorii Strashko wrote: > From: Wang Qing > > We always have to update the value of ret, otherwise the > error value may be the previous one. > > Fixes: f6bd59526ca5 ("net: ethernet: ti: introduce am654 common platform time > sync driver") > Signed-off-by: W

Re: [PATCH net-next 0/6] net: ipa: GSI register consolidation

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 10 Nov 2020 15:59:16 -0600 you wrote: > This series rearranges and consolidates some GSI register > definitions. Its general aim is to make things more > consistent, by: > - Using enumerated types to define the

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-13 Thread Greg KH
On Fri, Nov 13, 2020 at 04:07:57PM +, Ertman, David M wrote: > > -Original Message- > > From: Greg KH > > Sent: Friday, November 13, 2020 7:50 AM > > To: Ertman, David M > > Cc: alsa-de...@alsa-project.org; ti...@suse.de; broo...@kernel.org; linux- > > r...@vger.kernel.org; j...@nvidi

Re: [PATCH net] net: marvell: prestera: fix error return code in prestera_pci_probe()

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 13 Nov 2020 19:32:36 +0800 you wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 4c2703dfd7fa ("net: marvell: prestera: Add PCI inte

[PATCH net-next v3 4/4] selftests: add ring and coalesce selftests

2020-11-13 Thread Antonio Cardace
Add scripts to test ring and coalesce settings of netdevsim. Signed-off-by: Antonio Cardace --- .../drivers/net/netdevsim/ethtool-coalesce.sh | 68 +++ .../drivers/net/netdevsim/ethtool-ring.sh | 53 +++ 2 files changed, 121 insertions(+) create mode 100755 tool

[PATCH net-next v3 2/4] netdevsim: support ethtool ring and coalesce settings

2020-11-13 Thread Antonio Cardace
Add ethtool ring and coalesce settings support for testing. Signed-off-by: Antonio Cardace --- drivers/net/netdevsim/ethtool.c | 82 ++- drivers/net/netdevsim/netdevsim.h | 9 +++- 2 files changed, 79 insertions(+), 12 deletions(-) diff --git a/drivers/net/netdevs

[PATCH net-next v3 3/4] selftests: extract common functions in ethtool-common.sh

2020-11-13 Thread Antonio Cardace
Factor out some useful functions so that they can be reused by other ethtool-netdevsim scripts. Signed-off-by: Antonio Cardace --- .../drivers/net/netdevsim/ethtool-common.sh | 69 +++ .../drivers/net/netdevsim/ethtool-pause.sh| 63 + 2 files changed, 71 ins

[PATCH net-next v3 1/4] ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define

2020-11-13 Thread Antonio Cardace
This bitmask represents all existing coalesce parameters. Signed-off-by: Antonio Cardace --- include/linux/ethtool.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index 6408b446051f..e3da25b51ae4 100644 --- a/include/linux/ethtool.h +++ b/i

Re: [PATCH net V4] Exempt multicast addresses from five-second neighbor lifetime

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 12 Nov 2020 20:58:15 -0500 you wrote: > Commit 58956317c8de ("neighbor: Improve garbage collection") > guarantees neighbour table entries a five-second lifetime. Processes > which make heavy use of multicast can fill th

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread Andrea Mayer
Hi Jakub, On Fri, 13 Nov 2020 13:40:10 -0800 Jakub Kicinski wrote: > On Fri, 13 Nov 2020 11:40:36 -0800 Jakub Kicinski wrote: > > > agreed. The v6 variant has existed for a while. The v4 version is > > > independent. > > > > Okay, I'm not sure what's the right call so I asked DaveM. > > Dave

Re: [net-next v2 03/15] ice: initialize ACL table

2020-11-13 Thread Alexander Duyck
On Fri, Nov 13, 2020 at 1:36 PM Tony Nguyen wrote: > > From: Real Valiquette > > ACL filtering can be utilized to expand support of ntuple rules by allowing > mask values to be specified for redirect to queue or drop. > > Implement support for specifying the 'm' value of ethtool ntuple command >

Re: devlink userspace process appears stuck (was: Re: [net-next] devlink: move request_firmware out of driver)

2020-11-13 Thread Jacob Keller
On 11/13/2020 2:32 PM, Jacob Keller wrote: > > > On 11/13/2020 1:34 PM, Jacob Keller wrote: >> Well, at least with ice, the experience is pretty bad. I tried out with >> a garbage file name on one of my test systems. This was on a slightly >> older kernel without this patch applied, and the de

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Ard Biesheuvel
On Fri, 13 Nov 2020 at 23:43, Andrew Lunn wrote: > > Hi Arnd > > > Something of that sort. I also see a similar patch in KSZ9031 > > now, see 7dd8f0ba88fc ("arm: dts: imx6qdl-udoo: fix rgmii phy-mode > > for ksz9031 phy") > > > > As this exact mismatch between rgmii and rgmii-id mode is apparently

[net-next v2 PATCH] devlink: move request_firmware out of driver

2020-11-13 Thread Jacob Keller
All drivers which implement the devlink flash update support, with the exception of netdevsim, use either request_firmware or request_firmware_direct to locate the firmware file. Rather than having each driver do this separately as part of its .flash_update implementation, perform the request_firmw

Re: [RESEND PATCH] bluetooth: Set ext scan response only when it exists

2020-11-13 Thread Luiz Augusto von Dentz
Hi Marcel, Abhishek, On Sun, Sep 13, 2020 at 12:51 AM Marcel Holtmann wrote: > > Hi Abhishek, > > > Only set extended scan response only when it exists. Otherwise, clear > > the scan response data. > > > > Per the core spec v5.2, Vol 4, Part E, 7.8.55 > > > > If the advertising set is non-scannab

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Andrew Lunn
Hi Arnd > Something of that sort. I also see a similar patch in KSZ9031 > now, see 7dd8f0ba88fc ("arm: dts: imx6qdl-udoo: fix rgmii phy-mode > for ksz9031 phy") > > As this exact mismatch between rgmii and rgmii-id mode is apparently > a more widespread problem, the best workaround I can think of

Re: [PATCH AUTOSEL 5.9 26/55] wireguard: selftests: check that route_me_harder packets use the right sk

2020-11-13 Thread Jason A. Donenfeld
On Tue, Nov 10, 2020 at 6:20 PM Greg KH wrote: > > On Tue, Nov 10, 2020 at 01:29:41PM +0100, Jason A. Donenfeld wrote: > > Note that this requires > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=46d6c5ae953cc0be38efd0e469284df7c4328cf8 > > And that commit should b

devlink userspace process appears stuck (was: Re: [net-next] devlink: move request_firmware out of driver)

2020-11-13 Thread Jacob Keller
On 11/13/2020 1:34 PM, Jacob Keller wrote: > Well, at least with ice, the experience is pretty bad. I tried out with > a garbage file name on one of my test systems. This was on a slightly > older kernel without this patch applied, and the device had a pending > update that had not yet been fina

Re: [PATCH] tipc: fix -Wstringop-truncation warnings

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 12 Nov 2020 17:34:42 +0800 you wrote: > From: Wenlin Kang > > Replace strncpy() with strscpy(), fixes the following warning: > > In function 'bearer_name_validate', > inlined from 'tipc_enable_bearer' at net/

Re: [PATCH] net: ethernet: ti: cpsw: fix cpts irq after suspend

2020-11-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 12 Nov 2020 13:15:46 +0200 you wrote: > Depending on the SoC/platform the CPSW can completely lose context after a > suspend/resume cycle, including CPSW wrapper (WR) which will cause reset of > WR_C0_MISC_EN register, s

[PATCH net-next 1/3] net: add support for sending probe messages

2020-11-13 Thread Andreas Roeseler
Modifying the ping_supported function to support probe message types allows the user to send probe requests through the existing framework for sending ping requests. Signed-off-by: Andreas Roeseler --- net/ipv4/ping.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ipv

[PATCH net-next 3/3] ICMPv6: define probe message types

2020-11-13 Thread Andreas Roeseler
The types of ICMPv6 Extended Echo Request and ICMPv6 Extended Echo Reply messages are defined by sections 2 adn 3 of RFC8335. Signed-off-by: Andreas Roeseler --- include/uapi/linux/icmpv6.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux

[PATCH net-next 2/3] icmp: define probe message types

2020-11-13 Thread Andreas Roeseler
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are defined in sections 2 and 3 of RFC8335. Signed-off-by: Andreas Roeseler --- include/uapi/linux/icmp.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/icmp.h b/include/uapi/linux/icmp.h index fb169

[PATCH net-next 0/3] Add support for sending RFC8335 PROBE

2020-11-13 Thread Andreas Roeseler
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the new utility PROBE which is a speci

[PATCH v3] net: xfrm: use core API for updating/providing stats

2020-11-13 Thread Lev Stipakov
Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added function "dev_sw_netstats_tx_add()" to update net device per-cpu TX stats. Use this function instead of own code. While on it, remove xfrmi_get_stats64() and replace it with dev_get_tstats64(). Signed-off-by: Lev Stipakov

[PATCH v3] net: openvswitch: use core API to update/provide stats

2020-11-13 Thread Lev Stipakov
Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added function "dev_sw_netstats_tx_add()" to update net device per-cpu TX stats. Use this function instead of own code. While on it, remove internal_get_stats() and replace it with dev_get_tstats64(). Signed-off-by: Lev Stipakov

[PATCH v3] net: mac80211: use core API for updating TX/RX stats

2020-11-13 Thread Lev Stipakov
Commits d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") 451b05f413d3f ("net: netdevice.h: sw_netstats_rx_add helper) have added API to update net device per-cpu TX/RX stats. Use core API instead of ieee80211_tx/rx_stats(). Signed-off-by: Lev Stipakov Reviewed-by: Heiner Kallweit -

[net-next v3 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-11-13

2020-11-13 Thread Tony Nguyen
This series contains updates to ice driver only. Bruce changes the allocation of ice_flow_prof_params from stack to heap to avoid excessive stack usage. Corrects a misleading comment and silences a sparse warning that is not a problem. Tony renames Flow Director functions to be more generic as th

  1   2   3   4   >