On Fri, 2020-11-13 at 14:59 -0800, Alexander Duyck wrote: > On Fri, Nov 13, 2020 at 1:36 PM Tony Nguyen < > anthony.l.ngu...@intel.com> wrote: > > > > From: Real Valiquette <real.valique...@intel.com> > > > > ACL filtering can be utilized to expand support of ntuple rules by > > allowing > > mask values to be specified for redirect to queue or drop. > > > > Implement support for specifying the 'm' value of ethtool ntuple > > command > > for currently supported fields (src-ip, dst-ip, src-port, and dst- > > port). > > > > For example: > > > > ethtool -N eth0 flow-type tcp4 dst-port 8880 m 0x00ff action 10 > > or > > ethtool -N eth0 flow-type tcp4 src-ip 192.168.0.55 m 0.0.0.255 > > action -1 > > > > At this time the following flow-types support mask values: tcp4, > > udp4, > > sctp4, and ip4. > > So you spend all of the patch description describing how this might > be > used in the future. However there is nothing specific to the ethtool > interface as far as I can tell anywhere in this patch. With this > patch > the actual command called out above cannot be performed, correct? > > > Begin implementation of ACL filters by setting up structures, > > AdminQ > > commands, and allocation of the ACL table in the hardware. > > This seems to be what this patch is actually doing. You may want to > rewrite this patch description to focus on this and explain that you > are enabling future support for ethtool ntuple masks. However save > this feature description for the patch that actually enables the > functionality.
Thanks for the feedback Alex. I believe you're still reviewing the patches, I'l look through and make changes accordingly or get responses as neeeded. Thanks, Tony
