Re: [EXT] Fwd: net: fec: rx descriptor ring out of order

2020-11-11 Thread Kegl Rohit
On Thu, Nov 12, 2020 at 2:29 AM Andy Duan wrote: > > From: Kegl Rohit Sent: Wednesday, November 11, 2020 > 10:27 PM > > Hello! > > > > We are using a imx6q platform. > > The fec interface is used to receive a continuous stream of custom / raw > > ethernet packets. The packet size is fixed ~132 b

Re: [PATCH bpf-next v2 5/5] i40e: use batched xsk Tx interfaces to increase performance

2020-11-11 Thread Magnus Karlsson
On Wed, Nov 11, 2020 at 8:16 PM Nick Desaulniers wrote: > > On Wed, Nov 11, 2020 at 3:57 AM Magnus Karlsson > wrote: > > > > On Wed, Nov 11, 2020 at 2:38 AM kernel test robot wrote: > > > > > > Hi Magnus, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test W

Re: [PATCH net-next v2 2/3] net: evaluate net.ipv4.conf.all.proxy_arp_pvlan

2020-11-11 Thread Jesper Dangaard Brouer
On Tue, 10 Nov 2020 15:21:18 -0800 Jakub Kicinski wrote: > On Sat, 7 Nov 2020 20:35:14 +0100 Vincent Bernat wrote: > > Introduced in 65324144b50b, the "proxy_arp_vlan" sysctl is a ^ pvlan The sysctl is called "proxy_arp_pvlan" > > per-interface sy

Re: thunderbolt: How to disconnect without physically unplugging

2020-11-11 Thread Mika Westerberg
Hi, On Thu, Nov 12, 2020 at 07:55:23AM +0100, Christian Eggers wrote: > Hi, > > sorry for asking "user" questions directly to developers. But I didn't find a > better place for asking. > > I own a "hp zbook thunderbolt 3 dock". This docking station has 2 thunderbolt > connectors, the first (prim

Re: [EXT] Re: [PATCH v3 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address

2020-11-11 Thread Igor Russkikh
Hi Anant, >> >> +static int aqc111_set_mac_addr(struct net_device *net, void *p) >> +{ >> +struct usbnet *dev = netdev_priv(net); >> +int ret = 0; >> + >> +ret = eth_mac_addr(net, p); >> +if (ret < 0) >> +return ret; >> + > > When eth_mac_addr() fails, from what I can

RE: [EXT] Re: [PATCH v9,net-next,05/12] crypto: octeontx2: add mailbox communication with AF

2020-11-11 Thread Srujana Challa
> On Mon, 9 Nov 2020 17:39:17 +0530 Srujana Challa wrote: > > + err = pci_alloc_irq_vectors(pdev, RVU_PF_INT_VEC_CNT, > > + RVU_PF_INT_VEC_CNT, PCI_IRQ_MSIX); > > I don't see any pci_free_irq_vectors() in this patch This will be handled by the devres managed PCI in

Re: [PATCH net-next RFC] MAINTAINERS: Add Martin Schiller as a maintainer for the X.25 stack

2020-11-11 Thread Martin Schiller
On 2020-11-11 22:36, Xie He wrote: Hi Martin Schiller, would you like to be a maintainer for the X.25 stack? As we know the linux-x25 mail list has stopped working for a long time. Adding you as a maintainer may make you be Cc'd for new patches so that you can review them. About 1 year ago I

thunderbolt: How to disconnect without physically unplugging

2020-11-11 Thread Christian Eggers
Hi, sorry for asking "user" questions directly to developers. But I didn't find a better place for asking. I own a "hp zbook thunderbolt 3 dock". This docking station has 2 thunderbolt connectors, the first (primary?) is connected to my personal laptop and the other port I use for my company's la

Re: net: fec: rx descriptor ring out of order

2020-11-11 Thread Kegl Rohit
On Wed, Nov 11, 2020 at 11:18 PM Fabio Estevam wrote: > > On Wed, Nov 11, 2020 at 11:27 AM Kegl Rohit wrote: > > > > Hello! > > > > We are using a imx6q platform. > > The fec interface is used to receive a continuous stream of custom / > > raw ethernet packets. The packet size is fixed ~132 bytes

Re: [PATCH] net: xfrm: fix memory leak in xfrm_user_policy()

2020-11-11 Thread Steffen Klassert
On Tue, Nov 10, 2020 at 09:14:43AM +0800, Yu Kuai wrote: > if xfrm_get_translator() failed, xfrm_user_policy() return without > freeing 'data', which is allocated in memdup_sockptr(). > > Fixes: 96392ee5a13b ("xfrm/compat: Translate 32-bit user_policy from sockptr") > Reported-by: Hulk Robot > Si

[PATCH 7/7] vdpa/vdpa_sim: Enable user to create vdpasim net devices

2020-11-11 Thread Parav Pandit
Enable user to create vdpasim net simulate devices. Show vdpa parent device that supports creating, deleting vdpa devices. $ vdpa parentdev show vdpasim: supported_classes net $ vdpa parentdev show -jp { "show": { "vdpasim": { "supported_classes": { "n

[PATCH 5/7] vdpa: Enable a user to add and delete a vdpa device

2020-11-11 Thread Parav Pandit
Add the ability to add and delete a vdpa device. Examples: Create a vdpa device of type network named "foo2" from the parent device vdpasim: $ vdpa dev add parentdev vdpasim type net name foo2 Delete the vdpa device after its use: $ vdpa dev del foo2 Signed-off-by: Parav Pandit Reviewed-by: El

[PATCH 3/7] vdpa: Extend routine to accept vdpa device name

2020-11-11 Thread Parav Pandit
In a subsequent patch, when user initiated command creates a vdpa device, the user chooses the name of the vdpa device. To support it, extend the device allocation API to consider this name specified by the caller driver. Split the device unregistration to device delete and device put so that devi

[PATCH 6/7] vdpa: Enable user to query vdpa device info

2020-11-11 Thread Parav Pandit
Enable user to query vdpa device information. $ vdpa dev add parentdev vdpasim type net name foo2 Show the newly created vdpa device by its name: $ vdpa dev show foo2 foo2: type network parentdev vdpasim vendor_id 0 max_vqs 2 max_vq_size 256 $ vdpa dev show foo2 -jp { "dev": { "foo2"

[PATCH 0/7] Introduce vdpa management tool

2020-11-11 Thread Parav Pandit
This patchset covers user requirements for managing existing vdpa devices, using a tool and its internal design notes for kernel drivers. Background and user requirements: -- (1) Currently VDPA device is created by driver when driver is loaded. However, user should

[PATCH 2/7] vdpa: Use simpler version of ida allocation

2020-11-11 Thread Parav Pandit
vdpa doesn't have any specific need to define start and end range of the device index. Hence use the simper version of the ida allocator. Signed-off-by: Parav Pandit Reviewed-by: Eli Cohen Acked-by: Jason Wang --- drivers/vdpa/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 4/7] vdpa: Define vdpa parent device, ops and a netlink interface

2020-11-11 Thread Parav Pandit
To add one or more VDPA devices, define a parent device which allows adding or removing vdpa device. A parent device defines set of callbacks to manage vdpa devices. To begin with, it defines add and remove callbacks through which a user defined vdpa device can be added or removed. A unique paren

[PATCH 1/7] vdpa: Add missing comment for virtqueue count

2020-11-11 Thread Parav Pandit
Add missing comment for number of virtqueue. Signed-off-by: Parav Pandit Reviewed-by: Eli Cohen Acked-by: Jason Wang --- include/linux/vdpa.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index 30bc7a7223bb..0fefeb976877 100644 --- a/include/li

[PATCH v2] net/ncsi: Fix netlink registration

2020-11-11 Thread Joel Stanley
8c768dd6 [80a8f858] *pgd=80a0841e(bad) Internal error: Oops: 80d [#1] SMP ARM CPU: 0 PID: 116 Comm: sh Not tainted 5.10.0-rc3-next-2020-3-gdd25b227ec1e #51 Hardware name: Generic DT based system PC is at genl_register_family+0x1f8/0x6d4 LR is at 0xff26 pc : [<8073f930>]

[PATCH net-next 0/2] Add support for DSFP transceiver type

2020-11-11 Thread Moshe Shemesh
Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable transceiver). DSFP EEPROM memory layout is compatible with CMIS 4.0 spec. Add CMIS 4.0 module type to UAPI and implement DSFP EEPROM dump in mlx5. Vladyslav Tarasiuk (2): ethtool: Add CMIS 4.0 module type to UAPI net/

[PATCH net-next 1/2] ethtool: Add CMIS 4.0 module type to UAPI

2020-11-11 Thread Moshe Shemesh
From: Vladyslav Tarasiuk CMIS 4.0 document describes a universal EEPROM memory layout, which is used for some modules such as DSFP, OSFP and QSFP-DD modules. In order to distinguish them in userspace from existing standards, add corresponding values. Signed-off-by: Vladyslav Tarasiuk Reviewed-b

[PATCH net-next 2/2] net/mlx5e: Add DSFP EEPROM dump support to ethtool

2020-11-11 Thread Moshe Shemesh
From: Vladyslav Tarasiuk DSFP is a new cable module type, which EEPROM uses memory layout described in CMIS 4.0 document. Use corresponding standard value for userspace ethtool to distinguish DSFP's layout from older standards. Add DSFP module ID in accordance to SFF-8024. DSFP module memory ca

Re:Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread 王擎
>On Thu, 12 Nov 2020 09:15:05 +0800 (GMT+08:00) 王擎 wrote: >> >Grygorii, would you mind sending a correct patch in so Wang Qing can >> >see how it's done? I've been asking for a fixes tag multiple times >> >already :( >> >> I still don't quite understand what a fixes tag means, >> can you tell me

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 09:15:05 +0800 (GMT+08:00) 王擎 wrote: > >Grygorii, would you mind sending a correct patch in so Wang Qing can > >see how it's done? I've been asking for a fixes tag multiple times > >already :( > > I still don't quite understand what a fixes tag means, > can you tell me how to

Re: [PATCH net-next] MAINTAINERS: Add entry for Hirschmann Hellcreek Switch Driver

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 08:18:29 +0100 Kurt Kanzenbach wrote: > Add myself to cover the Hirschmann Hellcreek TSN Ethernet Switch Driver. > > Suggested-by: Andrew Lunn > Signed-off-by: Kurt Kanzenbach Applied, thanks!

Re: [PATCH net-next] net: dsa: mv88e6xxx: 6352: parse VTU data before loading STU data

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 00:49:03 +0100 Tobias Waldekranz wrote: > > I'm unclear what this fixes. What functionality is broken on 6097? > > VLAN configuration. As soon as you add the second port to a VLAN, all > other port membership configuration is overwritten with zeroes. The HW > interprets this

[PATCH V3 net-next 02/10] net: hns3: add support for querying maximum value of GL

2020-11-11 Thread Huazhong Tan
For maintainability and compatibility, add support for querying the maximum value of GL. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 1 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_en

[PATCH V3 net-next 06/10] net: hns3: add ethtool priv-flag for DIM

2020-11-11 Thread Huazhong Tan
Add a control private flag in ethtool for enable/disable DIM feature. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 7 +++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 71 ++

[PATCH V3 net-next 10/10] net: hns3: add ethtool priv-flag for EQ/CQ

2020-11-11 Thread Huazhong Tan
Add a control private flag in ethtool for switching EQ/CQ mode. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 19 +++-- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h| 2 ++ drive

Re: [PATCH v2 0/5] net: qrtr: Add distant node support

2020-11-11 Thread Manivannan Sadhasivam
On Tue, Nov 10, 2020 at 09:44:27AM -0800, Jakub Kicinski wrote: > On Tue, 10 Nov 2020 10:03:29 +0100 Loic Poulain wrote: > > On Mon, 9 Nov 2020 at 19:39, Jakub Kicinski wrote: > > > > > > On Mon, 9 Nov 2020 09:49:24 +0100 Loic Poulain wrote: > > > > > Looks like patch 1 is a bug fix and patches

[PATCH V3 net-next 08/10] net: hns3: add a check for ethtool priv-flag interface

2020-11-11 Thread Huazhong Tan
Add a check for hns3_set_priv_flags() since if the capability is unsupported its private flags should not be modified as well. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 1 + drivers/net/etherne

[PATCH v10 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb

2020-11-11 Thread wenxu
From: wenxu The mru in the qdisc_skb_cb should be init as 0. Only defrag packets in the act_ct will set the value. Fixes: 038ebb1a713d ("net/sched: act_ct: fix miss set mru for ovs after defrag in act_ct") Signed-off-by: wenxu --- v10: no change net/core/dev.c | 2 ++ 1 file changed, 2 inser

[PATCH V3 net-next 09/10] net: hns3: add support for EQ/CQ mode configuration

2020-11-11 Thread Huazhong Tan
For device whose version is above V3(include V3), the GL can select EQ or CQ mode, so adds support for it. In CQ mode, the coalesced timer will restart when the first new completion occurs, while in EQ mode, the timer will not restart. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisili

[PATCH V3 net-next 05/10] net: hns3: add support for dynamic interrupt moderation

2020-11-11 Thread Huazhong Tan
Add dynamic interrupt moderation support for the HNS3 driver. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/Kconfig | 1 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 87 - drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 4 ++ 3 files c

[PATCH v10 net-next 0/3] net/sched: fix over mtu packet of defrag in

2020-11-11 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in act_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH V3 net-next 03/10] net: hns3: add support for 1us unit GL configuration

2020-11-11 Thread Huazhong Tan
For device whose version is above V3(include V3), the GL configuration can set as 1us unit, so adds support for configuring this field. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 26 ++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.h

[PATCH V3 net-next 00/10] net: hns3: updates for -next

2020-11-11 Thread Huazhong Tan
There are several updates relating to the interrupt coalesce for the HNS3 ethernet driver. #1 adds support for QL(quantity limiting, interrupt coalesce based on the frame quantity). #2 queries the maximum value of GL from the firmware instead of a fixed value in code. #3 adds support for 1us

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 10:48:37 +0800 (GMT+08:00) 王擎 wrote: > >On Thu, 12 Nov 2020 09:15:05 +0800 (GMT+08:00) 王擎 wrote: > >> >Grygorii, would you mind sending a correct patch in so Wang Qing can > >> >see how it's done? I've been asking for a fixes tag multiple times > >> >already :( > >> > >>

Re: [PATCH net-next] ipv4: Set nexthop flags in a more consistent way

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 08:25:50 -0700 David Ahern wrote: > On 11/10/20 3:25 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Be more consistent about the way in which the nexthop flags are set and > > set them in one go. > > > > Suggested-by: Jakub Kicinski > > Signed-off-by: Ido Schimmel >

Re: [PATCH net-next v2] drivers: net: sky2: Fix -Wstringop-truncation with W=1

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 03:32:22 +0100 Andrew Lunn wrote: > In function ‘strncpy’, > inlined from ‘sky2_name’ at drivers/net/ethernet/marvell/sky2.c:4903:3, > inlined from ‘sky2_probe’ at drivers/net/ethernet/marvell/sky2.c:5049:2: > ./include/linux/string.h:297:30: warning: ‘__builtin_strncpy’

[PATCH v2 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name

2020-11-11 Thread Florian Fainelli
The register name should be "sgmii_config", not "sgmii", this is not a functional change since no code is currently looking for that register by name (or at all). Reviewed-by: Vladimir Oltean Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- 1 file changed, 1 insertion(

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add helper to get a chip's max_vid

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 20:23:32 +0100 Andrew Lunn wrote: > On Tue, Nov 10, 2020 at 07:57:20PM +0100, Tobias Waldekranz wrote: > > Most of the other chip info constants have helpers to get at them; add > > one for max_vid to keep things consistent. > > > > Suggested-by: Andrew Lunn > > Signed-off-by:

[PATCH v10 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit

2020-11-11 Thread wenxu
From: wenxu This one is prepare for the next patch. Signed-off-by: wenxu --- v10: no change include/net/sch_generic.h | 5 - net/sched/act_mirred.c| 21 +++-- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch

[PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-11 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in cat_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH v2 08/10] ARM: dts: NSP: Add a SRAB compatible string for each board

2020-11-11 Thread Florian Fainelli
Provide a valid compatible string for the Ethernet switch node based on the board including the switch. This allows us to have sane defaults and silences the following warnings: arch/arm/boot/dts/bcm958522er.dt.yaml: ethernet-switch@36000: compatible: 'oneOf' conditional failed, one must

[PATCH v2 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-11 Thread Florian Fainelli
Provide an empty 'ports' container node with the correct #address-cells and #size-cells properties. This silences the following warning: arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed: 'ports' is a required property

[PATCH v2 02/10] dt-bindings: net: dsa: Document sfp and managed properties

2020-11-11 Thread Florian Fainelli
The 'sfp' and 'managed' properties are commonly used to describe Ethernet switch ports connecting to SFP/SFF cages, describe these two properties as valid that we inherit from ethernet-controller.yaml. Acked-by: Rob Herring Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/n

[PATCH v2 01/10] dt-bindings: net: dsa: Extend switch nodes pattern

2020-11-11 Thread Florian Fainelli
Upon discussion with Kurt, Rob and Vladimir it appears that we should be allowing ethernet-switch as a node name, update dsa.yaml accordingly. Reviewed-by: Vladimir Oltean Acked-by: Rob Herring Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 2 +- 1 fil

[PATCH v2 10/10] dt-bindings: net: dsa: b53: Add YAML bindings

2020-11-11 Thread Florian Fainelli
From: Kurt Kanzenbach Convert the b53 DSA device tree bindings to YAML in order to allow for automatic checking and such. Reviewed-by: Rob Herring Suggested-by: Florian Fainelli Signed-off-by: Kurt Kanzenbach --- .../devicetree/bindings/net/dsa/b53.txt | 149 --- .../devicetree

Re: [PATCH v2 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node

2020-11-11 Thread Rafał Miłecki
On 12.11.2020 05:50, Florian Fainelli wrote: Provide a default compatible string which is based on the 53011 SRAB compatible by default. The 4709 and 47094 default to the 53012 SRAB compatible. (...) Signed-off-by: Florian Fainelli Looks good, thanks! Acked-by: Rafał Miłecki

Re: [PATCH v2 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-11 Thread Rafał Miłecki
On 12.11.2020 05:50, Florian Fainelli wrote: Provide an empty 'ports' container node with the correct #address-cells and #size-cells properties. This silences the following warning: arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: ethernet-switch@18007000: 'oneOf' conditional failed, one must be

[PATCH v2 03/10] ARM: dts: BCM5301X: Update Ethernet switch node name

2020-11-11 Thread Florian Fainelli
Update the switch unit name from srab to ethernet-switch, allowing us to fix warnings such as: CHECK arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dt.yaml arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dt.yaml: srab@18007000: $nodename:0: 'srab@18007000' does not match '^(ethernet-)?switch(@.*)

[PATCH v2 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node

2020-11-11 Thread Florian Fainelli
Provide a default compatible string which is based on the 53011 SRAB compatible by default. The 4709 and 47094 default to the 53012 SRAB compatible. This allows us to have sane defaults and silences the following warnings: arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: ethernet-switch@18007000:

[PATCH v2 00/10] Broadcom b53 YAML bindings

2020-11-11 Thread Florian Fainelli
Hi, This patch series fixes the various Broadcom SoCs DTS files and the existing YAML binding for missing properties before adding a proper b53 switch YAML binding from Kurt. If this all looks good, given that there are quite a few changes to the DTS files, it might be best if I take them through

[PATCH v2 06/10] ARM: dts: NSP: Update ethernet switch node name

2020-11-11 Thread Florian Fainelli
Update the switch unit name from srab to ethernet-switch, allowing us to fix warnings such as: CHECK arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dt.yaml arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dt.yaml: srab@18007000: $nodename:0: 'srab@18007000' does not match '^(etherne

[PATCH v2 09/10] ARM: dts: NSP: Provide defaults ports container node

2020-11-11 Thread Florian Fainelli
Provide an empty 'ports' container node with the correct #address-cells and #size-cells properties. This silences the following warning: arch/arm/boot/dts/bcm958522er.dt.yaml: ethernet-switch@36000: 'oneOf' conditional failed, one must be fixed: 'ports' is a required property

[PATCH V3 net-next 01/10] net: hns3: add support for configuring interrupt quantity limiting

2020-11-11 Thread Huazhong Tan
QL(quantity limiting) means that hardware supports the interrupt coalesce based on the frame quantity. QL can be configured when int_ql_max in device's specification is non-zero, so add support to configure it. Also, rename two coalesce init function to fit their purpose. Signed-off-by: Huazhong

Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer

2020-11-11 Thread Geliang Tang
Hi Jakub, Matt, Jakub Kicinski 于2020年11月10日周二 上午6:20写道: > > On Mon, 9 Nov 2020 21:23:33 + (UTC) Matthieu Baerts wrote: > > 09 Nov 2020 21:57:05 Jakub Kicinski : > > > On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote: > > >> A small detail (I think): the Signed-off-by of the sender (Gel

Re: [PATCH net] cosa: Add missing kfree in error path of cosa_write

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 17:38:09 +0100 Jan Kasprzak wrote: > Wang Hai wrote: > : If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a > : corresponding kfree() in exception handling. Thus add kfree() for this > : function implementation. > > Acked-By: Jan "Yenya" Kasprzak Applied, th

[PATCH V3 net-next 07/10] net: hns3: add hns3_state_init() to do state initialization

2020-11-11 Thread Huazhong Tan
To improve the readability and maintainability, add hns3_state_init() to initialize the state. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/h

[PATCH V3 net-next 04/10] net: hns3: rename gl_adapt_enable in struct hns3_enet_coalesce

2020-11-11 Thread Huazhong Tan
Besides GL(Gap Limiting), QL(Quantity Limiting) can be modified dynamically when DIM is supported. So rename gl_adapt_enable as adapt_enable in struct hns3_enet_coalesce. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 12 ++-- drivers/net/ethernet/hi

RE: [EXT] Fwd: net: fec: rx descriptor ring out of order

2020-11-11 Thread Andy Duan
From: Kegl Rohit Sent: Wednesday, November 11, 2020 10:27 PM > Hello! > > We are using a imx6q platform. > The fec interface is used to receive a continuous stream of custom / raw > ethernet packets. The packet size is fixed ~132 bytes and they get sent every > 250µs. > > While testing I observ

Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Joel Stanley
On Thu, 12 Nov 2020 at 01:20, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 01:11:04 + Joel Stanley wrote: > > On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote: > > > > > > On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > > > > If a user unbinds and re-binds a ncsi aware driver, the

Re: [PATCH v3 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-11 Thread Andrii Nakryiko
On Wed, Nov 11, 2020 at 2:37 PM Andrii Nakryiko wrote: > > On Wed, Nov 11, 2020 at 1:24 PM Daniel Borkmann wrote: > > > > On 11/11/20 2:54 PM, Wang Hai wrote: > > > progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, > > > it should be closed. > > > > > > Fixes: 04949ccc273e (

Re: [PATCH 01/10] dt-bindings: net: dsa: Extend switch nodes pattern

2020-11-11 Thread Rob Herring
On Mon, 09 Nov 2020 19:31:04 -0800, Florian Fainelli wrote: > Upon discussion with Kurt, Rob and Vladimir it appears that we should be > allowing ethernet-switch as a node name, update dsa.yaml accordingly. > > Signed-off-by: Florian Fainelli > --- > Documentation/devicetree/bindings/net/dsa/dsa

Re: [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect

2020-11-11 Thread Jakub Kicinski
On Wed, 11 Nov 2020 03:59:47 -0800 Xie He wrote: > > @@ -825,7 +825,7 @@ static int x25_connect(struct socket *sock, struct > > sockaddr *uaddr, > > sock->state = SS_CONNECTED; > > rc = 0; > > out_put_neigh: > > - if (rc) { > > + if (rc && x25->neighbour) { > > read_lock_

Re: [PATCH net] tipc: fix memory leak in tipc_topsrv_start()

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 22:09:13 +0800 Wang Hai wrote: > kmemleak report a memory leak as follows: > > unreferenced object 0x88810a596800 (size 512): > comm "ip", pid 21558, jiffies 4297568990 (age 112.120s) > hex dump (first 32 bytes): > 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 ...

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-11 Thread Daniel Borkmann
On 11/11/20 3:12 PM, Santucci Pierpaolo wrote: Hi Jakub, thanks for your reply. (Santucci, please do not top-post but always reply inline which makes it easier for discussions to follow.) Let me explain the problem with an example. Please consider the PCAP file: https://github.com/named-da

[PATCH bpf] selftests/bpf: fix unused attribute usage in subprogs_unused test

2020-11-11 Thread Andrii Nakryiko
Correct attribute name is "unused". maybe_unused is a C++17 addition. This patch fixes compilation warning during selftests compilation. Fixes: 197afc631413 ("libbpf: Don't attempt to load unused subprog as an entry-point BPF program") Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/

Re: [PATCH net-next] net: dsa: mv88e6xxx: 6352: parse VTU data before loading STU data

2020-11-11 Thread Jakub Kicinski
On Sun, 8 Nov 2020 23:38:10 +0100 Tobias Waldekranz wrote: > On the 6352, doing a VTU GetNext op, followed by an STU GetNext op > will leave you with both the member- and state- data in the VTU/STU > data registers. But on the 6097 (which uses the same implementation), > the STU GetNext will overr

Re: [PATCH v2 0/5] net: qrtr: Add distant node support

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 09:44:27 -0800 Jakub Kicinski wrote: > Thanks! Sounds like net-next will work just fine, but won't you need > these changes in mhi-next, then? In which case you should send a pull > request based on Linus' tree so that both Mani and netdev can pull it > in. > > Mani, WDYT? App

Re: [PATCH net] vrf: Fix fast path output packet handling with async Netfilter rules

2020-11-11 Thread Pablo Neira Ayuso
Hi Martin, On Tue, Nov 10, 2020 at 04:02:13PM +0100, Martin Willi wrote: > Hi Pablo, > > > > +static int vrf_output6_direct_finish(struct net *net, struct sock *sk, > > > + struct sk_buff *skb) > > > +{ > > > + vrf_finish_direct(skb); > > > + > > > + return vrf_ip6_l

Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()

2020-11-11 Thread Vinicius Costa Gomes
Hi, Miroslav Lichvar writes: > On Mon, Nov 09, 2020 at 10:10:19PM -0800, Vinicius Costa Gomes wrote: >> i225 has support for PCIe PTM, which allows us to implement support >> for the PTP_SYS_OFFSET_PRECISE ioctl(), implemented in the driver via >> the getcrosststamp() function. > > Would it be p

[PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Joel Stanley
If a user unbinds and re-binds a ncsi aware driver, the kernel will attempt to register the netlink interface at runtime. The structure is marked __ro_after_init so this fails at this point. Unable to handle kernel paging request at virtual address 80bb588c pgd = 0ff284bb [80bb588c] *pgd=80a194

Re: [PATCH net-next] net: dsa: mv88e6xxx: 6352: parse VTU data before loading STU data

2020-11-11 Thread Tobias Waldekranz
On Wed Nov 11, 2020 at 4:27 PM CET, Jakub Kicinski wrote: > On Sun, 8 Nov 2020 23:38:10 +0100 Tobias Waldekranz wrote: > > On the 6352, doing a VTU GetNext op, followed by an STU GetNext op > > will leave you with both the member- and state- data in the VTU/STU > > data registers. But on the 6097 (

Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:39:24 +0530 Srujana Challa wrote: > CPT offload module utilises the linux crypto framework to offload > crypto processing. This patch registers supported algorithms by > calling registration functions provided by the kernel crypto API. > > The module currently supports: > - A

[PATCH] net: ftgmac100: Fix crash when removing driver

2020-11-11 Thread Joel Stanley
core/dev.c:10254! Internal error: Oops - BUG: 0 [#1] SMP ARM CPU: 0 PID: 115 Comm: sh Not tainted 5.10.0-rc3-next-2020-7-g02e0365710c4 #46 Hardware name: Generic DT based system PC is at netdev_run_todo+0x314/0x394 LR is at cpumask_next+0x20/0x24 pc : [<806f5830>]

Re: [bpf PATCH 1/5] bpf, sockmap: fix partial copy_page_to_iter so progress can still be made

2020-11-11 Thread Daniel Borkmann
On 11/7/20 8:37 PM, John Fastabend wrote: If copy_page_to_iter() fails or even partially completes, but with fewer bytes copied than expected we currently reset sg.start and return EFAULT. This proves problematic if we already copied data into the user buffer before we return an error. Because we

IPv4 TOS vs DSCP

2020-11-11 Thread Russell Strong
Hello, After needing to do policy based routing based on DSCP, I discovered that IPv4 does not support this. It does support TOS, but this has never been upgraded to the new ( now quite old ) DSCP interpretation. Is there a historical reason why the interpretation has not changed? I could copy

Re: [PATCH net-next,v3 5/9] bridge: resolve forwarding path for bridge devices

2020-11-11 Thread Nikolay Aleksandrov
On 11/11/2020 21:37, Pablo Neira Ayuso wrote: > Add .ndo_fill_forward_path for bridge devices. > > Signed-off-by: Pablo Neira Ayuso > --- > include/linux/netdevice.h | 1 + > net/bridge/br_device.c| 24 > 2 files changed, 25 insertions(+) > > diff --git a/include/l

Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > If a user unbinds and re-binds a ncsi aware driver, the kernel will > attempt to register the netlink interface at runtime. The structure is > marked __ro_after_init so this fails at this point. netlink family should be registered at module

[PATCH v2 net-next] net: stmmac: platform: use optional clk/reset get APIs

2020-11-11 Thread Jisheng Zhang
Use the devm_reset_control_get_optional() and devm_clk_get_optional() rather than open coding them. Signed-off-by: Jisheng Zhang --- Since v1: - keep wrapped as suggested by Jakub .../ethernet/stmicro/stmmac/stmmac_platform.c | 22 --- 1 file changed, 9 insertions(+), 13 deleti

Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 01:11:04 + Joel Stanley wrote: > On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote: > > > > On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > > > If a user unbinds and re-binds a ncsi aware driver, the kernel will > > > attempt to register the netlink interface at

Re: [PATCH net] net: switch to the kernel.org patchwork instance

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 19:51:20 -0800 Jakub Kicinski wrote: > Move to the kernel.org patchwork instance, it has significantly > lower latency for accessing from Europe and the US. Other quirks > include the reply bot. > > Signed-off-by: Jakub Kicinski > --- > We were in process of transitioning alre

Re:Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread 王擎
>> On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: >> > >> > Following Richard's comments v1 of the patch has to be applied [1]. >> > I've also added my Reviewed-by there. >> > >> > [1] https://lore.kernel.org/patchwork/patch/1334067/ >> >> +1 >> >> Jakub, can you please ta

Re: net: evaluate net.ipvX.conf.all.* sysctls

2020-11-11 Thread Jakub Kicinski
On Sat, 7 Nov 2020 20:35:12 +0100 Vincent Bernat wrote: > Some per-interface sysctls are ignoring the "all" variant. This > patchset fixes some of them when such a sysctl is handled as a > boolean. This includes: > > - net.ipvX.conf.all.disable_policy > - net.ipvX.conf.all.disable_policy.disabl

Re: [PATCH] net/ncsi: Fix re-registering ncsi device

2020-11-11 Thread Joel Stanley
On Thu, 12 Nov 2020 at 00:57, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 11:10:21 +1030 Joel Stanley wrote: > > If a user unbinds and re-binds a ncsi aware driver, the kernel will > > attempt to register the netlink interface at runtime. The structure is > > marked __ro_after_init so this fails

Re: [bpf PATCH 3/5] bpf, sockmap: Avoid returning unneeded EAGAIN when redirecting to self

2020-11-11 Thread Daniel Borkmann
On 11/7/20 8:38 PM, John Fastabend wrote: If a socket redirects to itself and it is under memory pressure it is possible to get a socket stuck so that recv() returns EAGAIN and the socket can not advance for some time. This happens because when redirecting a skb to the same socket we received the

Re: [PATCH V2 net-next 11/11] net: hns3: add debugfs support for interrupt coalesce

2020-11-11 Thread tanhuazhong
On 2020/11/12 0:15, Jakub Kicinski wrote: On Wed, 11 Nov 2020 11:16:37 +0800 tanhuazhong wrote: On 2020/11/11 9:28, Jakub Kicinski wrote: On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote: Since user may need to check the current configuration of the interrupt coalesce, so add debugfs su

Re: [net v6 00/12] cxgb4/ch_ktls: Fixes in nic tls code

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 16:21:30 +0530 Rohit Maheshwari wrote: > This series helps in fixing multiple nic ktls issues. Series is broken > into 12 patches. Applied.

Re: [PATCH v9,net-next,05/12] crypto: octeontx2: add mailbox communication with AF

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:39:17 +0530 Srujana Challa wrote: > + err = pci_alloc_irq_vectors(pdev, RVU_PF_INT_VEC_CNT, > + RVU_PF_INT_VEC_CNT, PCI_IRQ_MSIX); I don't see any pci_free_irq_vectors() in this patch

[4.4] Security fixes (pinctrl, i40e, geneve)

2020-11-11 Thread Ben Hutchings
Here are backports of some fixes to the 4.4 stable branch. I wasn't able to test the pinctrl fix (no idea how to reproduce it). I wasn't able to test the i40e changes (no hardware and no reproducer available). I tested the geneve fix with libreswan as (roughly) described in the commit message.

Re: [PATCH net RESEND] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 12:04:36 +0100 Michael Walle wrote: > Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the > network port of the Kontron sl28 board is broken. After the migration to > phylink the device tree has to specify the in-band-mode property. Add > it. > > Fixes: 71b

Re: [PATCH net-next] net: stmmac: dwc-qos: Change the dwc_eth_dwmac_data's .probe prototype

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 16:05:14 +0800 Jisheng Zhang wrote: > The return pointer of dwc_eth_dwmac_data's .probe isn't used, and > "probe" usually return int, so change the prototype to follow standard > way. Secondly, it can simplify the tegra_eqos_probe() code. > > Signed-off-by: Jisheng Zhang Appli

Re: [PATCH v2] can: m_can: Set device to software init mode before closing

2020-11-11 Thread Marc Kleine-Budde
On 8/25/20 7:54 AM, Faiz Abbas wrote: > There might be some requests pending in the buffer when the > interface close sequence occurs. In some devices, these > pending requests might lead to the module not shutting down > properly when m_can_clk_stop() is called. > > Therefore, move the device to

Re: [PATCH v3 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-11 Thread Andrii Nakryiko
On Wed, Nov 11, 2020 at 1:24 PM Daniel Borkmann wrote: > > On 11/11/20 2:54 PM, Wang Hai wrote: > > progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, > > it should be closed. > > > > Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP > > on interface"

Re: [PATCH] bpf: relax return code check for subprograms

2020-11-11 Thread Andrii Nakryiko
On Wed, Nov 11, 2020 at 2:38 AM Dmitrii Banshchikov wrote: > > On Tue, Nov 10, 2020 at 08:47:13PM -0800, Andrii Nakryiko wrote: > > On Tue, Nov 10, 2020 at 1:03 PM Dmitrii Banshchikov > > wrote: > > > > > > Currently verifier enforces return code checks for subprograms in the > > > same manner a

Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()

2020-11-11 Thread Vinicius Costa Gomes
Miroslav Lichvar writes: > On Tue, Nov 10, 2020 at 11:06:07AM -0800, Vinicius Costa Gomes wrote: >> Miroslav Lichvar writes: >> > I suspect the estimate would be valid only when the NIC is connected >> > directly to the PTM root (PCI root complex). Is it possible to get the >> > timestamps or de

Re: [PATCH 10/10] dt-bindings: net: dsa: b53: Add YAML bindings

2020-11-11 Thread Rob Herring
On Mon, 09 Nov 2020 19:31:13 -0800, Florian Fainelli wrote: > From: Kurt Kanzenbach > > Convert the b53 DSA device tree bindings to YAML in order to allow > for automatic checking and such. > > Suggested-by: Florian Fainelli > Signed-off-by: Kurt Kanzenbach > --- > .../devicetree/bindings/net

Re: [PATCH net-next v4 08/15] net/smc: Add ability to work with extended SMC netlink API

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 16:18:07 +0100 Karsten Graul wrote: > From: Guvenc Gulce > > smc_diag module should be able to work with legacy and > extended netlink api. This is done by using the sequence field > of the netlink message header. Sequence field is optional and was > filled with a constant val

  1   2   3   >