Re: [RFC] can: can_create_echo_skb(): fix echo skb generation: always use skb_clone()

2020-10-18 Thread Oliver Hartkopp
On 19.10.20 08:28, Marc Kleine-Budde wrote: On 10/18/20 10:46 AM, Oliver Hartkopp wrote: Oh, answering myself ... On 17.10.20 21:13, Oliver Hartkopp wrote: On 16.10.20 21:36, Marc Kleine-Budde wrote: On 2/14/20 1:09 PM, Oleksij Rempel wrote: Hi all, any comments on this patch? I'm go

Re: [PATCH net] netsec: ignore 'phy-mode' device property on ACPI systems

2020-10-18 Thread Ard Biesheuvel
On Sun, 18 Oct 2020 at 22:32, Ilias Apalodimas wrote: > > On Sun, Oct 18, 2020 at 07:52:18PM +0200, Andrew Lunn wrote: > > > --- a/Documentation/devicetree/bindings/net/socionext-netsec.txt > > > +++ b/Documentation/devicetree/bindings/net/socionext-netsec.txt > > > @@ -30,7 +30,9 @@ Optional prop

Re: [RFC] can: can_create_echo_skb(): fix echo skb generation: always use skb_clone()

2020-10-18 Thread Marc Kleine-Budde
On 10/18/20 10:46 AM, Oliver Hartkopp wrote: > Oh, answering myself ... > > On 17.10.20 21:13, Oliver Hartkopp wrote: >> >> >> On 16.10.20 21:36, Marc Kleine-Budde wrote: >>> On 2/14/20 1:09 PM, Oleksij Rempel wrote: Hi all, any comments on this patch? >>> >>> I'm going to take this

Re: [PATCH] [v5] wireless: Initial driver submission for pureLiFi STA devices

2020-10-18 Thread Srinivasan Raju
Mostly trivial comments: >> Ok Thanks, I will address them

Re: [PATCH v2 0/6] igb: xdp patches followup

2020-10-18 Thread Sven Auhagen
On Sun, Oct 18, 2020 at 03:39:51PM +0200, Maciej Fijalkowski wrote: > On Sat, Oct 17, 2020 at 09:12:32AM +0200, sven.auha...@voleatech.de wrote: > > From: Sven Auhagen > > > > This patch series addresses some of the comments that came back > > after the igb XDP patch was accepted. > > Most of it

Re: [PATCH v2 0/6] igb: xdp patches followup

2020-10-18 Thread Sven Auhagen
On Sun, Oct 18, 2020 at 12:03:36PM -0700, Jakub Kicinski wrote: > On Sun, 18 Oct 2020 15:39:51 +0200 Maciej Fijalkowski wrote: > > - next time please specify the tree in the subject that you're targetting > > this set to land; is it net or net-next? net-next is currently closed so > > you proba

[PATCH rdma-rc] RDMA/mlx5: Fix devlink deadlock on net namespace deletion

2020-10-18 Thread Leon Romanovsky
From: Parav Pandit When a mlx5 core devlink instance is reloaded in different net namespace, its associated IB device is deleted and recreated. Example sequence is: $ ip netns add foo $ devlink dev reload pci/:00:08.0 netns foo $ ip netns del foo mlx5 IB device needs to attach and detach th

[PATCH v4] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

2020-10-18 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits. 2 megabits is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Reviewed-by: Vladimir Oltean Fixes: a63ed92d217f ("net: dsa: seville: fix buf

Re: [PATCH] [v5] wireless: Initial driver submission for pureLiFi STA devices

2020-10-18 Thread Joe Perches
On Mon, 2020-10-19 at 08:47 +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. Mostly trivial comments: > diff --git a/drivers/net/wireless/purelifi/chip.c > b/drivers/net/wireless/purelifi/chip.c [] > +int purelifi_chip_set_ra

[PATCH] rtl8188ee: avoid accessing the data mapped to streaming DMA

2020-10-18 Thread Jia-Ju Bai
In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 677: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 680, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

[PATCH] rtl8723ae: avoid accessing the data mapped to streaming DMA

2020-10-18 Thread Jia-Ju Bai
In rtl8723e_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 531: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 534, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-18 Thread Reji Thomas
Hi, Please find my replies inline below. Regards Reji On Mon, Oct 19, 2020 at 4:31 AM Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 13:51:19 +0530 Reji Thomas wrote: > > Currently End.X action doesn't consider the outgoing interface > > while looking up the nexthop.This breaks packet path funct

Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev statistics

2020-10-18 Thread Florian Fainelli
On 10/18/2020 5:21 PM, Vladimir Oltean wrote: On Sun, Oct 18, 2020 at 04:11:14PM -0700, Florian Fainelli wrote: How about when used as a netconsole? We do support netconsole over DSA interfaces. How? Who is supposed to bring up the master interface, and when? You are right that this appe

[PATCH] [v5] wireless: Initial driver submission for pureLiFi STA devices

2020-10-18 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in ARM

Re: gssapi, crypto and afs/rxrpc

2020-10-18 Thread Herbert Xu
On Fri, Oct 16, 2020 at 05:18:26PM +0100, David Howells wrote: > > If I do this, should I create a "kerberos" crypto API for the data wrapping > functions? I'm not sure that it quite matches the existing APIs because the > size of the input data will likely not match the size of the output data an

[PATCH] rtl8192de: avoid accessing the data mapped to streaming DMA

2020-10-18 Thread Jia-Ju Bai
In rtl92de_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 667: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 669, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

[PATCH] rtl8192ce: avoid accessing the data mapped to streaming DMA

2020-10-18 Thread Jia-Ju Bai
In rtl92ce_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 530: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 533, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

[PATCHv5] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

2020-10-18 Thread Po-Hsu Lin
The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh needs the fou module to work. Otherwise it will fail with: $ ip netns exec "$testns" ip fou add port ipproto 47 RTNETLINK answers: No such file or directory Error talking to the kernel Add the CONFIG_NET_FOU into the c

[PATCH] rtl8180: avoid accessing the data mapped to streaming DMA

2020-10-18 Thread Jia-Ju Bai
In rtl8180_tx(), skb->data is mapped to streaming DMA on line 476: mapping = dma_map_single(..., skb->data, ...); On line 459, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; Then hdr->seq_ctrl is accessed on lines 540 and 541: hdr->se

Re: [PATCHv4] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

2020-10-18 Thread Po-Hsu Lin
On Sat, Oct 17, 2020 at 7:32 AM Jakub Kicinski wrote: > > On Fri, 16 Oct 2020 12:12:11 +0800 Po-Hsu Lin wrote: > > The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh > > needs the fou module to work. Otherwise it will fail with: > > > > $ ip netns exec "$testns" ip fou add port

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097

2020-10-18 Thread Chris Packham
On 19/10/20 11:31 am, Chris Packham wrote: > > On 19/10/20 11:08 am, Andrew Lunn wrote: >> On Sun, Oct 18, 2020 at 09:15:52PM +, Chris Packham wrote: >>> On 19/10/20 9:25 am, Andrew Lunn wrote: > I assume you're talking about the PHY Control Register 0 bit 11. > If so > that's for

[PATCH v2 3/3] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-18 Thread Chris Packham
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for the MV88E6123 so that the ports without a built-in PHY supported as serdes ports and directly connected to other network interfaces or to SFPs. Also implement serdes_get_regs_len and serdes_get_regs to aid future debugging. S

[PATCH v2 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-18 Thread Chris Packham
When a port is configured with 'managed = "in-band-status"' don't force the link up, the switch MAC will detect the link status correctly. Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn --- Changes in v2: - Add review from Andrew drivers/net/dsa/mv88e6xxx/chip.c | 7 +-- 1 file cha

[PATCH v2 0/3] net: dsa: mv88e6xxx: serdes link without phy

2020-10-18 Thread Chris Packham
This small series gets my hardware into a working state. The key points are to make sure we don't force the link and that we ask the MAC for the link status. I also have updated my dts to say `phy-mode = "1000base-x";` and `managed = "in-band-status";` I've included patch #3 in this series but I d

[PATCH v2 2/3] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097/6095/6185

2020-10-18 Thread Chris Packham
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for the MV88E6097/6095/6185 so that ports 8 & 9 can be supported as serdes ports and directly connected to other network interfaces or to SFPs without a PHY. Signed-off-by: Chris Packham --- Changes in v2: - expand support to c

Re: [PATCH v2 1/7] staging: qlge: replace ql_* with qlge_* to avoid namespace clashes with other qlogic drivers

2020-10-18 Thread Coiby Xu
On Sun, Oct 18, 2020 at 08:02:53PM +0900, Benjamin Poirier wrote: On 2020-10-17 07:16 +0800, Coiby Xu wrote: On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote: > On 2020-10-14 18:43 +0800, Coiby Xu wrote: > > To avoid namespace clashes with other qlogic drivers and also for the >

Re: [PATCH] rtnetlink: fix data overflow in rtnl_calcit()

2020-10-18 Thread zhudi (J)
> On Sat, 17 Oct 2020 14:34:11 +0200 Michal Kubecek wrote: > > On Fri, Oct 16, 2020 at 10:02:38AM +0800, zhudi wrote: > > > "ip addr show" command execute error when we have a physical > network > > > card with number of VFs larger than 247. > > > > > > The return value of if_nlmsg_size() in rtnl_c

Re: [PATCH] Bluetooth: Use lock_sock() when acquiring lock in sco_conn_del

2020-10-18 Thread Xu, Yanfei
On 10/16/20 12:10 PM, Hillf Danton wrote: On Fri, 16 Oct 2020 11:15:27 +0800 Yanfei Xu wrote: On 10/14/20 8:31 PM, Hillf Danton wrote: On Wed, 14 Oct 2020 15:17:31 +0800 From: Yanfei Xu Locking slock-AF_BLUETOOTH-BTPROTO_SCO may happen in process context or BH context. If in process cont

Re: Why revert commit 2271c95 ("vrf: mark skb for multicast or link-local as enslaved to VRF")?

2020-10-18 Thread David Ahern
On 10/18/20 10:06 AM, Stephen Suryaputra wrote: > $ git --no-pager show afed1a4 > > commit afed1a4dbb76c81900f10fd77397fb91ad442702 > Author: Sasha Levin > Date: Mon Mar 23 16:21:31 2020 -0400 > > Revert "vrf: mark skb for multicast or link-local as enslaved to VRF" > > This rever

iperf 2.0.14 in early field test (EFT) phase

2020-10-18 Thread rjmcmahon
Hi All, Sorry for the spam - trying to reach interested parties. Just a heads up that iperf 2.0.14 is in early field test phase. Lots of new features around write to read latencies and others. Also, full-duplex, same socket testing now supported too. Use -e to get the enhanced output. Man pa

Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)

2020-10-18 Thread David Ahern
On 10/18/20 1:40 PM, Jakub Kicinski wrote: > This one got applied a few days ago, and the urgency is low so it may be > worth letting it see at least one -rc release ;) agreed

答复: [PATCH] rtnetlink: fix data overflow in rtnl_calcit()

2020-10-18 Thread zhudi (J)
> > "ip addr show" command execute error when we have a physical network > > card with number of VFs larger than 247. > > Oh man, this bug has been hurting us forever and I've tried to fix it several > times without much luck, so thanks for working on it! > > CC: David Ahern > > As he's mention

Re: [PATCH] rtnetlink: fix data overflow in rtnl_calcit()

2020-10-18 Thread zhudi (J)
> On Fri, Oct 16, 2020 at 10:02:38AM +0800, zhudi wrote: > > "ip addr show" command execute error when we have a physical network > > card with number of VFs larger than 247. > > > > The return value of if_nlmsg_size() in rtnl_calcit() will exceed range > > of u16 data type when any network cards

Re: perf measure for stalled cycles per instruction on newer Intel processors

2020-10-18 Thread Andi Kleen
> > Don't use it. It's misleading on a out-of-order CPU because you don't > > know if it's actually limiting anything. > > > > If you want useful bottleneck data use --topdown. > > So running again, this time with the below params, I got this output > where all the right most column is colored red

Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev statistics

2020-10-18 Thread Vladimir Oltean
On Sun, Oct 18, 2020 at 04:11:14PM -0700, Florian Fainelli wrote: > How about when used as a netconsole? We do support netconsole over DSA > interfaces. How? Who is supposed to bring up the master interface, and when?

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-18 Thread Xie He
On Sun, Oct 18, 2020 at 3:05 PM Jakub Kicinski wrote: > > Whenever you make a list like that it's a strong indication that > each of these should be a separate commit. That makes things easier > to review. > > > We have already sent a pull request for 5.10 and therefore net-next > is closed for ne

Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev statistics

2020-10-18 Thread Florian Fainelli
On 10/18/2020 3:58 PM, Vladimir Oltean wrote: On Sun, Oct 18, 2020 at 04:13:28PM +0200, Heiner Kallweit wrote: On a side note, because I'm also just dealing with it: this_cpu_ptr() is safe only if preemption is disabled. Is this the case here? Else there's get_cpu_ptr/put_cpu_ptr. lockdep w

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-18 Thread Jakub Kicinski
On Thu, 15 Oct 2020 13:51:19 +0530 Reji Thomas wrote: > Currently End.X action doesn't consider the outgoing interface > while looking up the nexthop.This breaks packet path functionality > specifically while using link local address as the End.X nexthop. > The patch fixes this by enforcing End.X a

Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev statistics

2020-10-18 Thread Vladimir Oltean
On Sun, Oct 18, 2020 at 04:13:28PM +0200, Heiner Kallweit wrote: > On a side note, because I'm also just dealing with it: this_cpu_ptr() > is safe only if preemption is disabled. Is this the case here? Else > there's get_cpu_ptr/put_cpu_ptr. lockdep would shout about using smp_processor_id() in pr

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097

2020-10-18 Thread Chris Packham
On 19/10/20 11:08 am, Andrew Lunn wrote: > On Sun, Oct 18, 2020 at 09:15:52PM +, Chris Packham wrote: >> On 19/10/20 9:25 am, Andrew Lunn wrote: I assume you're talking about the PHY Control Register 0 bit 11. If so that's for the internal PHYs on ports 0-7. Ports 8, 9 and 10 don't h

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097

2020-10-18 Thread Andrew Lunn
On Sun, Oct 18, 2020 at 09:15:52PM +, Chris Packham wrote: > > On 19/10/20 9:25 am, Andrew Lunn wrote: > >> I assume you're talking about the PHY Control Register 0 bit 11. If so > >> that's for the internal PHYs on ports 0-7. Ports 8, 9 and 10 don't have > >> PHYs. > > Hi Chris > > > > I have

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-18 Thread Jakub Kicinski
On Fri, 16 Oct 2020 22:19:51 -0700 Xie He wrote: > 1. Change the fr_rx function to make this driver support any Ethertype > when receiving. (This driver is already able to handle any Ethertype > when sending.) > > Originally in the fr_rx function, the code that parses the long (10-byte) > header o

Re: [PATCH net] net: core: use list_del_init() instead of list_del() in netdev_run_todo()

2020-10-18 Thread Jakub Kicinski
On Thu, 15 Oct 2020 16:26:06 + Taehee Yoo wrote: > dev->unlink_list is reused unless dev is deleted. > So, list_del() should not be used. > Due to using list_del(), dev->unlink_list can't be reused so that > dev->nested_level update logic doesn't work. > In order to fix this bug, list_del_init(

Re: [PATCH] arch: um: convert tasklets to use new tasklet_setup() API

2020-10-18 Thread Richard Weinberger
On Mon, Aug 17, 2020 at 11:17 AM Allen Pais wrote: > > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-of

[PATCH ethtool v3 4/7] add support for stats in subcommands

2020-10-18 Thread Jakub Kicinski
Add new parameters (-I | --include-statistics) which will control requesting statistic dumps from the kernel. Signed-off-by: Jakub Kicinski --- ethtool.8.in | 7 +++ ethtool.c| 8 internal.h | 1 + 3 files changed, 16 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in ind

[PATCH ethtool v3 3/7] separate FLAGS out in -h

2020-10-18 Thread Jakub Kicinski
Help output is quite crowded already with every command being prefixed by --debug and --json options, and we're about to add a third one. Add an indirection. Signed-off-by: Jakub Kicinski --- ethtool.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ethtool.c b/etht

[PATCH ethtool v3 2/7] pause: add --json support

2020-10-18 Thread Jakub Kicinski
No change in normal text output: # ./ethtool -a eth0 Pause parameters for eth0: Autonegotiate: on RX: on TX: on RX negotiated: on TX negotiated: on JSON: # ./ethtool --json -a eth0 [ { "ifname": "eth0", "autonegotiate": true, "rx": true,

[PATCH ethtool v3 1/7] update UAPI header copies

2020-10-18 Thread Jakub Kicinski
Update to kernel commit 9453b2d4694c. Signed-off-by: Jakub Kicinski --- uapi/linux/genetlink.h | 11 +++ uapi/linux/netlink.h | 4 2 files changed, 15 insertions(+) diff --git a/uapi/linux/genetlink.h b/uapi/linux/genetlink.h index 7c6c390c48ee..9fa720ee87ae 100644 --- a/uapi/li

[PATCH ethtool v3 5/7] netlink: prepare for more per-op info

2020-10-18 Thread Jakub Kicinski
We stored an array of op flags, to check if operations are supported. Make that array a structure rather than plain uint32_t in preparation for storing more state. v3: new patch Signed-off-by: Jakub Kicinski --- netlink/netlink.c | 25 + netlink/netlink.h | 6 +- 2

[PATCH ethtool v3 6/7] netlink: use policy dumping to check if stats flag is supported

2020-10-18 Thread Jakub Kicinski
Older kernels don't support statistics, to avoid retries make use of netlink policy dumps to figure out which flags kernel actually supports. v3: - s/ctx/policy_ctx/ - save the flags in nl_context to be able to reuse them, and not have to return errors and values from the policy get functi

[PATCH ethtool v3 7/7] pause: add support for dumping statistics

2020-10-18 Thread Jakub Kicinski
Add support for requesting pause frame stats from the kernel. # ./ethtool -I -a eth0 Pause parameters for eth0: Autonegotiate: on RX: on TX: on Statistics: tx_pause_frames: 1 rx_pause_frames: 1 # ./ethtool -I --json -a eth0 [ { "ifname": "eth0", "aut

[PATCH ethtool v3 0/7] pause frame stats

2020-10-18 Thread Jakub Kicinski
Hi! Sorry about the delay from v2. This set adds support for pause frame statistics. First pause frame info is extended to support --json. Pause stats are first of this kind of statistics so add support for a new flag (--include-statistics). Next add support for dumping policy to check if the

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097

2020-10-18 Thread Chris Packham
On 19/10/20 9:25 am, Andrew Lunn wrote: >> I assume you're talking about the PHY Control Register 0 bit 11. If so >> that's for the internal PHYs on ports 0-7. Ports 8, 9 and 10 don't have >> PHYs. > Hi Chris > > I have a datasheet for the 6122/6121, from some corner of the web, > Part 3 of 3, Gig

Re: [PATCH net] netsec: ignore 'phy-mode' device property on ACPI systems

2020-10-18 Thread Ilias Apalodimas
On Sun, Oct 18, 2020 at 07:52:18PM +0200, Andrew Lunn wrote: > > --- a/Documentation/devicetree/bindings/net/socionext-netsec.txt > > +++ b/Documentation/devicetree/bindings/net/socionext-netsec.txt > > @@ -30,7 +30,9 @@ Optional properties: (See ethernet.txt file in the same > > directory) > > -

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097

2020-10-18 Thread Andrew Lunn
> I assume you're talking about the PHY Control Register 0 bit 11. If so > that's for the internal PHYs on ports 0-7. Ports 8, 9 and 10 don't have > PHYs. Hi Chris I have a datasheet for the 6122/6121, from some corner of the web, Part 3 of 3, Gigabit PHYs and SERDES. http://www.image.micros.c

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097

2020-10-18 Thread Chris Packham
On 19/10/20 5:16 am, Andrew Lunn wrote: > On Tue, Oct 13, 2020 at 03:18:58PM +1300, Chris Packham wrote: >> Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for >> the MV88E6097 so that ports 8 & 9 can be supported as serdes ports and >> directly connected to other network inte

Re: [PATCH net] ixgbe: fix probing of multi-port devices with one MDIO

2020-10-18 Thread Jakub Kicinski
On Fri, 16 Oct 2020 17:48:07 -0700 Jesse Brandeburg wrote: > Jakub Kicinski wrote: > > > On Sat, 17 Oct 2020 01:50:59 +0200 Ian Kumlien wrote: > > > On Sat, Oct 17, 2020 at 1:20 AM Jakub Kicinski wrote: > > > > Ian reports that after upgrade from v5.8.14 to v5.9 only one > > > > of his 4 ixgb

[PATCH AUTOSEL 5.9 041/111] bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI

2020-10-18 Thread Sasha Levin
From: Song Liu [ Upstream commit 39d8f0d1026a990604770a658708f5845f7dbec0 ] Recent improvements in LOCKDEP highlighted a potential A-A deadlock with pcpu_freelist in NMI: ./tools/testing/selftests/bpf/test_progs -t stacktrace_build_id_nmi [ 18.984807] [ 18.

[PATCH AUTOSEL 5.9 037/111] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-18 Thread Sasha Levin
From: Cong Wang [ Upstream commit fdafed459998e2be0e877e6189b24cb7a0183224 ] GRE tunnel has its own header_ops, ipgre_header_ops, and sets it conditionally. When it is set, it assumes the outer IP header is already created before ipgre_xmit(). This is not true when we send packets through a raw

[PATCH AUTOSEL 5.9 038/111] mac80211: handle lack of sband->bitrates in rates

2020-10-18 Thread Sasha Levin
From: Thomas Pedersen [ Upstream commit 8b783d104e7f40684333d2ec155fac39219beb2f ] Even though a driver or mac80211 shouldn't produce a legacy bitrate if sband->bitrates doesn't exist, don't crash if that is the case either. This fixes a kernel panic if station dump is run before last_rate can

[PATCH AUTOSEL 5.9 053/111] selftests/bpf: Fix overflow tests to reflect iter size increase

2020-10-18 Thread Sasha Levin
From: Alan Maguire [ Upstream commit eb58bbf2e5c7917aa30bf8818761f26bbeeb2290 ] bpf iter size increase to PAGE_SIZE << 3 means overflow tests assuming page size need to be bumped also. Signed-off-by: Alan Maguire Signed-off-by: Alexei Starovoitov Link: https://lore.kernel.org/bpf/1601292670-

[PATCH AUTOSEL 5.9 060/111] ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()

2020-10-18 Thread Sasha Levin
From: Brooke Basile [ Upstream commit 03fb92a432ea5abe5909bca1455b7e44a9380480 ] Calls to usb_kill_anchored_urbs() after usb_kill_urb() on multiprocessor systems create a race condition in which usb_kill_anchored_urbs() deallocates the URB before the completer callback is called in usb_kill_urb(

[PATCH AUTOSEL 5.9 055/111] mt76: mt7915: do not do any work in napi poll after calling napi_complete_done()

2020-10-18 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit 38b04398c532e9bb9aa90fc07846ad0b0845fe94 ] Fixes a race condition where multiple tx cleanup or sta poll tasks could run in parallel. Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt7915/dma.c | 9 +++--

[PATCH AUTOSEL 5.9 058/111] can: flexcan: flexcan_chip_stop(): add error handling and propagate error value

2020-10-18 Thread Sasha Levin
From: Joakim Zhang [ Upstream commit 9ad02c7f4f279504bdd38ab706fdc97d5f2b2a9c ] This patch implements error handling and propagates the error value of flexcan_chip_stop(). This function will be called from flexcan_suspend() in an upcoming patch in some SoCs which support LPSR mode. Add a new fu

[PATCH AUTOSEL 5.9 049/111] rtw88: pci: Power cycle device during shutdown

2020-10-18 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 44492e70adc8086c42d3745d21d591657a427f04 ] There are reports that 8822CE fails to work rtw88 with "failed to read DBI register" error. Also I have a system with 8723DE which freezes the whole system when the rtw88 is probing the device. According to [1], pl

[PATCH AUTOSEL 5.9 072/111] Bluetooth: Only mark socket zapped after unlocking

2020-10-18 Thread Sasha Levin
From: Abhishek Pandit-Subedi [ Upstream commit 20ae4089d0afeb24e9ceb026b996bfa55c983cc2 ] Since l2cap_sock_teardown_cb doesn't acquire the channel lock before setting the socket as zapped, it could potentially race with l2cap_sock_release which frees the socket. Thus, wait until the cleanup is c

[PATCH AUTOSEL 5.9 064/111] bpf: Limit caller's stack depth 256 for subprogs with tailcalls

2020-10-18 Thread Sasha Levin
From: Maciej Fijalkowski [ Upstream commit 7f6e4312e15a5c370e84eaa685879b6bdcc717e4 ] Protect against potential stack overflow that might happen when bpf2bpf calls get combined with tailcalls. Limit the caller's stack depth for such case down to 256 so that the worst case scenario would result i

[PATCH AUTOSEL 5.9 080/111] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

2020-10-18 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f4443293d741d1776b86ed1dd8c4e4285d0775fc ] When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy, the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be freed in the caller function. Fix this by calling wlc_phy_detach_lcnphy in

[PATCH AUTOSEL 5.9 081/111] rtl8xxxu: prevent potential memory leak

2020-10-18 Thread Sasha Levin
From: Chris Chiu [ Upstream commit 86279456a4d47782398d3cb8193f78f672e36cac ] Free the skb if usb_submit_urb fails on rx_urb. And free the urb no matter usb_submit_urb succeeds or not in rtl8xxxu_submit_int_urb. Signed-off-by: Chris Chiu Signed-off-by: Kalle Valo Link: https://lore.kernel.org

[PATCH AUTOSEL 5.9 095/111] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-10-18 Thread Sasha Levin
From: Tetsuo Handa [ Upstream commit 621a3a8b1c0ecf16e1e5667ea5756a76a082b738 ] syzbot is reporting that del_timer_sync() is called from mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without checking timer_setup() from mwifiex_usb_tx_init() was called [1]. Ganapathi Bhat proposed

[PATCH AUTOSEL 5.9 092/111] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-10-18 Thread Sasha Levin
From: Peilin Ye [ Upstream commit c5a8a8498eed1c164afc94f50a939c1a10abf8ad ] do_ip_vs_set_ctl() is referencing uninitialized stack value when `len` is zero. Fix it. Reported-by: syzbot+23b5f9e7caf61d9a3...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=46ebfb92a8a812621a0

[PATCH AUTOSEL 5.9 101/111] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach

2020-10-18 Thread Sasha Levin
From: Wang Yufen [ Upstream commit 6c151410d5b57e6bb0d91a735ac511459539a7bf ] When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL, we should destroy the workqueue. Reported-by: Hulk Robot Signed-off-by: Wang Yufen Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/15952

[PATCH AUTOSEL 5.9 111/111] ath10k: check idx validity in __ath10k_htt_rx_ring_fill_n()

2020-10-18 Thread Sasha Levin
From: Zekun Shen [ Upstream commit bad60b8d1a7194df38fd7fe4b22f3f4dcf775099 ] The idx in __ath10k_htt_rx_ring_fill_n function lives in consistent dma region writable by the device. Malfunctional or malicious device could manipulate such idx to have a OOB write. Either by htt->rx_ring.netbufs

Re: [PATCH v2] net: usb: rtl8150: don't incorrectly assign random MAC addresses

2020-10-18 Thread Jakub Kicinski
On Thu, 15 Oct 2020 15:37:00 -0700 Jakub Kicinski wrote: > On Thu, 15 Oct 2020 15:24:51 -0700 Jakub Kicinski wrote: > > On Fri, 16 Oct 2020 08:59:22 +1100 Stephen Rothwell wrote: > > > > I will apply the above patch to the merge of the usb tree today to fix > > > > up a semantic conflict between

[PATCH AUTOSEL 5.8 036/101] mac80211: handle lack of sband->bitrates in rates

2020-10-18 Thread Sasha Levin
From: Thomas Pedersen [ Upstream commit 8b783d104e7f40684333d2ec155fac39219beb2f ] Even though a driver or mac80211 shouldn't produce a legacy bitrate if sband->bitrates doesn't exist, don't crash if that is the case either. This fixes a kernel panic if station dump is run before last_rate can

Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

2020-10-18 Thread James Bottomley
On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote: > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > clang has a number of useful, new warnings see > > https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F9

[PATCH AUTOSEL 5.8 039/101] bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI

2020-10-18 Thread Sasha Levin
From: Song Liu [ Upstream commit 39d8f0d1026a990604770a658708f5845f7dbec0 ] Recent improvements in LOCKDEP highlighted a potential A-A deadlock with pcpu_freelist in NMI: ./tools/testing/selftests/bpf/test_progs -t stacktrace_build_id_nmi [ 18.984807] [ 18.

Re: [PATCH net] selftests: forwarding: Add missing 'rp_filter' configuration

2020-10-18 Thread Jakub Kicinski
On Thu, 15 Oct 2020 11:45:25 +0300 Ido Schimmel wrote: > From: Ido Schimmel > > When 'rp_filter' is configured in strict mode (1) the tests fail because > packets received from the macvlan netdevs would not be forwarded through > them on the reverse path. > > Fix this by disabling the 'rp_filter

[PATCH AUTOSEL 5.8 057/101] ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()

2020-10-18 Thread Sasha Levin
From: Brooke Basile [ Upstream commit 03fb92a432ea5abe5909bca1455b7e44a9380480 ] Calls to usb_kill_anchored_urbs() after usb_kill_urb() on multiprocessor systems create a race condition in which usb_kill_anchored_urbs() deallocates the URB before the completer callback is called in usb_kill_urb(

[PATCH AUTOSEL 5.8 055/101] can: flexcan: flexcan_chip_stop(): add error handling and propagate error value

2020-10-18 Thread Sasha Levin
From: Joakim Zhang [ Upstream commit 9ad02c7f4f279504bdd38ab706fdc97d5f2b2a9c ] This patch implements error handling and propagates the error value of flexcan_chip_stop(). This function will be called from flexcan_suspend() in an upcoming patch in some SoCs which support LPSR mode. Add a new fu

[PATCH AUTOSEL 5.8 051/101] selftests/bpf: Fix overflow tests to reflect iter size increase

2020-10-18 Thread Sasha Levin
From: Alan Maguire [ Upstream commit eb58bbf2e5c7917aa30bf8818761f26bbeeb2290 ] bpf iter size increase to PAGE_SIZE << 3 means overflow tests assuming page size need to be bumped also. Signed-off-by: Alan Maguire Signed-off-by: Alexei Starovoitov Link: https://lore.kernel.org/bpf/1601292670-

[PATCH AUTOSEL 5.8 047/101] rtw88: pci: Power cycle device during shutdown

2020-10-18 Thread Sasha Levin
From: Kai-Heng Feng [ Upstream commit 44492e70adc8086c42d3745d21d591657a427f04 ] There are reports that 8822CE fails to work rtw88 with "failed to read DBI register" error. Also I have a system with 8723DE which freezes the whole system when the rtw88 is probing the device. According to [1], pl

[PATCH AUTOSEL 5.8 061/101] bpf: Limit caller's stack depth 256 for subprogs with tailcalls

2020-10-18 Thread Sasha Levin
From: Maciej Fijalkowski [ Upstream commit 7f6e4312e15a5c370e84eaa685879b6bdcc717e4 ] Protect against potential stack overflow that might happen when bpf2bpf calls get combined with tailcalls. Limit the caller's stack depth for such case down to 256 so that the worst case scenario would result i

[PATCH AUTOSEL 5.8 068/101] Bluetooth: Only mark socket zapped after unlocking

2020-10-18 Thread Sasha Levin
From: Abhishek Pandit-Subedi [ Upstream commit 20ae4089d0afeb24e9ceb026b996bfa55c983cc2 ] Since l2cap_sock_teardown_cb doesn't acquire the channel lock before setting the socket as zapped, it could potentially race with l2cap_sock_release which frees the socket. Thus, wait until the cleanup is c

[PATCH AUTOSEL 5.8 074/101] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

2020-10-18 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f4443293d741d1776b86ed1dd8c4e4285d0775fc ] When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy, the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be freed in the caller function. Fix this by calling wlc_phy_detach_lcnphy in

[PATCH AUTOSEL 5.8 075/101] rtl8xxxu: prevent potential memory leak

2020-10-18 Thread Sasha Levin
From: Chris Chiu [ Upstream commit 86279456a4d47782398d3cb8193f78f672e36cac ] Free the skb if usb_submit_urb fails on rx_urb. And free the urb no matter usb_submit_urb succeeds or not in rtl8xxxu_submit_int_urb. Signed-off-by: Chris Chiu Signed-off-by: Kalle Valo Link: https://lore.kernel.org

[PATCH AUTOSEL 5.8 073/101] selftests/bpf: Fix test_sysctl_loop{1, 2} failure due to clang change

2020-10-18 Thread Sasha Levin
From: Yonghong Song [ Upstream commit 7fb5eefd76394cfefb380724a87ca40b47d44405 ] Andrii reported that with latest clang, when building selftests, we have error likes: error: progs/test_sysctl_loop1.c:23:16: in function sysctl_tcp_mem i32 (%struct.bpf_sysctl*): Looks like the BPF stack limit

[PATCH AUTOSEL 5.8 089/101] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-10-18 Thread Sasha Levin
From: Tetsuo Handa [ Upstream commit 621a3a8b1c0ecf16e1e5667ea5756a76a082b738 ] syzbot is reporting that del_timer_sync() is called from mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without checking timer_setup() from mwifiex_usb_tx_init() was called [1]. Ganapathi Bhat proposed

[PATCH AUTOSEL 5.8 095/101] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach

2020-10-18 Thread Sasha Levin
From: Wang Yufen [ Upstream commit 6c151410d5b57e6bb0d91a735ac511459539a7bf ] When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL, we should destroy the workqueue. Reported-by: Hulk Robot Signed-off-by: Wang Yufen Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/15952

[PATCH AUTOSEL 5.8 101/101] ath10k: check idx validity in __ath10k_htt_rx_ring_fill_n()

2020-10-18 Thread Sasha Levin
From: Zekun Shen [ Upstream commit bad60b8d1a7194df38fd7fe4b22f3f4dcf775099 ] The idx in __ath10k_htt_rx_ring_fill_n function lives in consistent dma region writable by the device. Malfunctional or malicious device could manipulate such idx to have a OOB write. Either by htt->rx_ring.netbufs

[PATCH AUTOSEL 5.4 30/80] mac80211: handle lack of sband->bitrates in rates

2020-10-18 Thread Sasha Levin
From: Thomas Pedersen [ Upstream commit 8b783d104e7f40684333d2ec155fac39219beb2f ] Even though a driver or mac80211 shouldn't produce a legacy bitrate if sband->bitrates doesn't exist, don't crash if that is the case either. This fixes a kernel panic if station dump is run before last_rate can

[PATCH AUTOSEL 5.4 27/80] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)

2020-10-18 Thread Sasha Levin
From: Mathieu Desnoyers [ Upstream commit 272928d1cdacfc3b55f605cb0e9115832ecfb20c ] As per RFC4443, the destination address field for ICMPv6 error messages is copied from the source address field of the invoking packet. In configurations with Virtual Routing and Forwarding tables, looking up w

[PATCH AUTOSEL 5.4 29/80] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-18 Thread Sasha Levin
From: Cong Wang [ Upstream commit fdafed459998e2be0e877e6189b24cb7a0183224 ] GRE tunnel has its own header_ops, ipgre_header_ops, and sets it conditionally. When it is set, it assumes the outer IP header is already created before ipgre_xmit(). This is not true when we send packets through a raw

[PATCH AUTOSEL 5.4 40/80] rtw88: increse the size of rx buffer size

2020-10-18 Thread Sasha Levin
From: Tzu-En Huang [ Upstream commit ee755732b7a16af018daa77d9562d2493fb7092f ] The vht capability of MAX_MPDU_LENGTH is 11454 in rtw88; however, the rx buffer size for each packet is 8192. When receiving packets that are larger than rx buffer size, it will leads to rx buffer ring overflow. Sig

[PATCH AUTOSEL 5.4 46/80] bpf: Limit caller's stack depth 256 for subprogs with tailcalls

2020-10-18 Thread Sasha Levin
From: Maciej Fijalkowski [ Upstream commit 7f6e4312e15a5c370e84eaa685879b6bdcc717e4 ] Protect against potential stack overflow that might happen when bpf2bpf calls get combined with tailcalls. Limit the caller's stack depth for such case down to 256 so that the worst case scenario would result i

[PATCH AUTOSEL 5.4 43/80] can: flexcan: flexcan_chip_stop(): add error handling and propagate error value

2020-10-18 Thread Sasha Levin
From: Joakim Zhang [ Upstream commit 9ad02c7f4f279504bdd38ab706fdc97d5f2b2a9c ] This patch implements error handling and propagates the error value of flexcan_chip_stop(). This function will be called from flexcan_suspend() in an upcoming patch in some SoCs which support LPSR mode. Add a new fu

[PATCH AUTOSEL 5.4 52/80] Bluetooth: Only mark socket zapped after unlocking

2020-10-18 Thread Sasha Levin
From: Abhishek Pandit-Subedi [ Upstream commit 20ae4089d0afeb24e9ceb026b996bfa55c983cc2 ] Since l2cap_sock_teardown_cb doesn't acquire the channel lock before setting the socket as zapped, it could potentially race with l2cap_sock_release which frees the socket. Thus, wait until the cleanup is c

[PATCH AUTOSEL 5.4 44/80] ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()

2020-10-18 Thread Sasha Levin
From: Brooke Basile [ Upstream commit 03fb92a432ea5abe5909bca1455b7e44a9380480 ] Calls to usb_kill_anchored_urbs() after usb_kill_urb() on multiprocessor systems create a race condition in which usb_kill_anchored_urbs() deallocates the URB before the completer callback is called in usb_kill_urb(

[PATCH AUTOSEL 5.4 57/80] selftests/bpf: Fix test_sysctl_loop{1, 2} failure due to clang change

2020-10-18 Thread Sasha Levin
From: Yonghong Song [ Upstream commit 7fb5eefd76394cfefb380724a87ca40b47d44405 ] Andrii reported that with latest clang, when building selftests, we have error likes: error: progs/test_sysctl_loop1.c:23:16: in function sysctl_tcp_mem i32 (%struct.bpf_sysctl*): Looks like the BPF stack limit

[PATCH AUTOSEL 5.4 58/80] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

2020-10-18 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f4443293d741d1776b86ed1dd8c4e4285d0775fc ] When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy, the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be freed in the caller function. Fix this by calling wlc_phy_detach_lcnphy in

  1   2   3   >