Re: BPF redirect API design issue for BPF-prog MTU feedback?

2020-09-21 Thread Eyal Birger
On Mon, Sep 21, 2020 at 7:30 PM Jesper Dangaard Brouer wrote: > > On Mon, 21 Sep 2020 17:08:17 +0200 > Daniel Borkmann wrote: > > > On 9/21/20 2:49 PM, Jesper Dangaard Brouer wrote: > > > On Mon, 21 Sep 2020 11:37:18 +0100 > > > Lorenz Bauer wrote: > > >> On Sat, 19 Sep 2020 at 00:06, Maciej Żen

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Michal Kubecek
On Tue, Sep 22, 2020 at 11:24:24AM +0530, Vasundhara Volam wrote: > On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > > + return -1; > > > + } > > > + > > > + pcie_stats = (u16 *)(regs->data + BNXT_PXP_REG_LEN); > > > + fprintf(stdout, "PCIe statistics:\n"); > > > +

RE: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-21 Thread 劉偉權
Hi Andrew, I summary table 12,13 from RTL8211E-VB datasheet as below. [Table 12] RTL8211E-VB Pin Pin Name LED0 PHYAD[0] LED1 PHYAD[1] RXCTLPHYAD[2] RXD2 AN[0] RXD3 AN[1] -Mode LED2

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-21 Thread Pavel Begunkov
On 22/09/2020 03:58, Andy Lutomirski wrote: > On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov wrote: >>> Ah, so reading /dev/input/event* would suffer from the same issue, >>> and that one would in fact be broken by your patch in the hypothetical >>> case that someone tried to use io_ur

Re: [PATCH iproute2] ip: do not exit if RTM_GETNSID failed

2020-09-21 Thread Jan Engelhardt
On Tuesday 2020-09-22 02:22, Stephen Hemminger wrote: >Jan Engelhardt wrote: > >> `ip addr` when run under qemu-user-riscv64, fails. This likely is >> due to qemu-5.1 not doing translation of RTM_GETNSID calls. >> >> 2: host0@if5: mtu 1500 qdisc noqueue state >> UP group default qlen 1000 >>

[PATCH v2 ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
This patch adds the initial support for parsing registers dumped by the Broadcom driver. Currently, PXP and PCIe registers are parsed. Reviewed-by: Andy Gospodarek Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam --- v2: - Fix format specifiers in bnxt_pcie_stats[] array. - Use width for

Re: [PATCH iproute2] build: avoid make jobserver warnings

2020-09-21 Thread Jan Engelhardt
On Tuesday 2020-09-22 02:19, Stephen Hemminger wrote: >> I observe: >> >> » make -j8 CCOPTS=-ggdb3 >> lib >> make[1]: warning: -j8 forced in submake: resetting jobserver mode. >> make[1]: Nothing to be done for 'all'. >> ip >> make[1]: warning: -j8 forced in submake

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
On Mon, Sep 21, 2020 at 6:11 PM Andrew Lunn wrote: > > > +struct bnxt_pcie_stat { > > + const char *name; > > + u16 offset; > > + u8 size; > > + const char *format; > > +}; > > + > > +static const struct bnxt_pcie_stat bnxt_pcie_stats[] = { > > + { .name = "PL Signal integrity

Re: [PATCH] net/mlx5: remove unreachable return

2020-09-21 Thread Saeed Mahameed
On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > The last return statement is unreachable code. I'm not sure if it > will > provoke any warnings, but it looks ugly. > > Signed-off-by: Pavel Machek (CIP) > > Applied to net-next-mlx5. Thanks, Saeed.

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > On Mon, Sep 21, 2020 at 12:09:51PM +0530, Vasundhara Volam wrote: > > This patch adds the initial support for parsing registers dumped > > by the Broadcom driver. Currently, PXP and PCIe registers are > > parsed. > > > > Reviewed-by: Andy G

Re: [PATCH -next] net/mlx5: simplify the return expression of mlx5_ec_init()

2020-09-21 Thread Saeed Mahameed
On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- > drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > Applied to net-next-mlx5. Thanks.

Re: [PATCH 2/2] net/mlx5e: Use kfree() to free fd->g in accel_fs_tcp_create_groups()

2020-09-21 Thread Saeed Mahameed
On Mon, 2020-09-21 at 19:23 +0300, Denis Efremov wrote: > Memory ft->g in accel_fs_tcp_create_groups() is allocaed with > kcalloc(). > It's excessive to free ft->g with kvfree(). Use kfree() instead. > > Signed-off-by: Denis Efremov > --- > series applied to net-next-mlx5

RE: [PATCH net-next v2 0/8] devlink: Add SF add/delete devlink ops

2020-09-21 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Tuesday, September 22, 2020 3:32 AM > > On Fri, 18 Sep 2020 20:09:24 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Friday, September 18, 2020 11:58 PM > > > > > > On Fri, 18 Sep 2020 17:47:24 + Parav Pandit wrote: > > > > > > What do you s

Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2

2020-09-21 Thread Yafang Shao
On Mon, Sep 21, 2020 at 7:36 PM Michal Hocko wrote: > > On Mon 21-09-20 19:23:01, Yafang Shao wrote: > > On Mon, Sep 21, 2020 at 7:05 PM Michal Hocko wrote: > > > > > > On Mon 21-09-20 18:55:40, Yafang Shao wrote: > > > > On Mon, Sep 21, 2020 at 4:12 PM Michal Hocko wrote: > > > > > > > > > > On

Re: UBSAN: array-index-out-of-bounds in arch_uprobe_analyze_insn

2020-09-21 Thread syzbot
syzbot has bisected this issue to: commit 4b2bd5fec007a4fd3fc82474b9199af25013de4c Author: John Stultz Date: Sat Oct 8 00:02:33 2016 + proc: fix timerslack_ns CAP_SYS_NICE check when adjusting self bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1697348d90 start commi

Re: [PATCH bpf-next v3 3/5] bpf: add 'bpf_mptcp_sock' structure and helper

2020-09-21 Thread Alexei Starovoitov
On Fri, Sep 18, 2020 at 02:10:42PM +0200, Nicolas Rybowski wrote: > + > +BPF_CALL_1(bpf_mptcp_sock, struct sock *, sk) > +{ > + if (sk_fullsock(sk) && sk->sk_protocol == IPPROTO_TCP && > sk_is_mptcp(sk)) { > + struct mptcp_subflow_context *mptcp_sfc = mptcp_subflow_ctx(sk); Could

Re: [PATCH bpf-next] bpf: add support for other map types to bpf_map_lookup_and_delete_elem

2020-09-21 Thread Andrii Nakryiko
On Thu, Sep 17, 2020 at 7:16 AM Luka Oreskovic wrote: > > Since this function already exists, it made sense to implement it for > map types other than stack and queue. This patch adds the necessary parts > from bpf_map_lookup_elem and bpf_map_delete_elem so it works as expected > for all map types

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-21 Thread Nitesh Narayan Lal
On 9/21/20 7:40 PM, Frederic Weisbecker wrote: > On Wed, Sep 09, 2020 at 11:08:16AM -0400, Nitesh Narayan Lal wrote: >> +/* >> + * num_housekeeping_cpus() - Read the number of housekeeping CPUs. >> + * >> + * This function returns the number of available housekeeping CPUs >> + * based on __num_hou

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-21 Thread Nitesh Narayan Lal
On 9/21/20 6:58 PM, Frederic Weisbecker wrote: > On Thu, Sep 17, 2020 at 11:23:59AM -0700, Jesse Brandeburg wrote: >> Nitesh Narayan Lal wrote: >> >>> In a realtime environment, it is essential to isolate unwanted IRQs from >>> isolated CPUs to prevent latency overheads. Creating MSIX vectors only

[net-next v3 PATCH 0/2] Introduce mbox tracepoints for Octeontx2

2020-09-21 Thread sundeep . lkml
From: Subbaraya Sundeep This patchset adds tracepoints support for mailbox. In Octeontx2, PFs and VFs need to communicate with AF for allocating and freeing resources. Once all the configuration is done by AF for a PF/VF then packet I/O can happen on PF/VF queues. When an interface is brought up

[net-next v3 PATCH 1/2] octeontx2-af: Introduce tracepoints for mailbox

2020-09-21 Thread sundeep . lkml
From: Subbaraya Sundeep Added tracepoints in mailbox code so that the mailbox operations like message allocation, sending message and message interrupts are traced. Also the mailbox errors occurred like timeout or wrong responses are traced. These will help in debugging mailbox issues. Here's an

[net-next v3 PATCH 2/2] octeontx2-pf: Add tracepoints for PF/VF mailbox

2020-09-21 Thread sundeep . lkml
From: Subbaraya Sundeep With tracepoints support present in the mailbox code this patch adds tracepoints in PF and VF drivers at places where mailbox messages are allocated, sent and at message interrupts. Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham --- drivers/net/ethernet/

Re: [net-next v2 PATCH 1/2] octeontx2-af: Introduce tracepoints for mailbox

2020-09-21 Thread sundeep subbaraya
Hi Jakub, On Tue, Sep 22, 2020 at 4:48 AM Jakub Kicinski wrote: > > On Mon, 21 Sep 2020 22:32:41 +0530 sundeep.l...@gmail.com wrote: > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c > > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c > > new file mode 100644 > > ind

[net-next V3 11/12] net/mlx5e: Move TX code into functions to be used by MPWQE

2020-09-21 Thread saeed
From: Maxim Mikityanskiy mlx5e_txwqe_complete performs some actions that can be taken to separate functions: 1. Update the flags needed for hardware timestamping. 2. Stop the TX queue if it's full. Take these actions into separate functions to be reused by the MPWQE code in the following commi

[net-next V3 02/12] net/mlx5e: Use struct assignment to initialize mlx5e_tx_wqe_info

2020-09-21 Thread saeed
From: Maxim Mikityanskiy Struct assignment guarantees that all fields of the structure are initialized (those that are not mentioned are zeroed). It makes code mode robust and reduces chances for unpredictable behavior when one forgets to reset some field and it holds an old value from previous i

[net-next V3 07/12] net/mlx5e: Move the TLS resync check out of the function

2020-09-21 Thread saeed
From: Maxim Mikityanskiy Before this patch, mlx5e_ktls_tx_handle_resync_dump_comp checked for resync_dump_frag_page. It happened for all WQEs without an SKB, including padding WQEs, and required a function call. Normally, padding WQEs happen more often than TLS resyncs. Take this check out of the

[net-next V3 08/12] net/mlx5e: Support multiple SKBs in a TX WQE

2020-09-21 Thread saeed
From: Maxim Mikityanskiy TX MPWQE support for SKBs is coming in one of the following patches, and a single MPWQE can send multiple SKBs. This commit prepares the TX path code to handle such cases: 1. An additional FIFO for SKBs is added, just like the FIFO for DMA chunks. 2. struct mlx5e_tx_wqe

[net-next V3 09/12] net/mlx5e: Generalize TX MPWQE checks for full session

2020-09-21 Thread saeed
From: Maxim Mikityanskiy As preparation for the upcoming TX MPWQE for SKBs, create a function (mlx5e_tx_mpwqe_is_full) to check whether an MPWQE session is full. This function will be shared by MPWQE code for XDP and for SKBs. Defines are renamed and moved to make them not XDP-specific. Signed-o

[net-next V3 10/12] net/mlx5e: Rename xmit-related structs to generalize them

2020-09-21 Thread saeed
From: Maxim Mikityanskiy As preparation for the upcoming TX MPWQE support for SKBs, rename struct mlx5e_xdp_mpwqe to mlx5e_tx_mpwqe and move it above struct mlx5e_txqsq. This structure will be reused in the regular SQ and in the regular TX data path. Also rename mlx5e_xdp_xmit_data to mlx5e_xmit_

[net-next V3 04/12] net/mlx5e: Refactor xmit functions

2020-09-21 Thread saeed
From: Maxim Mikityanskiy A huge function mlx5e_sq_xmit was split into several to achieve multiple goals: 1. Reuse the code in IPoIB. 2. Better intergrate with TLS, IPSEC, GENEVE and checksum offloads. Now it's possible to reserve space in the WQ before running eseg-based offloads, so: 2.1. It'

[net-next V3 12/12] net/mlx5e: Enhanced TX MPWQE for SKBs

2020-09-21 Thread saeed
From: Maxim Mikityanskiy This commit adds support for Enhanced TX MPWQE feature in the regular (SKB) data path. A MPWQE (multi-packet work queue element) can serve multiple packets, reducing the PCI bandwidth on control traffic. Two new stats (tx*_mpwqe_blks and tx*_mpwqe_pkts) are added. The fe

[net-next V3 05/12] net/mlx5e: Small improvements for XDP TX MPWQE logic

2020-09-21 Thread saeed
From: Maxim Mikityanskiy Use MLX5E_XDP_MPW_MAX_WQEBBS to reserve space for a MPWQE, because it's actually the maximal size a MPWQE can take. Reorganize the logic that checks when to close the MPWQE session: 1. Put all checks into a single function. 2. When inline is on, make only one compariso

[net-next V3 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-21 Thread saeed
From: Maxim Mikityanskiy Move mlx5e_tx_wqe_inline_mode from en/txrx.h to en_tx.c as it's only used there. Signed-off-by: Maxim Mikityanskiy Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 23 --- .../net/ethernet/mel

[net-next V3 06/12] net/mlx5e: Unify constants for WQE_EMPTY_DS_COUNT

2020-09-21 Thread saeed
From: Maxim Mikityanskiy A constant for the number of DS in an empty WQE (i.e. a WQE without data segments) is needed in multiple places (normal TX data path, MPWQE in XDP), but currently we have a constant for XDP and an inline formula in normal TX. This patch introduces a common constant. Addi

[net-next V3 01/12] net/mlx5e: Refactor inline header size calculation in the TX path

2020-09-21 Thread saeed
From: Maxim Mikityanskiy As preparation for the next patch, don't increase ihs to calculate ds_cnt and then decrease it, but rather calculate the intermediate value temporarily. This code has the same amount of arithmetic operations, but now allows to split out ds_cnt calculation, which will be p

[pull request][net-next V3 00/12] mlx5 Multi packet tx descriptors for SKBs

2020-09-21 Thread saeed
ion with GCC 10. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit c5a2a132a38619d24d6d115c66cc277594b4fe01: Merge tag 'linux-can-next-for-5.10-20200921' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next (2

[PATCH] net: allwinner: remove redundant irqsave and irqrestore in hardIRQ

2020-09-21 Thread Barry Song
The comment "holders of db->lock must always block IRQs" and related code to do irqsave and irqrestore don't make sense since we are in a IRQ-disabled hardIRQ context. Cc: Maxime Ripard Cc: Chen-Yu Tsai Signed-off-by: Barry Song --- drivers/net/ethernet/allwinner/sun4i-emac.c | 6 ++ 1 fil

Re: [PATCH -next] mlxsw: spectrum_acl_tcam: simplify the return expression of ishtp_cl_driver_register()

2020-09-21 Thread miaoqinglang
在 2020/9/21 21:51, Ido Schimmel 写道: On Mon, Sep 21, 2020 at 09:10:39PM +0800, Qinglang Miao wrote: Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff -

[GIT] Networking

2020-09-21 Thread Jakub Kicinski
Hi! Here are the latest updates from the networking tree: Ido fixes failure to add bond interfaces to a bridge, the offload-handling code was too defensive there and recent refactoring unearthed that. Users complained. Wei fixes unnecessarily reflecting ECN bits within TOS values / QoS marking i

Re: [PATCH v5 bpf-next 5/6] bpf: add bpf_seq_btf_write helper

2020-09-21 Thread Alexei Starovoitov
On Fri, Sep 18, 2020 at 02:34:34PM +0100, Alan Maguire wrote: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 9b89b67..c0815f1 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -3614,6 +3614,15 @@ struct bpf_stack_build_id { > * The

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-21 Thread Andy Lutomirski
On Mon, Sep 21, 2020 at 5:24 PM Pavel Begunkov wrote: > > > > On 22/09/2020 02:51, Andy Lutomirski wrote: > > On Mon, Sep 21, 2020 at 9:15 AM Pavel Begunkov > > wrote: > >> > >> On 21/09/2020 19:10, Pavel Begunkov wrote: > >>> On 20/09/2020 01:22, Andy Lutomirski wrote: > > > On Sep 19,

[PATCH v2 net] net: mscc: ocelot: return error if VCAP filter is not found

2020-09-21 Thread Vladimir Oltean
From: Xiaoliang Yang There are 2 separate, but related, issues. First, the ocelot_vcap_block_get_filter_index function, née ocelot_ace_rule_get_index_id prior to the aae4e500e106 ("net: mscc: ocelot: generalize the "ACE/ACL" names") rename, does not do what the author probably intended. If the d

Re: [PATCH net] net: mscc: ocelot: return error if VCAP filter is not found

2020-09-21 Thread David Miller
From: Vladimir Oltean Date: Tue, 22 Sep 2020 00:39:13 + > On Mon, Sep 21, 2020 at 05:31:02PM -0700, David Miller wrote: >> Please repost this with an appropriate Fixes: tag. > > I shouldn't need to do that if you apply the patch using patchwork: > > Fixes: b596229448dd ("net: mscc: ocelot:

Re: [PATCH net 0/3] Fix broken tc-flower rules for mscc_ocelot switches

2020-09-21 Thread David Miller
From: Vladimir Oltean Date: Tue, 22 Sep 2020 01:56:35 +0300 > All 3 switch drivers from the Ocelot family have the same bug in the > VCAP IS2 key offsets, which is that some keys are in the incorrect > order. Series applied, thank you.

Re: [PATCH net] inet_diag: validate INET_DIAG_REQ_PROTOCOL attribute

2020-09-21 Thread David Miller
From: Eric Dumazet Date: Mon, 21 Sep 2020 07:27:20 -0700 > User space could send an invalid INET_DIAG_REQ_PROTOCOL attribute > as caught by syzbot. > > BUG: KMSAN: uninit-value in inet_diag_lock_handler net/ipv4/inet_diag.c:55 > [inline] > BUG: KMSAN: uninit-value in __inet_diag_dump+0x58c/0x72

Re: [PATCH net] net: mscc: ocelot: return error if VCAP filter is not found

2020-09-21 Thread Vladimir Oltean
On Mon, Sep 21, 2020 at 05:31:02PM -0700, David Miller wrote: > Please repost this with an appropriate Fixes: tag. I shouldn't need to do that if you apply the patch using patchwork: Fixes: b596229448dd ("net: mscc: ocelot: Add support for tcam") But this tag is more or less decorative, since ev

Re: [PATCH net] net: bridge: br_vlan_get_pvid_rcu() should dereference the VLAN group under RCU

2020-09-21 Thread David Miller
From: Vladimir Oltean Date: Tue, 22 Sep 2020 01:07:09 +0300 > When calling the RCU brother of br_vlan_get_pvid(), lockdep warns: > > = > WARNING: suspicious RCU usage > 5.9.0-rc3-01631-g13c17acb8e38-dirty #814 Not tainted > - > net/bridge/b

Re: [pull request][net V2 00/15] mlx5 fixes-2020-09-18

2020-09-21 Thread David Miller
From: sa...@kernel.org Date: Mon, 21 Sep 2020 17:30:46 -0700 > This series introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. Pulled. > For -stable v5.1 > ('net/mlx5: Fix FTE cleanup') > > For -stable v5.3 > ('net/mlx5e: TLS, Do not expose FPGA TLS

[net V2 14/15] net/mlx5e: kTLS, Avoid kzalloc(GFP_KERNEL) under spinlock

2020-09-21 Thread saeed
From: Saeed Mahameed The spinlock only needed when accessing the channel's icosq, grab the lock after the buf allocation in resync_post_get_progress_params() to avoid kzalloc(GFP_KERNEL) in atomic context. Fixes: 0419d8c9d8f8 ("net/mlx5e: kTLS, Add kTLS RX resync support") Reported-by: YueHaibin

[net V2 11/15] net/mlx5e: kTLS, Fix napi sync and possible use-after-free

2020-09-21 Thread saeed
From: Tariq Toukan Using synchronize_rcu() is sufficient to wait until running NAPI quits. See similar upstream fix with detailed explanation: ("net/mlx5e: Use synchronize_rcu to sync with NAPI") This change also fixes a possible use-after-free as the NAPI might be already released at this stag

[net V2 07/15] net/mlx5e: Fix endianness when calculating pedit mask first bit

2020-09-21 Thread saeed
From: Maor Dickman The field mask value is provided in network byte order and has to be converted to host byte order before calculating pedit mask first bit. Fixes: 88f30bbcbaaa ("net/mlx5e: Bit sized fields rewrite support") Signed-off-by: Maor Dickman Reviewed-by: Roi Dayan Signed-off-by: Sa

[net V2 12/15] net/mlx5e: kTLS, Add missing dma_unmap in RX resync

2020-09-21 Thread saeed
From: Saeed Mahameed Progress params dma address is never unmapped, unmap it when completion handling is over. Fixes: 0419d8c9d8f8 ("net/mlx5e: kTLS, Add kTLS RX resync support") Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c

[net V2 13/15] net/mlx5e: kTLS, Fix leak on resync error flow

2020-09-21 Thread saeed
From: Saeed Mahameed Resync progress params buffer and dma weren't released on error, Add missing error unwinding for resync_post_get_progress_params(). Fixes: 0419d8c9d8f8 ("net/mlx5e: kTLS, Add kTLS RX resync support") Signed-off-by: Saeed Mahameed Reviewed-by: Tariq Toukan --- .../net/ethe

[net V2 09/15] net/mlx5e: Fix using wrong stats_grps in mlx5e_update_ndo_stats()

2020-09-21 Thread saeed
From: Alaa Hleihel The cited commit started to reuse function mlx5e_update_ndo_stats() for the representors as well. However, the function is hard-coded to work on mlx5e_nic_stats_grps only. Due to this issue, the representors statistics were not updated in the output of "ip -s". Fix it to work

[net V2 04/15] net/mlx5e: Fix memory leak of tunnel info when rule under multipath not ready

2020-09-21 Thread saeed
From: Jianbo Liu When deleting vxlan flow rule under multipath, tun_info in parse_attr is not freed when the rule is not ready. Fixes: ef06c9ee8933 ("net/mlx5e: Allow one failure when offloading tc encap rules under multipath") Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan Signed-off-by: S

[net V2 06/15] net/mlx5e: Enable adding peer miss rules only if merged eswitch is supported

2020-09-21 Thread saeed
From: Maor Dickman The cited commit creates peer miss group during switchdev mode initialization in order to handle miss packets correctly while in VF LAG mode. This is done regardless of FW support of such groups which could cause rules setups failure later on. Fix by adding FW capability check

[pull request][net V2 00/15] mlx5 fixes-2020-09-18

2020-09-21 Thread saeed
From: Saeed Mahameed Hi Dave, This series introduces some fixes to mlx5 driver. Please pull and let me know if there is any problem. v1->v2: Remove missing patch from -stable list. For -stable v5.1 ('net/mlx5: Fix FTE cleanup') For -stable v5.3 ('net/mlx5e: TLS, Do not expose FPGA TLS co

[net V2 03/15] net/mlx5e: Use synchronize_rcu to sync with NAPI

2020-09-21 Thread saeed
From: Maxim Mikityanskiy As described in the previous commit, napi_synchronize doesn't quite fit the purpose when we just need to wait until the currently running NAPI quits. Its implementation waits until NAPI is not running by polling and waiting for 1ms in between. In cases where we need to de

[net V2 10/15] net/mlx5e: TLS, Do not expose FPGA TLS counter if not supported

2020-09-21 Thread saeed
From: Tariq Toukan The set of TLS TX global SW counters in mlx5e_tls_sw_stats_desc is updated from all rings by using atomic ops. This set of stats is used only in the FPGA TLS use case, not in the Connect-X TLS one, where regular per-ring counters are used. Do not expose them in the Connect-X u

[net V2 15/15] net/mlx5e: mlx5e_fec_in_caps() returns a boolean

2020-09-21 Thread saeed
From: Saeed Mahameed Returning errno is a bug, fix that. Also fixes smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/en/port.c:453 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)' Fixes: 2132b71f78d2 ("net/mlx5e: Advertise globaly supported FEC modes") Reported-by: kernel test

[net V2 08/15] net/mlx5e: Fix multicast counter not up-to-date in "ip -s"

2020-09-21 Thread saeed
From: Ron Diskin Currently the FW does not generate events for counters other than error counters. Unlike ".get_ethtool_stats", ".ndo_get_stats64" (which ip -s uses) might run in atomic context, while the FW interface is non atomic. Thus, 'ip' is not allowed to issue FW commands, so it will only

[net V2 01/15] net/mlx5: Fix FTE cleanup

2020-09-21 Thread saeed
From: Maor Gottlieb Currently, when an FTE is allocated, its refcount is decreased to 0 with the purpose it will not be a stand alone steering object and every rule (destination) of the FTE would increase the refcount. When mlx5_cleanup_fs is called while not all rules were deleted by the steerin

[net V2 05/15] net/mlx5e: CT: Fix freeing ct_label mapping

2020-09-21 Thread saeed
From: Roi Dayan Add missing mapping remove call when removing ct rule, as the mapping was allocated when ct rule was adding with ct_label. Also there is a missing mapping remove call in error flow. Fixes: 54b154ecfb8c ("net/mlx5e: CT: Map 128 bits labels to 32 bit map ID") Signed-off-by: Roi Day

[net V2 02/15] net/mlx5e: Use RCU to protect rq->xdp_prog

2020-09-21 Thread saeed
From: Maxim Mikityanskiy Currently, the RQs are temporarily deactivated while hot-replacing the XDP program, and napi_synchronize is used to make sure rq->xdp_prog is not in use. However, napi_synchronize is not ideal: instead of waiting till the end of a NAPI cycle, it polls and waits until NAPI

Re: [PATCH net] net: mscc: ocelot: return error if VCAP filter is not found

2020-09-21 Thread David Miller
From: Vladimir Oltean Date: Tue, 22 Sep 2020 02:36:37 +0300 > From: Xiaoliang Yang > > There are 2 separate, but related, issues. > > First, the ocelot_vcap_block_get_filter_index function, née > ocelot_ace_rule_get_index_id prior to the aae4e500e106 ("net: mscc: > ocelot: generalize the "ACE/

Re: [PATCH net-next] net: Update MAINTAINERS for MediaTek switch driver

2020-09-21 Thread David Miller
From: Date: Tue, 22 Sep 2020 07:09:23 +0800 > From: Sean Wang > > Update maintainers for MediaTek switch driver with Landen Chao who is > familiar with MediaTek MT753x switch devices and will help maintenance > from the vendor side. > > Cc: Steven Liu > Signed-off-by: Sean Wang > Signed-off-

Re: [net-next v8 0/5] devlink flash update overwrite mask

2020-09-21 Thread David Miller
From: Jacob Keller Date: Mon, 21 Sep 2020 15:42:21 -0700 > On 9/21/2020 3:31 PM, Jacob Keller wrote: >> (This is essentially a resend of v7 because some of the patches didn't hit >> the netdev list last Friday due to an SMTP server issue here) >> > > Heh. Apparently it's not fixed yet. I am sor

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-21 Thread Pavel Begunkov
On 22/09/2020 02:51, Andy Lutomirski wrote: > On Mon, Sep 21, 2020 at 9:15 AM Pavel Begunkov wrote: >> >> On 21/09/2020 19:10, Pavel Begunkov wrote: >>> On 20/09/2020 01:22, Andy Lutomirski wrote: > On Sep 19, 2020, at 2:16 PM, Arnd Bergmann wrote: > > On Sat, Sep 19, 2020 at

Re: [PATCH iproute2] ip: do not exit if RTM_GETNSID failed

2020-09-21 Thread Stephen Hemminger
On Tue, 22 Sep 2020 01:53:18 +0200 Jan Engelhardt wrote: > `ip addr` when run under qemu-user-riscv64, fails. This likely is > due to qemu-5.1 not doing translation of RTM_GETNSID calls. > > 2: host0@if5: mtu 1500 qdisc noqueue state > UP group default qlen 1000 > link/ether 5a:44:da:1a:c4

Re: [PATCH iproute2] build: avoid make jobserver warnings

2020-09-21 Thread Stephen Hemminger
On Tue, 22 Sep 2020 01:22:31 +0200 Jan Engelhardt wrote: > I observe: > > » make -j8 CCOPTS=-ggdb3 > lib > make[1]: warning: -j8 forced in submake: resetting jobserver mode. > make[1]: Nothing to be done for 'all'. > ip > make[1]: warning: -j8 forced in submak

Re: [PATCH] net: lantiq: Add locking for TX DMA channel

2020-09-21 Thread David Miller
From: Hauke Mehrtens Date: Tue, 22 Sep 2020 00:31:13 +0200 > The TX DMA channel data is accessed by the xrx200_start_xmit() and the > xrx200_tx_housekeeping() function from different threads. Make sure the > accesses are synchronized by using locking around the accesses. > > Signed-off-by: Hauke

Re: [PATCH net-next] net: phy: bcm7xxx: Add an entry for BCM72113

2020-09-21 Thread David Miller
From: Florian Fainelli Date: Mon, 21 Sep 2020 15:10:53 -0700 > BCM72113 features a 28nm integrated EPHY, add an entry to the driver for > it. > > Signed-off-by: Florian Fainelli Applied, thanks Florian.

Re: [PATCH 1/3 nf] selftests: netfilter: add cpu counter check

2020-09-21 Thread Pablo Neira Ayuso
On Wed, Sep 09, 2020 at 08:25:36PM +0200, Fabian Frederick wrote: > run task on first CPU with netfilter counters reset and check > cpu meta after another ping Patches from 1 to 3 in this series are now applied, thanks.

[PATCH iproute2] ip: do not exit if RTM_GETNSID failed

2020-09-21 Thread Jan Engelhardt
`ip addr` when run under qemu-user-riscv64, fails. This likely is due to qemu-5.1 not doing translation of RTM_GETNSID calls. 2: host0@if5: mtu 1500 qdisc noqueue state UP group default qlen 1000 link/ether 5a:44:da:1a:c4:0b brd ff:ff:ff:ff:ff:ff request send failed: Operation not supported

Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag

2020-09-21 Thread Andy Lutomirski
On Mon, Sep 21, 2020 at 9:15 AM Pavel Begunkov wrote: > > On 21/09/2020 19:10, Pavel Begunkov wrote: > > On 20/09/2020 01:22, Andy Lutomirski wrote: > >> > >>> On Sep 19, 2020, at 2:16 PM, Arnd Bergmann wrote: > >>> > >>> On Sat, Sep 19, 2020 at 6:21 PM Andy Lutomirski wrote: > > On Fri, Se

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-21 Thread Frederic Weisbecker
On Wed, Sep 09, 2020 at 11:08:16AM -0400, Nitesh Narayan Lal wrote: > +/* > + * num_housekeeping_cpus() - Read the number of housekeeping CPUs. > + * > + * This function returns the number of available housekeeping CPUs > + * based on __num_housekeeping_cpus which is of type atomic_t > + * and is i

[PATCH net] net: mscc: ocelot: return error if VCAP filter is not found

2020-09-21 Thread Vladimir Oltean
From: Xiaoliang Yang There are 2 separate, but related, issues. First, the ocelot_vcap_block_get_filter_index function, née ocelot_ace_rule_get_index_id prior to the aae4e500e106 ("net: mscc: ocelot: generalize the "ACE/ACL" names") rename, does not do what the author probably intended. If the d

Re: [PATCH net-next] ipvs: Remove unused macros

2020-09-21 Thread Pablo Neira Ayuso
On Mon, Sep 21, 2020 at 09:24:40AM +0200, Simon Horman wrote: > On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote: > > They are not used since commit e4ff67513096 ("ipvs: add > > sync_maxlen parameter for the sync daemon") > > > > Signed-off-by: YueHaibing > > Thanks, this look good to

Re: [PATCHv2 bpf-next] selftests/bpf: Fix stat probe in d_path test

2020-09-21 Thread Alexei Starovoitov
On Fri, Sep 18, 2020 at 4:23 AM Jiri Olsa wrote: > > Some kernels builds might inline vfs_getattr call within fstat > syscall code path, so fentry/vfs_getattr trampoline is not called. > > Alexei suggested [1] we should use security_inode_getattr instead, > because it's less likely to get inlined.

Wir finanzieren Projekte und Unternehmen

2020-09-21 Thread Blue Oak Mortgage and Loans
Dies ist ein Newsletter von Blue Oak Mortgage and Loans. Bitte melden Sie sich ab, wenn Sie keine E-Mail mehr von uns erhalten möchten. Eine kurze Einführung. Wir sind ein führendes Finanzierungsunternehmen in Europa. Wir finanzieren Startups / etablierte Unternehmen, finanzieren Großprojek

[PATCH iproute2] build: avoid make jobserver warnings

2020-09-21 Thread Jan Engelhardt
I observe: » make -j8 CCOPTS=-ggdb3 lib make[1]: warning: -j8 forced in submake: resetting jobserver mode. make[1]: Nothing to be done for 'all'. ip make[1]: warning: -j8 forced in submake: resetting jobserver mode. CC ipntable.o M

Re: [PATCH net-next v2 3/3] octeontx2-af: add support for custom KPU entries

2020-09-21 Thread Jakub Kicinski
On Mon, 21 Sep 2020 19:54:42 +0200 Stanislaw Kardach wrote: > Add ability to load a set of custom KPU entries via firmware APIs. This > allows for flexible support for custom protocol parsing and CAM matching. > > The firmware file name is specified by a module parameter (kpu_profile) > to allow r

Re: [PATCH bpf-next v7 00/10] bpf: Support multi-attach for freplace programs

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > This series adds support attaching freplace BPF programs to multiple targets. > This is needed to support incremental attachment of multiple XDP programs > using > the libxdp dispatcher model. > > The first patch fixes an issue tha

Re: [PATCH bpf-next v7 10/10] selftests: Add selftest for disallowing modify_return attachment to freplace

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > This adds a selftest that ensures that modify_return tracing programs > cannot be attached to freplace programs. The security_ prefix is added to > the freplace program because that would otherwise

Re: [PATCH bpf-next v7 08/10] selftests: add test for multiple attachments of freplace program

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > This adds a selftest for attaching an freplace program to multiple targets > simultaneously. > > Signed-off-by: Toke Høiland-Jørgensen > --- > .../selftests/bpf/prog_tests/fexit_bpf2bpf.c |

Re: [PATCH bpf-next v7 07/10] libbpf: add support for freplace attachment in bpf_link_create

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:51 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > This adds support for supplying a target btf ID for the bpf_link_create() > operation, and adds a new bpf_program__attach_freplace() high-level API for > attaching freplace functions with a target.

Re: [net-next v2 PATCH 1/2] octeontx2-af: Introduce tracepoints for mailbox

2020-09-21 Thread Jakub Kicinski
On Mon, 21 Sep 2020 22:32:41 +0530 sundeep.l...@gmail.com wrote: > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c > new file mode 100644 > index 000..f0b3f17 > --- /dev/null > +++ b/drivers/net/ethernet/marvell/octeo

[PATCH net-next] net: Update MAINTAINERS for MediaTek switch driver

2020-09-21 Thread sean.wang
From: Sean Wang Update maintainers for MediaTek switch driver with Landen Chao who is familiar with MediaTek MT753x switch devices and will help maintenance from the vendor side. Cc: Steven Liu Signed-off-by: Sean Wang Signed-off-by: Landen Chao --- MAINTAINERS | 1 + 1 file changed, 1 inser

Re: [PATCH bpf-next v7 06/10] bpf: Fix context type resolving for extension programs

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > Eelco reported we can't properly access arguments if the tracing > program is attached to extension program. > > Having following program: > > SEC("classifier/test_pkt_md_access") > int test_pkt

Re: [PATCH bpf-next v7 05/10] bpf: support attaching freplace programs to multiple attach points

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > This enables support for attaching freplace programs to multiple attach > points. It does this by amending the UAPI for bpf_link_Create with a target > btf ID that can be used to supply the new atta

Re: [PATCH bpf-next v7 03/10] bpf: verifier: refactor check_attach_btf_id()

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > The check_attach_btf_id() function really does three things: > > 1. It performs a bunch of checks on the program to ensure that the >attachment is valid. > > 2. It stores a bunch of state about

Re: [PATCH bpf-next v7 04/10] bpf: move prog->aux->linked_prog and trampoline into bpf_link on attach

2020-09-21 Thread Andrii Nakryiko
On Sat, Sep 19, 2020 at 4:50 AM Toke Høiland-Jørgensen wrote: > > From: Toke Høiland-Jørgensen > > In preparation for allowing multiple attachments of freplace programs, move > the references to the target program and trampoline into the > bpf_tracing_link structure when that is created. To do th

[PATCH net-next] net: hns3: Constify static structs

2020-09-21 Thread Rikard Falkeborn
A number of static variables were not modified. Make them const to allow the compiler to put them in read-only memory. In order to do so, constify a couple of input pointers as well as some local pointers. This moves about 35Kb to read-only memory as seen by the output of the size command. Before:

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-21 Thread Frederic Weisbecker
On Thu, Sep 17, 2020 at 11:23:59AM -0700, Jesse Brandeburg wrote: > Nitesh Narayan Lal wrote: > > > In a realtime environment, it is essential to isolate unwanted IRQs from > > isolated CPUs to prevent latency overheads. Creating MSIX vectors only > > based on the online CPUs could lead to a poten

[PATCH net 1/3] net: dsa: felix: fix some key offsets for IP4_TCP_UDP VCAP IS2 entries

2020-09-21 Thread Vladimir Oltean
From: Xiaoliang Yang Some of the IS2 IP4_TCP_UDP keys are not correct, like L4_DPORT, L4_SPORT and other L4 keys. This prevents offloaded tc-flower rules from matching on src_port and dst_port for TCP and UDP packets. Signed-off-by: Xiaoliang Yang Signed-off-by: Vladimir Oltean --- drivers/ne

[PATCH net 0/3] Fix broken tc-flower rules for mscc_ocelot switches

2020-09-21 Thread Vladimir Oltean
All 3 switch drivers from the Ocelot family have the same bug in the VCAP IS2 key offsets, which is that some keys are in the incorrect order. Vladimir Oltean (2): net: dsa: seville: fix some key offsets for IP4_TCP_UDP VCAP IS2 entries net: mscc: ocelot: fix some key offsets for IP4_TCP_U

[PATCH net 3/3] net: mscc: ocelot: fix some key offsets for IP4_TCP_UDP VCAP IS2 entries

2020-09-21 Thread Vladimir Oltean
The IS2 IP4_TCP_UDP key offsets do not correspond to the VSC7514 datasheet. Whether they work or not is unknown to me. On VSC9959 and VSC9953, with the same mistake and same discrepancy from the documentation, tc-flower src_port and dst_port rules did not work, so I am assuming the same is true her

[PATCH net 2/3] net: dsa: seville: fix some key offsets for IP4_TCP_UDP VCAP IS2 entries

2020-09-21 Thread Vladimir Oltean
Since these were copied from the Felix VCAP IS2 code, and only the offsets were adjusted, the order of the bit fields is still wrong. Fix it. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/seville_vsc9953.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff -

Re: [PATCH net-next] net: phy: bcm7xxx: Add an entry for BCM72113

2020-09-21 Thread Andrew Lunn
On Mon, Sep 21, 2020 at 03:10:53PM -0700, Florian Fainelli wrote: > BCM72113 features a 28nm integrated EPHY, add an entry to the driver for > it. > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew

Re: [PATCH bpf-next v4] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-21 Thread Alexei Starovoitov
On Thu, Sep 17, 2020 at 8:46 AM Yonghong Song wrote: > > If a bucket contains a lot of sockets, during bpf_iter traversing > a bucket, concurrent userspace bpf_map_update_elem() and > bpf program bpf_sk_storage_{get,delete}() may experience > some undesirable delays as they will compete with bpf_i

  1   2   3   4   5   >